<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>382460</bug_id>
          
          <creation_ts>2017-07-18 09:03:12 +0000</creation_ts>
          <short_desc>Exec line in kglobalaccel5 service file must not have any path prefix on Windows</short_desc>
          <delta_ts>2018-01-12 09:07:16 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>Frameworks and Libraries</classification>
          <product>frameworks-kglobalaccel</product>
          <component>general</component>
          <version>5.36.0</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>380136</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ralf Habacker">ralf.habacker</reporter>
          <assigned_to name="Ralf Habacker">ralf.habacker</assigned_to>
          <cc>kdelibs-bugs-null</cc>
    
    <cc>simonandric5</cc>
          
          <cf_commitlink>https://commits.kde.org/kglobalaccel/205b69533bb54ee196cf50b3af1e4224d46ca94b</cf_commitlink>
          <cf_versionfixedin>5.43.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1689497</commentid>
    <comment_count>0</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2017-07-18 09:03:12 +0000</bug_when>
    <thetext>The Exec line in kglobalaccel/src/runtime/org.kde.kglobalaccel.service.in
[D-BUS Service]
Name=org.kde.kglobalaccel
Exec=@CMAKE_INSTALL_PREFIX@/bin/kglobalaccel5

and ./kglobalaccel/src/runtime/dbus/org.kde.kglobalaccel.service.in
[D-BUS Service]
Name=org.kde.kglobalaccel
Exec=@CMAKE_INSTALL_PREFIX@/bin/kglobalaccel5

will not work on Windows (see bug 382458 for details)

Instead the prefix in the Exec line needs to be completely removed on windows e.g.

Exec=@SOME_PREFIX@kglobalaccel5

with SOME_PREFIX set to empty on Windows and to ${CMAKE_INSTALL_PREFIX}/bin/ otherwise

Also on Windows kglobalaccel5 needs to be installed in bindir</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1717689</commentid>
    <comment_count>1</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2017-12-20 10:00:04 +0000</bug_when>
    <thetext>review request https://phabricator.kde.org/D9424</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721649</commentid>
    <comment_count>2</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2018-01-12 09:07:16 +0000</bug_when>
    <thetext>Git commit 205b69533bb54ee196cf50b3af1e4224d46ca94b by Ralf Habacker.
Committed on 12/01/2018 at 09:06.
Pushed by habacker into branch &apos;master&apos;.

Use cmake function &apos;kdbusaddons_generate_dbus_service_file&apos; from kdbusaddons to generate dbus service file

Summary:
FIXED-IN:5.43.0

Test Plan:
compiled against installed build from kdbusaddons git repo master branch

Reviewers: dfaure, bcooksley, apol

Reviewed By: dfaure

Subscribers: kfunk, vonreth, #windows, apol, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D9424

M  +1    -4    src/runtime/CMakeLists.txt
D  +0    -3    src/runtime/org.kde.kglobalaccel.service.in

https://commits.kde.org/kglobalaccel/205b69533bb54ee196cf50b3af1e4224d46ca94b</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>