381784 2017-06-29 07:39:33 +0000 Improve foreground and background color behavior in vector objects. 2019-09-21 12:09:08 +0000 1 1 2 Applications krita Layers/Vector git master (please specify the git hash!) Other Linux RESOLVED FIXED NOR normal --- 1 raghu dimula73 griffinvalley halla raghu 0 oldest_to_newest 1686071 0 raghu 2017-06-29 07:39:33 +0000 Currently When you select a vector shape, and change the foreground color in the toolbar, it changes the fill color of the vector shape, And consequently when you change color through the palette docker it changes its fill color too. Similarly if you change the background color it changes its stroke color. This functionality is nice. it is nice to associate foreground to fill color and background to stroke color when user selects an vector object. However if you have an vector object selected it's stroke and color don't show-up in the toolbar. Also the restore to default foreground and background color shortcuts don't work when user is on a vector layer. The swap foreground and background color is also a important feature. But the shortcut to do so, also doesn't work when user is in vector layer. I request to improve the foreground and background color functionality in vector layer as below: 1) Change the foreground and background color in the toolbar according to the fill and background color of the vector shape selected. 2)Add ability to restore to default colors (i.e. black & white) with shortcut in vector layer, which in-turn will change the fill and stroke of the vector object to black and white. 3) Add ability to swap foreground and background color in vector layer, which will in-turn allow user to swap fill and stroke color like in inkscape. 1713530 1 halla 2017-11-26 14:38:02 +0000 Added to https://phabricator.kde.org/T6369 1733287 2 griffinvalley 2018-02-23 18:00:11 +0000 I am adding dmitry to this, but he's already fixed a bunch of color related bugs. Raghukamath, could you check which ones are still relevant on master? 1745475 3 raghu 2018-04-14 04:58:18 +0000 Hi Wolthera, I checked on the latest master and all three of them are reproducible. 1880540 4 dimula73 2019-09-17 12:21:48 +0000 Git commit 1fdb15d0dae77917b20c61033345fa6124499b35 by Dmitry Kazakov. Committed on 17/09/2019 at 11:15. Pushed by dkazakov into branch 'kazakov/vector-color-fix-381784'. Fix color of the shape being synched with the color selectors 1) When the shape is selected, its color now loaded into the color selector 2) If the shape was deselected without editing the color, then old color (before selection) is recovered back 3) If the shape is deselected after its color was modified in any way, then the newly selected color is kept in the selector. M +36 -0 libs/ui/widgets/KoFillConfigWidget.cpp M +2 -0 libs/ui/widgets/KoFillConfigWidget.h https://invent.kde.org/kde/krita/commit/1fdb15d0dae77917b20c61033345fa6124499b35 1881350 5 dimula73 2019-09-21 07:15:11 +0000 Fixed in https://invent.kde.org/kde/krita/commit/5f783c4035ad1b5b3f656ff3fdeb567a4aced4d7 1881393 6 dimula73 2019-09-21 12:09:08 +0000 Git commit 32285d7da2fa1f45ed5c15a42aba8289d5743261 by Dmitry Kazakov. Committed on 21/09/2019 at 10:08. Pushed by dkazakov into branch 'krita/4.2'. Fix color of the shape being synched with the color selectors 1) When the shape is selected, its color now loaded into the color selector 2) If the shape was deselected without editing the color, then old color (before selection) is recovered back 3) If the shape is deselected after its color was modified in any way, then the newly selected color is kept in the selector. M +36 -0 libs/ui/widgets/KoFillConfigWidget.cpp M +2 -0 libs/ui/widgets/KoFillConfigWidget.h https://invent.kde.org/kde/krita/commit/32285d7da2fa1f45ed5c15a42aba8289d5743261