<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>381367</bug_id>
          
          <creation_ts>2017-06-18 14:46:37 +0000</creation_ts>
          <short_desc>Populate UDS_CREATION_TIME on Linux when the statx() system call is available</short_desc>
          <delta_ts>2019-04-13 13:37:02 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>Frameworks and Libraries</classification>
          <product>frameworks-kio</product>
          <component>general</component>
          <version>unspecified</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>usability</keywords>
          <priority>NOR</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nate Graham">nate</reporter>
          <assigned_to name="David Faure">faure</assigned_to>
          <cc>bughunt</cc>
    
    <cc>bugseforuns</cc>
    
    <cc>grahamperrin</cc>
    
    <cc>karl</cc>
    
    <cc>kdelibs-bugs-null</cc>
    
    <cc>meven29</cc>
    
    <cc>nate</cc>
    
    <cc>toddrme2178</cc>
          
          <cf_commitlink>https://commits.kde.org/kio/f3b0f220a78d4e5a5b94b46e931779d755ac19ce</cf_commitlink>
          <cf_versionfixedin>5.58</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1683182</commentid>
    <comment_count>0</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2017-06-18 14:46:37 +0000</bug_when>
    <thetext>Linux Kernel 4.11 has the statx() system call, which among other things reports files&apos; creation times. This supports the much-requested feature to add file creation files to Dolphin&apos;s file info display and columns (https://bugs.kde.org/show_bug.cgi?id=286689).

Preliminary support in DOlphin is getting done now, and it currently works for FreeBSD with the UFS and ZFS file systems: https://phabricator.kde.org/D5138

It would be great to integrate Linux support by adding some code to populate UDS_CREATION_TIME if the filesystem is EXT4 and the kernel has the statx() system call available.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1695720</commentid>
    <comment_count>1</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2017-08-20 20:31:48 +0000</bug_when>
    <thetext>No real need for this separate bug; duplicate of https://bugs.kde.org/show_bug.cgi?id=286689

*** This bug has been marked as a duplicate of bug 286689 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697188</commentid>
    <comment_count>2</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2017-08-27 18:08:54 +0000</bug_when>
    <thetext>Re-opening since the duped bug has been closed as fixed, and anyway, my patch to implement the functionality in Linux (https://phabricator.kde.org/D7423) really belongs in this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1741753</commentid>
    <comment_count>3</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2018-03-29 21:43:49 +0000</bug_when>
    <thetext>*** Bug 389893 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1773299</commentid>
    <comment_count>4</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2018-08-21 19:14:26 +0000</bug_when>
    <thetext>*** Bug 397398 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849403</commentid>
    <comment_count>5</comment_count>
    <who name="Méven Car">meven29</who>
    <bug_when>2019-04-09 10:01:24 +0000</bug_when>
    <thetext>A patch is underway https://phabricator.kde.org/D20096</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1849747</commentid>
    <comment_count>6</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2019-04-10 20:19:28 +0000</bug_when>
    <thetext>Thanks so much, Méven!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1850151</commentid>
    <comment_count>7</comment_count>
    <who name="Méven Car">meven29</who>
    <bug_when>2019-04-13 13:30:50 +0000</bug_when>
    <thetext>Git commit f3b0f220a78d4e5a5b94b46e931779d755ac19ce by Méven Car.
Committed on 13/04/2019 at 13:30.
Pushed by meven into branch &apos;master&apos;.

Fill UDSEntry::UDS_CREATION_TIME under linux when glibc &gt;= 2.28

Summary:
The birthtime can be retrieved using using the statx function, available since glibc 2.28. In case the kernel lacks support for the underlying syscall, glibc falls back to stat internally. The validity of the btime field is indicated in the mask field, e.g. when the kernel or the filesystem lacks support for btime.
For details, see http://man7.org/linux/man-pages/man2/statx.2.html

In dolphin, the creation time column is now filled in linux :
{F6736022}
FIXED-IN: 5.58

Test Plan:
Tested using kioslavetest and local build of dolphin.
Tested without HAVE_STATX under linux.

Reviewers: #frameworks, dfaure, fvogt, bruns, broulik

Reviewed By: fvogt, bruns

Subscribers: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20096

M  +18   -0    src/ioslaves/file/ConfigureChecks.cmake
M  +3    -0    src/ioslaves/file/config-kioslave-file.h.cmake
M  +92   -24   src/ioslaves/file/file.cpp
M  +17   -0    tests/kioslavetest.cpp

https://commits.kde.org/kio/f3b0f220a78d4e5a5b94b46e931779d755ac19ce</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1850153</commentid>
    <comment_count>8</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2019-04-13 13:37:02 +0000</bug_when>
    <thetext>&lt;3</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>