380437 2017-06-01 18:29:18 +0000 Save does not work when I only change layer name 2019-05-03 11:50:25 +0000 1 1 2 Applications krita Usability 3.1.4 Microsoft Windows Microsoft Windows RESOLVED FIXED NOR normal --- 1 longleaffriends halla chris.webb4 freebox64 halla katearcher89 lou nevineviril scottpetrovic https://invent.kde.org/kde/krita/commit/43f89ce8d9c13ee0c174737166ec3cec4eecff3e 0 oldest_to_newest 1678869 0 longleaffriends 2017-06-01 18:29:18 +0000 Both ctrl-s and menu File->Save don't work if no other changes has been applied to .ora document. 1679141 1 freebox64 2017-06-03 07:05:30 +0000 (This is on Ubuntu 14.04 with Krita 3.1.4 appimage). I think I can confirm this behaviour with *.kra files too, in my case it happens whenever I change the layer name without accessing the layer Property dialog (important). Steps to reproduce: - open an existing *.ora or *.kra file, - change a layer name on the "Layers" docker just by double clicking on the name (important) - save the file (either by doing "CTRL+S" or by going to menu "File > Save") - close and reopen. Actual results: the file has not been saved, the layer name has not been saved. Expected results: save the file even after changing the layer name without accessing the Property dialog? 1686909 2 katearcher89 2017-07-03 23:59:58 +0000 I confirm this, happens on win7 too. Krita doesn't change the modified status of a file(* symbol in the header of the file/window) if only a layer name through the layer docker was changed and thus not giving an option to save the file since it thinks nothing have changed. 1707253 3 nevineviril 2017-10-20 18:05:14 +0000 It might go slightly deeper than this. I noticed that not only these actions don't "dirty" an image, but they also are not undoable: - Layer name (renaming by double clicking or F2 key) From the right-click context menu on the layer boxes: - Layer color - Isolate layer - Show in timeline Setting layer color and name with the Layer Properties dialog (F3 key) however does "dirty" the image and is an undoable action. 1753143 4 halla 2018-05-17 09:23:32 +0000 *** Bug 394363 has been marked as a duplicate of this bug. *** 1847602 5 scottpetrovic 2019-03-30 17:59:23 +0000 This was a recent bug that was introduced a week ago. I am working on a patch to fix this...as well as add some functionality to the transform tool. The work is being done here... https://phabricator.kde.org/D18792 1847603 6 scottpetrovic 2019-03-30 17:59:58 +0000 sorry...posted on wrong ticket :( 1854149 7 halla 2019-05-03 11:26:39 +0000 *** Bug 389562 has been marked as a duplicate of this bug. *** 1854150 8 halla 2019-05-03 11:27:46 +0000 Changing the layer name is not an undoable action and doesn't set the document to modified. 1854154 9 halla 2019-05-03 11:50:25 +0000 Git commit 43f89ce8d9c13ee0c174737166ec3cec4eecff3e by Boudewijn Rempt. Committed on 03/05/2019 at 11:50. Pushed by rempt into branch 'master'. Create an undo command for node renaming This means that changing a node's name will now mark the document modified so it can be saved, and it's possible to undo a node rename. M +1 -0 libs/image/CMakeLists.txt C +11 -15 libs/image/commands/KisNodeRenameCommand.cpp [from: libs/image/commands/kis_node_compositeop_command.cpp - 055% similarity] A +40 -0 libs/image/commands/KisNodeRenameCommand.h [License: GPL (v2+)] M +0 -2 libs/image/commands/kis_node_compositeop_command.cpp M +7 -0 libs/ui/kis_node_commands_adapter.cpp M +1 -0 libs/ui/kis_node_commands_adapter.h M +9 -0 libs/ui/kis_node_manager.cpp M +5 -0 libs/ui/kis_node_manager.h M +1 -1 libs/ui/kis_node_model.cpp https://invent.kde.org/kde/krita/commit/43f89ce8d9c13ee0c174737166ec3cec4eecff3e