376104 2017-02-06 16:03:21 +0000 Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0 2022-02-25 08:24:34 +0000 1 1 4 Plasma kwin core 5.10.3 Arch Linux Linux RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=449541 usability NOR normal --- 1 muesli kwin-bugs-null 2019nicholas andrewnguyen841 AndyKluger archmizuchi brendon bugs.kde.org.trustful938 bugseforuns Flupp+bugs.kde.org jeremy9856 kde2 kde mail mu nate nortexoid richard.llom thanosapostolou till2.schaefer https://commits.kde.org/kwin/8a2796d280dd7e891724cb6e6d873a57e2ae8c52 5.12.0 0 oldest_to_newest 1659102 0 muesli 2017-02-06 16:03:21 +0000 Trying to move a window to the left border of my leftest monitor sometimes sends the window to the wrong place, e.g. to the top right corner of that monitor - even tho the preview indicates it would snap into the right place. On second try it usually works fine. 1659166 1 mgraesslin 2017-02-06 18:42:24 +0000 Please provide the output of: qdbus org.kde.KWin /KWin supportInformation 1659181 2 muesli 2017-02-06 19:58:31 +0000 Version ======= KWin version: 5.9.0 Qt Version: 5.8.0 Qt compile version: 5.8.0 XCB compile version: 1.12 Operation Mode: X11 only Build Options ============= KWIN_BUILD_DECORATIONS: yes KWIN_BUILD_TABBOX: yes KWIN_BUILD_ACTIVITIES: yes HAVE_INPUT: yes HAVE_DRM: yes HAVE_GBM: yes HAVE_X11_XCB: yes HAVE_EPOXY_GLX: yes HAVE_WAYLAND_EGL: yes X11 === Vendor: The X.Org Foundation Vendor Release: 11901000 Protocol Version/Revision: 11/0 SHAPE: yes; Version: 0x11 RANDR: yes; Version: 0x14 DAMAGE: yes; Version: 0x11 Composite: yes; Version: 0x4 RENDER: yes; Version: 0xb XFIXES: yes; Version: 0x50 SYNC: yes; Version: 0x31 GLX: yes; Version: 0x0 Decoration ========== Plugin: org.kde.breeze Theme: Blur: 0 onAllDesktopsAvailable: true alphaChannelSupported: true closeOnDoubleClickOnMenu: false decorationButtonsLeft: 0, 1, 2 decorationButtonsRight: 6, 3, 4, 5 borderSize: 3 gridUnit: 10 font: Noto Sans,10,-1,5,50,0,0,0,0,0 smallSpacing: 2 largeSpacing: 10 Options ======= focusPolicy: 0 nextFocusPrefersMouse: false clickRaise: true autoRaise: false autoRaiseInterval: 0 delayFocusInterval: 0 shadeHover: true shadeHoverInterval: 250 separateScreenFocus: false placement: 4 focusPolicyIsReasonable: true borderSnapZone: 2 windowSnapZone: 2 centerSnapZone: 0 snapOnlyWhenOverlapping: false rollOverDesktops: true focusStealingPreventionLevel: 1 legacyFullscreenSupport: false operationTitlebarDblClick: 5000 operationMaxButtonLeftClick: 5000 operationMaxButtonMiddleClick: 5015 operationMaxButtonRightClick: 5014 commandActiveTitlebar1: 0 commandActiveTitlebar2: 30 commandActiveTitlebar3: 2 commandInactiveTitlebar1: 4 commandInactiveTitlebar2: 30 commandInactiveTitlebar3: 2 commandWindow1: 7 commandWindow2: 8 commandWindow3: 8 commandWindowWheel: 31 commandAll1: 10 commandAll2: 3 commandAll3: 14 keyCmdAllModKey: 16777251 showGeometryTip: false condensedTitle: false electricBorderMaximize: true electricBorderTiling: true electricBorderCornerRatio: 0.25 borderlessMaximizedWindows: false killPingTimeout: 5000 hideUtilityWindowsForInactive: true inactiveTabsSkipTaskbar: false autogroupSimilarWindows: false autogroupInForeground: true compositingMode: 1 useCompositing: true compositingInitialized: true hiddenPreviews: 1 glSmoothScale: 2 xrenderSmoothScale: false maxFpsInterval: 16666666 refreshRate: 0 vBlankTime: 6000000 glStrictBinding: true glStrictBindingFollowsDriver: true glCoreProfile: true glPreferBufferSwap: 101 glPlatformInterface: 1 windowsBlockCompositing: true Screen Edges ============ desktopSwitching: false desktopSwitchingMovingClients: false cursorPushBackDistance: 1x1 timeThreshold: 150 reActivateThreshold: 350 actionTopLeft: 0 actionTop: 0 actionTopRight: 0 actionRight: 0 actionBottomRight: 0 actionBottom: 0 actionBottomLeft: 0 actionLeft: 0 Screens ======= Multi-Head: no Active screen follows mouse: no Number of Screens: 3 Screen 0: --------- Name: DisplayPort-0 Geometry: 0,0,3840x2160 Refresh Rate: 59.9966 Screen 1: --------- Name: HDMI-0 Geometry: 5760,856,1920x1080 Refresh Rate: 60 Screen 2: --------- Name: DVI-1 Geometry: 3840,856,1920x1080 Refresh Rate: 60 Compositing =========== Compositing is active Compositing Type: OpenGL OpenGL vendor string: X.Org OpenGL renderer string: Gallium 0.4 on AMD CAPE VERDE (DRM 2.48.0 / 4.9.6-1-ARCH, LLVM 3.9.1) OpenGL version string: 4.3 (Core Profile) Mesa 13.0.4 OpenGL platform interface: GLX OpenGL shading language version string: 4.30 Driver: Unknown GPU class: Unknown OpenGL version: 4.3 GLSL version: 4.30 Mesa version: 13.0.4 X server version: 1.19.1 Linux kernel version: 4.9.6 Direct rendering: Requires strict binding: yes GLSL shaders: yes Texture NPOT support: yes Virtual Machine: no OpenGL 2 Shaders are used Painting blocks for vertical retrace: no Loaded Effects: --------------- zoom slidingpopups kwin4_effect_login screenshot kwin4_effect_windowaperture kwin4_effect_translucency minimizeanimation kwin4_effect_fadedesktop desktopgrid colorpicker kwin4_effect_morphingpopups kwin4_effect_maximize kwin4_effect_fade presentwindows highlightwindow kwin4_effect_dialogparent blur contrast startupfeedback screenedge kscreen Currently Active Effects: ------------------------- blur contrast Effect Settings: ---------------- zoom: zoomFactor: 1.2 mousePointer: 0 mouseTracking: 0 enableFocusTracking: false followFocus: true focusDelay: 350 moveFactor: 20 targetZoom: 1 slidingpopups: fadeInTime: 150 fadeOutTime: 250 kwin4_effect_login: screenshot: kwin4_effect_windowaperture: kwin4_effect_translucency: minimizeanimation: kwin4_effect_fadedesktop: desktopgrid: zoomDuration: 300 border: 10 desktopNameAlignment: 0 layoutMode: 0 customLayoutRows: 2 usePresentWindows: true colorpicker: kwin4_effect_morphingpopups: kwin4_effect_maximize: kwin4_effect_fade: presentwindows: layoutMode: 0 showCaptions: false showIcons: false doNotCloseWindows: true ignoreMinimized: false accuracy: 20 fillGaps: true fadeDuration: 150 showPanel: false leftButtonWindow: 1 rightButtonWindow: 2 middleButtonWindow: 0 leftButtonDesktop: 2 middleButtonDesktop: 0 rightButtonDesktop: 0 highlightwindow: kwin4_effect_dialogparent: blur: blurRadius: 12 cacheTexture: true contrast: startupfeedback: type: 1 screenedge: kscreen: 1659183 3 mgraesslin 2017-02-06 20:12:35 +0000 Any chance to test with Qt 5.7? We have regressions in Qt 5.8 in other areas and I consider it as highly unlikely that our code broken given that quick tiling is completely under test coverage (at least the Wayland part and X11 didn't change). 1659372 4 muesli 2017-02-07 13:59:22 +0000 Understood, but I'm afraid I won't be able to do this anytime soon. 1660029 5 mgraesslin 2017-02-10 08:26:15 +0000 Are the windows you are trying to quick tile maximized vertically or horizontally? If yes this could be bug #376224 1660063 6 muesli 2017-02-10 10:34:26 +0000 Not sure whether you mean before or after tiling, so to clarify: I'm trying to tile a non-maximized window to the left border of my screen (so it would become vertically maximized). 1660102 7 mgraesslin 2017-02-10 13:24:14 +0000 non-maximized as in free floating or maybe touching some edges? We have a vertical maximized state which is not the quick tiling 1660115 8 muesli 2017-02-10 14:30:22 +0000 Usually close to a screen corner, but certainly nowhere near touching it (at least 16px margin). 1682211 9 muesli 2017-06-13 13:34:18 +0000 Confirmed as still existing with Qt 5.9. 1689225 10 mail 2017-07-17 14:27:39 +0000 Still present with KWin 5.10.3 and Qt 5.9.1 More-detailed repro steps: 1) Open a Konsole window. This matters. With many (all?) KDE applications, and some others, this bug occurs. With urxvt or claws-mail, it doesn't. 2) Drag it to the middle-right edge of the screen, so it snaps to the right half. 3) Close the window. 4) Open a new Konsole window. 5) Drag /that/ to the middle-right edge again. Observe that it snaps to a different area, usually one of the left corners. With some non-KDE apps (Chromium, qutebrowser) it snaps to the top-right corner instead. 1690194 11 mgraesslin 2017-07-22 15:15:05 +0000 *** Bug 376155 has been marked as a duplicate of this bug. *** 1700340 12 mgraesslin 2017-09-10 14:30:09 +0000 *** Bug 384552 has been marked as a duplicate of this bug. *** 1701336 13 mgraesslin 2017-09-15 16:26:08 +0000 *** Bug 384745 has been marked as a duplicate of this bug. *** 1703588 14 mgraesslin 2017-09-29 14:27:28 +0000 *** Bug 385192 has been marked as a duplicate of this bug. *** 1703593 15 nate 2017-09-29 14:57:10 +0000 *** Bug 376224 has been marked as a duplicate of this bug. *** 1703595 16 nate 2017-09-29 14:57:19 +0000 *** Bug 380005 has been marked as a duplicate of this bug. *** 1703597 17 nate 2017-09-29 14:57:43 +0000 *** Bug 380468 has been marked as a duplicate of this bug. *** 1703599 18 nate 2017-09-29 14:57:56 +0000 *** Bug 381824 has been marked as a duplicate of this bug. *** 1703602 19 nate 2017-09-29 15:53:23 +0000 Migrating info from duped bugs: This seems to have been caused by https://cgit.kde.org/kwin.git/commit/?id=9934f5b57537feae54afd0c4366c90253638ada2 The following quick-and-dirty patch seems to resolve it for some people: --- a/geometry.cpp 2017-03-21 21:54:36.000000000 +0800 +++ b/geometry.cpp 2017-03-23 19:11:02.872123167 +0800 @@ -3326,6 +3326,8 @@ TabSynchronizer syncer(this, TabGroup::QuickTile|TabGroup::Geometry|TabGroup::Maximized); + setMaximize(false, false); + if (mode != QuickTileNone) { m_quickTileMode = mode; // decorations may turn off some borders when tiled @@ -3336,8 +3338,6 @@ // Store the mode change m_quickTileMode = mode; - setMaximize(false, false); - emit quickTileModeChanged(); return; Martin, since we do have test cases for X11 now, is this something we can get submitted to Phabricator as a patch? 1703855 20 mgraesslin 2017-10-01 19:59:20 +0000 (In reply to Nate Graham from comment #19) > Martin, since we do have test cases for X11 now, is this something we can > get submitted to Phabricator as a patch? No as it does not address the reasons on why the code was moved in first place. Just reverting a commit does not fix things, it causes issues in other places. 1705521 21 archmizuchi 2017-10-12 12:43:33 +0000 (In reply to Nate Graham from comment #19) --- kwin-5.11.0/geometry.cpp 2017-10-12 15:13:48.467815000 +0300 +++ kwin-5.11.0/geometry.cpp 2017-10-12 15:13:34.340537140 +0300 @@ -3355,6 +3355,8 @@ if (maximizeMode() != MaximizeRestore) { TabSynchronizer syncer(this, TabGroup::QuickTile|TabGroup::Geometry|TabGroup::Maximized); + + setMaximize(false, false); if (mode != QuickTileMode(QuickTileFlag::None)) { m_quickTileMode = mode; This patch fixes the issue in 5.11.0. Tested in Archlinux. 1705523 22 nortexoid 2017-10-12 13:02:01 +0000 The bug I originally reported, https://bugs.kde.org/show_bug.cgi?id=376224, marked as a duplicate of this one, isn't solved in 5.11.0 (KDE Neon). If I tile a vertically maximized window, instead of tiling it, it brings it back to its original (pre-maximized) dimensions. 1705525 23 nate 2017-10-12 13:05:52 +0000 Antoscha, it looks like that simple fix doesn't address Martin's concerns. 1705559 24 mgraesslin 2017-10-12 15:15:04 +0000 The simple fix does not address the problem why the code changed like that in the first place. If we revert that part we just run into issues elsewhere in the code. We need a complete solution taking care of the required behavior on X11 and Wayland. 1706837 25 mgraesslin 2017-10-18 15:33:41 +0000 *** Bug 385904 has been marked as a duplicate of this bug. *** 1709196 26 andrewnguyen841 2017-10-31 21:20:38 +0000 I have a similar issue with kwin 5.10.5 on Debian Testing Linux. I have quick tile shortcuts assigned to Meta+Up/Down/Left/Right and whenever I attempt to quick-tile a maximized window via shortcut, it de-maximizes before I am able to quick tile it. If I activate the shortcut a second time, the window tiles as expected. 1712855 27 109016 mgraesslin 2017-11-22 20:06:12 +0000 Created attachment 109016 Proposed patch Attached is a patch built up on the suggestions we had so far. The suggestions didn't work, it broke existing test cases. This patch fixes the issue according to the tests and does not introduce regressions in other tests. Please give it a try. 1712996 28 till2.schaefer 2017-11-23 11:02:54 +0000 I applied the patch here on kwin 5.11.3 running on xorg-server 1.19.5 and it works like a charm. 1715068 29 mgraesslin 2017-12-04 17:31:27 +0000 Git commit 8a2796d280dd7e891724cb6e6d873a57e2ae8c52 by Martin Flöser. Committed on 04/12/2017 at 16:25. Pushed by graesslin into branch 'master'. Fix regression from KWin 5.9 regarding quick tiling Summary: The regression got introduced with 9934f5b57537feae54afd0c4366c90253638ada2. The order when setMaximize(false, false) was called changed in regard to when the quick tiling mode was adjusted. But just changing the ordering back was no solution as that would cause regressions in other areas (unit tests fail). This change builds up on the support for geometry update blocker on Wayland to be able to better support this situation without causing further regressions. Also this change rethinks the code area. There is an idea behind temporarily setting the quick tile mode to none and that is even documented in a comment: it should not confuse maximize. So let's do exactly that: call the maximize in the block where the quick tile mode is temporarily wrong. As that is only one branch the else branch performs the same steps. FIXED-IN: 5.12.0 Test Plan: Confirmation in bug report that patch fixes issue Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D9178 M +0 -16 autotests/integration/quick_tiling_test.cpp M +8 -5 geometry.cpp https://commits.kde.org/kwin/8a2796d280dd7e891724cb6e6d873a57e2ae8c52 2100485 30 2019nicholas 2022-02-02 20:41:16 +0000 Currently using Fedora 35 and it seems this bugged behavior has returned at some point. Using a keybind to quick tile a currently maximized window causes the window to unmaximize but not tile as desired until a subsequent quick tile bind is pressed. Has anyone else run into this issue? 2100523 31 nate 2022-02-02 22:54:57 +0000 Can you please file a new bug report and put it in the "See also" field for this one? 2100595 32 nortexoid 2022-02-03 07:43:07 +0000 Don't have this issue on Manjaro testing, plasma 5.23.5. 2107915 33 nortexoid 2022-02-25 08:24:34 +0000 The bug's returned for me as well, at least on wayland, plasma 5.24.1. Was another report ever filed? 109016 2017-11-22 20:06:12 +0000 2017-11-22 20:06:12 +0000 Proposed patch 0001-Fix-regression-from-KWin-5.9-regarding-quick-tiling.patch text/plain 4216 mgraesslin RnJvbSA4NGUzNjdmNWNjNmIxNDY1N2MxZWRhZjdjMDVjZTAwYzA3NjIxNDZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWFydGluPTIwRmw9QzM9QjZzZXI/PSA8bWdy YWVzc2xpbkBrZGUub3JnPgpEYXRlOiBXZWQsIDIyIE5vdiAyMDE3IDIwOjU3OjIyICswMTAwClN1 YmplY3Q6IFtQQVRDSF0gRml4IHJlZ3Jlc3Npb24gZnJvbSBLV2luIDUuOSByZWdhcmRpbmcgcXVp Y2sgdGlsaW5nCgpUaGUgcmVncmVzc2lvbiBnb3QgaW50cm9kdWNlZCB3aXRoIDk5MzRmNWI1NzUz N2ZlYWU1NGFmZDBjNDM2NmM5MDI1MzYzOGFkYTIuClRoZSBvcmRlciB3aGVuIHNldE1heGltaXpl KGZhbHNlLCBmYWxzZSkgd2FzIGNhbGxlZCBjaGFuZ2VkIGluIHJlZ2FyZCB0bwp3aGVuIHRoZSBx dWljayB0aWxpbmcgbW9kZSB3YXMgYWRqdXN0ZWQuIEJ1dCBqdXN0IGNoYW5naW5nIHRoZSBvcmRl cmluZwpiYWNrIHdhcyBubyBzb2x1dGlvbiBhcyB0aGF0IHdvdWxkIGNhdXNlIHJlZ3Jlc3Npb25z IGluIG90aGVyIGFyZWFzCih1bml0IHRlc3RzIGZhaWwpLgoKVGhpcyBjaGFuZ2UgYnVpbGRzIHVw IG9uIHRoZSBzdXBwb3J0IGZvciBnZW9tZXRyeSB1cGRhdGUgYmxvY2tlciBvbgpXYXlsYW5kIHRv IGJlIGFibGUgdG8gYmV0dGVyIHN1cHBvcnQgdGhpcyBzaXR1YXRpb24gd2l0aG91dCBjYXVzaW5n CmZ1cnRoZXIgcmVncmVzc2lvbnMuCgpBbHNvIHRoaXMgY2hhbmdlIHJldGhpbmtzIHRoZSBjb2Rl IGFyZWEuIFRoZXJlIGlzIGFuIGlkZWEgYmVoaW5kCnRlbXBvcmFyaWx5IHNldHRpbmcgdGhlIHF1 aWNrIHRpbGUgbW9kZSB0byBub25lIGFuZCB0aGF0IGlzIGV2ZW4KZG9jdW1lbnRlZCBpbiBhIGNv bW1lbnQ6IGl0IHNob3VsZCBub3QgY29uZnVzZSBtYXhpbWl6ZS4gU28gbGV0J3MgZG8KZXhhY3Rs eSB0aGF0OiBjYWxsIHRoZSBtYXhpbWl6ZSBpbiB0aGUgYmxvY2sgd2hlcmUgdGhlIHF1aWNrIHRp bGUKbW9kZSBpcyB0ZW1wb3JhcmlseSB3cm9uZy4gQXMgdGhhdCBpcyBvbmx5IG9uZSBicmFuY2gg dGhlIGVsc2UgYnJhbmNoCnBlcmZvcm1zIHRoZSBzYW1lIHN0ZXBzLgoKQlVHOiAzNzYxMDQKRklY RUQtSU46IDUuMTIuMAotLS0KIGF1dG90ZXN0cy9pbnRlZ3JhdGlvbi9xdWlja190aWxpbmdfdGVz dC5jcHAgfCAxNiAtLS0tLS0tLS0tLS0tLS0tCiBnZW9tZXRyeS5jcHAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgMTMgKysrKysrKystLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA4IGlu c2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2F1dG90ZXN0cy9pbnRl Z3JhdGlvbi9xdWlja190aWxpbmdfdGVzdC5jcHAgYi9hdXRvdGVzdHMvaW50ZWdyYXRpb24vcXVp Y2tfdGlsaW5nX3Rlc3QuY3BwCmluZGV4IDY5MGQyZTcuLjE5ODRmYWIgMTAwNjQ0Ci0tLSBhL2F1 dG90ZXN0cy9pbnRlZ3JhdGlvbi9xdWlja190aWxpbmdfdGVzdC5jcHAKKysrIGIvYXV0b3Rlc3Rz L2ludGVncmF0aW9uL3F1aWNrX3RpbGluZ190ZXN0LmNwcApAQCAtNTg0LDIzICs1ODQsNyBAQCB2 b2lkIFF1aWNrVGlsaW5nVGVzdDo6dGVzdFgxMVF1aWNrVGlsaW5nQWZ0ZXJWZXJ0TWF4aW1pemUo KQogICAgIFFWRVJJRlkocXVpY2tUaWxlQ2hhbmdlZFNweS5pc1ZhbGlkKCkpOwogICAgIFFGRVRD SChRdWlja1RpbGVNb2RlLCBtb2RlKTsKICAgICBjbGllbnQtPnNldFF1aWNrVGlsZU1vZGUobW9k ZSwgdHJ1ZSk7Ci0gICAgUUVYUEVDVF9GQUlMKCJsZWZ0IiwgIlF1aWNrIHRpbGluZyBub3Qgd29y a2luZyIsIENvbnRpbnVlKTsKLSAgICBRRVhQRUNUX0ZBSUwoInJpZ2h0IiwgIlF1aWNrIHRpbGlu ZyBub3Qgd29ya2luZyIsIENvbnRpbnVlKTsKLSAgICBRRVhQRUNUX0ZBSUwoInRvcCIsICJRdWlj ayB0aWxpbmcgbm90IHdvcmtpbmciLCBDb250aW51ZSk7Ci0gICAgUUVYUEVDVF9GQUlMKCJib3R0 b20iLCAiUXVpY2sgdGlsaW5nIG5vdCB3b3JraW5nIiwgQ29udGludWUpOwotICAgIFFFWFBFQ1Rf RkFJTCgidG9wIGxlZnQiLCAiUXVpY2sgdGlsaW5nIG5vdCB3b3JraW5nIiwgQ29udGludWUpOwot ICAgIFFFWFBFQ1RfRkFJTCgidG9wIHJpZ2h0IiwgIlF1aWNrIHRpbGluZyBub3Qgd29ya2luZyIs IENvbnRpbnVlKTsKLSAgICBRRVhQRUNUX0ZBSUwoImJvdHRvbSBsZWZ0IiwgIlF1aWNrIHRpbGlu ZyBub3Qgd29ya2luZyIsIENvbnRpbnVlKTsKLSAgICBRRVhQRUNUX0ZBSUwoImJvdHRvbSByaWdo dCIsICJRdWljayB0aWxpbmcgbm90IHdvcmtpbmciLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUo Y2xpZW50LT5xdWlja1RpbGVNb2RlKCksIG1vZGUpOwotICAgIFFFWFBFQ1RfRkFJTCgibGVmdCIs ICJRdWljayB0aWxpbmcgbm90IHdvcmtpbmciLCBDb250aW51ZSk7Ci0gICAgUUVYUEVDVF9GQUlM KCJyaWdodCIsICJRdWljayB0aWxpbmcgbm90IHdvcmtpbmciLCBDb250aW51ZSk7Ci0gICAgUUVY UEVDVF9GQUlMKCJ0b3AiLCAiUXVpY2sgdGlsaW5nIG5vdCB3b3JraW5nIiwgQ29udGludWUpOwot ICAgIFFFWFBFQ1RfRkFJTCgiYm90dG9tIiwgIlF1aWNrIHRpbGluZyBub3Qgd29ya2luZyIsIENv bnRpbnVlKTsKLSAgICBRRVhQRUNUX0ZBSUwoInRvcCBsZWZ0IiwgIlF1aWNrIHRpbGluZyBub3Qg d29ya2luZyIsIENvbnRpbnVlKTsKLSAgICBRRVhQRUNUX0ZBSUwoInRvcCByaWdodCIsICJRdWlj ayB0aWxpbmcgbm90IHdvcmtpbmciLCBDb250aW51ZSk7Ci0gICAgUUVYUEVDVF9GQUlMKCJib3R0 b20gbGVmdCIsICJRdWljayB0aWxpbmcgbm90IHdvcmtpbmciLCBDb250aW51ZSk7Ci0gICAgUUVY UEVDVF9GQUlMKCJib3R0b20gcmlnaHQiLCAiUXVpY2sgdGlsaW5nIG5vdCB3b3JraW5nIiwgQ29u dGludWUpOwogICAgIFFURVNUKGNsaWVudC0+Z2VvbWV0cnkoKSwgImV4cGVjdGVkR2VvbWV0cnki KTsKICAgICBRRVhQRUNUX0ZBSUwoIiIsICJXZSBnZXQgdHdvIGNoYW5nZWQgZXZlbnRzIiwgQ29u dGludWUpOwogICAgIFFDT01QQVJFKHF1aWNrVGlsZUNoYW5nZWRTcHkuY291bnQoKSwgMSk7CmRp ZmYgLS1naXQgYS9nZW9tZXRyeS5jcHAgYi9nZW9tZXRyeS5jcHAKaW5kZXggZDEyODIyMC4uNzg4 NWI2YiAxMDA2NDQKLS0tIGEvZ2VvbWV0cnkuY3BwCisrKyBiL2dlb21ldHJ5LmNwcApAQCAtMzM2 MCwxNiArMzM2MCwxOSBAQCB2b2lkIEFic3RyYWN0Q2xpZW50OjpzZXRRdWlja1RpbGVNb2RlKFF1 aWNrVGlsZU1vZGUgbW9kZSwgYm9vbCBrZXlib2FyZCkKICAgICAgICAgVGFiU3luY2hyb25pemVy IHN5bmNlcih0aGlzLCBUYWJHcm91cDo6UXVpY2tUaWxlfFRhYkdyb3VwOjpHZW9tZXRyeXxUYWJH cm91cDo6TWF4aW1pemVkKTsKIAogICAgICAgICBpZiAobW9kZSAhPSBRdWlja1RpbGVNb2RlKFF1 aWNrVGlsZUZsYWc6Ok5vbmUpKSB7Ci0gICAgICAgICAgICBtX3F1aWNrVGlsZU1vZGUgPSBtb2Rl OwogICAgICAgICAgICAgLy8gZGVjb3JhdGlvbnMgbWF5IHR1cm4gb2ZmIHNvbWUgYm9yZGVycyB3 aGVuIHRpbGVkCiAgICAgICAgICAgICBjb25zdCBGb3JjZUdlb21ldHJ5X3QgZ2VvbV9tb2RlID0g aXNEZWNvcmF0ZWQoKSA/IEZvcmNlR2VvbWV0cnlTZXQgOiBOb3JtYWxHZW9tZXRyeVNldDsKICAg ICAgICAgICAgIG1fcXVpY2tUaWxlTW9kZSA9IGludChRdWlja1RpbGVGbGFnOjpOb25lKTsgLy8g VGVtcG9yYXJ5LCBzbyB0aGUgbWF4aW1pemUgY29kZSBkb2Vzbid0IGdldCBhbGwgY29uZnVzZWQK KworICAgICAgICAgICAgc2V0TWF4aW1pemUoZmFsc2UsIGZhbHNlKTsKKwogICAgICAgICAgICAg c2V0R2VvbWV0cnkoZWxlY3RyaWNCb3JkZXJNYXhpbWl6ZUdlb21ldHJ5KGtleWJvYXJkID8gZ2Vv bWV0cnkoKS5jZW50ZXIoKSA6IEN1cnNvcjo6cG9zKCksIGRlc2t0b3AoKSksIGdlb21fbW9kZSk7 CisgICAgICAgICAgICAvLyBTdG9yZSB0aGUgbW9kZSBjaGFuZ2UKKyAgICAgICAgICAgIG1fcXVp Y2tUaWxlTW9kZSA9IG1vZGU7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBtX3F1aWNr VGlsZU1vZGUgPSBtb2RlOworICAgICAgICAgICAgc2V0TWF4aW1pemUoZmFsc2UsIGZhbHNlKTsK ICAgICAgICAgfQotICAgICAgICAvLyBTdG9yZSB0aGUgbW9kZSBjaGFuZ2UKLSAgICAgICAgbV9x dWlja1RpbGVNb2RlID0gbW9kZTsKLQotICAgICAgICBzZXRNYXhpbWl6ZShmYWxzZSwgZmFsc2Up OwogCiAgICAgICAgIGVtaXQgcXVpY2tUaWxlTW9kZUNoYW5nZWQoKTsKIAotLSAKMi43LjQKCg==