<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>369085</bug_id>
          
          <creation_ts>2016-09-19 22:33:11 +0000</creation_ts>
          <short_desc>Umbrello and KMymoney build with KF5 do not show icons</short_desc>
          <delta_ts>2022-08-15 07:56:30 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>Frameworks and Libraries</classification>
          <product>frameworks-kiconthemes</product>
          <component>general</component>
          <version>5.36.0</version>
          <rep_platform>Microsoft Windows</rep_platform>
          <op_sys>Microsoft Windows</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>382423</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ralf Habacker">ralf.habacker</reporter>
          <assigned_to name="Christoph Feck">cfeck</assigned_to>
          <cc>kdelibs-bugs-null</cc>
    
    <cc>null</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1623440</commentid>
    <comment_count>0</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2016-09-19 22:33:11 +0000</bug_when>
    <thetext>Running umbrello compiled for KF5 on Windows with KDE/emerge does not show any icons in the diagram tool bar.


Reproducible: Always

Steps to Reproduce:
1. Compile umbrello for KF5 on Windows using KDE/emerge
2. start umbrello


Actual Results:  
The diagram tool bar does not show any icons

Expected Results:  
The diagram tool bar should show icons.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1623669</commentid>
    <comment_count>1</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2016-09-20 18:40:40 +0000</bug_when>
    <thetext>Bug has been detected with KDE Frameworks 5.22.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1647655</commentid>
    <comment_count>2</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2016-12-26 21:17:19 +0000</bug_when>
    <thetext>The problem happens because on windows there is a misunderstanding between expected and installed path of ui_standards.rc.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1647657</commentid>
    <comment_count>3</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2016-12-26 21:23:39 +0000</bug_when>
    <thetext>Kxmlgui installs ui_standards.rc into &lt;install-root&gt;/etc/xdg/ui/ui_standards.rc and uses QStandardPaths::locate(QStandardPaths::GenericConfigLocation, QStringLiteral(&quot;ui/ui_standards.rc&quot;)) which is resolved on linux to &quot;/etc/xdg/ui/ui_standards.rc&quot; and on windows to &quot;C:/Users/&lt;USER&gt;/AppData/Local/ui/ui_standards.rc&quot; or &quot;C:/ProgramData/ui/ui_standards.rc&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1647694</commentid>
    <comment_count>4</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2016-12-27 08:05:07 +0000</bug_when>
    <thetext>The current QStandardPath implementation in Qt5 only supports hardcoded installation pathes 

1. bound to a fixed drive and 
2. bound to a fixed path 

KDE Applications on Window provided as portable, setup or msi packages have all required Qt5 and KF5 libraries bundled in the related binary packages. Issue 2 makes it impossible to build portable applications and to use installers with  with different frameworks versions because ui_standards.rc would be overwritten by other installers.

To solve the issues kxmlgui needs to embed ui_standards.rc into the installed shared library.
Another approach would be to patch Qt5 to support QStandardPaths directories relative to the Qt installation pathes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1648106</commentid>
    <comment_count>5</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2016-12-29 11:12:14 +0000</bug_when>
    <thetext>(In reply to Ralf Habacker from comment #4)
&gt; To solve the issues kxmlgui needs to embed ui_standards.rc into the
&gt; installed shared library.
kxmlgui already embeds ui_standards.rc into the shared library but installs the file too. The currently implemented logic prevents loading the embeded file if a related file is located in the file system (see https://cgit.kde.org/kxmlgui.git/tree/src/kxmlguiclient.cpp#n202) which the result that no ui_standards.rc file is loaded.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1695010</commentid>
    <comment_count>6</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2017-08-16 20:20:39 +0000</bug_when>
    <thetext>Moved the ui_standards.rc related stuff to bug 383609.

Retesting with KF 5.36 shows that there are still no icons in tool bars, which could be verified by downloading a portable snapshot for windows from https://software.opensuse.org/package/mingw32-umbrello5-portable?search_term=mingw32-umbrello5-portable

Using the workaround for loading the ui_standards.rc shows that there are still no icons on the toolbar, which let me think that this issue may have a different root cause. Because icon display is provided by kiconthemes library, I assume the root cause may be caused by this library. Any hints welcome how to fix the issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1695014</commentid>
    <comment_count>7</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2017-08-16 20:36:41 +0000</bug_when>
    <thetext>umbrello/KF5 on linux does not show this issue which let me think that this issue must be related to the windows implementation of kiconthemes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1769883</commentid>
    <comment_count>8</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2018-08-02 08:49:21 +0000</bug_when>
    <thetext>It looks that kiconthemes on Windows only supports binary icon resources, which is only implemented in the breeze, but not in the currently used oxygen icon package.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1769885</commentid>
    <comment_count>9</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2018-08-02 08:50:06 +0000</bug_when>
    <thetext>*** Bug 369086 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1769887</commentid>
    <comment_count>10</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2018-08-02 08:50:37 +0000</bug_when>
    <thetext>*** Bug 369087 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2007167</commentid>
    <comment_count>11</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2021-02-28 02:31:19 +0000</bug_when>
    <thetext>(In reply to Ralf Habacker from comment #8)
&gt; It looks that kiconthemes on Windows only supports binary icon resources,
&gt; which is only implemented in the breeze, but not in the currently used
&gt; oxygen icon package.

As a result of an investigation conducted for kmymoney, it looks like the rcc file provided by the Breeze theme can be used by a KF5 application on Windows if it is installed in the QStandardPaths::AppDataLocation directory and renamed to icontheme.rcc e.g.

copy &lt;install-root&gt;/share/icons/breeze/breeze-icons.rcc &lt;install-root&gt;/share/&lt;appname&gt;/icontheme.rcc</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2007519</commentid>
    <comment_count>12</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2021-03-01 08:45:43 +0000</bug_when>
    <thetext>(In reply to Ralf Habacker from comment #11)

&gt; &lt;install-root&gt;/share/&lt;appname&gt;/icontheme.rcc

Further investigation shows, that kiconthemes works by default in a &quot;standalone&quot; mode dedicated for a single appplication and ignores any installed KF5 icon themes provided for example by the mingw32-breeze5-icons package.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2020863</commentid>
    <comment_count>13</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2021-03-31 14:47:43 +0000</bug_when>
    <thetext>(In reply to Ralf Habacker from comment #12)
&gt; Further investigation shows, that kiconthemes works by default in a
&gt; &quot;standalone&quot; mode dedicated for a single appplication and ignores any
&gt; installed KF5 icon themes provided for example by the mingw32-breeze5-icons package.

See https://github.com/KDE/kiconthemes/blob/master/README.md for the reference</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2145769</commentid>
    <comment_count>14</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2022-08-15 07:56:30 +0000</bug_when>
    <thetext>Fixed by using workaround mentioned at https://bugs.kde.org/show_bug.cgi?id=369085#c11</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>