366138 2016-07-26 16:39:06 +0000 configure errors out when using Xcode 8 (clang 8.0.0) 2016-09-11 13:56:21 +0000 1 1 6 Developer tools valgrind general 3.12 SVN MacPorts macOS RESOLVED FIXED NOR normal --- 365327 1 jeremyhu rhyskidd douglas.pearless rhyskidd 0 oldest_to_newest 1610665 0 jeremyhu 2016-07-26 16:39:06 +0000 Using current trunk (valgrind r15915, vex r3232), valgrind is failing to configure when using Xcode 8. configure:5397: checking for a supported version of gcc configure:5481: result: no (8.0.0) configure:5483: error: please use gcc >= 3.0 or clang >= 2.9 or icc >= 13.0 The problem is with: applellvm-5.1|applellvm-6.*|applellvm-7.*) and also note that is_clang is not included in the error message. Reproducible: Always Steps to Reproduce: 1. Use Xcode 8 to build valgrind Actual Results: configure should have succeeded Expected Results: configure failed --- configure.ac.orig 2016-07-26 09:30:11.000000000 -0700 +++ configure.ac 2016-07-26 09:30:27.000000000 -0700 @@ -154,7 +154,7 @@ AM_CONDITIONAL(COMPILER_IS_ICC, test $is # Note: m4 arguments are quoted with [ and ] so square brackets in shell # statements have to be quoted. case "${is_clang}-${gcc_version}" in - applellvm-5.1|applellvm-6.*|applellvm-7.*) + applellvm-5.1|applellvm-[[6-9]].*|applellvm-[[1-9]][[0-9]].*) AC_MSG_RESULT([ok (Apple LLVM version ${gcc_version})]) ;; icc-1[[3-9]].*) @@ -167,7 +167,7 @@ case "${is_clang}-${gcc_version}" in AC_MSG_RESULT([ok (clang-${gcc_version})]) ;; *) - AC_MSG_RESULT([no (${gcc_version})]) + AC_MSG_RESULT([no (${is_clang}-${gcc_version})]) AC_MSG_ERROR([please use gcc >= 3.0 or clang >= 2.9 or icc >= 13.0]) ;; esac 1610667 1 100314 jeremyhu 2016-07-26 16:45:40 +0000 Created attachment 100314 configure.ac patch 1613035 2 rhyskidd 2016-08-10 06:48:13 +0000 Thanks, I'll take a look. As Xcode 8 remains in pre-release this isn't an urgent fix, although I aim to land this ahead of the next valgrind release. Such a release will hopefully also include initial support of macOS 10.12. 1620812 3 douglas.pearless 2016-09-11 01:35:56 +0000 i fixed my config script by changing: applellvm-5.1|applellvm-6.*|applellvm-7.*) to applellvm-5.1|applellvm-6.*|applellvm-7.*|applellvm-8.*) 1620964 4 rhyskidd 2016-09-11 13:45:17 +0000 Jeremy, I've split the fix into two. Your patch for an improved configure output message upon compiler version error landed in r15948. Thanks! Support for Xcode 8's clang compiler will land separately. 1620987 5 rhyskidd 2016-09-11 13:56:21 +0000 Xcode 8 support landed in r15949. Xcode 8 has a GM available to download. This applies to both OS X 10.11 and macOS 10.12; although the later requires further patches to land before Valgrind supports that xnu kernel. 100314 2016-07-26 16:45:40 +0000 2016-07-26 16:45:40 +0000 configure.ac patch patch-configure.ac.diff text/plain 852 jeremyhu aHR0cHM6Ly9idWdzLmtkZS5vcmcvc2hvd19idWcuY2dpP2lkPTM2NjEzOAoKLS0tIGNvbmZpZ3Vy ZS5hYy5vcmlnCTIwMTYtMDctMjYgMDk6MzA6MTEuMDAwMDAwMDAwIC0wNzAwCisrKyBjb25maWd1 cmUuYWMJMjAxNi0wNy0yNiAwOTozMDoyNy4wMDAwMDAwMDAgLTA3MDAKQEAgLTE1NCw3ICsxNTQs NyBAQCBBTV9DT05ESVRJT05BTChDT01QSUxFUl9JU19JQ0MsIHRlc3QgJGlzCiAjIE5vdGU6IG00 IGFyZ3VtZW50cyBhcmUgcXVvdGVkIHdpdGggWyBhbmQgXSBzbyBzcXVhcmUgYnJhY2tldHMgaW4g c2hlbGwKICMgc3RhdGVtZW50cyBoYXZlIHRvIGJlIHF1b3RlZC4KIGNhc2UgIiR7aXNfY2xhbmd9 LSR7Z2NjX3ZlcnNpb259IiBpbgotICAgICBhcHBsZWxsdm0tNS4xfGFwcGxlbGx2bS02Lip8YXBw bGVsbHZtLTcuKikKKyAgICAgYXBwbGVsbHZtLTUuMXxhcHBsZWxsdm0tW1s2LTldXS4qfGFwcGxl bGx2bS1bWzEtOV1dW1swLTldXS4qKQogCUFDX01TR19SRVNVTFQoW29rIChBcHBsZSBMTFZNIHZl cnNpb24gJHtnY2NfdmVyc2lvbn0pXSkKIAk7OwogICAgICBpY2MtMVtbMy05XV0uKikKQEAgLTE2 Nyw3ICsxNjcsNyBAQCBjYXNlICIke2lzX2NsYW5nfS0ke2djY192ZXJzaW9ufSIgaW4KIAlBQ19N U0dfUkVTVUxUKFtvayAoY2xhbmctJHtnY2NfdmVyc2lvbn0pXSkKIAk7OwogICAgICAqKQotCUFD X01TR19SRVNVTFQoW25vICgke2djY192ZXJzaW9ufSldKQorCUFDX01TR19SRVNVTFQoW25vICgk e2lzX2NsYW5nfS0ke2djY192ZXJzaW9ufSldKQogCUFDX01TR19FUlJPUihbcGxlYXNlIHVzZSBn Y2MgPj0gMy4wIG9yIGNsYW5nID49IDIuOSBvciBpY2MgPj0gMTMuMF0pCiAJOzsKIGVzYWMK