364822 2016-06-27 16:24:54 +0000 SVGs are not zoomed to fit 2018-03-01 23:27:35 +0000 1 1 2 Applications gwenview general Other (add details in bug description) Arch Linux Linux RESOLVED FIXED http://i.imgur.com/a4x1Yiu.png NOR normal --- 1 AndyKluger gwenview-bugs-null AndyKluger myriam nate https://commits.kde.org/gwenview/9b1714fc7b50be746f39e835c8b3146c38a9ddd9 17.12.3 0 oldest_to_newest 1603782 0 AndyKluger 2016-06-27 16:24:54 +0000 Gwenview 16.04.2 fails to enlarge SVGs, as attempted either by toggling the "Fit" button or selecting "Autofit each image" and "Enlarge smaller images" in the settings. View: http://i.imgur.com/a4x1Yiu.png Settings: http://i.imgur.com/g5y3j7c.png Reproducible: Always Steps to Reproduce: 1. "Autofit each image" and "Enlarge smaller images" in the settings 2. Open an SVG OR 1. Open an SVG 2. Toggle on the Fit button Actual Results: The SVG is displayed in its "original" small size. Expected Results: The SVG should be enlarged to fit the available space, as is the behavior with other image formats. I'm using - Arch Linux - qt5-imageformats 5.7.0 - kimageformats 5.23.0 I do not have kipi-plugins installed. 1699814 1 nate 2017-09-08 19:04:03 +0000 Confirmed. I suspect that there are a lot of people who would blow a blood vessel if this behavior were enabled, though... 1700351 2 AndyKluger 2017-09-10 16:05:56 +0000 (In reply to Nate Graham from comment #1) > Confirmed. I suspect that there are a lot of people who would blow a blood > vessel if this behavior were enabled, though... Why would someone who explicitly turns on auto fit, or someone who deliberately hits the auto fit button, blow a blood vessel if the program were to do what they asked? 1735080 3 null 2018-03-01 23:27:35 +0000 Git commit 9b1714fc7b50be746f39e835c8b3146c38a9ddd9 by Henrik Fehlauer. Committed on 01/03/2018 at 23:27. Pushed by rkflx into branch 'Applications/17.12'. Enlarge small SVGs too Summary: For images smaller than the viewport at 100% zoom, Gwenview allows to scale up the image to {nav Fit} the window if {nav Enlarge smaller images} is checked in the configuration dialog. So far this only worked for raster-based images, but not for SVGs. `mEnlargeSmallerImages` is meant to be handled by the abstract base class `AbstractImageView`, however when f00cef3c0 moved code over there from `RasterImageView`, it was missed to also adapt `SvgImageView`. This can be fixed by implementing the missing function. In addition, a left-over `bool` is removed. FIXED-IN: 17.12.3 Test Plan: - Open `icons/hisc-apps-gwenview.svgz`, press {nav Fit}: Small icon shown. - Check {nav Enlarge smaller images}, press {nav Fit} again: Icon scaled up to fit window. - Enlarging raster-based images still works fine. Reviewers: #gwenview, huoni, muhlenpfordt, ngraham Reviewed By: #gwenview, huoni, muhlenpfordt, ngraham Subscribers: ngraham, muhlenpfordt, huoni Differential Revision: https://phabricator.kde.org/D10926 M +0 -2 lib/documentview/rasterimageview.cpp M +6 -0 lib/documentview/svgviewadapter.cpp M +2 -0 lib/documentview/svgviewadapter.h https://commits.kde.org/gwenview/9b1714fc7b50be746f39e835c8b3146c38a9ddd9