<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>357210</bug_id>
          
          <creation_ts>2015-12-27 09:39:14 +0000</creation_ts>
          <short_desc>Red close icon does not work on colored backgrounds</short_desc>
          <delta_ts>2017-10-02 20:56:08 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>Frameworks and Libraries</classification>
          <product>frameworks-kwidgetsaddons</product>
          <component>general</component>
          <version>5.29.0</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.kde.org/show_bug.cgi?id=385299</see_also>
          <bug_file_loc>https://git.reviewboard.kde.org/r/126523/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Heiko Tietze">tietze.heiko</reporter>
          <assigned_to name="Uri Herrera">uri_herrera</assigned_to>
          <cc>andreas_k</cc>
    
    <cc>elvis.angelaccio</cc>
    
    <cc>kainz.a</cc>
    
    <cc>kdelibs-bugs-null</cc>
    
    <cc>mklapetek</cc>
          
          <cf_commitlink>https://commits.kde.org/kwidgetsaddons/497c463a4a430f8bef726bc415011d231bf9cf46</cf_commitlink>
          <cf_versionfixedin>5.30</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1566004</commentid>
    <comment_count>0</comment_count>
    <who name="Heiko Tietze">tietze.heiko</who>
    <bug_when>2015-12-27 09:39:14 +0000</bug_when>
    <thetext>The message panel has a colored background that jars with the red close icon.

Reproducible: Always</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1566133</commentid>
    <comment_count>1</comment_count>
    <who name="andreas_k">andreas_k</who>
    <bug_when>2015-12-27 19:46:22 +0000</bug_when>
    <thetext>screenshot please</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1566134</commentid>
    <comment_count>2</comment_count>
    <who name="Heiko Tietze">tietze.heiko</who>
    <bug_when>2015-12-27 20:07:46 +0000</bug_when>
    <thetext>The URL shows all three types of message panels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1579586</commentid>
    <comment_count>3</comment_count>
    <who name="Heiko Tietze">tietze.heiko</who>
    <bug_when>2016-02-29 23:06:36 +0000</bug_when>
    <thetext>Likely fixed, see https://git.reviewboard.kde.org/r/126523/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1579677</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Klapetek">mklapetek</who>
    <bug_when>2016-03-01 15:21:21 +0000</bug_when>
    <thetext>I&apos;m not sure if it&apos;s actually fixed, both window-close and dialog-close do not really work on the colored backgrounds of KMessageWidget. I&apos;m just not sure if that&apos;s something that should be fixed in the icon or in KMessageWidget (by setting a background for the button, for example)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1648291</commentid>
    <comment_count>5</comment_count>
    <who name="Elvis Angelaccio">elvis.angelaccio</who>
    <bug_when>2016-12-30 11:08:47 +0000</bug_when>
    <thetext>Reopened and moved to kwidgetsaddons, fix in https://phabricator.kde.org/D3418</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1648303</commentid>
    <comment_count>6</comment_count>
    <who name="Elvis Angelaccio">elvis.angelaccio</who>
    <bug_when>2016-12-30 11:32:27 +0000</bug_when>
    <thetext>Git commit 497c463a4a430f8bef726bc415011d231bf9cf46 by Elvis Angelaccio.
Committed on 30/12/2016 at 11:29.
Pushed by elvisangelaccio into branch &apos;master&apos;.

KMessageWidget: use darker red color when type is Error

Otherwise the close button is barely visible. There isn&apos;t an easy way to
change to color of the close button icon, so we use a slightly darker
background color instead.
FIXED-IN: 5.30

Differential Revision: D3418

M  +2    -0    src/kmessagewidget.cpp

https://commits.kde.org/kwidgetsaddons/497c463a4a430f8bef726bc415011d231bf9cf46</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>