354610 2015-10-30 18:05:59 +0000 ECMInstallIcons.cmake may call REMOVE_DUPLICATES(_themes) without checking if _themes is actually set. 2015-11-04 09:41:01 +0000 1 1 3 Frameworks and Libraries extra-cmake-modules general unspecified Compiled Sources Linux RESOLVED FIXED NOR normal --- 1 bricedb alex.merry ecm-bugs-null http://commits.kde.org/extra-cmake-modules/21629f651a6a5d9d977be03fd9f98417c4fa27ae 0 oldest_to_newest 1553682 0 bricedb 2015-10-30 18:05:59 +0000 git master commit fb7b8eea7d91772f989d5b060c86df20f2ebdb66 breaks ECMInstallIcons.cmake when calling REMOVE_DUPLICATES(_theme) when _theme is unset. This renders ksirk unconfigurable, possibly other packages too. A simple check whether _themes is set fixes this: --- extra-cmake-modules-1/modules/ECMInstallIcons.cmake 2015-10-30 18:53:04.065271019 +0100 +++ extra-cmake-modules/modules/ECMInstallIcons.cmake 2015-10-30 18:53:51.103271014 +0100 @@ -169,10 +169,12 @@ endif( _theme_GROUP) endforeach (_current_ICON) - list(REMOVE_DUPLICATES _themes) - foreach(_theme ${_themes}) - _ecm_update_iconcache("${_defaultpath}" "${_theme}") - endforeach() + if(_themes) + list(REMOVE_DUPLICATES _themes) + foreach(_theme ${_themes}) + _ecm_update_iconcache("${_defaultpath}" "${_theme}") + endforeach() + endif(_themes) endmacro() Reproducible: Always Steps to Reproduce: 1. install latest ecm 2. get latest ksirk git 3. try to get it configured. Actual Results: cmake error Expected Results: cmake succeeds fix: --- extra-cmake-modules-1/modules/ECMInstallIcons.cmake 2015-10-30 18:53:04.065271019 +0100 +++ extra-cmake-modules/modules/ECMInstallIcons.cmake 2015-10-30 18:53:51.103271014 +0100 @@ -169,10 +169,12 @@ endif( _theme_GROUP) endforeach (_current_ICON) - list(REMOVE_DUPLICATES _themes) - foreach(_theme ${_themes}) - _ecm_update_iconcache("${_defaultpath}" "${_theme}") - endforeach() + if(_themes) + list(REMOVE_DUPLICATES _themes) + foreach(_theme ${_themes}) + _ecm_update_iconcache("${_defaultpath}" "${_theme}") + endforeach() + endif(_themes) endmacro() 1553683 1 95229 bricedb 2015-10-30 18:07:34 +0000 Created attachment 95229 ecm-fix-ECMInstallIcons_cmake-1.patch 1554445 2 alex.merry 2015-11-03 12:05:34 +0000 Given that this only happens when ecm_install_icons is called in such a way that it does nothing, I figured it would be better to make it a warning: https://git.reviewboard.kde.org/r/125931/ In the meantime, ksirk can just have that ecm_install_icons call removed, as it is useless. 1554680 3 alex.merry 2015-11-04 09:41:01 +0000 Git commit 21629f651a6a5d9d977be03fd9f98417c4fa27ae by Alex Merry. Committed on 04/11/2015 at 09:40. Pushed by alexmerry into branch 'master'. Warn instead of error if ecm_install_icons finds no icons. The V1 syntax of ecm_install_icons searched for icons by globbing files with a particular naming pattern. If there were no such icons, this used to do nothing, but silently. Commit fb7b8eea7d accidentally made this an error. More sensible would be to make it a warning. REVIEW: 125931 M +8 -4 modules/ECMInstallIcons.cmake M +1 -0 tests/ECMInstallIconsTest/CMakeLists.txt A +1 -0 tests/ECMInstallIconsTest/v1-syntax-no-icons/CMakeLists.txt http://commits.kde.org/extra-cmake-modules/21629f651a6a5d9d977be03fd9f98417c4fa27ae 95229 2015-10-30 18:07:34 +0000 2015-10-30 18:07:34 +0000 ecm-fix-ECMInstallIcons_cmake-1.patch ecm-fix-ECMInstallIcons_cmake-1.patch text/plain 618 bricedb LS0tIGV4dHJhLWNtYWtlLW1vZHVsZXMtMS9tb2R1bGVzL0VDTUluc3RhbGxJY29ucy5jbWFrZQky MDE1LTEwLTMwIDE4OjUzOjA0LjA2NTI3MTAxOSArMDEwMAorKysgZXh0cmEtY21ha2UtbW9kdWxl cy9tb2R1bGVzL0VDTUluc3RhbGxJY29ucy5jbWFrZQkyMDE1LTEwLTMwIDE4OjUzOjUxLjEwMzI3 MTAxNCArMDEwMApAQCAtMTY5LDEwICsxNjksMTIgQEAKICAgICAgIGVuZGlmKCBfdGhlbWVfR1JP VVApCiAgICBlbmRmb3JlYWNoIChfY3VycmVudF9JQ09OKQogCi0gICBsaXN0KFJFTU9WRV9EVVBM SUNBVEVTIF90aGVtZXMpCi0gICBmb3JlYWNoKF90aGVtZSAke190aGVtZXN9KQotICAgICAgIF9l Y21fdXBkYXRlX2ljb25jYWNoZSgiJHtfZGVmYXVsdHBhdGh9IiAiJHtfdGhlbWV9IikKLSAgIGVu ZGZvcmVhY2goKQorICAgaWYoX3RoZW1lcykKKyAgICAgIGxpc3QoUkVNT1ZFX0RVUExJQ0FURVMg X3RoZW1lcykKKyAgICAgIGZvcmVhY2goX3RoZW1lICR7X3RoZW1lc30pCisgICAgICAgICAgX2Vj bV91cGRhdGVfaWNvbmNhY2hlKCIke19kZWZhdWx0cGF0aH0iICIke190aGVtZX0iKQorICAgICAg ZW5kZm9yZWFjaCgpCisgICBlbmRpZihfdGhlbWVzKQogCiBlbmRtYWNybygpCiAK