350612 2015-07-25 13:37:21 +0000 Custom folder icons aren't displayed. 2015-09-25 12:43:06 +0000 1 1 3 Frameworks and Libraries frameworks-kio general unspecified Other Linux RESOLVED FIXED NOR normal --- 1 perrantrevan faure arojas chgonzalezg chrno-sphered emmanuelpescosta099 ht990332 kdelibs-bugs-null http://commits.kde.org/kio/d8aafbc37daab3cd62ee77430a55b3d72ccc12e0 5.14 0 oldest_to_newest 1533269 0 perrantrevan 2015-07-25 13:37:21 +0000 Version 14.12.95 Archlinux AUR git package I changed the Downloads folders etc in my Home folder to custom icons which reflect their contents. However, since upgrading to Dolphin using Qt5, these custom icons don't show and setting them again using the properties dialogue doesn't work. In the latest Gwenview, however, the correct icons are displayed using it's browsing mode. Reproducible: Always 1534173 1 cfeck 2015-07-30 16:27:44 +0000 *** Bug 350761 has been marked as a duplicate of this bug. *** 1534396 2 emmanuelpescosta099 2015-07-31 16:53:18 +0000 Thanks for the bug report! I can reproduce it, I will have a look at it. 1534400 3 emmanuelpescosta099 2015-07-31 17:23:59 +0000 Also reproducible in the open/save file dialog. I'll reassign it to KIO. 1535969 4 93965 emmanuelpescosta099 2015-08-09 21:21:13 +0000 Created attachment 93965 Patch: show custom folder icons again I have found some time to have a look at it again, this problem was introduced by commit 46cd152f. I will upload my patch to review board tomorrow. 1536140 5 wbauer1 2015-08-10 18:50:06 +0000 *** Bug 346317 has been marked as a duplicate of this bug. *** 1536339 6 emmanuelpescosta099 2015-08-11 18:18:06 +0000 Git commit d8aafbc37daab3cd62ee77430a55b3d72ccc12e0 by Emmanuel Pescosta. Committed on 11/08/2015 at 18:13. Pushed by emmanuelp into branch 'master'. Show custom folder icons again Set mimetype as known when we assign the mime type for inode/directory This bug was introduced by commit 46cd152f FIXED-IN: 5.14 REVIEW: 124690 M +21 -0 autotests/kfileitemtest.cpp M +1 -0 autotests/kfileitemtest.h M +8 -8 src/core/kfileitem.cpp http://commits.kde.org/kio/d8aafbc37daab3cd62ee77430a55b3d72ccc12e0 1536353 7 perrantrevan 2015-08-11 20:09:35 +0000 Thanks a lot! 93965 2015-08-09 21:21:13 +0000 2015-08-09 21:21:13 +0000 Patch: show custom folder icons again 0001-Show-custom-folder-icons-again.patch text/plain 3575 emmanuelpescosta099 RnJvbSBlMDRhZWFkMDlhNDIwYTdiN2Y2OWFhOTdjOTkxYjYxNTg4ZTkyMDg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbW1hbnVlbCBQZXNjb3N0YSA8ZW1tYW51ZWxwZXNjb3N0YTA5 OUBnbWFpbC5jb20+CkRhdGU6IFN1biwgOSBBdWcgMjAxNSAyMzoxMTozOCArMDIwMApTdWJqZWN0 OiBbUEFUQ0hdIFNob3cgY3VzdG9tIGZvbGRlciBpY29ucyBhZ2FpbgoKU2V0IG1pbWV0eXBlIGFz IGtub3duIHdoZW4gd2UgYXNzaWduIHRoZSBtaW1lIHR5cGUgZm9yIGlub2RlL2RpcmVjdG9yeQoK VGhpcyBidWcgd2FzIGludHJvZHVjZWQgYnkgY29tbWl0IDQ2Y2QxNTJmCgpCVUc6IDM1MDYxMgpG SVhFRC1JTjogNS4xNAotLS0KIGF1dG90ZXN0cy9rZmlsZWl0ZW10ZXN0LmNwcCB8IDIxICsrKysr KysrKysrKysrKysrKysrKwogYXV0b3Rlc3RzL2tmaWxlaXRlbXRlc3QuaCAgIHwgIDEgKwogc3Jj L2NvcmUva2ZpbGVpdGVtLmNwcCAgICAgIHwgMTYgKysrKysrKystLS0tLS0tLQogMyBmaWxlcyBj aGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2F1 dG90ZXN0cy9rZmlsZWl0ZW10ZXN0LmNwcCBiL2F1dG90ZXN0cy9rZmlsZWl0ZW10ZXN0LmNwcApp bmRleCA0YTg3NDY5Li4xNDRmOTc1IDEwMDY0NAotLS0gYS9hdXRvdGVzdHMva2ZpbGVpdGVtdGVz dC5jcHAKKysrIGIvYXV0b3Rlc3RzL2tmaWxlaXRlbXRlc3QuY3BwCkBAIC0yNSw2ICsyNSw4IEBA CiAjaW5jbHVkZSA8cXRlbXBvcmFyeWRpci5oPgogI2luY2x1ZGUgPHF0ZW1wb3JhcnlmaWxlLmg+ CiAjaW5jbHVkZSA8a3VzZXIuaD4KKyNpbmNsdWRlIDxrZGVza3RvcGZpbGUuaD4KKyNpbmNsdWRl IDxrY29uZmlnZ3JvdXAuaD4KIAogUVRFU1RfTUFJTihLRmlsZUl0ZW1UZXN0KQogCkBAIC00NzIs NiArNDc0LDI1IEBAIHZvaWQgS0ZpbGVJdGVtVGVzdDo6dGVzdEN1cnJlbnRNaW1ldHlwZUZvclJl bW90ZUZvbGRlcldpdGhGaWxlVHlwZSgpCiAgICAgUUNPTVBBUkUoZmlsZUl0ZW0uY3VycmVudE1p bWVUeXBlKCkubmFtZSgpLCB1ZHNNaW1lVHlwZSk7CiB9CiAKK3ZvaWQgS0ZpbGVJdGVtVGVzdDo6 dGVzdEljb25OYW1lRm9yQ3VzdG9tRm9sZGVySWNvbnMoKQoreworICAgIC8vIEN1c3RvbSBmb2xk ZXIgaWNvbnMgYXJlbid0IGRpc3BsYXllZCAoYnVnIDM1MDYxMikKKworICAgIGNvbnN0IFFTdHJp bmcgaWNvbk5hbWUgPSBRU3RyaW5nTGl0ZXJhbCgiZm9sZGVyLW11c2ljIik7CisKKyAgICBRVGVt cG9yYXJ5RGlyIHRlbXBEaXI7CisgICAgY29uc3QgUVVybCB1cmwgPSBRVXJsOjpmcm9tTG9jYWxG aWxlKHRlbXBEaXIucGF0aCgpKTsKKyAgICBLRGVza3RvcEZpbGUgY2ZnKHVybC5wYXRoKCkgKyBR U3RyaW5nOjpmcm9tTGF0aW4xKCIvLmRpcmVjdG9yeSIpKTsKKyAgICBjZmcuZGVza3RvcEdyb3Vw KCkud3JpdGVFbnRyeSgiSWNvbiIsIGljb25OYW1lKTsKKyAgICBjZmcuc3luYygpOworCisgICAg S0lPOjpVRFNFbnRyeSBlbnRyeTsKKyAgICBlbnRyeS5pbnNlcnQoS0lPOjpVRFNFbnRyeTo6VURT X0ZJTEVfVFlQRSwgU19JRkRJUik7CisgICAgS0ZpbGVJdGVtIGZpbGVJdGVtKGVudHJ5LCB1cmwp OworCisgICAgUUNPTVBBUkUoZmlsZUl0ZW0uaWNvbk5hbWUoKSwgaWNvbk5hbWUpOworfQorCiAj aWZuZGVmIFFfT1NfV0lOIC8vIHVzZXIvZ3JvdXAvb3RoZXIgd3JpdGUgcGVybWlzc2lvbnMgYXJl IG5vdCBoYW5kbGVkIG9uIHdpbmRvd3MKIAogdm9pZCBLRmlsZUl0ZW1UZXN0Ojp0ZXN0SXNSZWFk YWJsZV9kYXRhKCkKZGlmZiAtLWdpdCBhL2F1dG90ZXN0cy9rZmlsZWl0ZW10ZXN0LmggYi9hdXRv dGVzdHMva2ZpbGVpdGVtdGVzdC5oCmluZGV4IDk1NjEyZWQuLjYxNTMyNGYgMTAwNjQ0Ci0tLSBh L2F1dG90ZXN0cy9rZmlsZWl0ZW10ZXN0LmgKKysrIGIvYXV0b3Rlc3RzL2tmaWxlaXRlbXRlc3Qu aApAQCAtNDEsNiArNDEsNyBAQCBwcml2YXRlIFFfU0xPVFM6CiAgICAgdm9pZCB0ZXN0TWltZXR5 cGVGb3JSZW1vdGVGb2xkZXJXaXRoRmlsZVR5cGUoKTsKICAgICB2b2lkIHRlc3RDdXJyZW50TWlt ZXR5cGVGb3JSZW1vdGVGb2xkZXIoKTsKICAgICB2b2lkIHRlc3RDdXJyZW50TWltZXR5cGVGb3JS ZW1vdGVGb2xkZXJXaXRoRmlsZVR5cGUoKTsKKyAgICB2b2lkIHRlc3RJY29uTmFtZUZvckN1c3Rv bUZvbGRlckljb25zKCk7CiAKICNpZm5kZWYgUV9PU19XSU4KICAgICB2b2lkIHRlc3RJc1JlYWRh YmxlX2RhdGEoKTsKZGlmZiAtLWdpdCBhL3NyYy9jb3JlL2tmaWxlaXRlbS5jcHAgYi9zcmMvY29y ZS9rZmlsZWl0ZW0uY3BwCmluZGV4IDM0NGFjNjcuLmRjM2E2YzEgMTAwNjQ0Ci0tLSBhL3NyYy9j b3JlL2tmaWxlaXRlbS5jcHAKKysrIGIvc3JjL2NvcmUva2ZpbGVpdGVtLmNwcApAQCAtNzMyLDE1 ICs3MzIsMTUgQEAgUU1pbWVUeXBlIEtGaWxlSXRlbTo6ZGV0ZXJtaW5lTWltZVR5cGUoKSBjb25z dAogICAgICAgICBRTWltZURhdGFiYXNlIGRiOwogICAgICAgICBpZiAoaXNEaXIoKSkgewogICAg ICAgICAgICAgZC0+bV9taW1lVHlwZSA9IGRiLm1pbWVUeXBlRm9yTmFtZSgiaW5vZGUvZGlyZWN0 b3J5Iik7Ci0gICAgICAgICAgICByZXR1cm4gZC0+bV9taW1lVHlwZTsKKyAgICAgICAgfSBlbHNl IHsKKyAgICAgICAgICAgIGJvb2wgaXNMb2NhbFVybDsKKyAgICAgICAgICAgIGNvbnN0IFFVcmwg dXJsID0gbW9zdExvY2FsVXJsKCZpc0xvY2FsVXJsKTsKKyAgICAgICAgICAgIGQtPm1fbWltZVR5 cGUgPSBkYi5taW1lVHlwZUZvclVybCh1cmwpOworICAgICAgICAgICAgLy8gd2FzOiAgZC0+bV9t aW1lVHlwZSA9IEtNaW1lVHlwZTo6ZmluZEJ5VXJsKCB1cmwsIGQtPm1fZmlsZU1vZGUsIGlzTG9j YWxVcmwgKTsKKyAgICAgICAgICAgIC8vID0+IHdlIGFyZSBubyBsb25nZXIgdXNpbmcgZC0+bV9m aWxlTW9kZSBmb3IgcmVtb3RlIFVSTHMuCisgICAgICAgICAgICBRX0FTU0VSVChkLT5tX21pbWVU eXBlLmlzVmFsaWQoKSk7CisgICAgICAgICAgICAvL3FEZWJ1ZygpIDw8IGQgPDwgImZpbmRpbmcg ZmluYWwgbWltZXR5cGUgZm9yIiA8PCB1cmwgPDwgIjoiIDw8IGQtPm1fbWltZVR5cGUubmFtZSgp OwogICAgICAgICB9Ci0gICAgICAgIGJvb2wgaXNMb2NhbFVybDsKLSAgICAgICAgY29uc3QgUVVy bCB1cmwgPSBtb3N0TG9jYWxVcmwoJmlzTG9jYWxVcmwpOwotICAgICAgICBkLT5tX21pbWVUeXBl ID0gZGIubWltZVR5cGVGb3JVcmwodXJsKTsKLSAgICAgICAgLy8gd2FzOiAgZC0+bV9taW1lVHlw ZSA9IEtNaW1lVHlwZTo6ZmluZEJ5VXJsKCB1cmwsIGQtPm1fZmlsZU1vZGUsIGlzTG9jYWxVcmwg KTsKLSAgICAgICAgLy8gPT4gd2UgYXJlIG5vIGxvbmdlciB1c2luZyBkLT5tX2ZpbGVNb2RlIGZv ciByZW1vdGUgVVJMcy4KLSAgICAgICAgUV9BU1NFUlQoZC0+bV9taW1lVHlwZS5pc1ZhbGlkKCkp OwotICAgICAgICAvL3FEZWJ1ZygpIDw8IGQgPDwgImZpbmRpbmcgZmluYWwgbWltZXR5cGUgZm9y IiA8PCB1cmwgPDwgIjoiIDw8IGQtPm1fbWltZVR5cGUubmFtZSgpOwogICAgICAgICBkLT5tX2JN aW1lVHlwZUtub3duID0gdHJ1ZTsKICAgICB9CiAKLS0gCjIuNS4wCgo=