343699 2015-02-02 15:10:10 +0000 Layer Preview thumbnails do not update until cursor hovers over the Layers Docker 2015-02-06 15:19:20 +0000 1 1 2 Applications krita Layer Stack unspecified Other Linux RESOLVED FIXED NOR normal --- 1 tysontanx halla griffinvalley halla http://commits.kde.org/calligra/75e35fbcd90b33a2df5d2c9276dd20db798f94db 0 oldest_to_newest 1496525 0 tysontanx 2015-02-02 15:10:10 +0000 Krita's Layer Preview thumbnail in Layers Docker does not update to reflect my recent my actions until I hover the cursor over the Layers Docker. By "Preview" I didn't mean the hover popup preview but the small thumbnail that always displayed in the Docker's left column. There are exceptions – Filling and Transformation seemed to trigger the re-generation of the thumbnail once the operation is finished. This problem as been there for a while, Boud reminded me about it in Bug 343685, so I decided to report it as well. Reproducible: Always Steps to Reproduce: 1. Create a new document; 2. Brush >> Fill_circle preset >> Enlarge brush size >> Pure Red (so it is more visible); 3. Draw something >> The Layers Docker's thumbnails do not update; 4. Move the cursor over the Layers docker >> The thumbnails get re-generated. Actual Results: Layer Preview thumbnails do not update until cursor hovers over the Layers Docker. Expected Results: The thumbnails automatically updates to refelct recent change. If real-time refreshing is too taxing, do it once per 5-10 seconds or 5-10 steps, at least. 1496567 1 halla 2015-02-02 18:38:55 +0000 Hm, the speed with which the thumbnail is painted when hovering over the layer box suggests that we do the thumbnail updating in a timeley fashion but that somehow the widget isn't redrawn. 1497597 2 halla 2015-02-06 12:04:16 +0000 This was already the case in 2.8, I see. 1497603 3 halla 2015-02-06 12:20:14 +0000 And 2.7 1497713 4 halla 2015-02-06 12:32:31 +0000 And 2.6. But interestingly, it's not just hovering over the layerbox that updates the previews, it's also when a dialog or message box pops up. 1498109 5 90941 halla 2015-02-06 13:22:28 +0000 Created attachment 90941 patch to enable immediate thumbnail updates This patch needs testing... It updates the thumbnail as you go. Here it doesn't seem to cause any performance regression, not even big images. I had another patch that would introduce a timed delay, but that made Krita deadlock all the time. 1498167 6 tysontanx 2015-02-06 14:02:54 +0000 Thank you for the patch. It seems to be working fine. I will keep my build static for a while to test it out. The preview updates the previous change when I begin a new action. Is that correct? 1498169 7 halla 2015-02-06 14:17:11 +0000 It depends a bit, painting gets updated when you end the stroke, but handling vector shapes causes immediate updates. 1498172 8 griffinvalley 2015-02-06 14:49:08 +0000 boud, unfortunately it does give me a slight performance regression. The tiles don't update as nicely as they should. Either make it optional(we have an entry for layer-thumbnails already), or discard it. 1498182 9 halla 2015-02-06 15:16:38 +0000 Git commit 65cfc79e83061aa9863a47e8a2641e750ee2cea2 by Boudewijn Rempt. Committed on 06/02/2015 at 13:49. Pushed by rempt into branch 'calligra/2.9'. M +10 -3 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp M +3 -1 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.h M +5 -0 krita/ui/KisDocumentSectionView.cpp M +1 -0 krita/ui/KisDocumentSectionView.h http://commits.kde.org/calligra/65cfc79e83061aa9863a47e8a2641e750ee2cea2 1498186 10 halla 2015-02-06 15:19:20 +0000 Git commit 75e35fbcd90b33a2df5d2c9276dd20db798f94db by Boudewijn Rempt. Committed on 06/02/2015 at 13:49. Pushed by rempt into branch 'master'. M +10 -3 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp M +3 -1 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.h M +5 -0 krita/ui/KisDocumentSectionView.cpp M +1 -0 krita/ui/KisDocumentSectionView.h http://commits.kde.org/calligra/75e35fbcd90b33a2df5d2c9276dd20db798f94db 90941 2015-02-06 13:22:28 +0000 2015-02-06 13:22:28 +0000 patch to enable immediate thumbnail updates updates.diff text/plain 3936 halla ZGlmZiAtLWdpdCBhL2tyaXRhL3BsdWdpbnMvZXh0ZW5zaW9ucy9kb2NrZXJzL2RlZmF1bHRkb2Nr ZXJzL2tpc19sYXllcl9ib3guY3BwIGIva3JpdGEvcGx1Z2lucy9leHRlbnNpb25zL2RvY2tlcnMv ZGVmYXVsdGRvY2tlcnMva2lzX2xheWVyX2JveC5jcHAKaW5kZXggNWQ3ZDJmYi4uZGIxNzI4YyAx MDA2NDQKLS0tIGEva3JpdGEvcGx1Z2lucy9leHRlbnNpb25zL2RvY2tlcnMvZGVmYXVsdGRvY2tl cnMva2lzX2xheWVyX2JveC5jcHAKKysrIGIva3JpdGEvcGx1Z2lucy9leHRlbnNpb25zL2RvY2tl cnMvZGVmYXVsdGRvY2tlcnMva2lzX2xheWVyX2JveC5jcHAKQEAgLTEyNCw3ICsxMjQsNyBAQCBL aXNMYXllckJveDo6S2lzTGF5ZXJCb3goKQogCiAgICAgUVdpZGdldCogbWFpbldpZGdldCA9IG5l dyBRV2lkZ2V0KHRoaXMpOwogICAgIHNldFdpZGdldChtYWluV2lkZ2V0KTsKLSAgICBtX2RlbGF5 VGltZXIuc2V0U2luZ2xlU2hvdCh0cnVlKTsKKyAgICBtX29wYWNpdHlEZWxheVRpbWVyLnNldFNp bmdsZVNob3QodHJ1ZSk7CiAKICAgICBtX3dkZ0xheWVyQm94LT5zZXR1cFVpKG1haW5XaWRnZXQp OwogCkBAIC0yMjYsNyArMjI2LDcgQEAgS2lzTGF5ZXJCb3g6Oktpc0xheWVyQm94KCkKICAgICBt X3dkZ0xheWVyQm94LT5kb3VibGVPcGFjaXR5LT5zZXRTdWZmaXgoIiUiKTsKIAogICAgIGNvbm5l Y3QobV93ZGdMYXllckJveC0+ZG91YmxlT3BhY2l0eSwgU0lHTkFMKHZhbHVlQ2hhbmdlZChxcmVh bCkpLCBTTE9UKHNsb3RPcGFjaXR5U2xpZGVyTW92ZWQocXJlYWwpKSk7Ci0gICAgY29ubmVjdCgm bV9kZWxheVRpbWVyLCBTSUdOQUwodGltZW91dCgpKSwgU0xPVChzbG90T3BhY2l0eUNoYW5nZWQo KSkpOworICAgIGNvbm5lY3QoJm1fb3BhY2l0eURlbGF5VGltZXIsIFNJR05BTCh0aW1lb3V0KCkp LCBTTE9UKHNsb3RPcGFjaXR5Q2hhbmdlZCgpKSk7CiAKICAgICBjb25uZWN0KG1fd2RnTGF5ZXJC b3gtPmNtYkNvbXBvc2l0ZSwgU0lHTkFMKGFjdGl2YXRlZChpbnQpKSwgU0xPVChzbG90Q29tcG9z aXRlT3BDaGFuZ2VkKGludCkpKTsKIApAQCAtMzMwLDYgKzMzMCw4IEBAIHZvaWQgS2lzTGF5ZXJC b3g6OnNldENhbnZhcyhLb0NhbnZhc0Jhc2UgKmNhbnZhcykKICAgICBpZiAobV9jYW52YXMpIHsK ICAgICAgICAgbV9pbWFnZSA9IG1fY2FudmFzLT5pbWFnZSgpOwogCisgICAgICAgIGNvbm5lY3Qo bV9pbWFnZSwgU0lHTkFMKHNpZ0ltYWdlVXBkYXRlZChRUmVjdCkpLCBTTE9UKHVwZGF0ZVRodW1i bmFpbCgpKSk7CisKICAgICAgICAgS2lzRG9jdW1lbnQqIGRvYyA9IHN0YXRpY19jYXN0PEtpc0Rv Y3VtZW50Kj4obV9jYW52YXMtPmltYWdlVmlldygpLT5kb2N1bWVudCgpKTsKICAgICAgICAgS2lz U2hhcGVDb250cm9sbGVyICprcml0YVNoYXBlQ29udHJvbGxlciA9IGR5bmFtaWNfY2FzdDxLaXNT aGFwZUNvbnRyb2xsZXIqPihkb2MtPnNoYXBlQ29udHJvbGxlcigpKTsKICAgICAgICAgS2lzRHVt bWllc0ZhY2FkZUJhc2UgKmtyaXRhRHVtbWllc0ZhY2FkZSA9IHN0YXRpY19jYXN0PEtpc0R1bW1p ZXNGYWNhZGVCYXNlKj4oa3JpdGFTaGFwZUNvbnRyb2xsZXIpOwpAQCAtNjUzLDcgKzY1NSw3IEBA IHZvaWQgS2lzTGF5ZXJCb3g6OnNsb3RPcGFjaXR5Q2hhbmdlZCgpCiB2b2lkIEtpc0xheWVyQm94 OjpzbG90T3BhY2l0eVNsaWRlck1vdmVkKHFyZWFsIG9wYWNpdHkpCiB7CiAgICAgbV9uZXdPcGFj aXR5ID0gb3BhY2l0eTsKLSAgICBtX2RlbGF5VGltZXIuc3RhcnQoMjAwKTsKKyAgICBtX29wYWNp dHlEZWxheVRpbWVyLnN0YXJ0KDIwMCk7CiB9CiAKIHZvaWQgS2lzTGF5ZXJCb3g6OnNsb3RDb2xs YXBzZWQoY29uc3QgUU1vZGVsSW5kZXggJmluZGV4KQpAQCAtNzc1LDQgKzc3Nyw5IEBAIHZvaWQg S2lzTGF5ZXJCb3g6OnNlbGVjdGlvbkNoYW5nZWQoY29uc3QgUU1vZGVsSW5kZXhMaXN0IHNlbGVj dGlvbikKICAgICB1cGRhdGVVSSgpOwogfQogCit2b2lkIEtpc0xheWVyQm94Ojp1cGRhdGVUaHVt Ym5haWwoKQoreworICAgIG1fd2RnTGF5ZXJCb3gtPmxpc3RMYXllcnMtPnVwZGF0ZU5vZGUobV93 ZGdMYXllckJveC0+bGlzdExheWVycy0+Y3VycmVudEluZGV4KCkpOworfQorCiAjaW5jbHVkZSAi a2lzX2xheWVyX2JveC5tb2MiCmRpZmYgLS1naXQgYS9rcml0YS9wbHVnaW5zL2V4dGVuc2lvbnMv ZG9ja2Vycy9kZWZhdWx0ZG9ja2Vycy9raXNfbGF5ZXJfYm94LmggYi9rcml0YS9wbHVnaW5zL2V4 dGVuc2lvbnMvZG9ja2Vycy9kZWZhdWx0ZG9ja2Vycy9raXNfbGF5ZXJfYm94LmgKaW5kZXggY2Ew MjYwOC4uNGI3OTY4OSAxMDA2NDQKLS0tIGEva3JpdGEvcGx1Z2lucy9leHRlbnNpb25zL2RvY2tl cnMvZGVmYXVsdGRvY2tlcnMva2lzX2xheWVyX2JveC5oCisrKyBiL2tyaXRhL3BsdWdpbnMvZXh0 ZW5zaW9ucy9kb2NrZXJzL2RlZmF1bHRkb2NrZXJzL2tpc19sYXllcl9ib3guaApAQCAtMTEwLDYg KzExMCw4IEBAIHByaXZhdGUgc2xvdHM6CiAKICAgICB2b2lkIHNlbGVjdGlvbkNoYW5nZWQoY29u c3QgUU1vZGVsSW5kZXhMaXN0IHNlbGVjdGlvbik7CiAKKyAgICB2b2lkIHVwZGF0ZVRodW1ibmFp bCgpOworCiBwcml2YXRlOgogICAgIGlubGluZSB2b2lkIGNvbm5lY3RBY3Rpb25Ub0J1dHRvbihL aXNWaWV3TWFuYWdlciogdmlldywgUUFic3RyYWN0QnV0dG9uICpidXR0b24sIGNvbnN0IFFTdHJp bmcgJmlkKTsKICAgICBpbmxpbmUgdm9pZCBhZGRBY3Rpb25Ub01lbnUoUU1lbnUgKm1lbnUsIGNv bnN0IFFTdHJpbmcgJmlkKTsKQEAgLTEyNCw3ICsxMjYsNyBAQCBwcml2YXRlOgogICAgIFFQb2lu dGVyPEtpc05vZGVNb2RlbD4gbV9ub2RlTW9kZWw7CiAgICAgUVBvaW50ZXI8S2lzTm9kZU1hbmFn ZXI+IG1fbm9kZU1hbmFnZXI7CiAgICAgVWlfV2RnTGF5ZXJCb3gqIG1fd2RnTGF5ZXJCb3g7Ci0g ICAgUVRpbWVyIG1fZGVsYXlUaW1lcjsKKyAgICBRVGltZXIgbV9vcGFjaXR5RGVsYXlUaW1lcjsK ICAgICBpbnQgbV9uZXdPcGFjaXR5OwogCiAgICAgUVZlY3RvcjxLaXNBY3Rpb24qPiBtX2FjdGlv bnM7CmRpZmYgLS1naXQgYS9rcml0YS91aS9LaXNEb2N1bWVudFNlY3Rpb25WaWV3LmNwcCBiL2ty aXRhL3VpL0tpc0RvY3VtZW50U2VjdGlvblZpZXcuY3BwCmluZGV4IDRmNTY1MjcuLmM5Mzg1ZGMg MTAwNjQ0Ci0tLSBhL2tyaXRhL3VpL0tpc0RvY3VtZW50U2VjdGlvblZpZXcuY3BwCisrKyBiL2ty aXRhL3VpL0tpc0RvY3VtZW50U2VjdGlvblZpZXcuY3BwCkBAIC0xMjgsNiArMTI4LDExIEBAIHZv aWQgS2lzRG9jdW1lbnRTZWN0aW9uVmlldzo6YWRkUHJvcGVydHlBY3Rpb25zKFFNZW51ICptZW51 LCBjb25zdCBRTW9kZWxJbmRleCAmCiAgICAgfQogfQogCit2b2lkIEtpc0RvY3VtZW50U2VjdGlv blZpZXc6OnVwZGF0ZU5vZGUoY29uc3QgUU1vZGVsSW5kZXggJmluZGV4KQoreworICAgIGRhdGFD aGFuZ2VkKGluZGV4LCBpbmRleCk7Cit9CisKIGJvb2wgS2lzRG9jdW1lbnRTZWN0aW9uVmlldzo6 dmlld3BvcnRFdmVudChRRXZlbnQgKmUpCiB7CiAgICAgaWYgKG1vZGVsKCkpIHsKZGlmZiAtLWdp dCBhL2tyaXRhL3VpL0tpc0RvY3VtZW50U2VjdGlvblZpZXcuaCBiL2tyaXRhL3VpL0tpc0RvY3Vt ZW50U2VjdGlvblZpZXcuaAppbmRleCA2ZjlhOWI2Li5mZmMwYzcwIDEwMDY0NAotLS0gYS9rcml0 YS91aS9LaXNEb2N1bWVudFNlY3Rpb25WaWV3LmgKKysrIGIva3JpdGEvdWkvS2lzRG9jdW1lbnRT ZWN0aW9uVmlldy5oCkBAIC0xMjIsNiArMTIyLDcgQEAgcHVibGljOgogICAgICAqLwogICAgIHZv aWQgYWRkUHJvcGVydHlBY3Rpb25zKFFNZW51ICptZW51LCBjb25zdCBRTW9kZWxJbmRleCAmaW5k ZXgpOwogCisgICAgdm9pZCB1cGRhdGVOb2RlKGNvbnN0IFFNb2RlbEluZGV4ICZpbmRleCk7CiAK IHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIGJvb2wgdmlld3BvcnRFdmVudChRRXZlbnQgKmV2ZW50 KTsK