<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>340487</bug_id>
          
          <creation_ts>2014-10-30 09:12:00 +0000</creation_ts>
          <short_desc>Add Album Category as a search criteria [patch]</short_desc>
          <delta_ts>2017-08-18 09:07:33 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>digikam</product>
          <component>Searches-Advanced</component>
          <version>4.4.0</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Vincent Tassy">timetre</reporter>
          <assigned_to name="Digikam Developers">digikam-bugs-null</assigned_to>
          <cc>caulier.gilles</cc>
          
          <cf_commitlink>http://commits.kde.org/digikam/4fdb64cff1e88a27312bc3759a5071a706efe612</cf_commitlink>
          <cf_versionfixedin>4.5.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1478735</commentid>
    <comment_count>0</comment_count>
    <who name="Vincent Tassy">timetre</who>
    <bug_when>2014-10-30 09:12:00 +0000</bug_when>
    <thetext>When Albums are created, one can assign a Category to it. Today, this information is never used.
It would be nice to add this as a potential search field in the Advanced Search dialog.

Reproducible: Always


Actual Results:  
Album Category is never used anywhere

Expected Results:  
User is able to to search for pictures in Albums from a particular Category</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1479247</commentid>
    <comment_count>1</comment_count>
      <attachid>89410</attachid>
    <who name="Vincent Tassy">timetre</who>
    <bug_when>2014-11-02 22:04:30 +0000</bug_when>
    <thetext>Created attachment 89410
Patch to add Album Category as a search criteria in Advanced Search

Adds a choice selector in the search Advanced Search dialog
Adds logic in the database query to handle it

Works fine here</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1480060</commentid>
    <comment_count>2</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2014-11-07 08:13:11 +0000</bug_when>
    <thetext>Git commit 4fdb64cff1e88a27312bc3759a5071a706efe612 by Gilles Caulier.
Committed on 07/11/2014 at 08:11.
Pushed by cgilles into branch &apos;master&apos;.

Apply patch #89410 from Vincent Tassy about to add Album Category as a search criteria in advanced Search tool
FIXED-IN: 4.5.0

M  +2    -1    NEWS
M  +1    -1    libs/database/imagequerybuilder.cpp
M  +15   -2    utilities/searchwindow/searchfields.cpp
M  +1    -0    utilities/searchwindow/searchgroup.cpp

http://commits.kde.org/digikam/4fdb64cff1e88a27312bc3759a5071a706efe612</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89410</attachid>
            <date>2014-11-02 22:04:30 +0000</date>
            <delta_ts>2014-11-02 22:04:30 +0000</delta_ts>
            <desc>Patch to add Album Category as a search criteria in Advanced Search</desc>
            <filename>AlbumCategorySearchAttribute.patch</filename>
            <type>text/plain</type>
            <size>2600</size>
            <attacher name="Vincent Tassy">timetre</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL2xpYnMvZGF0YWJhc2UvaW1hZ2VxdWVyeWJ1aWxkZXIuY3BwIGIvbGlicy9k
YXRhYmFzZS9pbWFnZXF1ZXJ5YnVpbGRlci5jcHAKaW5kZXggMWZkZjY2Yy4uODBhOGY0MyAxMDA2
NDQKLS0tIGEvbGlicy9kYXRhYmFzZS9pbWFnZXF1ZXJ5YnVpbGRlci5jcHAKKysrIGIvbGlicy9k
YXRhYmFzZS9pbWFnZXF1ZXJ5YnVpbGRlci5jcHAKQEAgLTg1MCw3ICs4NTAsNyBAQCBib29sIElt
YWdlUXVlcnlCdWlsZGVyOjpidWlsZEZpZWxkKFFTdHJpbmcmIHNxbCwgU2VhcmNoWG1sQ2FjaGlu
Z1JlYWRlciYgcmVhZGVyLAogICAgIH0KICAgICBlbHNlIGlmIChuYW1lID09ICJhbGJ1bWNvbGxl
Y3Rpb24iKQogICAgIHsKLSAgICAgICAgZmllbGRRdWVyeS5hZGRTdHJpbmdGaWVsZCgiQWxidW1z
LmNvbGxlY3Rpb24iKTsKKyAgICAgICAgZmllbGRRdWVyeS5hZGRDaG9pY2VTdHJpbmdGaWVsZCgi
QWxidW1zLmNvbGxlY3Rpb24iKTsKICAgICB9CiAgICAgZWxzZSBpZiAobmFtZSA9PSAidGFnaWQi
KQogICAgIHsKZGlmZiAtLWdpdCBhL3V0aWxpdGllcy9zZWFyY2h3aW5kb3cvc2VhcmNoZmllbGRz
LmNwcCBiL3V0aWxpdGllcy9zZWFyY2h3aW5kb3cvc2VhcmNoZmllbGRzLmNwcAppbmRleCA1MjA1
ZmUwLi40ZTcyYTkwIDEwMDY0NAotLS0gYS91dGlsaXRpZXMvc2VhcmNod2luZG93L3NlYXJjaGZp
ZWxkcy5jcHAKKysrIGIvdXRpbGl0aWVzL3NlYXJjaHdpbmRvdy9zZWFyY2hmaWVsZHMuY3BwCkBA
IC03Myw2ICs3Myw3IEBACiAjaW5jbHVkZSAidGFnc2NhY2hlLmgiCiAjaW5jbHVkZSAiY29sb3Js
YWJlbGZpbHRlci5oIgogI2luY2x1ZGUgInBpY2tsYWJlbGZpbHRlci5oIgorI2luY2x1ZGUgImFw
cGxpY2F0aW9uc2V0dGluZ3MuaCIKIAogdXNpbmcgbmFtZXNwYWNlIEtEY3Jhd0lmYWNlOwogCkBA
IC0xMDQsOSArMTA1LDIxIEBAIFNlYXJjaEZpZWxkKiBTZWFyY2hGaWVsZDo6Y3JlYXRlRmllbGQo
Y29uc3QgUVN0cmluZyYgbmFtZSwgU2VhcmNoRmllbGRHcm91cCogY29uCiAgICAgfQogICAgIGVs
c2UgaWYgKG5hbWUgPT0gImFsYnVtY29sbGVjdGlvbiIpCiAgICAgewotICAgICAgICBTZWFyY2hG
aWVsZFRleHQqIGNvbnN0IGZpZWxkID0gbmV3IFNlYXJjaEZpZWxkVGV4dChwYXJlbnQpOworICAg
ICAgICBTZWFyY2hGaWVsZENob2ljZSogY29uc3QgZmllbGQgPSBuZXcgU2VhcmNoRmllbGRDaG9p
Y2UocGFyZW50KTsKICAgICAgICAgZmllbGQtPnNldEZpZWxkTmFtZShuYW1lKTsKLSAgICAgICAg
ZmllbGQtPnNldFRleHQoaTE4bigiQWxidW0iKSwgaTE4bigiVGhlIGFsYnVtIGNvbGxlY3Rpb24g
Y29udGFpbnMiKSk7CisgICAgICAgIGZpZWxkLT5zZXRUZXh0KGkxOG4oIkFsYnVtIiksIGkxOG4o
IlRoZSBhbGJ1bSBjYXRlZ29yeSBpcyIpKTsKKyAgICAgICAgQXBwbGljYXRpb25TZXR0aW5ncyog
Y29uc3Qgc2V0dGluZ3MgPSBBcHBsaWNhdGlvblNldHRpbmdzOjppbnN0YW5jZSgpOworICAgICAg
ICBpZiAoc2V0dGluZ3MpCisgICAgICAgIHsKKyAgICAgICAgICAgIFFTdHJpbmdMaXN0IENhdGVn
b3JpZXMgPSBzZXR0aW5ncy0+Z2V0QWxidW1DYXRlZ29yeU5hbWVzKCk7CisgICAgICAgICAgICBp
bnQgc2l6ZSA9IENhdGVnb3JpZXMuc2l6ZSgpOworICAgICAgICAgICAgUVN0cmluZ0xpc3QgY2F0
ZWdvcnljaG9pY2VzOworICAgICAgICAgICAgZm9yKGludCBpPTA7IGk8c2l6ZTsgaSsrKQorICAg
ICAgICAgICAgeworICAgICAgICAgICAgICAgIGNhdGVnb3J5Y2hvaWNlcyA8PCBDYXRlZ29yaWVz
LmF0KGkpIDw8IENhdGVnb3JpZXMuYXQoaSk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBm
aWVsZC0+c2V0Q2hvaWNlKGNhdGVnb3J5Y2hvaWNlcyk7CisgICAgICAgIH0KICAgICAgICAgcmV0
dXJuIGZpZWxkOwogICAgIH0KICAgICBlbHNlIGlmIChuYW1lID09ICJ0YWdpZCIpCmRpZmYgLS1n
aXQgYS91dGlsaXRpZXMvc2VhcmNod2luZG93L3NlYXJjaGdyb3VwLmNwcCBiL3V0aWxpdGllcy9z
ZWFyY2h3aW5kb3cvc2VhcmNoZ3JvdXAuY3BwCmluZGV4IGFkMjlmNTMuLjc5NWU1MWEgMTAwNjQ0
Ci0tLSBhL3V0aWxpdGllcy9zZWFyY2h3aW5kb3cvc2VhcmNoZ3JvdXAuY3BwCisrKyBiL3V0aWxp
dGllcy9zZWFyY2h3aW5kb3cvc2VhcmNoZ3JvdXAuY3BwCkBAIC05Nyw2ICs5Nyw3IEBAIHZvaWQg
U2VhcmNoR3JvdXA6OnNldHVwKFR5cGUgdHlwZSkKIAogICAgIGdyb3VwLT5hZGRGaWVsZChTZWFy
Y2hGaWVsZDo6Y3JlYXRlRmllbGQoImFsYnVtaWQiLCBncm91cCkpOwogICAgIGdyb3VwLT5hZGRG
aWVsZChTZWFyY2hGaWVsZDo6Y3JlYXRlRmllbGQoImFsYnVtbmFtZSIsIGdyb3VwKSk7CisgICAg
Z3JvdXAtPmFkZEZpZWxkKFNlYXJjaEZpZWxkOjpjcmVhdGVGaWVsZCgiYWxidW1jb2xsZWN0aW9u
IiwgZ3JvdXApKTsKICAgICBncm91cC0+YWRkRmllbGQoU2VhcmNoRmllbGQ6OmNyZWF0ZUZpZWxk
KCJ0YWdpZCIsIGdyb3VwKSk7CiAgICAgZ3JvdXAtPmFkZEZpZWxkKFNlYXJjaEZpZWxkOjpjcmVh
dGVGaWVsZCgidGFnbmFtZSIsIGdyb3VwKSk7CiAgICAgZ3JvdXAtPmFkZEZpZWxkKFNlYXJjaEZp
ZWxkOjpjcmVhdGVGaWVsZCgibm90YWciLCBncm91cCkpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>