339584 2014-10-01 19:41:30 +0000 Web Interface has problems in loading certain magnet links 2014-11-08 11:54:47 +0000 1 1 2 Applications ktorrent general 4.3.1 Other Linux RESOLVED FIXED NOR normal --- 0 leszek.lesner joris.guisson http://commits.kde.org/ktorrent/2af04ef8e6607625458ca557dd26689503f17789 0 oldest_to_newest 1474094 0 leszek.lesner 2014-10-01 19:41:30 +0000 I was informed by one of our users that ktorrent has problems in the web user interface with opening certain magnet links. Example (only for the sake of example): This works fine: magnet:?xt=urn:btih:385821e75c87064d4a641bb3d6e23c6585d2e8c7&dn=2005+-+System+Of+A+Down+-+Mezmerize+%5BLimited+Edition+Picture+Dis&tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80&tr=udp%3A%2F%2Ftracker.publicbt.com%3A80&tr=udp%3A%2F%2Ftracker.istole.it%3A6969&tr=udp%3A%2F%2Fopen.demonii.com%3A1337 This one doesn't: magnet:?xt=urn:btih:bdd19c5f47cd6ad8c1791e5f2eba898d550fc680&dn=System+Of+A+Down+-+Mezmerize+%282005%29+Flac%5B24+Bit+96KHz+Vinyl%5D&tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80&tr=udp%3A%2F%2Ftracker.publicbt.com%3A80&tr=udp%3A%2F%2Ftracker.istole.it%3A6969&tr=udp%3A%2F%2Fopen.demonii.com%3A1337 Reproducible: Always Steps to Reproduce: 1. Enable Web Interface 2. Try to load "not working marked link" Actual Results: Produces an error (wrong link ?.) Expected Results: Load magnet link. I discovered that double escaping the url.value somehow seems to fix this issue. See attached patch 1474095 1 88922 leszek.lesner 2014-10-01 19:42:05 +0000 Created attachment 88922 Patch for action.js 1480237 2 joris.guisson 2014-11-08 11:54:47 +0000 Git commit 2af04ef8e6607625458ca557dd26689503f17789 by Joris Guisson. Committed on 08/11/2014 at 11:54. Pushed by guisson into branch 'master'. Fix some magnet links not working in webinterface plugin REVIEW: 120808 M +1 -0 ChangeLog M +1 -0 ktorrent/main.cpp M +2 -1 plugins/webinterface/www/common/action.js http://commits.kde.org/ktorrent/2af04ef8e6607625458ca557dd26689503f17789 88922 2014-10-01 19:42:05 +0000 2014-10-01 19:42:05 +0000 Patch for action.js action_js.patch text/plain 436 leszek.lesner LS0tIGEvYWN0aW9uLmpzCTIwMTMtMDEtMTQgMTg6MTI6MjQuMDAwMDAwMDAwICswMTAwCisrKyBi L2FjdGlvbi5qcwkyMDE0LTEwLTAxIDIxOjM5OjU5LjIwNDM0Nzk0OCArMDIwMApAQCAtMjQsNiAr MjQsNyBAQAogZnVuY3Rpb24gbG9hZF91cmwoKQogewogCXZhciB1cmwgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgidG9ycmVudF91cmwiKTsKLQlmZXRjaF94bWwoIi9hY3Rpb24/bG9hZF90b3Jy ZW50PSIgKyBlc2NhcGUodXJsLnZhbHVlKSxhY3Rpb25fb2ssYWN0aW9uX2Vycm9yKTsKKwl2YXIg ZXVybCA9IGVzY2FwZSh1cmwudmFsdWUpOworCWZldGNoX3htbCgiL2FjdGlvbj9sb2FkX3RvcnJl bnQ9IiArIGVzY2FwZShldXJsKSxhY3Rpb25fb2ssYWN0aW9uX2Vycm9yKTsKIAl1cmwudmFsdWUg PSAiIjsKIH0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==