<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>336899</bug_id>
          
          <creation_ts>2014-06-30 12:01:11 +0000</creation_ts>
          <short_desc>JJ &quot;activate next/previous layer&quot; shorcut</short_desc>
          <delta_ts>2017-02-06 13:43:41 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Layer Stack</component>
          <version>unspecified</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>junior-jobs</keywords>
          <priority>NOR</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Bollebib">kwadraatnope</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          <cc>dimula73</cc>
    
    <cc>halla</cc>
    
    <cc>nidhi98gupta</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1458654</commentid>
    <comment_count>0</comment_count>
    <who name="Bollebib">kwadraatnope</who>
    <bug_when>2014-06-30 12:01:11 +0000</bug_when>
    <thetext>&quot;activate next/previous layer&quot; shorcut already exists,but I propose an alternate version that should also be present.

The function as we have it works well,but skips groups entirely when it encounters them.
I propose a seperate other function that works like the  Qt layerbox shorcut.

Select layerbox
press up arrow/down arrow
-&gt;the layers get selected as expected,without skipping some layers.

This does however not work on canvas. 
So when on canvas the shortcut should also be recognized.




13:27:21 - Bollebib: When you use arrows up and down in layer box it selects like I would expect
13:27:36 - Bollebib: 1 space up and down each time
13:27:36 - Bollebib: this does not seem to be the same as activate next/previous layer which jumps from group to group and ignores group contents when present
13:28:00 - Bollebib: and when on canvas you can&apos;t use the arrows up and down as it is then used for nudging the canvas,which is arguably expected,but in that case I would expect those 2 seperate features not share the same shortcuts
13:28:00 - Bollebib: is there a way for me to access those functions and change the shortcuts in the settings?
13:28:23 - boud: Bollebib: aren&apos;t they in the shortcuts dialog?
13:28:54 - Bollebib: boud: the only ones I found work as I described,they skip between groups,they don&apos;t work the same
13:29:05 - boud: ah, wait
13:29:23 - boud: in the layerbox, arrow up and down isn&apos;t a shortcut... it&apos;s just what the Qt layerbox provides
13:29:50 - boud: same, probably, for the canvas which is in a scrolled pane, and that scrolls wit hthe arrow keys by default
13:31:44 - Bollebib: boud: is there a way to provide this functionality by just adding a seperate function ,similar to activate next/previous layer,but that works like the QT layerbox shortcut?
13:32:21 - Bollebib: and so that it does work when on canvas?
13:33:25 - boud: Bollebib: yes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1458658</commentid>
    <comment_count>1</comment_count>
    <who name="Bollebib">kwadraatnope</who>
    <bug_when>2014-06-30 12:15:05 +0000</bug_when>
    <thetext>this could then get another name or description obviously</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1499845</commentid>
    <comment_count>2</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2015-02-14 11:13:38 +0000</bug_when>
    <thetext>Implemented by now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1499879</commentid>
    <comment_count>3</comment_count>
    <who name="Bollebib">kwadraatnope</who>
    <bug_when>2015-02-14 13:43:37 +0000</bug_when>
    <thetext>Reopened as something was not clear


Activate next/previous only activates in the same hierarchy-level

I need it to access ALL the levels (like how the QT arrow shortcuts in the layerbox work)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1531380</commentid>
    <comment_count>4</comment_count>
      <attachid>93566</attachid>
    <who name="">g6793396</who>
    <bug_when>2015-07-11 18:32:29 +0000</bug_when>
    <thetext>Created attachment 93566
enter groups with activateNextNode/activatePreviousNode

Since this is probably a shortcut used to speed workflow up, skipping the selection of the groups themselves could be desirable. I made a couple of tries at that but it is pretty hard to get right with the layers panel seemingly upside-down, it is easy one way with
while (node &amp;&amp; node-&gt;childCount() &amp;&amp; node-&gt;lastChild()){ node = node-&gt;lastChild(); }
but the other way need some recursive stuff.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1572104</commentid>
    <comment_count>5</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2016-01-24 14:28:14 +0000</bug_when>
    <thetext>WISHGROUP: Small Usability Fixes

Ah, it doesn&apos;t actually enter groups yet, Dmitry says.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638036</commentid>
    <comment_count>6</comment_count>
    <who name="Bollebib">kwadraatnope</who>
    <bug_when>2016-11-06 11:11:42 +0000</bug_when>
    <thetext>right now ,this is actually solved.
But it does not go into hidden groups

i think even for hidden groups this should work,and go through EACH layer


might perhaps be necessary to close this bug and open a new one?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658184</commentid>
    <comment_count>7</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2017-02-02 08:04:40 +0000</bug_when>
    <thetext>Hi, Bollebib!

Should this shortcut be able to enter *locked* groups as well?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1659065</commentid>
    <comment_count>8</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2017-02-06 13:43:41 +0000</bug_when>
    <thetext>Fixed in https://phabricator.kde.org/R37:6a909e99b81e</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93566</attachid>
            <date>2015-07-11 18:32:29 +0000</date>
            <delta_ts>2015-07-11 18:32:29 +0000</delta_ts>
            <desc>enter groups with activateNextNode/activatePreviousNode</desc>
            <filename>krita-fix-336899</filename>
            <type>text/plain</type>
            <size>898</size>
            <attacher>g6793396</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL2tyaXRhL3VpL2tpc19ub2RlX21hbmFnZXIuY3BwIGIva3JpdGEvdWkva2lz
X25vZGVfbWFuYWdlci5jcHAKaW5kZXggMWVkNjUzZi4uMWY2OGE3MyAxMDA2NDQKLS0tIGEva3Jp
dGEvdWkva2lzX25vZGVfbWFuYWdlci5jcHAKKysrIGIva3JpdGEvdWkva2lzX25vZGVfbWFuYWdl
ci5jcHAKQEAgLTg3Miw2ICs4NzIsMTEgQEAgdm9pZCBLaXNOb2RlTWFuYWdlcjo6YWN0aXZhdGVO
ZXh0Tm9kZSgpCiAKICAgICBLaXNOb2RlU1Agbm9kZSA9IGFjdGl2ZU5vZGUtPm5leHRTaWJsaW5n
KCk7CiAKKyAgICAvLyBlbnRlciBncm91cAorICAgIGlmIChub2RlICYmICFub2RlLT5jb2xsYXBz
ZWQoKSAmJiBub2RlLT5maXJzdENoaWxkKCkpeworICAgICAgICBub2RlID0gbm9kZS0+Zmlyc3RD
aGlsZCgpOworICAgIH0KKwogICAgIGlmICghbm9kZSAmJiBhY3RpdmVOb2RlLT5wYXJlbnQoKSAm
JiBhY3RpdmVOb2RlLT5wYXJlbnQoKS0+cGFyZW50KCkpIHsKICAgICAgICAgbm9kZSA9IGFjdGl2
ZU5vZGUtPnBhcmVudCgpOwogICAgIH0KQEAgLTg5Miw2ICs4OTcsMTEgQEAgdm9pZCBLaXNOb2Rl
TWFuYWdlcjo6YWN0aXZhdGVQcmV2aW91c05vZGUoKQogCiAgICAgS2lzTm9kZVNQIG5vZGUgPSBh
Y3RpdmVOb2RlLT5wcmV2U2libGluZygpOwogCisgICAgLy8gZW50ZXIgZ3JvdXAKKyAgICBpZiAo
bm9kZSAmJiAhYWN0aXZlTm9kZS0+Y29sbGFwc2VkKCkgJiYgYWN0aXZlTm9kZS0+bGFzdENoaWxk
KCkpeworICAgICAgICBub2RlID0gYWN0aXZlTm9kZS0+bGFzdENoaWxkKCk7CisgICAgfQorCiAg
ICAgaWYgKCFub2RlICYmIGFjdGl2ZU5vZGUtPnBhcmVudCgpKSB7CiAgICAgICAgIG5vZGUgPSBh
Y3RpdmVOb2RlLT5wYXJlbnQoKS0+cHJldlNpYmxpbmcoKTsKICAgICB9Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>