<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>335666</bug_id>
          
          <creation_ts>2014-06-01 21:48:10 +0000</creation_ts>
          <short_desc>Has unsharp allows for radius &lt;= 1 and it ignores the decimal part</short_desc>
          <delta_ts>2017-08-07 07:16:52 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>digikam</product>
          <component>Plugin-Editor-Sharpen</component>
          <version>4.0.0</version>
          <rep_platform>Compiled Sources</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter>pochini</reporter>
          <assigned_to name="Digikam Developers">digikam-bugs-null</assigned_to>
          <cc>caulier.gilles</cc>
    
    <cc>pascalio432</cc>
          
          <cf_commitlink>http://commits.kde.org/digikam/86f5988b7b15b9de8e93750ad5d40db434ab8361</cf_commitlink>
          <cf_versionfixedin>4.1.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>20</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1452548</commentid>
    <comment_count>0</comment_count>
    <who name="">pochini</who>
    <bug_when>2014-06-01 21:48:10 +0000</bug_when>
    <thetext>Unsharp mask tool allows the user to set a radius &lt;= 1.0 and in that case is just overexposes the image. Furthermore, it ignores the decimal part of the number. Any value between 1.01 and 1.99, 2.00-2.99 and so on are the same. It behaves like very old versions of digikam. I checked v4.0.0-beta4 and it does not have this issue.

Reproducible: Always</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1452719</commentid>
    <comment_count>1</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2014-06-02 14:12:15 +0000</bug_when>
    <thetext>Git commit 86f5988b7b15b9de8e93750ad5d40db434ab8361 by Gilles Caulier.
Committed on 02/06/2014 at 14:09.
Pushed by cgilles into branch &apos;master&apos;.

With 4.0.0 release, blur filter algorithm have been changed, and radius argument precision have been dropped due to use an interger value intead a float value.
This commit fix this wrong cast to take a acre about radius precision with UnsharpMask filter
FIXED-IN: 4.1.0

M  +3    -1    NEWS
M  +3    -3    imageplugins/enhance/sharpentool.cpp
M  +1    -1    imageplugins/enhance/sharpentool.h
M  +25   -24   libs/dimg/filters/sharp/sharpsettings.cpp
M  +1    -1    libs/dimg/filters/sharp/sharpsettings.h
M  +4    -4    libs/dimg/filters/sharp/unsharpmaskfilter.cpp
M  +2    -2    libs/dimg/filters/sharp/unsharpmaskfilter.h

http://commits.kde.org/digikam/86f5988b7b15b9de8e93750ad5d40db434ab8361</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1480250</commentid>
    <comment_count>2</comment_count>
    <who name="pascalio">pascalio432</who>
    <bug_when>2014-11-08 12:52:19 +0000</bug_when>
    <thetext>Hello,
I&apos;m sorry to say so but the bug doesn&apos;t seem to be fixed to me... In digikam 4.2.0 (from Ubuntu&apos;s repositories, Ubuntu 14.10) the USM still overexposes images with radius &lt; 1 and &quot;amount&quot; param sets the amount of overexposition... Moreover, radius &gt; 1 results in massive over-sharpening as compared to 3.5.0&apos;s behaviour: I used to batch process some pictures in 3.5.0 with radius = 8, amount = 1 and threshold = 0.05 to get a subtly sharpened image, but the very same batch workflow in 4.2.0 yield a completely transformed image (ie. highly oversharpened, much more global contrast, looks like an enormous radius blur on top of an enormous USM contrast amount)

I compiled and installed 4.1.0 and the result was the same.
I get the same on to different machines running Ubuntu 14.10 and digikam 4.1.0 or 4.2.0.
Reproducible: still always</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>