<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>334587</bug_id>
          
          <creation_ts>2014-05-10 19:06:20 +0000</creation_ts>
          <short_desc>Ctrl + S shortcut does not Save/Save As of table, form, etc.</short_desc>
          <delta_ts>2019-02-18 19:39:55 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>KEXI</product>
          <component>General</component>
          <version>2.8.2</version>
          <rep_platform>Arch Linux</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>junior-jobs</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.8.4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Wojciech Kosowicz">pcellix</reporter>
          <assigned_to name="Wojciech Kosowicz">pcellix</assigned_to>
          <cc>adam</cc>
    
    <cc>inksi</cc>
    
    <cc>staniek</cc>
          
          <cf_commitlink>http://commits.kde.org/calligra/58b704a7eaa5efb2c99e67b43bc2911dda9e96e7</cf_commitlink>
          <cf_versionfixedin>2.8.4</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      <flag name="Usability"
          id="2926"
          type_id="4"
          status="+"
          setter="staniek"
    />

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1447419</commentid>
    <comment_count>0</comment_count>
    <who name="Wojciech Kosowicz">pcellix</who>
    <bug_when>2014-05-10 19:06:20 +0000</bug_when>
    <thetext>Key combination Ctrl + S seems like the most natural one to call Save/Save As.. in almost every software. Still it is not active while editing table, forms in Kexi

Reproducible: Always

Steps to Reproduce:
1. Open a table
2. Edit some field
3. Press Ctrl + S
Actual Results:  
Nothing happens

Expected Results:  
Save As dialog should appear if table has never been saved  and if it has been Save operation should be performed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1454847</commentid>
    <comment_count>1</comment_count>
    <who name="Wojciech Kosowicz">pcellix</who>
    <bug_when>2014-06-12 21:38:25 +0000</bug_when>
    <thetext>Git commit 0e1cfb1b74e7c88c03f66bca39dde8fffef5b092 by Wojciech Kosowicz.
Committed on 12/06/2014 at 21:25.
Pushed by wkosowicz into branch &apos;calligra/2.8&apos;.

Added Ctrl+S shortcut for save action in Kexi

Adding Ctrl + S shorcut for save action in kexi required suppresing
default behavior of this shortcut in KTextEditor
FIXED-IN: 2.8.4
REVIEW: 118631

M  +18   -11   kexi/main/KexiMainWindow.cpp
M  +1    -1    kexi/main/KexiMainWindow.h
M  +2    -0    kexi/widget/kexieditor.cpp

http://commits.kde.org/calligra/0e1cfb1b74e7c88c03f66bca39dde8fffef5b092</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1454849</commentid>
    <comment_count>2</comment_count>
    <who name="Wojciech Kosowicz">pcellix</who>
    <bug_when>2014-06-12 21:42:53 +0000</bug_when>
    <thetext>Git commit 58b704a7eaa5efb2c99e67b43bc2911dda9e96e7 by Wojciech Kosowicz.
Committed on 12/06/2014 at 21:25.
Pushed by wkosowicz into branch &apos;master&apos;.

Added Ctrl+S shortcut for save action in Kexi

Adding Ctrl + S shorcut for save action in kexi required suppresing
default behavior of this shortcut in KTextEditor
FIXED-IN: 2.8.4
REVIEW: 118631

M  +18   -11   kexi/main/KexiMainWindow.cpp
M  +1    -1    kexi/main/KexiMainWindow.h
M  +2    -0    kexi/widget/kexieditor.cpp

http://commits.kde.org/calligra/58b704a7eaa5efb2c99e67b43bc2911dda9e96e7</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455266</commentid>
    <comment_count>3</comment_count>
    <who name="Jarosław Staniek">staniek</who>
    <bug_when>2014-06-14 22:11:56 +0000</bug_when>
    <thetext>Git commit 7fca08a271f468c7f28c915c542e20cc80fa314f by Jaroslaw Staniek.
Committed on 14/06/2014 at 22:03.
Pushed by staniek into branch &apos;master&apos;.

Make main shortcuts trigger only enabled actions

This fixes a crash (when pressing Ctrl+S i Data mode) introduced while fixing bug #334587.
In addition added condition for Save/Save As methods so they are ignored in Data mode even if called explicitly.

M  +25   -7    kexi/main/KexiMainWindow.cpp
M  +19   -1    kexi/main/KexiMainWindow_p.h

http://commits.kde.org/calligra/7fca08a271f468c7f28c915c542e20cc80fa314f</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455268</commentid>
    <comment_count>4</comment_count>
    <who name="Jarosław Staniek">staniek</who>
    <bug_when>2014-06-14 22:12:06 +0000</bug_when>
    <thetext>Git commit 84dbc21f28da81c4f1449df72b7d95a6fb673618 by Jaroslaw Staniek.
Committed on 14/06/2014 at 22:03.
Pushed by staniek into branch &apos;calligra/2.8&apos;.

Make main shortcuts trigger only enabled actions

This fixes a crash (when pressing Ctrl+S i Data mode) introduced while fixing bug #334587.
In addition added condition for Save/Save As methods so they are ignored in Data mode even if called explicitly.

M  +25   -7    kexi/main/KexiMainWindow.cpp
M  +19   -1    kexi/main/KexiMainWindow_p.h

http://commits.kde.org/calligra/84dbc21f28da81c4f1449df72b7d95a6fb673618</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>