333608 2014-04-19 06:46:36 +0000 [PATCH] Prolog highlighting marks Swi-Prolog 7.x new dict syntax as warning 2014-06-07 13:45:58 +0000 1 1 2 Applications kate syntax Git unspecified Linux RESOLVED FIXED NOR normal --- 0 info kwrite-bugs-null walter.von.entferndt http://commits.kde.org/kate/ab1e932a6d9ea88b2219f23f3a5b0628ba7d5fce 4.14 0 oldest_to_newest 1442095 0 info 2014-04-19 06:46:36 +0000 Swi-Prolog (a rather popular Prolog implementation) uses special syntax involving the dot (.) operator for their new dict feature: http://swi-prolog.org/pldoc/man?section=dicts Current Kate's Prolog highlighter marks such usages of dot as warnings. This makes it harder to see actual warnings. Reproducible: Always Steps to Reproduce: 1. Enter p:- (a -> X = Y.c ; true) into a new file. 2. Save file as a Prolog file. Actual Results: Observe that dot in X.c is marked as warning (red background). Expected Results: Dot in X.c should not be marked as a warning. I have created a patch that removes dot warning markers in the relevant contexts (nested, curly, nested_expr). Nested context: usually inside if-then-else (->;), curly: inside dicts themself and dcg {} blocks, nested_expr: arithmetic expressions like X is A * (Y.c + 3). I have tested it with some files. Previously I used a workaround by avoiding the dot operator but recent changes in Swi made that impossible: http://swi-prolog.996271.n3.nabble.com/Ann-SWI-Prolog-7-1-13-td14825.html 1442096 1 86164 info 2014-04-19 06:50:09 +0000 Created attachment 86164 Pathc to remove dot warning in relevant contexts. Uploading possible patch. 1444588 2 dhaumann 2014-04-29 18:51:31 +0000 @Raivo: Is there any negative side effect of this patch? Otherwise, we'll commit this. 1445139 3 info 2014-05-02 09:24:20 +0000 @Dominik: I hoped to get a comment from the original author (added to CC) but that has not happened. This is my first time to modify an highlight file. Someone with a deeper knowledge of highlight definitions should review my patch that it does exactly what it says: removes 3 warning markers. As far as I see it does not touch any other rules or context transitions and thus can't have negative side effects. I use the patched file on my system and daily work on Prolog projects using Kate, no issues so far. 1448589 4 walter.von.entferndt 2014-05-15 14:37:00 +0000 answer(Patch) :- Patch is ok + well.done; commit(Patch). 1453776 5 dhaumann 2014-06-07 13:38:25 +0000 Git commit ab1e932a6d9ea88b2219f23f3a5b0628ba7d5fce by Dominik Haumann. Committed on 07/06/2014 at 13:37. Pushed by dhaumann into branch 'master'. fix: Prolog highlighting marks Swi-Prolog 7.x new dict syntax as warning Thanks to Raivo Laanemets for the patch! M +1 -4 part/syntax/data/prolog.xml http://commits.kde.org/kate/ab1e932a6d9ea88b2219f23f3a5b0628ba7d5fce 1453777 6 dhaumann 2014-06-07 13:39:33 +0000 Git commit babe8751b504200a354029216c1250aaf8fc3d3d by Dominik Haumann. Committed on 07/06/2014 at 13:38. Pushed by dhaumann into branch 'master'. fix: Prolog highlighting marks Swi-Prolog 7.x new dict syntax as warning M +1 -4 src/syntax/data/prolog.xml http://commits.kde.org/ktexteditor/babe8751b504200a354029216c1250aaf8fc3d3d 86164 2014-04-19 06:50:09 +0000 2014-04-19 06:50:09 +0000 Pathc to remove dot warning in relevant contexts. dot_no_warning.patch text/plain 1724 info ZGlmZiAtLWdpdCBwYXJ0L3N5bnRheC9kYXRhL3Byb2xvZy54bWwgcGFydC9zeW50YXgvZGF0YS9w cm9sb2cueG1sCmluZGV4IGU5YWNiNGQuLjFlNzJmNzQgMTAwNjQ0Ci0tLSBwYXJ0L3N5bnRheC9k YXRhL3Byb2xvZy54bWwKKysrIHBhcnQvc3ludGF4L2RhdGEvcHJvbG9nLnhtbApAQCAtNjU2LDcg KzY1Niw2IEBAIFRPRE8gc29ydGVkIGJ5IHByaW9yaXR5CiAJCTxEZXRlY3RDaGFyIGNoYXI9IiZj dXQ7IiBjb250ZXh0PSIjc3RheSIgYXR0cmlidXRlPSJOb3JtYWwgVGV4dCIgLz4KIAkJPERldGVj dENoYXIgY2hhcj0iJmJhcjsiIGNvbnRleHQ9IiNzdGF5IiBhdHRyaWJ1dGU9Im90aGVyIGJ1aWx0 LWluIG9wZXJhdG9yIiAvPgogCQk8RGV0ZWN0MkNoYXJzIGxvb2tBaGVhZD0idHJ1ZSIgY2hhcj0i JmRvdDsiIGNoYXIxPSIoIiBjb250ZXh0PSJsaXN0X2Z1bmN0b3IiIGF0dHJpYnV0ZT0iTm9ybWFs IFRleHQiIC8+Ci0JCTxSZWdFeHByIFN0cmluZz0iJmZ1bGxzdG9wX2lzbzsiIGNvbnRleHQ9IiNz dGF5IiBhdHRyaWJ1dGU9Ildhcm5pbmcgKCF1c2UgYmFja2dyb3VuZCkiIC8+CiAJCTxJbmNsdWRl UnVsZXMgY29udGV4dD0iYXRvbWljIiAvPgogCSAgICA8L2NvbnRleHQ+CiAJICAgIDxjb250ZXh0 IG5hbWU9ImN1cmx5IiBsaW5lRW5kQ29udGV4dD0iI3N0YXkiIGF0dHJpYnV0ZT0iU3ludGF4IEVy cm9yIiBub0luZGVudGF0aW9uQmFzZWRGb2xkaW5nPSJ0cnVlIiA+CkBAIC02NjksNyArNjY4LDYg QEAgVE9ETyBzb3J0ZWQgYnkgcHJpb3JpdHkKIAkJPERldGVjdENoYXIgY2hhcj0iJmN1dDsiIGNv bnRleHQ9IiNzdGF5IiBhdHRyaWJ1dGU9IkxvZ2ljICZhbXA7IENvbnRyb2wiIC8+CiAJCTxEZXRl Y3RDaGFyIGNoYXI9IiZiYXI7IiBjb250ZXh0PSIjc3RheSIgYXR0cmlidXRlPSJOb3JtYWwgVGV4 dCIgLz4KIAkJPERldGVjdDJDaGFycyBsb29rQWhlYWQ9InRydWUiIGNoYXI9IiZkb3Q7IiBjaGFy MT0iKCIgY29udGV4dD0ibGlzdF9mdW5jdG9yIiBhdHRyaWJ1dGU9Ik5vcm1hbCBUZXh0IiAvPgot CQk8UmVnRXhwciBTdHJpbmc9IiZmdWxsc3RvcF9pc287IiBjb250ZXh0PSIjc3RheSIgYXR0cmli dXRlPSJXYXJuaW5nICghdXNlIGJhY2tncm91bmQpIiAvPgogCQk8SW5jbHVkZVJ1bGVzIGNvbnRl eHQ9ImF0b21pYyIgLz4KIAkgICAgPC9jb250ZXh0PgogCkBAIC03MDIsNyArNzAwLDYgQEAgVE9E TyBzb3J0ZWQgYnkgcHJpb3JpdHkKIAkJPERldGVjdENoYXIgY2hhcj0iJmNvbW1hOyIgY29udGV4 dD0iI3N0YXkiIGF0dHJpYnV0ZT0iU3ludGF4IEVycm9yIiAvPgogCQk8IS0tIGJhciAmIGRvdCBj b3VsZCBiZSBhIHVzZXItZGVmJ2Qgb3AsIHByZS1kZWYnZCBvcHMgY291bGQgYmUgcmVkZWYnZDsg ZWxzZSB0aGVzZSB3ZXJlIGVycm9ycyAtLT4KIAkJPERldGVjdENoYXIgY2hhcj0iJmJhcjsiIGNv bnRleHQ9IiNzdGF5IiBhdHRyaWJ1dGU9Ik5vcm1hbCBUZXh0IiAvPgotCQk8UmVnRXhwciBTdHJp bmc9IiZmdWxsc3RvcF9pc287IiBjb250ZXh0PSIjc3RheSIgYXR0cmlidXRlPSJXYXJuaW5nICgh dXNlIGJhY2tncm91bmQpIiAvPgogCQk8UmVnRXhwciBTdHJpbmc9IiZsb2dpY19jb250cm9sX29w c19pc287IiBjb250ZXh0PSIjc3RheSIgYXR0cmlidXRlPSJvdGhlciBidWlsdC1pbiBvcGVyYXRv ciIgLz4KIAkJPEluY2x1ZGVSdWxlcyBjb250ZXh0PSJhcml0aF9leHByX2NvbW1vbiIgLz4KIAkg ICAgPC9jb250ZXh0Pgo=