331805 2014-03-06 10:16:31 +0000 selection gets bigger than image 2014-03-15 09:09:07 +0000 1 1 2 Applications krita General 2.8 Beta Kubuntu Linux RESOLVED FIXED NOR normal --- 1 martin.tlustos krita-bugs-null ghevan http://commits.kde.org/calligra/2b871ece55655a88ff01f1dec07f38c6f3d4824e 0 oldest_to_newest 1434107 0 martin.tlustos 2014-03-06 10:16:31 +0000 When selecting all ((Ctrl-A), then scaling down the selection, then inverting it, the selection includes parts outside the image. Reproducible: Always Steps to Reproduce: 1. Load an image 2. Ctrl-A 3. Scale down selection (e.g. 100px) 4. invert selection Actual Results: Selected area involves area outside of the image Expected Results: only image area should be selected (layer size is image size). When resizing workspace size to layer size, still there are parts outside th image area that are selected. 1434166 1 ghevan 2014-03-06 15:03:31 +0000 Thanks for the report I can confirm this bug. It seems using any grow, shrink, feather near the edge causes the invert selection to grow beyond viewable canvas. 1435486 2 85568 uso.cosmo.ray 2014-03-13 17:30:01 +0000 Created attachment 85568 Shoul fix the bug. 1435491 3 85569 uso.cosmo.ray 2014-03-13 18:13:17 +0000 Created attachment 85569 Fix the bug in a better way. 1435709 4 halla 2014-03-15 09:08:52 +0000 Git commit 23c430a10d2824f2cfc9279d7e2256f5f9d2a26d by Boudewijn Rempt. Committed on 15/03/2014 at 09:06. Pushed by rempt into branch 'master'. Patch by Matthias, thanks! CCMAIL:uso.cosmo.ray@gmail.com M +7 -0 krita/image/kis_pixel_selection.cpp http://commits.kde.org/calligra/23c430a10d2824f2cfc9279d7e2256f5f9d2a26d 1435710 5 halla 2014-03-15 09:09:07 +0000 Git commit 2b871ece55655a88ff01f1dec07f38c6f3d4824e by Boudewijn Rempt. Committed on 15/03/2014 at 09:06. Pushed by rempt into branch 'calligra/2.8'. Patch by Matthias, thanks! CCMAIL:uso.cosmo.ray@gmail.com M +7 -0 krita/image/kis_pixel_selection.cpp http://commits.kde.org/calligra/2b871ece55655a88ff01f1dec07f38c6f3d4824e 85568 2014-03-13 17:30:01 +0000 2014-03-13 18:13:17 +0000 Shoul fix the bug. 0001-Fix-this-bug-https-bugs.kde.org-show_bug.cgi-id-3318.patch text/plain 1162 uso.cosmo.ray RnJvbSBjZDk3ODRlMWY4ZjljODBmZDVkMWI1NmM4Y2Q2MTg0YjMyOTUwODMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXR0aGlhcyA8dXNvLmNvc21vLnJheUBnbWFpbC5jb20+CkRh dGU6IFRodSwgMTMgTWFyIDIwMTQgMTk6MjY6NTIgKzAxMDAKU3ViamVjdDogW1BBVENIXSBGaXgg dGhpcyBidWc6IGh0dHBzOi8vYnVncy5rZGUub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzE4MDUKCi0t LQoga3JpdGEvaW1hZ2Uva2lzX3BpeGVsX3NlbGVjdGlvbi5jcHAgfCA3ICsrKysrKysKIDEgZmls ZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9rcml0YS9pbWFnZS9raXNf cGl4ZWxfc2VsZWN0aW9uLmNwcCBiL2tyaXRhL2ltYWdlL2tpc19waXhlbF9zZWxlY3Rpb24uY3Bw CmluZGV4IGJjYzBhMWUuLjBhMmY2ZTEgMTAwNjQ0Ci0tLSBhL2tyaXRhL2ltYWdlL2tpc19waXhl bF9zZWxlY3Rpb24uY3BwCisrKyBiL2tyaXRhL2ltYWdlL2tpc19waXhlbF9zZWxlY3Rpb24uY3Bw CkBAIC0yNDMsNiArMjQzLDEzIEBAIHZvaWQgS2lzUGl4ZWxTZWxlY3Rpb246OmludmVydCgpCiAg ICAgLy8gUmVnaW9uIGlzIG5lZWRlZCBoZXJlIChub3QgZXhhY3RCb3VuZHMgb3IgZXh0ZW50KSwg YmVjYXVzZQogICAgIC8vIHVuc2VsZWN0ZWQgYnV0IGV4aXN0aW5nIHBpeGVscyBuZWVkIHRvIGJl IGludmVydGVkIHRvbwogICAgIFFSZWN0IHJjID0gcmVnaW9uKCkuYm91bmRpbmdSZWN0KCk7Cisg ICAgUVJlY3Qgd2hvbGVJbWdTaXplID0gZGVmYXVsdEJvdW5kcygpLT5ib3VuZHMoKTsKKworICAg IC8vIGNoZWNrIGlmIHJjIGhhdmUgYmlnZXIgc2l6ZSB0aGFuIHRoZSB3aG9sZSBpbWFnZSBhbmQg c2V0IHRoZSByYyBzaXplIHRvIHRoZSB3aG9sZSBpbWFnZSBvbmUgaWYgeWVzLgorICAgIGlmIChy Yy53aWR0aCgpID4gd2hvbGVJbWdTaXplLndpZHRoKCkpCisgICAgICByYy5zZXRXaWR0aCh3aG9s ZUltZ1NpemUud2lkdGgoKSk7CisgICAgaWYgKHJjLmhlaWdodCgpID4gd2hvbGVJbWdTaXplLmhl aWdodCgpKQorICAgICAgcmMuc2V0SGVpZ2h0KHdob2xlSW1nU2l6ZS5oZWlnaHQoKSk7CiAKICAg ICBpZiAoIXJjLmlzRW1wdHkoKSkgewogICAgICAgICBLaXNTZXF1ZW50aWFsSXRlcmF0b3IgaXQo dGhpcywgcmMpOwotLSAKMS45LjAKCg== 85569 2014-03-13 18:13:17 +0000 2014-03-13 18:13:17 +0000 Fix the bug in a better way. 0001-Fix-this-bug-https-bugs.kde.org-show_bug.cgi-id-3318.patch text/plain 1185 uso.cosmo.ray RnJvbSAyNWE1MzAyMmI1NjRjMzNkODRkNzJhM2U3MWM2YzgyNDgxMTA0ZmQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXR0aGlhcyA8dXNvLmNvc21vLnJheUBnbWFpbC5jb20+CkRh dGU6IFRodSwgMTMgTWFyIDIwMTQgMTk6MjY6NTIgKzAxMDAKU3ViamVjdDogW1BBVENIXSBGaXgg dGhpcyBidWc6IGh0dHBzOi8vYnVncy5rZGUub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzE4MDUKCi0t LQoga3JpdGEvaW1hZ2Uva2lzX3BpeGVsX3NlbGVjdGlvbi5jcHAgfCA3ICsrKysrKysKIDEgZmls ZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9rcml0YS9pbWFnZS9raXNf cGl4ZWxfc2VsZWN0aW9uLmNwcCBiL2tyaXRhL2ltYWdlL2tpc19waXhlbF9zZWxlY3Rpb24uY3Bw CmluZGV4IGJjYzBhMWUuLmNkOTAwYTYgMTAwNjQ0Ci0tLSBhL2tyaXRhL2ltYWdlL2tpc19waXhl bF9zZWxlY3Rpb24uY3BwCisrKyBiL2tyaXRhL2ltYWdlL2tpc19waXhlbF9zZWxlY3Rpb24uY3Bw CkBAIC0yNDMsNiArMjQzLDEzIEBAIHZvaWQgS2lzUGl4ZWxTZWxlY3Rpb246OmludmVydCgpCiAg ICAgLy8gUmVnaW9uIGlzIG5lZWRlZCBoZXJlIChub3QgZXhhY3RCb3VuZHMgb3IgZXh0ZW50KSwg YmVjYXVzZQogICAgIC8vIHVuc2VsZWN0ZWQgYnV0IGV4aXN0aW5nIHBpeGVscyBuZWVkIHRvIGJl IGludmVydGVkIHRvbwogICAgIFFSZWN0IHJjID0gcmVnaW9uKCkuYm91bmRpbmdSZWN0KCk7Cisg ICAgUVJlY3QgaW1hZ2VCb3VuZHMgPSBkZWZhdWx0Qm91bmRzKCktPmJvdW5kcygpOworCisgICAg Ly8gY2hlY2sgaWYgcmMgaGF2ZSBiaWdlciBzaXplIHRoYW4gdGhlIHdob2xlIGltYWdlIGFuZCBz ZXQgdGhlIHJjIHNpemUgdG8gdGhlIHdob2xlIGltYWdlIG9uZSBpZiB5ZXMuCisgICAgaWYgKHJj LndpZHRoKCkgPiBpbWFnZUJvdW5kcy53aWR0aCgpKQorICAgICAgcmMuc2V0V2lkdGgoaW1hZ2VC b3VuZHMuaW50ZXJzZWN0KHJjKS53aWR0aCgpKTsKKyAgICBpZiAocmMuaGVpZ2h0KCkgPiBpbWFn ZUJvdW5kcy5oZWlnaHQoKSkKKyAgICAgIHJjLnNldEhlaWdodChpbWFnZUJvdW5kcy5pbnRlcnNl Y3QocmMpLmhlaWdodCgpKTsKIAogICAgIGlmICghcmMuaXNFbXB0eSgpKSB7CiAgICAgICAgIEtp c1NlcXVlbnRpYWxJdGVyYXRvciBpdCh0aGlzLCByYyk7Ci0tIAoxLjkuMAoK