<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>328358</bug_id>
          
          <creation_ts>2013-12-03 08:10:26 +0000</creation_ts>
          <short_desc>Too many and too fast clicks on a canvas lead to a lock-up and switching to Default Tool</short_desc>
          <delta_ts>2017-06-26 15:24:39 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Tools</component>
          <version>git master (please specify the git hash!)</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dmitry Kazakov">dimula73</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          <cc>halla</cc>
          
          <cf_commitlink>https://commits.kde.org/krita/0a2002ff58ee46933352fb9446141cc37f77346c</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1416015</commentid>
    <comment_count>0</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2013-12-03 08:10:26 +0000</bug_when>
    <thetext>I guess, it is somehow related to the &quot;Triple Click&quot; feature that is used somewhere in Ko libs.

1) Click fast, click much, click long

Firstly, you will get a message that the layer is locked and painting is impossible (although it is not locked of course). Then the tool will be switched to Default Tool automatically.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1417818</commentid>
    <comment_count>1</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2013-12-11 13:42:29 +0000</bug_when>
    <thetext>Yes, pretty easy to reproduce.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418087</commentid>
    <comment_count>2</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2013-12-12 13:18:04 +0000</bug_when>
    <thetext>Git commit f7e58c09c0167fcf984b369e43ac6c206e8e4b7f by Dmitry Kazakov.
Committed on 12/12/2013 at 13:17.
Pushed by dkazakov into branch &apos;master&apos;.

Fix too fast mouse clicks (triple clicks) issue

M  +5    -0    krita/ui/tool/kis_tool.cc
M  +1    -0    krita/ui/tool/kis_tool.h

http://commits.kde.org/calligra/f7e58c09c0167fcf984b369e43ac6c206e8e4b7f</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418089</commentid>
    <comment_count>3</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2013-12-12 13:26:42 +0000</bug_when>
    <thetext>Git commit e2ccd93765584816da70af5747e7ef7b1ce71422 by Dmitry Kazakov.
Committed on 12/12/2013 at 13:17.
Pushed by dkazakov into branch &apos;calligra/2.8&apos;.

Fix too fast mouse clicks (triple clicks) issue

M  +5    -0    krita/ui/tool/kis_tool.cc
M  +1    -0    krita/ui/tool/kis_tool.h

http://commits.kde.org/calligra/e2ccd93765584816da70af5747e7ef7b1ce71422</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685343</commentid>
    <comment_count>4</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2017-06-26 13:59:10 +0000</bug_when>
    <thetext>Git commit e0cbb305bd5b48f1ab7e310c05fd7b5caa899755 by Boudewijn Rempt.
Committed on 26/06/2017 at 13:57.
Pushed by rempt into branch &apos;rempt/touch-painting&apos;.

Remove the triple-click event from KoToolBase

This was added in

commit a7a75f0056abf59cbce27957ab7fb0b6e64e2cb2
Author: C. Boemann &lt;cbo@boemann.dk&gt;
Date:   Thu Jan 12 22:13:26 2012 +0100

to make it possible to select text with triple-click. It broke
Krita, so was worked around in

commit e2ccd93765584816da70af5747e7ef7b1ce71422
Author: Dmitry Kazakov &lt;dimula73@gmail.com&gt;
Date:   Thu Dec 12 17:17:37 2013 +0400

    Fix too fast mouse clicks (triple clicks) issue

And we just don&apos;t need it at all anymore now that the text tool
is deprecated.

M  +0    -5    libs/flake/KoToolBase.cpp
M  +0    -8    libs/flake/KoToolBase.h
M  +4    -42   libs/flake/KoToolProxy.cpp
M  +1    -6    libs/flake/KoToolProxy_p.h
M  +0    -5    libs/ui/tool/kis_tool.cc
M  +0    -1    libs/ui/tool/kis_tool.h
M  +0    -22   plugins/flake/textshape/TextTool.cpp
M  +0    -13   plugins/flake/textshape/TextTool.h

https://commits.kde.org/krita/e0cbb305bd5b48f1ab7e310c05fd7b5caa899755</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685397</commentid>
    <comment_count>5</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2017-06-26 15:24:39 +0000</bug_when>
    <thetext>Git commit 0a2002ff58ee46933352fb9446141cc37f77346c by Boudewijn Rempt.
Committed on 26/06/2017 at 14:56.
Pushed by rempt into branch &apos;rempt/touch-paint-4&apos;.

Remove the triple-click event from KoToolBase

This was added in

commit a7a75f0056abf59cbce27957ab7fb0b6e64e2cb2
Author: C. Boemann &lt;cbo@boemann.dk&gt;
Date:   Thu Jan 12 22:13:26 2012 +0100

to make it possible to select text with triple-click. It broke
Krita, so was worked around in

commit e2ccd93765584816da70af5747e7ef7b1ce71422
Author: Dmitry Kazakov &lt;dimula73@gmail.com&gt;
Date:   Thu Dec 12 17:17:37 2013 +0400

    Fix too fast mouse clicks (triple clicks) issue

And we just don&apos;t need it at all anymore now that the text tool
is deprecated.

M  +0    -5    libs/flake/KoToolBase.cpp
M  +0    -8    libs/flake/KoToolBase.h
M  +5    -41   libs/flake/KoToolProxy.cpp
M  +1    -6    libs/flake/KoToolProxy_p.h
M  +0    -5    libs/ui/tool/kis_tool.cc
M  +0    -1    libs/ui/tool/kis_tool.h
M  +0    -22   plugins/flake/textshape/TextTool.cpp
M  +0    -11   plugins/flake/textshape/TextTool.h

https://commits.kde.org/krita/0a2002ff58ee46933352fb9446141cc37f77346c</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>