<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>326538</bug_id>
          
          <creation_ts>2013-10-24 02:04:40 +0000</creation_ts>
          <short_desc>When a picture is in portrait, face thumbnails are not rotated</short_desc>
          <delta_ts>2019-12-23 15:18:43 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>digikam</product>
          <component>Faces-Workflow</component>
          <version>4.0.0</version>
          <rep_platform>Ubuntu</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter>e.longuemare</reporter>
          <assigned_to name="Digikam Developers">digikam-bugs-null</assigned_to>
          <cc>caulier.gilles</cc>
          
          <cf_commitlink>https://commits.kde.org/digikam/9b154ceeecb732ecb97d6900ab0841e643639f4e</cf_commitlink>
          <cf_versionfixedin>7.0.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1405816</commentid>
    <comment_count>0</comment_count>
    <who name="">e.longuemare</who>
    <bug_when>2013-10-24 02:04:40 +0000</bug_when>
    <thetext>Face thumbnails from portrait pictures are not rotated.

Reproducible: Always

Steps to Reproduce:
1.open the face management UI
2.select a face tag 
3.
Actual Results:  
face thumbnail from portrait pictures are not rotated.

Expected Results:  
face thumbnail are rotated as in picture preview

Digikam Date de compilation : Oct 23 2013 (cible : debugfull) Rév. :b30c5252509249d783307609a863d3a9c406564

Nothing has been done : compile and launch digikam, select a face tag in face management UI.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1405822</commentid>
    <comment_count>1</comment_count>
    <who name="">e.longuemare</who>
    <bug_when>2013-10-24 02:12:45 +0000</bug_when>
    <thetext>For those portrait pictures, sometimes the thumbnail don&apos;t meet the face : it&apos;s another piece of picture which is thumb.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1405823</commentid>
    <comment_count>2</comment_count>
    <who name="">e.longuemare</who>
    <bug_when>2013-10-24 02:14:20 +0000</bug_when>
    <thetext>But face square is good in preview.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1406298</commentid>
    <comment_count>3</comment_count>
    <who name="">e.longuemare</who>
    <bug_when>2013-10-25 15:51:38 +0000</bug_when>
    <thetext>Hello,

Have a look in thumb database :

For those two pictures, same shot, Raw + JPEG:

SELECT * FROM digikam_thumb_clone.CustomIdentifiers where identifier like &quot;%IMG_0980%&quot;
&apos;detail:/media/DiskphotosTests/forêt mormal février 2012/IMG_0980.JPG?rect=774,667-845x845&apos;, &apos;693&apos;
&apos;detail:/media/DiskphotosTests/forêt mormal février 2012/IMG_0980.CR2?rect=769,557-974x1109&apos;, &apos;694&apos;

For the JPG picture, face thumb is well orientated (portrait).
For the CR2 (RAW) pictures, the face thumbnail is a piece of the picture but not the face.
For the CR2 pictures, face marker is well placed and good in database.

Expected result : For the CR2 file, face delimited by face marker is shown in the thumbnail view 

Thank you,

Eric</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1406444</commentid>
    <comment_count>4</comment_count>
    <who name="">e.longuemare</who>
    <bug_when>2013-10-26 09:38:08 +0000</bug_when>
    <thetext>This the same for all my shot with RAW+JPG : face marker/delimiter/rectangle is good in database but it display a bad thumbnail for RAW/CR2 files: another part of the picture is shown.

A workaround : 
1 - go to picture view (two clic on the thumbnail) and if needed check face marker/delimiter/rectangle
2 - edit the face marker/delimiter/rectangle by clicking on the tag
3 - move or enlarge a litle the face marker/delimiter/rectangle by clicking on the tag
4 - confirm

The thumbnail, in thumbview is ok.

without 3 - , nothing change in thumbnail display</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1406451</commentid>
    <comment_count>5</comment_count>
    <who name="">e.longuemare</who>
    <bug_when>2013-10-26 09:48:50 +0000</bug_when>
    <thetext>This the same for all my shot with RAW+JPG : face marker/delimiter/rectangle is good in database but it display a bad thumbnail for RAW/CR2 files: another part of the picture is shown.

A workaround : 
1 - go to picture view (two clic on the thumbnail) and if needed check face marker/delimiter/rectangle
2 - edit the face marker/delimiter/rectangle by clicking on the tag
3 - move or enlarge a litle the face marker/delimiter/rectangle by clicking on the tag
4 - confirm
5 - return to thumbnail view by one clic one the picture

The thumbnail, in thumbview is ok.

without 3 - , nothing change in thumbnail display</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469581</commentid>
    <comment_count>6</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2014-09-05 09:41:26 +0000</bug_when>
    <thetext>This dysfunction still reproducible using last digiKam 4.2.0 ?

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1605228</commentid>
    <comment_count>7</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2016-07-04 16:54:28 +0000</bug_when>
    <thetext>This problem still reproducible with digiKam 5.0.0 ?

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1642823</commentid>
    <comment_count>8</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2016-12-01 10:08:40 +0000</bug_when>
    <thetext>Any feedback with current AppImage bundle for Linux ?

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1694797</commentid>
    <comment_count>9</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2017-08-15 18:11:23 +0000</bug_when>
    <thetext>Git commit 9b154ceeecb732ecb97d6900ab0841e643639f4e by Gilles Caulier.
Committed on 15/08/2017 at 18:06.
Pushed by cgilles into branch &apos;master&apos;.

patch from Yingjie Liu for fix face tag region if image is rotated.
The tag region in database is not expected when rotate the image. The reason : function FaceGroup::aboutToSetInfo(const ImageInfo&amp; info) in https://cgit.kde.org/digikam.git/tree/utilities/facemanagement/facegroup.cpp#n359 invoked applyItemGeometryChanges() after transformation. Before FaceGroup::aboutToSetInfo(const ImageInfo&amp; info), the new coordination of tag region has been written into database. However, in applyItemGeometryChanges(), the tag region coordination of tag region will be change again in database which caused a wrong coordination.
A new FaceGroup::aboutToSetInfoAfterRotate(const ImageInfo&amp; info) is now used instead of FaceGroup::aboutToSetInfo(const ImageInfo&amp; info) which will not invoke applyItemGeometryChanges(). Then the coordination of tag region in database is true after image transformation.
Related: bug 376681, bug 381378

M  +4    -1    NEWS
M  +2    -1    app/views/imagepreviewview.cpp
M  +11   -0    utilities/facemanagement/facegroup.cpp
M  +2    -0    utilities/facemanagement/facegroup.h

https://commits.kde.org/digikam/9b154ceeecb732ecb97d6900ab0841e643639f4e</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1898070</commentid>
    <comment_count>10</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2019-12-23 15:18:43 +0000</bug_when>
    <thetext>Not reproducible with 7.0.0-beta1</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>