<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>324391</bug_id>
          
          <creation_ts>2013-09-02 11:32:20 +0000</creation_ts>
          <short_desc>Manually reordering task bar items not possible anymore without creating unintended shortcut icons</short_desc>
          <delta_ts>2013-09-25 11:59:40 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>plasma4</product>
          <component>widget-taskbar</component>
          <version>4.11.0</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>regression</keywords>
          <priority>NOR</priority>
          <bug_severity>major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Janek Bevendorff">kde</reporter>
          <assigned_to name="Plasma Bugs List">plasma-bugs-null</assigned_to>
          <cc>clemens.brunner</cc>
    
    <cc>hein</cc>
    
    <cc>jirislaby</cc>
          
          <cf_commitlink>http://commits.kde.org/kde-workspace/e1a590badee13b862c5393f45ea59ecad98a7267</cf_commitlink>
          <cf_versionfixedin>4.11.2</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1394377</commentid>
    <comment_count>0</comment_count>
    <who name="Janek Bevendorff">kde</who>
    <bug_when>2013-09-02 11:32:20 +0000</bug_when>
    <thetext>When I reorder taskbar buttons with the mouse, it always creates a shortcut icon for it which I actually don&apos;t want to create.

Steps to reproduce:
1. Create a taskbar widget on a panel, right click on it and open the taskbar settings.
2. Set &quot;Sorting&quot; to &quot;Manually&quot; and close the dialog.
3. Open at least two (non-modal) windows that show up on the taskbar
4. click the right-most and drag it to the left

Actual results:
A shortcut icon for the program is created left to the taskbar widget

This bug has been introduced in 4.11 (beta) and has not appeared in earlier versions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394438</commentid>
    <comment_count>1</comment_count>
    <who name="Myriam Schweingruber">myriam</who>
    <bug_when>2013-09-02 14:53:30 +0000</bug_when>
    <thetext>Confirmed with  KDE 4.11.0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394443</commentid>
    <comment_count>2</comment_count>
    <who name="Eike Hein">hein</who>
    <bug_when>2013-09-02 15:05:08 +0000</bug_when>
    <thetext>Do you have widgets unlocked? Because dragging a task outside of the Task Manager with widgets unlocked is expected to insert an icon widget, that&apos;s not a bug (I heavily use manual reordering myself and have no problems here with widgets locked).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394445</commentid>
    <comment_count>3</comment_count>
    <who name="Myriam Schweingruber">myriam</who>
    <bug_when>2013-09-02 15:15:50 +0000</bug_when>
    <thetext>I didn&apos;t drag outside the Task manager, but in the middle of it, but this created an icon outside. And yes, I have the widgets unlocked.

FWIW: I just tested this behavior, I don&apos;t usually do manual reordering.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394498</commentid>
    <comment_count>4</comment_count>
    <who name="Eike Hein">hein</who>
    <bug_when>2013-09-02 18:09:20 +0000</bug_when>
    <thetext>Git commit e1a590badee13b862c5393f45ea59ecad98a7267 by Eike Hein.
Committed on 02/09/2013 at 18:08.
Pushed by hein into branch &apos;KDE/4.11&apos;.

Don&apos;t propagate drops to the containment while animating.

Plus a little cleanup in the drag move and leave code ...

M  +14   -13   plasma/desktop/applets/tasks/package/contents/ui/MouseHandler.qml

http://commits.kde.org/kde-workspace/e1a590badee13b862c5393f45ea59ecad98a7267</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394499</commentid>
    <comment_count>5</comment_count>
    <who name="Eike Hein">hein</who>
    <bug_when>2013-09-02 18:10:44 +0000</bug_when>
    <thetext>The above commit fixes this issue, thanks for the report. As a clumsy but effective workaround for 4.11.0: Wait with dropping until the reordering animation finishes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394501</commentid>
    <comment_count>6</comment_count>
    <who name="Janek Bevendorff">kde</who>
    <bug_when>2013-09-02 18:13:25 +0000</bug_when>
    <thetext>Waiting until the animation finishes doesn&apos;t work very reliably. Most 
of the time that still creates a quick launch icon or sometimes also 
just an empty placeholder for an item (which can&apos;t be removed unless I 
explicitly place a new icon there and then remove that one).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394502</commentid>
    <comment_count>7</comment_count>
    <who name="Eike Hein">hein</who>
    <bug_when>2013-09-02 18:16:53 +0000</bug_when>
    <thetext>Well, then just apply that patch locally if you prefer (it&apos;s a QML file, so you don&apos;t need to recompile).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395146</commentid>
    <comment_count>8</comment_count>
    <who name="Janek Bevendorff">kde</who>
    <bug_when>2013-09-04 14:58:15 +0000</bug_when>
    <thetext>Short question: this fix won&apos;t solve problems with dragging taskbar 
items to a pager widget, will it?
This is a similar issue I&apos;ve been experiencing since the 4.11 betas. 
Dragging a taskbar button to one of the rectangles on a pager widget 
worked fine in 4.10.x and earlier, even with an unlocked desktop. Since 
4.11 this always creates shortcut icons if I&apos;m not very, very careful.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395250</commentid>
    <comment_count>9</comment_count>
    <who name="Eike Hein">hein</who>
    <bug_when>2013-09-05 01:00:54 +0000</bug_when>
    <thetext>Dragging tasks to the pager didn&apos;t work at all in 4.11.0 because of a missing feature in an underlying QML library. I readded this very early in the 4.11.1 release cycle after the library&apos;s maintainer came back from vacation to review my proposed patch. Between that addition, some further work on the DND code and this fix, dragging tasks to the pager should work very well now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1395251</commentid>
    <comment_count>10</comment_count>
    <who name="Eike Hein">hein</who>
    <bug_when>2013-09-05 01:02:36 +0000</bug_when>
    <thetext>(Note though that you can easily avoid any sort of &quot;create shortcut&quot; problem by simply locking widgets.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397908</commentid>
    <comment_count>11</comment_count>
    <who name="Eike Hein">hein</who>
    <bug_when>2013-09-18 06:20:02 +0000</bug_when>
    <thetext>*** Bug 325030 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1399418</commentid>
    <comment_count>12</comment_count>
    <who name="Eike Hein">hein</who>
    <bug_when>2013-09-25 11:59:40 +0000</bug_when>
    <thetext>*** Bug 325294 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>