<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>324349</bug_id>
          
          <creation_ts>2013-09-01 11:08:26 +0000</creation_ts>
          <short_desc>Removing tags limited to 250 selected pictures</short_desc>
          <delta_ts>2013-09-03 20:20:50 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>digikam</product>
          <component>Tags-Engine</component>
          <version>3.3.0</version>
          <rep_platform>Ubuntu</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Slobodan Simic">slsimic</reporter>
          <assigned_to name="Digikam Developers">digikam-bugs-null</assigned_to>
          <cc>caulier.gilles</cc>
    
    <cc>veaceslav.munteanu90</cc>
          
          <cf_commitlink>http://commits.kde.org/digikam/c2ba1fa1d43c04e9e7b72dd43a32d4c645ab0d5d</cf_commitlink>
          <cf_versionfixedin>3.5.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1394192</commentid>
    <comment_count>0</comment_count>
    <who name="Slobodan Simic">slsimic</who>
    <bug_when>2013-09-01 11:08:26 +0000</bug_when>
    <thetext>Option to remove tag is grayed out if you select more than 250 pictures while when assigning tags you can do it to entire collection. So if you assign some tag to a pictures by mistake, when you removing it you need to select 250 by 250...
It&apos;s a bit annoying when you have few thousands of photos.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394196</commentid>
    <comment_count>1</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2013-09-01 11:55:24 +0000</bug_when>
    <thetext>Veaceslav,

Can you confirm this problem through your Tags Manager ?

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394362</commentid>
    <comment_count>2</comment_count>
    <who name="Veaceslav Munteanu">veaceslav.munteanu90</who>
    <bug_when>2013-09-02 09:47:58 +0000</bug_when>
    <thetext>I will check it on my desktop computer, with my laptop, I don&apos;t have a enough big collection :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394365</commentid>
    <comment_count>3</comment_count>
    <who name="Veaceslav Munteanu">veaceslav.munteanu90</who>
    <bug_when>2013-09-02 10:15:44 +0000</bug_when>
    <thetext>Here is the relevant piece of code &amp; comment about performace:

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/utils/contextmenuhelper.cpp#L500

it&apos;s limited to 250 indeed :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394367</commentid>
    <comment_count>4</comment_count>
    <who name="">caulier.gilles</who>
    <bug_when>2013-09-02 10:22:14 +0000</bug_when>
    <thetext>Right.

As it&apos;s a limitation in context menu option, this behavior can be/must be different in Tags Manager.

Also, this limitation must show a message-box warnings...

Gilles Caulier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394439</commentid>
    <comment_count>5</comment_count>
    <who name="Veaceslav Munteanu">veaceslav.munteanu90</who>
    <bug_when>2013-09-02 14:59:24 +0000</bug_when>
    <thetext>Tags Manager is a little bit different:

It should be like Delete Selected Tag from Images

But here is Select images and remove Tag.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1394900</commentid>
    <comment_count>6</comment_count>
    <who name="Marcel Wiesweg">marcel.wiesweg</who>
    <bug_when>2013-09-03 20:09:40 +0000</bug_when>
    <thetext>Git commit c2ba1fa1d43c04e9e7b72dd43a32d4c645ab0d5d by Marcel Wiesweg.
Committed on 03/09/2013 at 20:04.
Pushed by mwiesweg into branch &apos;master&apos;.

I believe this performance check ended with the wrong result of cutting
the feature instead of cutting &quot;intelligent&quot; checks.
If &gt;250 images are selected, do not check if they have tags - that may be costly - but simply
leave the action enabled.

M  +2    -2    digikam/utils/contextmenuhelper.cpp

http://commits.kde.org/digikam/c2ba1fa1d43c04e9e7b72dd43a32d4c645ab0d5d</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>