323053 2013-07-31 16:30:39 +0000 commit 913219a357252bfaee15d0df88918d2c6e3a12cf broke live preview if "synchronize preview position..." action is enabled 2013-09-01 20:39:35 +0000 1 1 2 Applications kile general trunk-kde4 unspecified Linux RESOLVED FIXED NOR normal --- 0 eugene.shalygin+bugzilla.kde michel.ludwig sait.a.umar http://commits.kde.org/kile/a212fe70364e2e59af911a8619b7c272d1ce8876 0 oldest_to_newest 1387269 0 eugene.shalygin+bugzilla.kde 2013-07-31 16:30:39 +0000 When "synchronize preview position..." action is enabled, document viewer is not updated after recompilation. According to note for LivePreviewManager::ensureDocumentIsOpenInViewer(), it seems to me that hadToOpen and m_synchronizeViewWithCursorAction->isChecked() conditions have to be checked independently in LivePreviewManager::updatePreviewInformationAfterCompilationFinished() Reproducible: Always 1387270 1 81485 eugene.shalygin+bugzilla.kde 2013-07-31 16:31:34 +0000 Created attachment 81485 Illustration and possible fix Thes changes fix the problem for me 1394271 2 michel.ludwig 2013-09-01 18:53:47 +0000 Git commit a212fe70364e2e59af911a8619b7c272d1ce8876 by Michel Ludwig. Committed on 01/09/2013 at 18:51. Pushed by mludwig into branch 'master'. Fix the reloading of the document after live preview compilations Thanks to Eugene Shalygin for suggesting the fix! M +8 -6 src/livepreview.cpp http://commits.kde.org/kile/a212fe70364e2e59af911a8619b7c272d1ce8876 1394302 3 michel.ludwig 2013-09-01 20:39:35 +0000 *** Bug 322527 has been marked as a duplicate of this bug. *** 81485 2013-07-31 16:31:34 +0000 2013-07-31 16:31:34 +0000 Illustration and possible fix fix-livepreview.path text/plain 623 eugene.shalygin+bugzilla.kde ZGlmZiAtLWdpdCBzcmMvbGl2ZXByZXZpZXcuY3BwIHNyYy9saXZlcHJldmlldy5jcHAKaW5kZXgg ZDI3MzUxYi4uZWZhODY2YiAxMDA2NDQKLS0tIHNyYy9saXZlcHJldmlldy5jcHAKKysrIHNyYy9s aXZlcHJldmlldy5jcHAKQEAgLTEzODAsMTIgKzEzODAsMTAgQEAgdm9pZCBMaXZlUHJldmlld01h bmFnZXI6OnVwZGF0ZVByZXZpZXdJbmZvcm1hdGlvbkFmdGVyQ29tcGlsYXRpb25GaW5pc2hlZCgp CiAJCXNob3dQcmV2aWV3RmFpbGVkKCk7CiAJfQogCi0JaWYoIW1fc3luY2hyb25pemVWaWV3V2l0 aEN1cnNvckFjdGlvbi0+aXNDaGVja2VkKCkpIHsKLQkJaWYoIWhhZFRvT3BlbikgewotCQkJcmVs b2FkRG9jdW1lbnRJblZpZXdlcigpOwotCQl9CisJaWYoIWhhZFRvT3BlbikgeworCQlyZWxvYWRE b2N1bWVudEluVmlld2VyKCk7CiAJfQotCWVsc2UgeworCWlmKG1fc3luY2hyb25pemVWaWV3V2l0 aEN1cnNvckFjdGlvbi0+aXNDaGVja2VkKCkpIHsKIAkJc3luY2hyb25pemVWaWV3V2l0aEN1cnNv cihtX3J1bm5pbmdMYVRlWEluZm8sIG1fcnVubmluZ1RleHRWaWV3LCBtX3J1bm5pbmdUZXh0Vmll dy0+Y3Vyc29yUG9zaXRpb24oKSk7CiAJfQogCXNob3dQcmV2aWV3U3VjY2Vzc2Z1bCgpOwo=