<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>322980</bug_id>
          
          <creation_ts>2013-07-30 08:53:01 +0000</creation_ts>
          <short_desc>Mounted USB devices are no longer visible on Amarok start</short_desc>
          <delta_ts>2013-07-30 17:56:06 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>amarok</product>
          <component>Collections/USB mass storage and MSC</component>
          <version>2.7-git</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.kde.org/show_bug.cgi?id=317485</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>regression</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.8</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Myriam Schweingruber">myriam</reporter>
          <assigned_to name="Amarok Bugs">amarok-bugs-null</assigned_to>
          <cc>afiestas</cc>
    
    <cc>bart.cerneels</cc>
    
    <cc>matej</cc>
          
          <cf_commitlink>http://commits.kde.org/amarok/cfaa48278274f70fab3f6e1b610660edafbf7bbc</cf_commitlink>
          <cf_versionfixedin>2.8</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1386932</commentid>
    <comment_count>0</comment_count>
    <who name="Myriam Schweingruber">myriam</who>
    <bug_when>2013-07-30 08:53:01 +0000</bug_when>
    <thetext>Since yesterday, all mounted USB devices don&apos;t show anymore in the Collection Browser, they still did before I recompiled this morning.

Current amarok v2.7.90-68-g1b208a0

UMS collection enabled in the settings, 2 external USB HD mounted, one USB vfat key mounted, all devices show correctly in Dolphin, and show again when mounted once Amarok is started.

Regression: mounted USB devices should show in the collection browser on start.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1386934</commentid>
    <comment_count>1</comment_count>
    <who name="Myriam Schweingruber">myriam</who>
    <bug_when>2013-07-30 08:53:41 +0000</bug_when>
    <thetext>FWIW: I didn&apos;t update KDE packages in between</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1386996</commentid>
    <comment_count>2</comment_count>
    <who name="Matěj Laitl">matej</who>
    <bug_when>2013-07-30 12:57:11 +0000</bug_when>
    <thetext>This is the bug I&apos;ve worked on with Alex at Akqdemy.

Alex, have you promised me to tell me a work-around so that we can still work fine with older KDE releases?

*** This bug has been marked as a duplicate of bug 317485 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1387056</commentid>
    <comment_count>3</comment_count>
    <who name="Matěj Laitl">matej</who>
    <bug_when>2013-07-30 17:53:07 +0000</bug_when>
    <thetext>Okay, let&apos;s make this a non-dupe as we&apos;re going to work-around it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1387059</commentid>
    <comment_count>4</comment_count>
    <who name="Matěj Laitl">matej</who>
    <bug_when>2013-07-30 17:56:06 +0000</bug_when>
    <thetext>Git commit cfaa48278274f70fab3f6e1b610660edafbf7bbc by Matěj Laitl.
Committed on 30/07/2013 at 17:51.
Pushed by laitl into branch &apos;master&apos;.

MediaDeviceCache: work-around Solid UDisks2 bug by not calling allDevices()

Kudos go to Alex Fiestas for extensive debugging and finding out the
root of the problem.

BUGFIXES:
 * Work-around Solid UDisks2 backend bug that caused USB Mass Storage
   devices and iPods not being recognized when connected before Amarok
   was started. Also fixes a bug where blank devices would appear in
   Play Media dialog. (BR 322980)

We don&apos;t need to call Solid::Device::allDevices() at all because that
was only needed for Apple iPhone support for the *old* iPod collection
that was replaced in Amarok 2.6.
Related: bug 317485
FIXED-IN: 2.8

M  +3    -0    ChangeLog
M  +0    -23   src/MediaDeviceCache.cpp

http://commits.kde.org/amarok/cfaa48278274f70fab3f6e1b610660edafbf7bbc</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>