322348 2013-07-14 13:40:59 +0000 Removed labels still shows up in column view 2013-07-18 15:10:29 +0000 1 1 2 Applications dolphin view-engine: columns mode 2.2 Ubuntu Linux RESOLVED FIXED NOR normal --- 1 damien.porquet dolphin-bugs-null emmanuelpescosta099 http://commits.kde.org/kde-baseapps/5b81abea5be6d6d57da7a1ca953f8371b23b6528 4.11.0 0 oldest_to_newest 1383272 0 damien.porquet 2013-07-14 13:40:59 +0000 I need to refresh the view to make them disappear. No problem if I add a label. Reproducible: Always Steps to Reproduce: 1. setup dolphin to column view mode 2. add a label to a file 3. remove it Actual Results: removed label still shown Expected Results: removed label should disappear 1383331 1 emmanuelpescosta099 2013-07-14 18:18:17 +0000 Thanks for the bug report! I can reproduce this problem in Dolphin 4.10.90 1383339 2 emmanuelpescosta099 2013-07-14 19:05:59 +0000 Review Request: https://git.reviewboard.kde.org/r/111505/ 1383376 3 frank78ac 2013-07-14 22:40:57 +0000 Just to be sure that we understand what the problem is, could you try to describe the problem more clearly or provide a screenshot of the bug? The combination of "column view mode", "label" and the component "Information Panel" doesn't make much sense to me. Emmanuel's patch looks like it makes sense (I'll try to have a closer look tomorrow or on Tuesday), but it doesn't have anything to do with the Information Panel, so I'd prefer to make sure that we don't misunderstand the problem that you are seeing. Thanks for your help! 1383453 4 damien.porquet 2013-07-15 08:33:24 +0000 Thank you for the quick reply (and fix!). I attached it to the component "panel" since I change tags through this panel, but it should probably go to component "view engine: column mode" instead. 1384291 5 emmanuelpescosta099 2013-07-18 15:10:29 +0000 Git commit 5b81abea5be6d6d57da7a1ca953f8371b23b6528 by Emmanuel Pescosta. Committed on 18/07/2013 at 15:07. Pushed by emmanuelp into branch 'KDE/4.11'. Overwrite the changed role value with an empty QVariant, because the nepomuk roles provider doesn't overwrite it when the property value list is empty. REVIEW: 111505 FIXED-IN: 4.11.0 M +10 -2 dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp M +5 -1 dolphin/src/kitemviews/kfileitemmodelrolesupdater.h M +6 -1 dolphin/src/kitemviews/private/knepomukrolesprovider.cpp M +2 -0 dolphin/src/kitemviews/private/knepomukrolesprovider.h http://commits.kde.org/kde-baseapps/5b81abea5be6d6d57da7a1ca953f8371b23b6528