<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>321381</bug_id>
          
          <creation_ts>2013-06-19 13:23:21 +0000</creation_ts>
          <short_desc>The $SubmitPending flag is not cleared upon succesful submit</short_desc>
          <delta_ts>2014-03-16 17:41:49 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>trojita</product>
          <component>Message Composer</component>
          <version>git</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jan Kundrát">jkt</reporter>
          <assigned_to name="Trojita default assignee">trojita-bugs</assigned_to>
          
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1378016</commentid>
    <comment_count>0</comment_count>
    <who name="Jan Kundrát">jkt</who>
    <bug_when>2013-06-19 13:23:21 +0000</bug_when>
    <thetext>The code which will do this is commented out in Submission.cpp; there&apos;s a couple of issues with the logic in there.

Continuing from https://projects.flaska.net/issues/554.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1405974</commentid>
    <comment_count>1</comment_count>
    <who name="Jan Kundrát">jkt</who>
    <bug_when>2013-10-24 15:13:30 +0000</bug_when>
    <thetext>Git commit b34c62841241092fb188f47b8ea111999cf1ec0c by Jan Kundrát.
Committed on 23/10/2013 at 01:24.
Pushed by jkt into branch &apos;master&apos;.

Do not set the $SubmitPending flag during the initial submission attempt

The $SubmitPending IMAP keywords  on its own is meant to indicate that &quot;this
message needs to be sent out&quot; [1]; MUAs are supposed to use both $Submitted and
$SubmitPending when the message is actively submitted, and just $Submitted when
the message was sent.

This is a serious bug -- a reasonable client could very well look at the Sent
mailbox and tell users &quot;Hey, it looks like there&apos;s a ton of messages to be sent
in there which were never actually sent. Do you want me to send them now?&quot;. We
should have never set this flag without proper support for $Submitted in place,
but this misfeature has been around since mid-2012 :(.

Sorry to all who are affected by this, I haven&apos;t realized this implication.

[1] http://tools.ietf.org/html/rfc5550#section-5.10

REVIEW: 113396

M  +2    -2    src/Composer/Submission.cpp
M  +5    -5    tests/Composer/test_Composer_Submission.cpp

http://commits.kde.org/trojita/b34c62841241092fb188f47b8ea111999cf1ec0c</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>