321160 2013-06-14 21:46:47 +0000 WebKit renders an empty view when fed text/plain which contains 0x00 characters 2013-06-16 09:42:27 +0000 1 1 2 Applications trojita Desktop GUI git Other Linux RESOLVED FIXED NOR normal --- 1 jkt trojita-bugs http://commits.kde.org/trojita/14efb142be63e7a25542ea09ad571ca320eaec16 0 oldest_to_newest 1376679 0 80517 jkt 2013-06-14 21:46:47 +0000 Created attachment 80517 The "text/plain" attachment which contains zero bytes msg_2282_1 The SimplePartWidget renders an empty page instead of the actual content when fed with the test data (a real-world example from the kdepim ML). The only "weird thing" I recognize in there are the null bytes within the contents, but I have no proof that this is what is causing troubles here. 1377021 1 jkt 2013-06-16 09:42:25 +0000 Git commit 653e02203abe1211780633e962835827219a52dc by Jan Kundrát. Committed on 15/06/2013 at 00:15. Pushed by jkt into branch 'master'. When decoding from unknown encoding and assuming UTF-8, be sure to not stop at first NULL byte This does *not* fix #321160 (this code is not even triggered in this situation), but it's a sane thing to do anyway. I guess that the code shall be audited for other instances where we might silently truncate the data here; it's caused by an implicit conversion from QByteArray to uchar*. M +1 -1 src/Imap/Encoders.cpp http://commits.kde.org/trojita/653e02203abe1211780633e962835827219a52dc 1377022 2 jkt 2013-06-16 09:42:27 +0000 Git commit 14efb142be63e7a25542ea09ad571ca320eaec16 by Jan Kundrát. Committed on 15/06/2013 at 00:23. Pushed by jkt into branch 'master'. WebKit: convert plaintext input with NULL bytes without silent truncation This does *not* fix HTML input containing null bytes. I don't know if this problem is relevant for HTML e-mails as well. REVIEW: 111030 M +10 -1 src/Gui/SimplePartWidget.cpp http://commits.kde.org/trojita/14efb142be63e7a25542ea09ad571ca320eaec16 80517 2013-06-14 21:46:47 +0000 2013-06-14 21:46:47 +0000 The "text/plain" attachment which contains zero bytes msg_2282_1 msg_2282_1 text/plain 1052 jkt QW0gRnJlaXRhZywgMTQuIEp1bmkgMjAxMywgMTI6MTY6MzEgc2NocmllYiBTY2FybGV0dCBDbGFy azoNCj4gSSBqdXN0IHJlY2lldmVkIGhlbHAgaW4gSVJDIGluIHJlZ2FyZHMgdG8gPHF1b3RlPiAs IEkgYW0gd29ya2luZyBvbiB0aGF0DQo+IG5vdy4NCj4gVGhlIEVCTiBoYXMgdGhpczoNCj4gVGhl IG1hcmt1cCBkb2VzIG5vdCBzZWVtIHRvIHVzZSB0aGUgJnVuZGVyRkRMOyBlbnRpdHkuIFRoaXMg aXMgcmVxdWlyZWQNCj4gZm9yIGFsbCBLREUgZG9jdW1lbnRhdGlvbiBmaWxlcyBpbiBvcmRlciB0 byBpbmNsdWRlIHRoZSAqRnJlZSBEb2N1bWVudGF0aW9uDQo+IExpY2Vuc2VbMV0qIHRleHQuAGFu ZCB0aGlzDQo+IDwhLS0gVFJBTlM6Q1JFRElUX0ZPUl9UUkFOU0xBVE9SUyAtLT4gVGhlcmUgbXVz dCBvbmx5IGJlIG9uZSBEb2NCb29rDQo+IGZpbGUgaW4gdGhlIGRpcmVjdG9yeSB3aGljaCBoYXMg dGhpcyBtYXJrZXIuIEl0IG5lZWRzIHRvIGJlIHBsYWNlZCBhdCB0aGUNCj4gZW5kIG9mIHlvdXIg ZG9jdW1lbnQsIHJpZ2h0IGJlZm9yZSB0aGUgJnVuZGVyRkRMOyBlbnRpdHkuAA0KPiANCllvdSBj YW4gc2F2ZWx5IGlnbm9yZSB0aGlzIEVCTiBtZXNzYWdlLCBpdCBpcyBhIGZhbHNlIHBvc2l0aXZl Lg0KSGFwcGVucyBpZiB5b3UgY2hlY2sgYSBkb2Nib29rIGJlZWluZyBwYXJ0IG9mIGEgY29tcGxl dGUgZG9jdW1lbnRhdGlvbiANCihpbmRleC5kb2Nib29rICsgc2V2ZXJhbCBzZXBhcmF0ZSBkb2Ni b29rcyBwdWxsZWQgaW4gdmlhIGEgZW50aXR5IGluIHRoZSANCmhlYWRlciBvZiBpbmRleC5kb2Ni b29rKS4NCg0KRUJOIGlzIG5vdCBzbWFydCBlbm91Z2ggdG8gZGV0ZWN0IHRoaXMgaXNzdWUuDQoN Ci0tIA0KQnVya2hhcmQgTPxjaw0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18NCktERSBQSU0gbWFpbGluZyBsaXN0IGtkZS1waW1Aa2RlLm9yZw0KaHR0cHM6 Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtcGltDQpLREUgUElNIGhvbWUgcGFn ZSBhdCBodHRwOi8vcGltLmtkZS5vcmcvDQo=