320533 2013-05-31 12:55:39 +0000 Connection failed notification triggered despite successful connection 2013-07-22 02:30:42 +0000 1 1 10 Unmaintained Network Management Wireless unspecified Fedora RPMs Linux RESOLVED FIXED NOR normal --- 0 hein lamarque adaptee info jgrulich starbuck http://commits.kde.org/networkmanagement/f5c57ab9ba95db528fa89906335f8dca44b43439 0.9.0.9 0 oldest_to_newest 1372822 0 hein 2013-05-31 12:55:39 +0000 I'm using an unpatched 0.9.0.8 from Fedora 18 repositories as far as I can see. If I do the following: 1. While connected to my WLAN, go into "Manage Connections" and delete the active connection 2. Pick the same WLAN from the connection list in the widget 3. Enter the password in the resulting properties dialog and OK it ... then the connection succeeds, but despite this the "Connection failed" KNotify connection is triggered, resulting in a confusing and incorrect notification bubble shown in the desktop shell. This bug seems to exist in a bunch of subtle variations and across distros; I've gotten reports from Kubuntu/Netrunner users as well for example. The general theme being that the "Connection failed" notification is triggered even if this isn't actually the case. Reproducible: Always 1372823 1 hein 2013-05-31 12:56:51 +0000 Sorry for the typo, s/KNotify connection/KNotify notification/ of course. 1372824 2 starbuck 2013-05-31 13:00:48 +0000 not sure about kubuntu, but netrunner is reported to be affected as well (0.9.0.8-0ubuntu1) 1372860 3 adaptee 2013-05-31 14:59:18 +0000 I remember seeing such notifications too, when playing with various recently released livecd for fun :) 1372862 4 80219 lamarque 2013-05-31 15:04:11 +0000 Created attachment 80219 Suppress "connection failed" notification if connection is deleted Well, when the connection is deleted the failed connection notification should be triggered since the connection attempt really failed, but it should not wait until the next connection attempt to show up. I have tested your steps here and no notification appears, maybe because the object that triggers the notification is being deleted too fast. Can you recompile Plasma NM with the patch attached and see if it suppress the "connection failed" notification? 1374898 5 hein 2013-06-07 21:39:03 +0000 The patch doesn't appear to help, I'm still getting the notification. Note that since I was evaluating for distro inclusion I tested it against the v0.9.0.8 tag, not master. (Also curious btw: In order for clicking a WLAN list item to bring up the dialog, I had to install into /usr, a folder in $KDEDIRS/$PATH in my $HOME didn't work as it normally does with KDE apps.) 1374900 6 hein 2013-06-07 21:43:12 +0000 Addendum: In addition to the notification I'm also getting a failed tray icon now, briefly, before it is replaced with the success one. I believe (but am not entirely sure) that's new with the patch, before it went straight to the success icon. 1374901 7 hein 2013-06-07 21:44:14 +0000 Hm, but not always either @ icon, so it may have been happening before, but is simply quite racy. Sorry for the reply noise. 1375595 8 lamarque 2013-06-10 14:25:15 +0000 By the way, you have to restart kded4 (or relogin) for the patch to take effect. Are you really sure you installed it in /usr? If you install it in another path probably Plasma NM's libraries in /usr will take precedence and the patch will not take effect. The systray icon glitch is unrelated to this patch, the notification system and the tray icon are handled by two different system proccesses (kded4 and plasma-desktop). Just for debugging, does the notification appears if you disable all Plasma NM's notifications in "Manage Connections" -> "Other" -> "Configure Notifications"? 1375662 9 hein 2013-06-10 17:26:25 +0000 - I logged in and out. - I tried removing the system version of KNM completely, but still had to install to /usr for the dialog to work, so maybe the KNM code uses KStandardDirs incorrectly somewhere (installing to $KDEDIRS and even overriding a system copy that way is supposed to work). I'll have a look at the notification thing later tonight, can't cut my connection at the moment. 1375771 10 hein 2013-06-11 03:14:49 +0000 Yes, the notification isn't triggered if I disable it in the KNotify settings. 1376337 11 hein 2013-06-13 09:22:31 +0000 FWIW, of the two possible KNotification callsites for this message, the one taken is notificationmanager.cpp:129. 1376338 12 hein 2013-06-13 09:24:03 +0000 So that means there's a state transition from Activating to Unknown that it declares as connection failure, which is apparently an incorrect assumption to make. 1376700 13 lamarque 2013-06-15 03:31:54 +0000 Can you test if the commit below fixes this problem? http://commits.kde.org/networkmanagement/4be000f0b162c52d4c7e0ffdc2f0143b1cfffcdb To test it just 'git pull' either master or nm09 branches and recompile it. 1376701 14 hein 2013-06-15 04:13:31 +0000 I'll test, but can you comment on whether you expect this patch to work against 0.9.0.8? If it works, I intend to ship this in a distro where this bug is considered a release blocker candidate (a confusing error message on initial connect is kind of terrible for users). 1376763 15 lamarque 2013-06-15 12:49:32 +0000 The patch requires NetworkManager 0.9.8, if the distribution you mentioned does not use that NetworkManager version then you will have to upgrade. This patch applies to Plasma NM 0.9.0.8 and you can even compile Plasma NM against NetworkManager 0.9.8 and then run a lower NetworkManager version but then the patch will have no effect since the notification manager now depends on the two new connection states (deactivating and deactivated) that only NetworkManager >= 0.9.8 uses. 1376766 16 hein 2013-06-15 13:15:50 +0000 I am about to test this with a simplified patch applied to v0.9.0.8, but please note that modern compilers will (with good reason) warn about this code because the switch statement in notificationmanager.cpp doesn't handle the Deactivating (as opposed to Deactivated) value and it has no default case. 1376769 17 80529 hein 2013-06-15 13:24:38 +0000 Created attachment 80529 Partial backport of 4706c1c2 that applies cleanly to v0.9.0.8 Yay - the attached patch that applies cleanly to v0.9.0.8 no longer incorrectly announces connection failure. I'll hold off on shipping this for now however in case you want to have another crack at that switch statement first? 1376783 18 lamarque 2013-06-15 14:12:34 +0000 Git commit 6582b1534e51e959593b17c8d4e52aa494e1d28c by Lamarque V. Souza. Committed on 15/06/2013 at 16:04. Pushed by lvsouza into branch 'nm09'. Distinguish between user deactivation and activation error for vpn connections as well. FIXED-IN: 0.9.0.9 (cherry picked from commit f5c57ab9ba95db528fa89906335f8dca44b43439) M +11 -4 libs/service/notificationmanager.cpp http://commits.kde.org/networkmanagement/6582b1534e51e959593b17c8d4e52aa494e1d28c 1376784 19 lamarque 2013-06-15 14:12:46 +0000 Git commit f5c57ab9ba95db528fa89906335f8dca44b43439 by Lamarque V. Souza. Committed on 15/06/2013 at 16:04. Pushed by lvsouza into branch 'master'. Distinguish between user deactivation and activation error for vpn connections as well. FIXED-IN: 0.9.0.9 M +11 -4 libs/service/notificationmanager.cpp http://commits.kde.org/networkmanagement/f5c57ab9ba95db528fa89906335f8dca44b43439 1377065 20 80552 hein 2013-06-16 13:41:10 +0000 Created attachment 80552 Partial backport of 4706c1c2 and 6582b153 that applies cleanly to v0.9.0.8 Thanks Lamarque; attached is the patch we'll apply to v0.9.0.8. 1384897 21 lamarque 2013-07-20 22:36:32 +0000 *** Bug 322631 has been marked as a duplicate of this bug. *** 1385176 22 info 2013-07-22 02:30:01 +0000 How do I Install this on Ubuntu 13.04. is there a .deb package available. 1385177 23 info 2013-07-22 02:30:42 +0000 How do I Install this on Ubuntu 13.04. is there a .deb package available. 80219 2013-05-31 15:04:11 +0000 2013-05-31 15:04:11 +0000 Suppress "connection failed" notification if connection is deleted supress_failed_notification_if_connection_is_removed.diff text/plain 693 lamarque ZGlmZiAtLWdpdCBhL2xpYnMvc2VydmljZS9ub3RpZmljYXRpb25tYW5hZ2VyLmNwcCBiL2xpYnMv c2VydmljZS9ub3RpZmljYXRpb25tYW5hZ2VyLmNwcAppbmRleCA1MWRiNWM3Li5hYzhjOTQyIDEw MDY0NAotLS0gYS9saWJzL3NlcnZpY2Uvbm90aWZpY2F0aW9ubWFuYWdlci5jcHAKKysrIGIvbGli cy9zZXJ2aWNlL25vdGlmaWNhdGlvbm1hbmFnZXIuY3BwCkBAIC0xMDcsNiArMTA3LDExIEBAIHZv aWQgSW50ZXJmYWNlTm90aWZpY2F0aW9uSG9zdDo6aW50ZXJmYWNlQ29ubmVjdGlvbkFjdGl2YXRp b25TdGF0ZUNoYW5nZWQoS25tOjpJCiAKICAgICBLbm06OkludGVyZmFjZUNvbm5lY3Rpb24gKiBp YyA9IHFvYmplY3RfY2FzdDxLbm06OkludGVyZmFjZUNvbm5lY3Rpb24gKj4oc2VuZGVyKCkpOwog CisgICAgLy8gQ2FuIGhhcHBlbiBpZiB1c2VyIGRlbGV0ZXMgdGhlIGNvbm5lY3Rpb24gYmVmb3Jl IGl0IGNoYW5nZXMgc3RhdGUuCisgICAgaWYgKCFtX2ludGVyZmFjZUNvbm5lY3Rpb25zLmNvbnRh aW5zKGljKSkgeworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgc3dpdGNoIChuZXdTdGF0 ZSkgewogICAgICAgICBjYXNlIEtubTo6SW50ZXJmYWNlQ29ubmVjdGlvbjo6QWN0aXZhdGluZzoK ICAgICAgICAgICAgIGtEZWJ1ZygpIDw8IGljLT5jb25uZWN0aW9uTmFtZSgpIDw8ICJpcyBhY3Rp dmF0aW5nIjsK 80529 2013-06-15 13:24:38 +0000 2013-06-15 13:24:38 +0000 Partial backport of 4706c1c2 that applies cleanly to v0.9.0.8 fix-failure-notification-v0.9.0.8.patch text/plain 3140 hein ZGlmZiAtLWdpdCBhL2JhY2tlbmRzL05ldHdvcmtNYW5hZ2VyL25tZGJ1c2FjdGl2ZWNvbm5lY3Rp b25tb25pdG9yLmNwcCBiL2JhY2tlbmRzL05ldHdvcmtNYW5hZ2VyL25tZGJ1c2FjdGl2ZWNvbm5l Y3Rpb25tb25pdG9yLmNwcAppbmRleCAwNjJmYTExLi5hZmUyZGMxIDEwMDY0NAotLS0gYS9iYWNr ZW5kcy9OZXR3b3JrTWFuYWdlci9ubWRidXNhY3RpdmVjb25uZWN0aW9ubW9uaXRvci5jcHAKKysr IGIvYmFja2VuZHMvTmV0d29ya01hbmFnZXIvbm1kYnVzYWN0aXZlY29ubmVjdGlvbm1vbml0b3Iu Y3BwCkBAIC04OCw2ICs4OCwxMCBAQCB2b2lkIE5NREJ1c0FjdGl2ZUNvbm5lY3Rpb25Qcm94eTo6 c2V0U3RhdGUodWludCBubVN0YXRlKQogICAgICAgICAgICAgYVN0YXRlID0gS25tOjpJbnRlcmZh Y2VDb25uZWN0aW9uOjpBY3RpdmF0ZWQ7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2Fz ZSBOTV9BQ1RJVkVfQ09OTkVDVElPTl9TVEFURV9ERUFDVElWQVRJTkc6CisgICAgICAgICAgICBh U3RhdGUgPSBLbm06OkludGVyZmFjZUNvbm5lY3Rpb246OkRlYWN0aXZhdGluZzsKKyAgICAgICAg ICAgIGJyZWFrOworICAgICAgICBjYXNlIE5NX0FDVElWRV9DT05ORUNUSU9OX1NUQVRFX0RFQUNU SVZBVEVEOgorICAgICAgICAgICAgYVN0YXRlID0gS25tOjpJbnRlcmZhY2VDb25uZWN0aW9uOjpE ZWFjdGl2YXRlZDsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBkZWZhdWx0OgogICAgICAg ICAgICAga0RlYnVnKCkgPDwgIlVuaGFuZGxlZCBhY3RpdmF0aW9uIHN0YXRlIiA8PCBubVN0YXRl OwpkaWZmIC0tZ2l0IGEvbGlicy9zZXJ2aWNlL25vdGlmaWNhdGlvbm1hbmFnZXIuY3BwIGIvbGli cy9zZXJ2aWNlL25vdGlmaWNhdGlvbm1hbmFnZXIuY3BwCmluZGV4IDUxZGI1YzcuLjk2ZjBjMWEg MTAwNjQ0Ci0tLSBhL2xpYnMvc2VydmljZS9ub3RpZmljYXRpb25tYW5hZ2VyLmNwcAorKysgYi9s aWJzL3NlcnZpY2Uvbm90aWZpY2F0aW9ubWFuYWdlci5jcHAKQEAgLTExNywxMyArMTE3LDE2IEBA IHZvaWQgSW50ZXJmYWNlTm90aWZpY2F0aW9uSG9zdDo6aW50ZXJmYWNlQ29ubmVjdGlvbkFjdGl2 YXRpb25TdGF0ZUNoYW5nZWQoS25tOjpJCiAgICAgICAgICAgICBtX2FjdGl2YXRpbmcucmVtb3Zl KGljKTsKICAgICAgICAgICAgIEtOb3RpZmljYXRpb246OmV2ZW50KEV2ZW50OjpDb25uZWN0ZWQs IG1faW50ZXJmYWNlTmFtZUxhYmVsLCBpMThuYygiQGluZm86c3RhdHVzIE5vdGlmaWNhdGlvbiB0 ZXh0IHdoZW4gYSBjb25uZWN0aW9uIGhhcyBiZWVuIGFjdGl2YXRlZCIsIiUxIGFjdGl2YXRlZCIs IGljLT5jb25uZWN0aW9uTmFtZSgpKSwgS0ljb24oS25tOjpDb25uZWN0aW9uOjppY29uTmFtZShp Yy0+Y29ubmVjdGlvblR5cGUoKSkpLnBpeG1hcChRU2l6ZShpY29uU2l6ZSxpY29uU2l6ZSkpLCAw LCBLTm90aWZpY2F0aW9uOjpDbG9zZU9uVGltZW91dCwgbV9tYW5hZ2VyLT5jb21wb25lbnREYXRh KCkpOwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgS25tOjpJbnRlcmZhY2VDb25u ZWN0aW9uOjpEZWFjdGl2YXRlZDoKKyAgICAgICAgICAgIG1fYWN0aXZhdGluZy5yZW1vdmUoaWMp OworICAgICAgICAgICAgS05vdGlmaWNhdGlvbjo6ZXZlbnQoRXZlbnQ6OkRpc2Nvbm5lY3RlZCwg bV9pbnRlcmZhY2VOYW1lTGFiZWwsIGkxOG5jKCJAaW5mbzpzdGF0dXMgTm90aWZpY2F0aW9uIHRl eHQgd2hlbiBkZWFjdGl2YXRpbmcgYSBjb25uZWN0aW9uIiwiJTEgZGVhY3RpdmF0ZWQiLCBpYy0+ Y29ubmVjdGlvbk5hbWUoKSksIEtJY29uKEtubTo6Q29ubmVjdGlvbjo6aWNvbk5hbWUoaWMtPmNv bm5lY3Rpb25UeXBlKCkpKS5waXhtYXAoUVNpemUoaWNvblNpemUsaWNvblNpemUpKSwgMCwgS05v dGlmaWNhdGlvbjo6Q2xvc2VPblRpbWVvdXQsIG1fbWFuYWdlci0+Y29tcG9uZW50RGF0YSgpKTsK KyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEtubTo6SW50ZXJmYWNlQ29ubmVjdGlv bjo6VW5rbm93bjoKICAgICAgICAgICAgIG1fYWN0aXZhdGluZy5yZW1vdmUoaWMpOwogICAgICAg ICAgICAgaWYgKGljLT5jb25uZWN0aW9uVHlwZSgpICE9IEtubTo6Q29ubmVjdGlvbjo6V2lyZWxl c3MgfHwgU29saWQ6OkNvbnRyb2w6Ok5ldHdvcmtNYW5hZ2VyTm0wOTo6aXNXaXJlbGVzc0hhcmR3 YXJlRW5hYmxlZCgpKSB7Ci0gICAgICAgICAgICAgICAgaWYgKGljLT5vbGRBY3RpdmF0aW9uU3Rh dGUoKSA9PSBLbm06OkludGVyZmFjZUNvbm5lY3Rpb246OkFjdGl2YXRpbmcpCisgICAgICAgICAg ICAgICAgaWYgKGljLT5vbGRBY3RpdmF0aW9uU3RhdGUoKSA9PSBLbm06OkludGVyZmFjZUNvbm5l Y3Rpb246OkFjdGl2YXRpbmcpIHsKICAgICAgICAgICAgICAgICAgICAgS05vdGlmaWNhdGlvbjo6 ZXZlbnQoRXZlbnQ6OkNvbm5lY3RGYWlsZWQsIG1faW50ZXJmYWNlTmFtZUxhYmVsLCBpMThuYygi QGluZm86c3RhdHVzIE5vdGlmaWNhdGlvbiB0ZXh0IHdoZW4gY29ubmVjdGlvbiBoYXMgZmFpbGVk IiwiQ29ubmVjdGlvbiAlMSBmYWlsZWQiLCBpYy0+Y29ubmVjdGlvbk5hbWUoKSksIEtJY29uKEtu bTo6Q29ubmVjdGlvbjo6aWNvbk5hbWUoaWMtPmNvbm5lY3Rpb25UeXBlKCkpKS5waXhtYXAoUVNp emUoaWNvblNpemUsaWNvblNpemUpKSwgMCwgS05vdGlmaWNhdGlvbjo6Q2xvc2VPblRpbWVvdXQs IG1fbWFuYWdlci0+Y29tcG9uZW50RGF0YSgpKTsKLSAgICAgICAgICAgICAgICBlbHNlCi0gICAg ICAgICAgICAgICAgICAgIEtOb3RpZmljYXRpb246OmV2ZW50KEV2ZW50OjpEaXNjb25uZWN0ZWQs IG1faW50ZXJmYWNlTmFtZUxhYmVsLCBpMThuYygiQGluZm86c3RhdHVzIE5vdGlmaWNhdGlvbiB0 ZXh0IHdoZW4gZGVhY3RpdmF0aW5nIGEgY29ubmVjdGlvbiIsIiUxIGRlYWN0aXZhdGVkIiwgaWMt PmNvbm5lY3Rpb25OYW1lKCkpLCBLSWNvbihLbm06OkNvbm5lY3Rpb246Omljb25OYW1lKGljLT5j b25uZWN0aW9uVHlwZSgpKSkucGl4bWFwKFFTaXplKGljb25TaXplLGljb25TaXplKSksIDAsIEtO b3RpZmljYXRpb246OkNsb3NlT25UaW1lb3V0LCBtX21hbmFnZXItPmNvbXBvbmVudERhdGEoKSk7 CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAg ICAgfQo= 80552 2013-06-16 13:41:10 +0000 2013-06-16 13:41:10 +0000 Partial backport of 4706c1c2 and 6582b153 that applies cleanly to v0.9.0.8 fix-failure-notification-v0.9.0.8-v2.patch text/plain 5413 hein ZGlmZiAtLWdpdCBhL2JhY2tlbmRzL05ldHdvcmtNYW5hZ2VyL25tZGJ1c2FjdGl2ZWNvbm5lY3Rp b25tb25pdG9yLmNwcCBiL2JhY2tlbmRzL05ldHdvcmtNYW5hZ2VyL25tZGJ1c2FjdGl2ZWNvbm5l Y3Rpb25tb25pdG9yLmNwcAppbmRleCAwNjJmYTExLi5hZmUyZGMxIDEwMDY0NAotLS0gYS9iYWNr ZW5kcy9OZXR3b3JrTWFuYWdlci9ubWRidXNhY3RpdmVjb25uZWN0aW9ubW9uaXRvci5jcHAKKysr IGIvYmFja2VuZHMvTmV0d29ya01hbmFnZXIvbm1kYnVzYWN0aXZlY29ubmVjdGlvbm1vbml0b3Iu Y3BwCkBAIC04OCw2ICs4OCwxMCBAQCB2b2lkIE5NREJ1c0FjdGl2ZUNvbm5lY3Rpb25Qcm94eTo6 c2V0U3RhdGUodWludCBubVN0YXRlKQogICAgICAgICAgICAgYVN0YXRlID0gS25tOjpJbnRlcmZh Y2VDb25uZWN0aW9uOjpBY3RpdmF0ZWQ7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2Fz ZSBOTV9BQ1RJVkVfQ09OTkVDVElPTl9TVEFURV9ERUFDVElWQVRJTkc6CisgICAgICAgICAgICBh U3RhdGUgPSBLbm06OkludGVyZmFjZUNvbm5lY3Rpb246OkRlYWN0aXZhdGluZzsKKyAgICAgICAg ICAgIGJyZWFrOworICAgICAgICBjYXNlIE5NX0FDVElWRV9DT05ORUNUSU9OX1NUQVRFX0RFQUNU SVZBVEVEOgorICAgICAgICAgICAgYVN0YXRlID0gS25tOjpJbnRlcmZhY2VDb25uZWN0aW9uOjpE ZWFjdGl2YXRlZDsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBkZWZhdWx0OgogICAgICAg ICAgICAga0RlYnVnKCkgPDwgIlVuaGFuZGxlZCBhY3RpdmF0aW9uIHN0YXRlIiA8PCBubVN0YXRl OwpkaWZmIC0tZ2l0IGEvbGlicy9zZXJ2aWNlL25vdGlmaWNhdGlvbm1hbmFnZXIuY3BwIGIvbGli cy9zZXJ2aWNlL25vdGlmaWNhdGlvbm1hbmFnZXIuY3BwCmluZGV4IDUxZGI1YzcuLmM3MjQ1ZmMg MTAwNjQ0Ci0tLSBhL2xpYnMvc2VydmljZS9ub3RpZmljYXRpb25tYW5hZ2VyLmNwcAorKysgYi9s aWJzL3NlcnZpY2Uvbm90aWZpY2F0aW9ubWFuYWdlci5jcHAKQEAgLTExNiwxNCArMTE2LDE5IEBA IHZvaWQgSW50ZXJmYWNlTm90aWZpY2F0aW9uSG9zdDo6aW50ZXJmYWNlQ29ubmVjdGlvbkFjdGl2 YXRpb25TdGF0ZUNoYW5nZWQoS25tOjpJCiAgICAgICAgIGNhc2UgS25tOjpJbnRlcmZhY2VDb25u ZWN0aW9uOjpBY3RpdmF0ZWQ6CiAgICAgICAgICAgICBtX2FjdGl2YXRpbmcucmVtb3ZlKGljKTsK ICAgICAgICAgICAgIEtOb3RpZmljYXRpb246OmV2ZW50KEV2ZW50OjpDb25uZWN0ZWQsIG1faW50 ZXJmYWNlTmFtZUxhYmVsLCBpMThuYygiQGluZm86c3RhdHVzIE5vdGlmaWNhdGlvbiB0ZXh0IHdo ZW4gYSBjb25uZWN0aW9uIGhhcyBiZWVuIGFjdGl2YXRlZCIsIiUxIGFjdGl2YXRlZCIsIGljLT5j b25uZWN0aW9uTmFtZSgpKSwgS0ljb24oS25tOjpDb25uZWN0aW9uOjppY29uTmFtZShpYy0+Y29u bmVjdGlvblR5cGUoKSkpLnBpeG1hcChRU2l6ZShpY29uU2l6ZSxpY29uU2l6ZSkpLCAwLCBLTm90 aWZpY2F0aW9uOjpDbG9zZU9uVGltZW91dCwgbV9tYW5hZ2VyLT5jb21wb25lbnREYXRhKCkpOwor ICAgICAgICBjYXNlIEtubTo6SW50ZXJmYWNlQ29ubmVjdGlvbjo6RGVhY3RpdmF0aW5nOgorICAg ICAgICAgICAgLy8gSWdub3JlZC4KKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEtu bTo6SW50ZXJmYWNlQ29ubmVjdGlvbjo6RGVhY3RpdmF0ZWQ6CisgICAgICAgICAgICBtX2FjdGl2 YXRpbmcucmVtb3ZlKGljKTsKKyAgICAgICAgICAgIEtOb3RpZmljYXRpb246OmV2ZW50KEV2ZW50 OjpEaXNjb25uZWN0ZWQsIG1faW50ZXJmYWNlTmFtZUxhYmVsLCBpMThuYygiQGluZm86c3RhdHVz IE5vdGlmaWNhdGlvbiB0ZXh0IHdoZW4gZGVhY3RpdmF0aW5nIGEgY29ubmVjdGlvbiIsIiUxIGRl YWN0aXZhdGVkIiwgaWMtPmNvbm5lY3Rpb25OYW1lKCkpLCBLSWNvbihLbm06OkNvbm5lY3Rpb246 Omljb25OYW1lKGljLT5jb25uZWN0aW9uVHlwZSgpKSkucGl4bWFwKFFTaXplKGljb25TaXplLGlj b25TaXplKSksIDAsIEtOb3RpZmljYXRpb246OkNsb3NlT25UaW1lb3V0LCBtX21hbmFnZXItPmNv bXBvbmVudERhdGEoKSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBLbm06Oklu dGVyZmFjZUNvbm5lY3Rpb246OlVua25vd246CiAgICAgICAgICAgICBtX2FjdGl2YXRpbmcucmVt b3ZlKGljKTsKICAgICAgICAgICAgIGlmIChpYy0+Y29ubmVjdGlvblR5cGUoKSAhPSBLbm06OkNv bm5lY3Rpb246OldpcmVsZXNzIHx8IFNvbGlkOjpDb250cm9sOjpOZXR3b3JrTWFuYWdlck5tMDk6 OmlzV2lyZWxlc3NIYXJkd2FyZUVuYWJsZWQoKSkgewotICAgICAgICAgICAgICAgIGlmIChpYy0+ b2xkQWN0aXZhdGlvblN0YXRlKCkgPT0gS25tOjpJbnRlcmZhY2VDb25uZWN0aW9uOjpBY3RpdmF0 aW5nKQorICAgICAgICAgICAgICAgIGlmIChpYy0+b2xkQWN0aXZhdGlvblN0YXRlKCkgPT0gS25t OjpJbnRlcmZhY2VDb25uZWN0aW9uOjpBY3RpdmF0aW5nKSB7CiAgICAgICAgICAgICAgICAgICAg IEtOb3RpZmljYXRpb246OmV2ZW50KEV2ZW50OjpDb25uZWN0RmFpbGVkLCBtX2ludGVyZmFjZU5h bWVMYWJlbCwgaTE4bmMoIkBpbmZvOnN0YXR1cyBOb3RpZmljYXRpb24gdGV4dCB3aGVuIGNvbm5l Y3Rpb24gaGFzIGZhaWxlZCIsIkNvbm5lY3Rpb24gJTEgZmFpbGVkIiwgaWMtPmNvbm5lY3Rpb25O YW1lKCkpLCBLSWNvbihLbm06OkNvbm5lY3Rpb246Omljb25OYW1lKGljLT5jb25uZWN0aW9uVHlw ZSgpKSkucGl4bWFwKFFTaXplKGljb25TaXplLGljb25TaXplKSksIDAsIEtOb3RpZmljYXRpb246 OkNsb3NlT25UaW1lb3V0LCBtX21hbmFnZXItPmNvbXBvbmVudERhdGEoKSk7Ci0gICAgICAgICAg ICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICBLTm90aWZpY2F0aW9uOjpldmVudChFdmVu dDo6RGlzY29ubmVjdGVkLCBtX2ludGVyZmFjZU5hbWVMYWJlbCwgaTE4bmMoIkBpbmZvOnN0YXR1 cyBOb3RpZmljYXRpb24gdGV4dCB3aGVuIGRlYWN0aXZhdGluZyBhIGNvbm5lY3Rpb24iLCIlMSBk ZWFjdGl2YXRlZCIsIGljLT5jb25uZWN0aW9uTmFtZSgpKSwgS0ljb24oS25tOjpDb25uZWN0aW9u OjppY29uTmFtZShpYy0+Y29ubmVjdGlvblR5cGUoKSkpLnBpeG1hcChRU2l6ZShpY29uU2l6ZSxp Y29uU2l6ZSkpLCAwLCBLTm90aWZpY2F0aW9uOjpDbG9zZU9uVGltZW91dCwgbV9tYW5hZ2VyLT5j b21wb25lbnREYXRhKCkpOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIGJyZWFrOwogICAgIH0KQEAgLTQ0OSwxMyArNDU0LDE3IEBAIHZvaWQgTm90aWZpY2F0 aW9uTWFuYWdlcjo6aGFuZGxlVXBkYXRlKEtubTo6QWN0aXZhdGFibGUgKmFjdGl2YXRhYmxlKQog ICAgICAgICAgICAgICAgICAgICBrRGVidWcoKSA8PCBpYy0+Y29ubmVjdGlvbk5hbWUoKSA8PCAi aXMgYWN0aXZhdGVkIjsKICAgICAgICAgICAgICAgICAgICAgS05vdGlmaWNhdGlvbjo6ZXZlbnQo RXZlbnQ6OkNvbm5lY3RlZCwgUVN0cmluZygpLCBpMThuYygiQGluZm86c3RhdHVzIE5vdGlmaWNh dGlvbiB0ZXh0IHdoZW4gYSBjb25uZWN0aW9uIGhhcyBiZWVuIGFjdGl2YXRlZCIsIiUxIGFjdGl2 YXRlZCIsIGljLT5jb25uZWN0aW9uTmFtZSgpKSwgS0ljb24oS25tOjpDb25uZWN0aW9uOjppY29u TmFtZShpYy0+Y29ubmVjdGlvblR5cGUoKSkpLnBpeG1hcChRU2l6ZShpY29uU2l6ZSxpY29uU2l6 ZSkpLCAwLCBLTm90aWZpY2F0aW9uOjpDbG9zZU9uVGltZW91dCwgY29tcG9uZW50RGF0YSgpKTsK ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgY2FzZSBLbm06Oklu dGVyZmFjZUNvbm5lY3Rpb246OkRlYWN0aXZhdGluZzoKKyAgICAgICAgICAgICAgICAgICAgLy8g SWdub3JlZC4KKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgY2Fz ZSBLbm06OkludGVyZmFjZUNvbm5lY3Rpb246OkRlYWN0aXZhdGVkOgorICAgICAgICAgICAgICAg ICAgICBLTm90aWZpY2F0aW9uOjpldmVudChFdmVudDo6RGlzY29ubmVjdGVkLCBRU3RyaW5nKCks IGkxOG5jKCJAaW5mbzpzdGF0dXMgTm90aWZpY2F0aW9uIHRleHQgd2hlbiBkZWFjdGl2YXRpbmcg YSBjb25uZWN0aW9uIiwiJTEgZGVhY3RpdmF0ZWQiLCBpYy0+Y29ubmVjdGlvbk5hbWUoKSksIEtJ Y29uKEtubTo6Q29ubmVjdGlvbjo6aWNvbk5hbWUoaWMtPmNvbm5lY3Rpb25UeXBlKCkpKS5waXht YXAoUVNpemUoaWNvblNpemUsaWNvblNpemUpKSwgMCwgS05vdGlmaWNhdGlvbjo6Q2xvc2VPblRp bWVvdXQsIGNvbXBvbmVudERhdGEoKSk7CisgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICAgICAgICAgIGNhc2UgS25tOjpJbnRlcmZhY2VDb25uZWN0aW9uOjpVbmtub3duOgogICAg ICAgICAgICAgICAgICAgICBrRGVidWcoKSA8PCBpYy0+Y29ubmVjdGlvbk5hbWUoKSA8PCAiaXMg dW5rbm93biI7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChpYy0+b2xkQWN0aXZhdGlvblN0YXRl KCkgPT0gS25tOjpJbnRlcmZhY2VDb25uZWN0aW9uOjpBY3RpdmF0aW5nKQorICAgICAgICAgICAg ICAgICAgICBpZiAoaWMtPm9sZEFjdGl2YXRpb25TdGF0ZSgpID09IEtubTo6SW50ZXJmYWNlQ29u bmVjdGlvbjo6QWN0aXZhdGluZykgewogICAgICAgICAgICAgICAgICAgICAgICAgS05vdGlmaWNh dGlvbjo6ZXZlbnQoRXZlbnQ6OkNvbm5lY3RGYWlsZWQsIFFTdHJpbmcoKSwgaTE4bmMoIkBpbmZv OnN0YXR1cyBOb3RpZmljYXRpb24gdGV4dCB3aGVuIGNvbm5lY3Rpb24gaGFzIGZhaWxlZCIsIkNv bm5lY3Rpb24gJTEgZmFpbGVkIiwgaWMtPmNvbm5lY3Rpb25OYW1lKCkpLCBLSWNvbihLbm06OkNv bm5lY3Rpb246Omljb25OYW1lKGljLT5jb25uZWN0aW9uVHlwZSgpKSkucGl4bWFwKFFTaXplKGlj b25TaXplLGljb25TaXplKSksIDAsIEtOb3RpZmljYXRpb246OkNsb3NlT25UaW1lb3V0LCBjb21w b25lbnREYXRhKCkpOwotICAgICAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAg ICAgICAgICBLTm90aWZpY2F0aW9uOjpldmVudChFdmVudDo6RGlzY29ubmVjdGVkLCBRU3RyaW5n KCksIGkxOG5jKCJAaW5mbzpzdGF0dXMgTm90aWZpY2F0aW9uIHRleHQgd2hlbiBkZWFjdGl2YXRp bmcgYSBjb25uZWN0aW9uIiwiJTEgZGVhY3RpdmF0ZWQiLCBpYy0+Y29ubmVjdGlvbk5hbWUoKSks IEtJY29uKEtubTo6Q29ubmVjdGlvbjo6aWNvbk5hbWUoaWMtPmNvbm5lY3Rpb25UeXBlKCkpKS5w aXhtYXAoUVNpemUoaWNvblNpemUsaWNvblNpemUpKSwgMCwgS05vdGlmaWNhdGlvbjo6Q2xvc2VP blRpbWVvdXQsIGNvbXBvbmVudERhdGEoKSk7Ci0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9Cg==