<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>319767</bug_id>
          
          <creation_ts>2013-05-13 06:22:51 +0000</creation_ts>
          <short_desc>Enable/Disable scripts in KCM does not (un)load the script in running KWin</short_desc>
          <delta_ts>2013-05-13 06:25:52 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>kwin</product>
          <component>scripting</component>
          <version>4.10.3</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>4.10.4</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Martin Flöser">mgraesslin</reporter>
          <assigned_to name="KWin default assignee">kwin-bugs-null</assigned_to>
          
          
          <cf_commitlink>http://commits.kde.org/kde-workspace/dd5b4bdec8e24359d4715c078e2f442967a3f873</cf_commitlink>
          <cf_versionfixedin>4.10.4</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1368429</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Flöser">mgraesslin</who>
    <bug_when>2013-05-13 06:22:51 +0000</bug_when>
    <thetext>Steps to reproduce:

1. open KCM KWin Scripts
2. activate a script
3. click apply

Expected result:
Script gets loaded in running KWin

Actual result:
Nothing, one needs to restart KWin to see the changes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1368430</commentid>
    <comment_count>1</comment_count>
    <who name="Martin Flöser">mgraesslin</who>
    <bug_when>2013-05-13 06:23:51 +0000</bug_when>
    <thetext>Git commit dd5b4bdec8e24359d4715c078e2f442967a3f873 by Martin Gräßlin.
Committed on 08/05/2013 at 10:45.
Pushed by graesslin into branch &apos;KDE/4.10&apos;.

Reparse configuration before (un)loading scripts

When the scripting KCM triggered a loading of a script it did not work
because the scripting code was operating on an old data set.

Reparsing the configuration before evaluating which scripts to (un)load
solves this problem.

REVIEW: 110357
FIXED-IN: 4.10.4

M  +6    -0    kwin/scripting/scripting.cpp

http://commits.kde.org/kde-workspace/dd5b4bdec8e24359d4715c078e2f442967a3f873</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1368431</commentid>
    <comment_count>2</comment_count>
    <who name="Martin Flöser">mgraesslin</who>
    <bug_when>2013-05-13 06:25:52 +0000</bug_when>
    <thetext>Git commit 2af4011145a017bf2d5dd868a53d262f58385a52 by Martin Gräßlin.
Committed on 08/05/2013 at 10:45.
Pushed by graesslin into branch &apos;master&apos;.

Reparse configuration before (un)loading scripts

When the scripting KCM triggered a loading of a script it did not work
because the scripting code was operating on an old data set.

Reparsing the configuration before evaluating which scripts to (un)load
solves this problem.

Cherry-picked from 4.10 branch: dd5b4bdec8e24359d4715c078e2f442967a3f873

M  +6    -0    kwin/scripting/scripting.cpp

http://commits.kde.org/kde-workspace/2af4011145a017bf2d5dd868a53d262f58385a52</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>