319294 2013-05-04 00:12:22 +0000 Thumbnails disappear when stretching Thumbnail column in Table view [patch] 2017-07-14 04:29:09 +0000 1 1 2 Applications digikam Thumbs-Image 3.2.0 Compiled Sources Linux RESOLVED FIXED NOR normal --- 0 nurupobugskde digikam-bugs-null caulier.gilles nurupobugskde http://commits.kde.org/digikam/885ccad530ba0ed23421f774a06a0f65c6d27fab 3.2.0 0 oldest_to_newest 1366133 0 nurupobugskde 2013-05-04 00:12:22 +0000 When stretching Thumbnail column in Table view with thumbnails set to 256, thumbnails will disappear and digiKam would complain "digikam(27871)/digikam (core): ThumbnailLoadThread::load: Thumbnail size 337 is larger than 256 . Refusing to load.". It does that when columns width is greater than `ThumbnailSize::Huge` (256). DigiKam shouldn't use the column's width as an thumbnails' width and pass it to `ThumbnailLoadThread::load`, since column's width is irrelevant from thumbnails' width. User can set arbitrary width of the column and changing column's width doesn't resize thumbnails. Reproducible: Always Steps to Reproduce: 1. Open digiKam with some images shown. 2. Switch to Table view. 3. Increase thumbnails' size to 256 by using the zoom slider. 4. Stretch the Thumbnail column of the Table view. Actual Results: When stretching the Thumbnail column too much (>256px), thumbnails disappear. Expected Results: When stretching the Thumbnail column too much (>256px), thumbnails don't disappear. 1366134 1 79681 nurupobugskde 2013-05-04 00:16:31 +0000 Created attachment 79681 patch_319294.diff Since column's width is irrelevant to thumbnail's width, don't use it as size parameter. 1366190 2 mike 2013-05-04 11:24:05 +0000 Git commit 885ccad530ba0ed23421f774a06a0f65c6d27fab by Michael Georg Hansen. Committed on 04/05/2013 at 13:22. Pushed by mghansen into branch 'master'. Fix thumbnails disappearing when columns are too wide. The idea here is that for landscape images, we adjust the height to to be as high as the row height as long as the width can stretch enough because the column is wider than the thumbnail size. However, digiKam limits the thumbnail size to 256, so we also do that here. M +9 -1 digikam/views/tableview_column_thumbnail.cpp http://commits.kde.org/digikam/885ccad530ba0ed23421f774a06a0f65c6d27fab 79681 2013-05-04 00:16:31 +0000 2013-05-04 00:16:31 +0000 patch_319294.diff patch_319294.diff text/plain 792 nurupobugskde ZGlmZiAtLWdpdCBhL2RpZ2lrYW0vdmlld3MvdGFibGV2aWV3X2NvbHVtbl90aHVtYm5haWwuY3Bw IGIvZGlnaWthbS92aWV3cy90YWJsZXZpZXdfY29sdW1uX3RodW1ibmFpbC5jcHAKaW5kZXggMjEx NzFhNC4uZjZmMTkyOSAxMDA2NDQKLS0tIGEvZGlnaWthbS92aWV3cy90YWJsZXZpZXdfY29sdW1u X3RodW1ibmFpbC5jcHAKKysrIGIvZGlnaWthbS92aWV3cy90YWJsZXZpZXdfY29sdW1uX3RodW1i bmFpbC5jcHAKQEAgLTEzNCw3ICsxMzQsNyBAQCBib29sIENvbHVtblRodW1ibmFpbDo6cGFpbnQo UVBhaW50ZXIqIGNvbnN0IHBhaW50ZXIsIGNvbnN0IFFTdHlsZU9wdGlvblZpZXdJdGVtJgogCiAg ICAgICAgIGNvbnN0IFFTdHJpbmcgcGF0aCA9IGluZm8uZmlsZVBhdGgoKTsKICAgICAgICAgUVBp eG1hcCB0aHVtYm5haWw7Ci0gICAgICAgIGlmIChzLT50aHVtYm5haWxMb2FkVGhyZWFkLT5maW5k KHBhdGgsIHRodW1ibmFpbCwgcU1heChzaXplLndpZHRoKCkvKiArIDIqLywgc2l6ZS5oZWlnaHQo KS8qICsgMiovKSkpCisgICAgICAgIGlmIChzLT50aHVtYm5haWxMb2FkVGhyZWFkLT5maW5kKHBh dGgsIHRodW1ibmFpbCwgc2l6ZS5oZWlnaHQoKSkpCiAgICAgICAgIHsKICAgICAgICAgICAgIC8v LyBAdG9kbyBJcyBzbG90VGh1bWJuYWlsTG9hZGVkIHN0aWxsIGNhbGxlZCB3aGVuIHRoZSB0aHVt Ym5haWwgaXMgZm91bmQgcmlnaHQgYXdheT8KICAgICAgICAgICAgIC8vLyBAdG9kbyBSZW1vdmUg Ym9yZGVycyAtIGJ1dCB0aGV5IGFjdHVhbGx5IGxvb2sgbmljZSBpbiB0aGUgdGFibGUK