315778 2013-02-25 22:49:00 +0000 "First layer from clipboard" auto selects even after explicit unselect [JJ] 2013-05-17 07:15:34 +0000 1 1 2 Applications krita Usability git master (please specify the git hash!) Gentoo Packages Linux RESOLVED FIXED junior-jobs NOR normal --- 1 ghevan krita-bugs-null dimula73 halla nagpal.sahil01 valerie_vk http://commits.kde.org/calligra/daa19d8f9843ee7451638abc13d54acdf693ace9 0 oldest_to_newest 1345237 0 ghevan 2013-02-25 22:49:00 +0000 When I have image data on the clipboard, Krita's new document window automatically sets the size of the Custom document size equal to the clipboard image data width and height size. When setting the flag "First layer from clipboard" to off, if automatically sets to On after selecting with the mouse either width or height, re setting width if you selected height or height if you selected width. Reproducible: Always Steps to Reproduce: 1. Copy any image data to clipboard. (from krita make a stroke, select the are with the painted stroke and hit Crtl+C. from gimp, open new image, press Ctrl + C to copy image) 2. In krita go to File > New 3. On the new document dialog select "Custom Document" 4. The flag "First layer from clipboard" should be On. Set it to Off 5. Set a new width using the mouse to select the string numbers (either by double clicking or click and drag) 6. Set a new height using the mouse to select the string numbers (either by double clicking or click and drag) Actual Results: The flag "First layer from clipboard" will be set to On auto magically The Width will be set to whatever width the image date from the clipboard is Expected Results: The flag "First layer from clipboard" should be kept Off The width should have the value entered by the user. Workaround: After setting the flag to Off Set cursor at the width value without selecting text using the mouse. Erase an d input a new value using only keyboard input. Press TAB twice to position cursor at Height. Set new value. Workaround 2: If lazy, just copy anything else, other than an image, to your clipboard. (text, file, etc) 1352579 1 halla 2013-03-19 16:14:26 +0000 Thanks for your report. We can confirm it. It should be an easy fix, so I'll mark it as a Junior Job for now. 1352580 2 halla 2013-03-19 16:15:09 +0000 Also, raising priority, since it's something that impacts the first impression of Krita. 1356438 3 78540 nagpal.sahil01 2013-04-01 11:25:08 +0000 Created attachment 78540 First layer from clipboard" auto select problem fixed. 1356442 4 halla 2013-04-01 11:28:44 +0000 Looks good! Thanks -- I'll push the patch for you. 1364576 5 myriam 2013-04-28 03:32:04 +0000 (In reply to comment #4) > Looks good! Thanks -- I'll push the patch for you. Was this pushed? I see no commit message about that. 1364588 6 halla 2013-04-28 08:14:02 +0000 Good point, I'll check with Sahil. He's got his own developer id now, he's keeping me real busy with his patches :-) 1364629 7 valerie_vk 2013-04-28 12:16:47 +0000 It's fixed for me, just so you'd know. :D Thanks! 1364722 8 halla 2013-04-28 19:50:54 +0000 Yeah, I pushed that. Forget my own head next. 1366406 9 dimula73 2013-05-05 09:37:42 +0000 The behavior of the "First layer from clipboard" option is still quite weird: i) When changing the size of the image manually, typing is veeery slow: it looks like the clip is recreated of every valueChanged() signal or something. Even when the checkbox is off, but the clipboard contains an image. ii) Switching off/on the checkbox sometimes resets the values of the size textboxes, even when you typed them manually before. Sometimes it happens even more weirdly: 1) type width; 2) type height; 3) after accepting height, the width is somehow reset to the clip's width automatically. 1366407 10 dimula73 2013-05-05 09:39:46 +0000 The second weirdness happens, when you do the following: 1) Type Width 2) Select entire Height field with mouse 3) Start typing Height without explicit deletion of the current contents In the result the Width is reset back to the clip's width. 1366494 11 79719 nagpal.sahil01 2013-05-05 16:57:32 +0000 Created attachment 79719 Solves the problem of changing height and width easily The patch also does a part of the work of Bug: 187300- Better visibility of the new image.. 1366696 12 halla 2013-05-06 12:57:26 +0000 Git commit 0545a852342b581da0d9f5f28905edaec0f19372 by Boudewijn Rempt. Committed on 06/05/2013 at 14:19. Pushed by rempt into branch 'master'. Fix issues with width/height when creatign image from clipboard Patch by Sahil Nagpal M +16 -10 krita/ui/forms/wdgnewimage.ui M +20 -10 krita/ui/widgets/kis_custom_image_widget.cc M +1 -0 krita/ui/widgets/kis_custom_image_widget.h http://commits.kde.org/calligra/0545a852342b581da0d9f5f28905edaec0f19372 1367401 13 dimula73 2013-05-08 18:18:22 +0000 Git commit f62ba74f786bb72392fbba5822c10decc0e796f4 by Dmitry Kazakov, on behalf of Boudewijn Rempt. Committed on 06/05/2013 at 14:19. Pushed by dkazakov into branch 'calligra/2.7'. Fix issues with width/height when creatign image from clipboard Patch by Sahil Nagpal M +16 -10 krita/ui/forms/wdgnewimage.ui M +20 -10 krita/ui/widgets/kis_custom_image_widget.cc M +1 -0 krita/ui/widgets/kis_custom_image_widget.h http://commits.kde.org/calligra/f62ba74f786bb72392fbba5822c10decc0e796f4 1369380 14 siddharth.kde 2013-05-17 07:15:34 +0000 Git commit daa19d8f9843ee7451638abc13d54acdf693ace9 by Siddharth Sharma, on behalf of Boudewijn Rempt. Committed on 06/05/2013 at 14:19. Pushed by siddharthsharma into branch 'krita-psd-plugin-siddharth'. Fix issues with width/height when creatign image from clipboard Patch by Sahil Nagpal M +16 -10 krita/ui/forms/wdgnewimage.ui M +20 -10 krita/ui/widgets/kis_custom_image_widget.cc M +1 -0 krita/ui/widgets/kis_custom_image_widget.h http://commits.kde.org/calligra/daa19d8f9843ee7451638abc13d54acdf693ace9 78540 2013-04-01 11:25:08 +0000 2013-04-01 11:25:08 +0000 First layer from clipboard" auto select problem fixed. 0001-BUG-315778-First-layer-from-clipboard-auto-select-fi.patch text/plain 2206 nagpal.sahil01 RnJvbSA2MzFmZTQ1Zjc3ZDUyYWE1MDQwYjljZGZhMDBjZjhiZDI1NDdhZTE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTYWhpbCA8c2FoaWxASFAuKG5vbmUpPgpEYXRlOiBNb24sIDEg QXByIDIwMTMgMTY6NTE6NTQgKzA1MzAKU3ViamVjdDogW1BBVENIXSBCVUcgMzE1Nzc4OiBGaXJz dCBsYXllciBmcm9tIGNsaXBib2FyZCIgYXV0byBzZWxlY3QgZml4ZWQKCi0tLQoga3JpdGEvdWkv d2lkZ2V0cy9raXNfY3VzdG9tX2ltYWdlX3dpZGdldC5jYyB8ICAgMTMgKysrKysrKysrLS0tLQog MSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9rcml0YS91aS93aWRnZXRzL2tpc19jdXN0b21faW1hZ2Vfd2lkZ2V0LmNjIGIva3JpdGEv dWkvd2lkZ2V0cy9raXNfY3VzdG9tX2ltYWdlX3dpZGdldC5jYwppbmRleCBkMTg1YTk5Li5kZDBh NzVmIDEwMDY0NAotLS0gYS9rcml0YS91aS93aWRnZXRzL2tpc19jdXN0b21faW1hZ2Vfd2lkZ2V0 LmNjCisrKyBiL2tyaXRhL3VpL3dpZGdldHMva2lzX2N1c3RvbV9pbWFnZV93aWRnZXQuY2MKQEAg LTExNSw2ICsxMTUsNyBAQCBLaXNDdXN0b21JbWFnZVdpZGdldDo6S2lzQ3VzdG9tSW1hZ2VXaWRn ZXQoUVdpZGdldCogcGFyZW50LCBLaXNEb2MyKiBkb2MsIHFpbnQzMgogICAgIGNvbG9yU3BhY2VT ZWxlY3Rvci0+c2V0Q3VycmVudENvbG9yRGVwdGgoS29JRChkZWZDb2xvckRlcHRoKSk7CiAgICAg Y29sb3JTcGFjZVNlbGVjdG9yLT5zZXRDdXJyZW50UHJvZmlsZShkZWZDb2xvclByb2ZpbGUpOwog CisgICAgY29ubmVjdChjaGtGcm9tQ2xpcGJvYXJkLFNJR05BTChzdGF0ZUNoYW5nZWQoaW50KSks dGhpcyxTTE9UKGNsaXBib2FyZERhdGFDaGFuZ2VkKCkpKTsKICAgICBjb25uZWN0KFFBcHBsaWNh dGlvbjo6Y2xpcGJvYXJkKCksIFNJR05BTChkYXRhQ2hhbmdlZCgpKSwgdGhpcywgU0xPVChjbGlw Ym9hcmREYXRhQ2hhbmdlZCgpKSk7CiAgICAgY29ubmVjdChRQXBwbGljYXRpb246OmNsaXBib2Fy ZCgpLCBTSUdOQUwoc2VsZWN0aW9uQ2hhbmdlZCgpKSwgdGhpcywgU0xPVChjbGlwYm9hcmREYXRh Q2hhbmdlZCgpKSk7CiAgICAgY29ubmVjdChRQXBwbGljYXRpb246OmNsaXBib2FyZCgpLCBTSUdO QUwoY2hhbmdlZChRQ2xpcGJvYXJkOjpNb2RlKSksIHRoaXMsIFNMT1QoY2xpcGJvYXJkRGF0YUNo YW5nZWQoKSkpOwpAQCAtMjYwLDE2ICsyNjEsMjAgQEAgdm9pZCBLaXNDdXN0b21JbWFnZVdpZGdl dDo6Y2xpcGJvYXJkRGF0YUNoYW5nZWQoKQogICAgICAgICBLaXNDbGlwYm9hcmQgKiBjYiA9IEtp c0NsaXBib2FyZDo6aW5zdGFuY2UoKTsKICAgICAgICAgUVNpemUgc3ogPSBjYi0+Y2xpcFNpemUo KTsKICAgICAgICAgaWYgKHN6LmlzVmFsaWQoKSAmJiBzei53aWR0aCgpICE9IDAgJiYgc3ouaGVp Z2h0KCkgIT0gMCkgewotICAgICAgICAgICAgY2hrRnJvbUNsaXBib2FyZC0+c2V0Q2hlY2tlZCh0 cnVlKTsKICAgICAgICAgICAgIGNoa0Zyb21DbGlwYm9hcmQtPnNldEVuYWJsZWQodHJ1ZSk7Ci0g ICAgICAgICAgICBkb3VibGVXaWR0aC0+c2V0VmFsdWUoc3oud2lkdGgoKSk7CisgICAgICAgICAg ICBpZiAoY2hrRnJvbUNsaXBib2FyZC0+aXNDaGVja2VkKCkpIHsKKyAgICAgICAgICAgICAgICBk b3VibGVXaWR0aC0+c2V0VmFsdWUoc3oud2lkdGgoKSk7CisgICAgICAgICAgICAgICAgZG91Ymxl SGVpZ2h0LT5zZXRWYWx1ZShzei5oZWlnaHQoKSk7CisgICAgICAgICAgICB9CisgICAgICAgICAg ICBlbHNlIHsKKyAgICAgICAgICAgICAgICBkb3VibGVXaWR0aC0+c2V0VmFsdWUoZG91YmxlV2lk dGgtPnZhbHVlKCkpOworICAgICAgICAgICAgICAgIGRvdWJsZUhlaWdodC0+c2V0VmFsdWUoZG91 YmxlSGVpZ2h0LT52YWx1ZSgpKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGRvdWJsZVdp ZHRoLT5zZXREZWNpbWFscygwKTsKLSAgICAgICAgICAgIGRvdWJsZUhlaWdodC0+c2V0VmFsdWUo c3ouaGVpZ2h0KCkpOwogICAgICAgICAgICAgZG91YmxlSGVpZ2h0LT5zZXREZWNpbWFscygwKTsK ICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIGNoa0Zyb21DbGlwYm9hcmQtPnNldENoZWNr ZWQoZmFsc2UpOwogICAgICAgICAgICAgY2hrRnJvbUNsaXBib2FyZC0+c2V0RW5hYmxlZChmYWxz ZSk7Ci0KICAgICAgICAgfQogICAgIH0KIAotLSAKMS43LjEwLjQKCg== 79719 2013-05-05 16:57:32 +0000 2013-05-05 16:57:32 +0000 Solves the problem of changing height and width easily 0001-Bug-315778-Autoselects-the-first-layer.patch text/plain 5416 nagpal.sahil01 RnJvbSA2MWJhYTU5NDU4ZWQ4ZTJiMTgwZTgwMDAzMWI4YTk1NzU2YzcxYjU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAibmFncGFsLnNhaGlsMDFAZ21haWwuY29tIiA8bmFncGFsLnNh aGlsMDFAZ21haWwuY29tPgpEYXRlOiBTdW4sIDUgTWF5IDIwMTMgMjE6MDk6NTAgKzA1MzAKU3Vi amVjdDogW1BBVENIXSBCdWc6MzE1Nzc4IEF1dG9zZWxlY3RzIHRoZSBmaXJzdCBsYXllcgoKLS0t CiBrcml0YS91aS9mb3Jtcy93ZGduZXdpbWFnZS51aSAgICAgICAgICAgICAgIHwgICAyNiArKysr KysrKysrKysrKy0tLS0tLS0tLQoga3JpdGEvdWkvd2lkZ2V0cy9raXNfY3VzdG9tX2ltYWdlX3dp ZGdldC5jYyB8ICAgMzAgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiBrcml0YS91aS93aWRn ZXRzL2tpc19jdXN0b21faW1hZ2Vfd2lkZ2V0LmggIHwgICAgMSArCiAzIGZpbGVzIGNoYW5nZWQs IDM3IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2tyaXRhL3Vp L2Zvcm1zL3dkZ25ld2ltYWdlLnVpIGIva3JpdGEvdWkvZm9ybXMvd2RnbmV3aW1hZ2UudWkKaW5k ZXggZmI2NzNjZC4uNGFhMTY3MiAxMDA2NDQKLS0tIGEva3JpdGEvdWkvZm9ybXMvd2RnbmV3aW1h Z2UudWkKKysrIGIva3JpdGEvdWkvZm9ybXMvd2RnbmV3aW1hZ2UudWkKQEAgLTYsOCArNiw4IEBA CiAgICA8cmVjdD4KICAgICA8eD4wPC94PgogICAgIDx5PjA8L3k+Ci0gICAgPHdpZHRoPjQ3Mjwv d2lkdGg+Ci0gICAgPGhlaWdodD41MDM8L2hlaWdodD4KKyAgICA8d2lkdGg+NjE4PC93aWR0aD4K KyAgICA8aGVpZ2h0PjUxODwvaGVpZ2h0PgogICAgPC9yZWN0PgogICA8L3Byb3BlcnR5PgogICA8 cHJvcGVydHkgbmFtZT0id2luZG93VGl0bGUiPgpAQCAtMjYwLDYgKzI2MCwyMCBAQAogICAgICAg ICAgPC93aWRnZXQ+CiAgICAgICAgIDwvaXRlbT4KICAgICAgICAgPGl0ZW0+CisgICAgICAgICA8 d2lkZ2V0IGNsYXNzPSJRUHVzaEJ1dHRvbiIgbmFtZT0iYnRuRnJvbUNsaXBib2FyZCI+CisgICAg ICAgICAgPHByb3BlcnR5IG5hbWU9InRleHQiPgorICAgICAgICAgICA8c3RyaW5nPlVzZSBjbGlw IGltYWdlPC9zdHJpbmc+CisgICAgICAgICAgPC9wcm9wZXJ0eT4KKyAgICAgICAgIDwvd2lkZ2V0 PgorICAgICAgICA8L2l0ZW0+CisgICAgICAgIDxpdGVtPgorICAgICAgICAgPHdpZGdldCBjbGFz cz0iUUNoZWNrQm94IiBuYW1lPSJjaGtGcm9tQ2xpcGJvYXJkIj4KKyAgICAgICAgICA8cHJvcGVy dHkgbmFtZT0idGV4dCI+CisgICAgICAgICAgIDxzdHJpbmc+JmFtcDtGaXJzdCBsYXllciBmcm9t IGNsaXBib2FyZDwvc3RyaW5nPgorICAgICAgICAgIDwvcHJvcGVydHk+CisgICAgICAgICA8L3dp ZGdldD4KKyAgICAgICAgPC9pdGVtPgorICAgICAgICA8aXRlbT4KICAgICAgICAgIDxzcGFjZXI+ CiAgICAgICAgICAgPHByb3BlcnR5IG5hbWU9Im9yaWVudGF0aW9uIj4KICAgICAgICAgICAgPGVu dW0+UXQ6Okhvcml6b250YWw8L2VudW0+CkBAIC00MTEsMTMgKzQyNSw2IEBACiAgICAgICA8aXRl bSByb3c9IjIiIGNvbHVtbj0iMSI+CiAgICAgICAgPHdpZGdldCBjbGFzcz0iUVRleHRFZGl0IiBu YW1lPSJ0eHREZXNjcmlwdGlvbiIvPgogICAgICAgPC9pdGVtPgotICAgICAgPGl0ZW0gcm93PSIz IiBjb2x1bW49IjAiIGNvbHNwYW49IjIiPgotICAgICAgIDx3aWRnZXQgY2xhc3M9IlFDaGVja0Jv eCIgbmFtZT0iY2hrRnJvbUNsaXBib2FyZCI+Ci0gICAgICAgIDxwcm9wZXJ0eSBuYW1lPSJ0ZXh0 Ij4KLSAgICAgICAgIDxzdHJpbmc+JmFtcDtGaXJzdCBsYXllciBmcm9tIGNsaXBib2FyZDwvc3Ry aW5nPgotICAgICAgICA8L3Byb3BlcnR5PgotICAgICAgIDwvd2lkZ2V0PgotICAgICAgPC9pdGVt PgogICAgICAgPGl0ZW0gcm93PSIwIiBjb2x1bW49IjEiPgogICAgICAgIDx3aWRnZXQgY2xhc3M9 IktDb2xvckJ1dHRvbiIgbmFtZT0iY21iQ29sb3IiPgogICAgICAgICA8cHJvcGVydHkgbmFtZT0i Y29sb3IiPgpAQCAtNTAyLDcgKzUwOSw2IEBACiAgIDx0YWJzdG9wPmNtYkNvbG9yPC90YWJzdG9w PgogICA8dGFic3RvcD5zbGlkZXJPcGFjaXR5PC90YWJzdG9wPgogICA8dGFic3RvcD50eHREZXNj cmlwdGlvbjwvdGFic3RvcD4KLSAgPHRhYnN0b3A+Y2hrRnJvbUNsaXBib2FyZDwvdGFic3RvcD4K ICAgPHRhYnN0b3A+Y3JlYXRlQnV0dG9uPC90YWJzdG9wPgogIDwvdGFic3RvcHM+CiAgPHJlc291 cmNlcy8+CmRpZmYgLS1naXQgYS9rcml0YS91aS93aWRnZXRzL2tpc19jdXN0b21faW1hZ2Vfd2lk Z2V0LmNjIGIva3JpdGEvdWkvd2lkZ2V0cy9raXNfY3VzdG9tX2ltYWdlX3dpZGdldC5jYwppbmRl eCA4YTMwZDUwLi5iZGQ4YWM0IDEwMDY0NAotLS0gYS9rcml0YS91aS93aWRnZXRzL2tpc19jdXN0 b21faW1hZ2Vfd2lkZ2V0LmNjCisrKyBiL2tyaXRhL3VpL3dpZGdldHMva2lzX2N1c3RvbV9pbWFn ZV93aWRnZXQuY2MKQEAgLTEwNyw5ICsxMDcsMTAgQEAgS2lzQ3VzdG9tSW1hZ2VXaWRnZXQ6Oktp c0N1c3RvbUltYWdlV2lkZ2V0KFFXaWRnZXQqIHBhcmVudCwgS2lzRG9jMiogZG9jLCBxaW50MzIK ICAgICBibkxhbmRzY2FwZS0+c2V0SWNvbihrb0ljb24oImxhbmRzY2FwZSIpKTsKIAogICAgIGNv bm5lY3QoYm5TYXZlQXNQcmVkZWZpbmVkLCBTSUdOQUwoY2xpY2tlZCgpKSwgdGhpcywgU0xPVChz YXZlQXNQcmVkZWZpbmVkKCkpKTsKKyAgICBjb25uZWN0KGJ0bkZyb21DbGlwYm9hcmQsIFNJR05B TChjbGlja2VkKCkpLCB0aGlzLCBTTE9UKHNldENsaXBJbWFnZSgpKSk7CiAKLSAgICBjaGtGcm9t Q2xpcGJvYXJkLT5zZXRDaGVja2VkKGNsaXBBdmFpbGFibGUpOwogICAgIGNoa0Zyb21DbGlwYm9h cmQtPnNldEVuYWJsZWQoY2xpcEF2YWlsYWJsZSk7CisgICAgYnRuRnJvbUNsaXBib2FyZC0+c2V0 RW5hYmxlZChjbGlwQXZhaWxhYmxlKTsKIAogICAgIGNvbG9yU3BhY2VTZWxlY3Rvci0+c2V0Q3Vy cmVudENvbG9yTW9kZWwoS29JRChkZWZDb2xvck1vZGVsKSk7CiAgICAgY29sb3JTcGFjZVNlbGVj dG9yLT5zZXRDdXJyZW50Q29sb3JEZXB0aChLb0lEKGRlZkNvbG9yRGVwdGgpKTsKQEAgLTE5NCw2 ICsxOTUsMjEgQEAgdm9pZCBLaXNDdXN0b21JbWFnZVdpZGdldDo6aGVpZ2h0Q2hhbmdlZChkb3Vi bGUgdmFsdWUpCiAgICAgbV9oZWlnaHQgPSBtX2hlaWdodFVuaXQuZnJvbVVzZXJWYWx1ZSh2YWx1 ZSk7CiB9CiAKK3ZvaWQgS2lzQ3VzdG9tSW1hZ2VXaWRnZXQ6OnNldENsaXBJbWFnZSgpCit7Cisg ICAgS2lzQ2xpcGJvYXJkICogY2IgPSBLaXNDbGlwYm9hcmQ6Omluc3RhbmNlKCk7CisgICAgUVNp emUgc3ogPSBjYi0+Y2xpcFNpemUoKTsKKyAgICBpZiAoc3ouaXNWYWxpZCgpICYmIHN6LndpZHRo KCkgIT0gMCAmJiBzei5oZWlnaHQoKSAhPSAwKSB7CisgICAgICAgIGRvdWJsZVdpZHRoLT5zZXRW YWx1ZShzei53aWR0aCgpKTsKKyAgICAgICAgZG91YmxlSGVpZ2h0LT5zZXRWYWx1ZShzei5oZWln aHQoKSk7CisgICAgICAgIGNoa0Zyb21DbGlwYm9hcmQtPnNldENoZWNrZWQodHJ1ZSk7CisgICAg fQorICAgIGVsc2UgeworICAgICAgICAgY2hrRnJvbUNsaXBib2FyZC0+c2V0Q2hlY2tlZChmYWxz ZSk7CisgICAgICAgICBjaGtGcm9tQ2xpcGJvYXJkLT5zZXRFbmFibGVkKGZhbHNlKTsKKyAgICB9 Cit9CisKIHZvaWQgS2lzQ3VzdG9tSW1hZ2VXaWRnZXQ6OmNyZWF0ZUltYWdlKCkKIHsKICAgICBj b25zdCBLb0NvbG9yU3BhY2UgKiBjcyA9IGNvbG9yU3BhY2VTZWxlY3Rvci0+Y3VycmVudENvbG9y U3BhY2UoKTsKQEAgLTI2MCwxNiArMjc2LDExIEBAIHZvaWQgS2lzQ3VzdG9tSW1hZ2VXaWRnZXQ6 OmNsaXBib2FyZERhdGFDaGFuZ2VkKCkKICAgICBpZiAoKGNiRGF0YSAmJiBjYkRhdGEtPmhhc0Zv cm1hdChtaW1lVHlwZSkpIHx8ICFxaW1hZ2UuaXNOdWxsKCkpIHsKICAgICAgICAgS2lzQ2xpcGJv YXJkICogY2IgPSBLaXNDbGlwYm9hcmQ6Omluc3RhbmNlKCk7CiAgICAgICAgIFFTaXplIHN6ID0g Y2ItPmNsaXBTaXplKCk7CisgICAgICAgIAogICAgICAgICBpZiAoc3ouaXNWYWxpZCgpICYmIHN6 LndpZHRoKCkgIT0gMCAmJiBzei5oZWlnaHQoKSAhPSAwKSB7CiAgICAgICAgICAgICBjaGtGcm9t Q2xpcGJvYXJkLT5zZXRFbmFibGVkKHRydWUpOwotICAgICAgICAgICAgaWYgKGNoa0Zyb21DbGlw Ym9hcmQtPmlzQ2hlY2tlZCgpKSB7Ci0gICAgICAgICAgICAgICAgZG91YmxlV2lkdGgtPnNldFZh bHVlKHN6LndpZHRoKCkpOwotICAgICAgICAgICAgICAgIGRvdWJsZUhlaWdodC0+c2V0VmFsdWUo c3ouaGVpZ2h0KCkpOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgZWxzZSB7Ci0gICAgICAg ICAgICAgICAgZG91YmxlV2lkdGgtPnNldFZhbHVlKGRvdWJsZVdpZHRoLT52YWx1ZSgpKTsKLSAg ICAgICAgICAgICAgICBkb3VibGVIZWlnaHQtPnNldFZhbHVlKGRvdWJsZUhlaWdodC0+dmFsdWUo KSk7Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICBkb3VibGVXaWR0aC0+c2V0VmFsdWUoZG91 YmxlV2lkdGgtPnZhbHVlKCkpOworICAgICAgICAgICAgZG91YmxlSGVpZ2h0LT5zZXRWYWx1ZShk b3VibGVIZWlnaHQtPnZhbHVlKCkpOwogICAgICAgICAgICAgZG91YmxlV2lkdGgtPnNldERlY2lt YWxzKDApOwogICAgICAgICAgICAgZG91YmxlSGVpZ2h0LT5zZXREZWNpbWFscygwKTsKICAgICAg ICAgfSBlbHNlIHsKQEAgLTI3Nyw3ICsyODgsNiBAQCB2b2lkIEtpc0N1c3RvbUltYWdlV2lkZ2V0 OjpjbGlwYm9hcmREYXRhQ2hhbmdlZCgpCiAgICAgICAgICAgICBjaGtGcm9tQ2xpcGJvYXJkLT5z ZXRFbmFibGVkKGZhbHNlKTsKICAgICAgICAgfQogICAgIH0KLQogfQogCiB2b2lkIEtpc0N1c3Rv bUltYWdlV2lkZ2V0OjpzY3JlZW5TaXplQ2xpY2tlZCgpCmRpZmYgLS1naXQgYS9rcml0YS91aS93 aWRnZXRzL2tpc19jdXN0b21faW1hZ2Vfd2lkZ2V0LmggYi9rcml0YS91aS93aWRnZXRzL2tpc19j dXN0b21faW1hZ2Vfd2lkZ2V0LmgKaW5kZXggZWQ0ZjIzYi4uZTQ1ZDNjNCAxMDA2NDQKLS0tIGEv a3JpdGEvdWkvd2lkZ2V0cy9raXNfY3VzdG9tX2ltYWdlX3dpZGdldC5oCisrKyBiL2tyaXRhL3Vp L3dpZGdldHMva2lzX2N1c3RvbV9pbWFnZV93aWRnZXQuaApAQCAtNjYsNiArNjYsNyBAQCBwcml2 YXRlIHNsb3RzOgogICAgIHZvaWQgcHJlZGVmaW5lZENsaWNrZWQoaW50IGluZGV4KTsKICAgICB2 b2lkIHNhdmVBc1ByZWRlZmluZWQoKTsKICAgICB2b2lkIHN3aXRjaFdpZHRoSGVpZ2h0KCk7Cisg ICAgdm9pZCBzZXRDbGlwSW1hZ2UoKTsKIHNpZ25hbHM6CiAgICAgLy8vIHRoaXMgc2lnbmFsIGlz IGVtaXR0ZWQgKGFzIGRlZmluZWQgYnkgS29Eb2N1bWVudCkgdGhlIG1vbWVudCB0aGUgZG9jdW1l bnQgaXMgJ3JlYWR5JwogICAgIHZvaWQgZG9jdW1lbnRTZWxlY3RlZCgpOwotLSAKMS43LjEwLjQK Cg==