315400 2013-02-18 17:33:34 +0000 Dialog windows draw extra internal margins 2020-10-04 15:29:00 +0000 1 1 4 Plasma Breeze QStyle 5.19.5 Arch Linux Linux CONFIRMED usability NOR minor --- 303462 1 rockonthemoonfm kdelibs-bugs-null cfeck kdelibs-bugs-null nate popov895 https://cgit.kde.org/breeze.git/commit/?id=e15989fb1f0d73200e5a328b86170af85457a114 5.17.0 0 oldest_to_newest 1343034 0 rockonthemoonfm 2013-02-18 17:33:34 +0000 you can see that Open/Save dialog has double margins around the window. Reproducible: Always Expected Results: normal margin, correct ui. 1343906 1 cfeck 2013-02-20 23:33:03 +0000 There are no double margins, but the margin should only be applied to the lower part of the window, not the complete window. 1381351 2 rockonthemoonfm 2013-07-04 16:43:15 +0000 bug still valid for 4.11 beta 2 1714063 3 nate 2017-11-28 21:39:51 +0000 Still present in Plasma 5.11.3. It's not so much that file chooser dialog windows have double borders, but rather that they their UI elements are inset a bit. So even if you set the use the No Borders setting, the dialogs still *effectively and visually* show a border. 1866137 4 nate 2019-06-28 21:39:56 +0000 Fixed with changes in Breeze: https://cgit.kde.org/breeze.git/commit/?id=e15989fb1f0d73200e5a328b86170af85457a114 1961271 5 nate 2020-09-29 17:58:08 +0000 I closed this incorrectly, sorry. The issue--if any--is that dialog windows have larger internal padding compared to non-dialog windows. As a result, when window-decoration-drawn window borders are turned on, dialog windows have implausibly enormous borders, and when windeco borders are turned off, it looks like they are still on. Probably what we need to do is to make dialog windows have no extra internal margins, and instead add margins only ad needed to the actual content items within the dialogs. 1961273 6 nate 2020-09-29 18:01:17 +0000 *** Bug 427032 has been marked as a duplicate of this bug. *** 1961324 7 nate 2020-09-29 20:27:49 +0000 Actually now I'm not sure whether these extra margins come from Breeze, or some frameworks component that generates the dialog. Christoph, any chance you know off the top of your head? 1961489 8 cfeck 2020-09-30 00:37:23 +0000 I am not sure if I understand the issue, but could you check if breeze returns different values for PM_Layout*Margin and (deprecated) PM_DefaultTopLevelMargin? 1961573 9 popov895 2020-09-30 08:33:58 +0000 Can you try > m_processList.setContentsMargins(0,0,0,0); See https://invent.kde.org/himanshur/ksysguard/-/blob/master/gui/SensorDisplayLib/ProcessController.cpp#L148 1961674 10 popov895 2020-09-30 18:19:26 +0000 (In reply to popov895 from comment #9) > Can you try > > > m_processList.setContentsMargins(0,0,0,0); > See > https://invent.kde.org/himanshur/ksysguard/-/blob/master/gui/ > SensorDisplayLib/ProcessController.cpp#L148 Ohh, of course it doesn't make the margins smaller. Shame on me:( 1962391 11 nate 2020-10-04 15:29:00 +0000 Breeze does: } else if (auto dialog = qobject_cast<const QDialog*>(widget)) { auto margins = dialog->contentsMargins(); const_cast<QDialog*>(dialog)->setContentsMargins(margins.left(), qMax(margins.top(), 1), margins.right(), margins.bottom()); painter->setPen(QPen(_helper->separatorColor(_toolsAreaManager->palette()), PenWidth::Frame * widget->devicePixelRatio())); painter->drawLine(widget->rect().topLeft(), widget->rect().topRight()); } ...But this doesn't seem to be responsible.