315205 2013-02-15 15:47:40 +0000 Menu action 'Layer'->'Rotate'->'Rotate Layer 90 to the Left' is rotating to the right instead. 2013-02-23 10:13:18 +0000 1 1 2 Applications krita Tools/Transform git master (please specify the git hash!) Compiled Sources Linux RESOLVED FIXED NOR minor --- 0 halcyon.kdeuser krita-bugs-null dariocambie sven.langkamp http://commits.kde.org/calligra/8ef7f458d83cb33fa0c9abeff51c7d32696f96e5 0 oldest_to_newest 1342086 0 halcyon.kdeuser 2013-02-15 15:47:40 +0000 The 'Layer' menu action 'Rotate Layer 90 to the Left' is rotating the layer 90 degrees to the right, instead of to the left. See Additional Information. Reproducible: Always Steps to Reproduce: 1. Open a non-blank image. 2. Select 'Layer' in the menu bar. 3. In the 'Layer' menu, select the 'Rotate' sub-menu, then 'Rotate 90 to the Left' Actual Results: The layer is rotated 90 degrees to the right. Expected Results: The layer should have been rotated 90 degrees to the left. In the file "calligra/krita/ui/kis_node_manager.cpp", the function KisNodeManager::rotateLeft90() is passing M_PI / 2 - 2*M_PI to rotate, which isn't quite right. This should be changed to M_PI + (M_PI / 2) or -M_PI / 2. 1343086 1 77412 dariocambie 2013-02-18 20:40:48 +0000 Created attachment 77412 Patch for the bug as suggested The suggested change resolves the bug indeed. Attached is a git-patch against current master. 1343092 2 sven.langkamp 2013-02-18 21:17:21 +0000 Git commit 5f053469c572135c5c5cc8c8cbe268a1c29abace by Sven Langkamp. Committed on 18/02/2013 at 22:13. Pushed by langkamp into branch 'master'. fix layer rotate left problem was found by Dario Cambié M +1 -1 krita/ui/kis_node_manager.cpp http://commits.kde.org/calligra/5f053469c572135c5c5cc8c8cbe268a1c29abace 1343094 3 sven.langkamp 2013-02-18 21:18:39 +0000 Thanks for the patch. I did change it so to rotate by -pi/2 as that's a bit simpler. 1343111 4 dariocambie 2013-02-18 21:53:21 +0000 Thank you for the quick fix but I have to give full credit to the original reporter halcyon.kdeuser@gmail.com ;) 1344577 5 halla 2013-02-23 10:13:18 +0000 Git commit 8ef7f458d83cb33fa0c9abeff51c7d32696f96e5 by Boudewijn Rempt, on behalf of Sven Langkamp. Committed on 18/02/2013 at 22:13. Pushed by rempt into branch 'calligra/2.6'. fix layer rotate left problem was found by Dario Cambié M +1 -1 krita/ui/kis_node_manager.cpp http://commits.kde.org/calligra/8ef7f458d83cb33fa0c9abeff51c7d32696f96e5 77412 2013-02-18 20:40:48 +0000 2013-02-18 20:40:48 +0000 Patch for the bug as suggested 0001-Fix-rotateLeft90-BUG-315205.patch text/plain 706 dariocambie RnJvbSA4ZDE2YWU5NDU1Zjc5NjMxNWRlZmJlNWU0ZmRlM2E3NWQwZGQ1MzBiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RGFyaW89MjBDYW1iaT1DMz1BOT89IDxkYXJp b2NhbWJpZUBnbWFpbC5jb20+CkRhdGU6IE1vbiwgMTggRmViIDIwMTMgMjE6Mzc6NDcgKzAxMDAK U3ViamVjdDogW1BBVENIXSBGaXggcm90YXRlTGVmdDkwIChCVUcgMzE1MjA1KQoKLS0tCiBrcml0 YS91aS9raXNfbm9kZV9tYW5hZ2VyLmNwcCB8ICAgIDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2tyaXRhL3VpL2tpc19ub2Rl X21hbmFnZXIuY3BwIGIva3JpdGEvdWkva2lzX25vZGVfbWFuYWdlci5jcHAKaW5kZXggY2ZlNDJl MS4uYmI1NWFhOCAxMDA2NDQKLS0tIGEva3JpdGEvdWkva2lzX25vZGVfbWFuYWdlci5jcHAKKysr IGIva3JpdGEvdWkva2lzX25vZGVfbWFuYWdlci5jcHAKQEAgLTU3Miw3ICs1NzIsNyBAQCB2b2lk IEtpc05vZGVNYW5hZ2VyOjpyb3RhdGUxODAoKQogCiB2b2lkIEtpc05vZGVNYW5hZ2VyOjpyb3Rh dGVMZWZ0OTAoKQogewotICAgcm90YXRlKE1fUEkgLyAyIC0gMipNX1BJKTsgCisgICByb3RhdGUo TV9QSSArIChNX1BJIC8gMikgKTsgCiB9CiAKIHZvaWQgS2lzTm9kZU1hbmFnZXI6OnJvdGF0ZVJp Z2h0OTAoKQotLSAKMS43LjEwLjQKCg==