<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>312905</bug_id>
          
          <creation_ts>2013-01-08 20:16:19 +0000</creation_ts>
          <short_desc>Opus files metadata/collection support</short_desc>
          <delta_ts>2024-02-15 21:38:16 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>amarok</product>
          <component>general</component>
          <version>2.7.0</version>
          <rep_platform>openSUSE</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>2.8</target_milestone>
          
          <blocked>481383</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Mister Ypsilon">mrypsilons</reporter>
          <assigned_to name="Amarok Bugs">amarok-bugs-null</assigned_to>
          <cc>bugs.kde.org</cc>
    
    <cc>martin</cc>
    
    <cc>mrypsilons</cc>
          
          <cf_commitlink>http://commits.kde.org/amarok/abd5c3ff4051c77075b39f827d58045f100a5be3</cf_commitlink>
          <cf_versionfixedin>2.8</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1330020</commentid>
    <comment_count>0</comment_count>
    <who name="Mister Ypsilon">mrypsilons</who>
    <bug_when>2013-01-08 20:16:19 +0000</bug_when>
    <thetext>Amarok can neither import Ogg-Opus files into the collection nor read their metadata if you directly add the file to a playlist.

Reproducible: Always

Steps to Reproduce:
1. Put an opus file into the collection folder (.oga / .opus / .ogg)
2. refresh collection
3. open the file directly
Actual Results:  
1-2: Amarok doesn&apos;t add the opus files to the collection
3: Amarok isn&apos;t able to read the metadata of the file

Expected Results:  
1-2: Opus files should added to the collection with metadata
3: Metadata should be determined

Amarok/Phonon with GStreamer backend play the file itself fine. It&apos;s only the metadata which is not detected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339668</commentid>
    <comment_count>1</comment_count>
    <who name="Mister Ypsilon">mrypsilons</who>
    <bug_when>2013-02-09 18:30:10 +0000</bug_when>
    <thetext>Just tried it with a newer taglib supporting Ogg-Opus tags. Still doesn&apos;t work in amarok.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339672</commentid>
    <comment_count>2</comment_count>
    <who name="Myriam Schweingruber">myriam</who>
    <bug_when>2013-02-09 18:35:51 +0000</bug_when>
    <thetext>Did you upgrade your Amarok to 2.7?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339934</commentid>
    <comment_count>3</comment_count>
    <who name="Mister Ypsilon">mrypsilons</who>
    <bug_when>2013-02-10 10:56:42 +0000</bug_when>
    <thetext>Just updraded to 2.7, still doesn&apos;t work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1339995</commentid>
    <comment_count>4</comment_count>
    <who name="Myriam Schweingruber">myriam</who>
    <bug_when>2013-02-10 14:07:21 +0000</bug_when>
    <thetext>Thank you for the feedback.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1341474</commentid>
    <comment_count>5</comment_count>
    <who name="Martin Brodbeck">martin</who>
    <bug_when>2013-02-13 19:12:50 +0000</bug_when>
    <thetext>There is a pending patch on the reviewboard which addresses the opus metadata support. I think it might make it in HEAD really soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1342037</commentid>
    <comment_count>6</comment_count>
    <who name="Mister Ypsilon">mrypsilons</who>
    <bug_when>2013-02-15 12:25:15 +0000</bug_when>
    <thetext>Wow, thanks for the patch, works very well. I would only add &quot;.oga&quot; as a file suffix, I had to rename my whole music collection ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1343007</commentid>
    <comment_count>7</comment_count>
    <who name="Matěj Laitl">matej</who>
    <bug_when>2013-02-18 16:09:20 +0000</bug_when>
    <thetext>Git commit abd5c3ff4051c77075b39f827d58045f100a5be3 by Matěj Laitl, on behalf of Martin Brodbeck.
Committed on 12/02/2013 at 17:07.
Pushed by laitl into branch &apos;master&apos;.

Add support for Opus files if compiled against TagLib &gt; 1.8

FEATURES:
 * Added support for files in Opus codec if Amarok is compiled against recent
   enough TagLib (post 1.8). patch by Martin Brodbeck.
FIXED-IN: 2.8
REVIEW: 108542
DIGEST: Amarok now supports Opus codec with recent TagLib

M  +4    -0    CMakeLists.txt
M  +2    -0    ChangeLog
M  +1    -0    README
M  +2    -1    shared/FileType.cpp
M  +2    -1    shared/FileType.h
M  +17   -0    shared/FileTypeResolver.cpp
M  +3    -0    shared/config.h.cmake
M  +10   -0    shared/tag_helpers/TagHelper.cpp

http://commits.kde.org/amarok/abd5c3ff4051c77075b39f827d58045f100a5be3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465331</commentid>
    <comment_count>8</comment_count>
    <who name="Matěj Laitl">matej</who>
    <bug_when>2014-08-11 22:40:00 +0000</bug_when>
    <thetext>*** Bug 338204 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>