312843 2013-01-07 20:41:15 +0000 Konsole does not use transparency when background image set 2023-12-16 23:57:03 +0000 1 1 2 Applications konsole general 2.9.3 Ubuntu Linux RESOLVED FIXED NOR normal --- 1 jistanidiot konsole-bugs-null proud2bl33t wolfgang.brehm http://commits.kde.org/konsole/d5d2d9ef0d41f2906f6995707b652b3260228f40 2.13 0 oldest_to_newest 1329683 0 jistanidiot 2013-01-07 20:41:15 +0000 Set a background image for konsole and also set background transparency to something above 0%. It will not be transparent. However if one removes the background image then the transparency works. Reproducible: Always Steps to Reproduce: 1. Set both a background image and transparency. 2. 3. Actual Results: no transparency. Background image completely opaque. Expected Results: Transparency. One should be able to see through the background image. 1366311 1 wolfgang.brehm 2013-05-04 18:58:38 +0000 Confirmed on KDE 4.10.2 on opensuse 12.3 x84-64 Also if you try to trick Konsole into using transparency with a wallpaper transparent itself, every action leaves some kind of visual trace or smear, but the window is only transparent for the very first frame, after that it seems the transparent image is added to itself over and over again. This might even be an other bug, but highly related. 1366313 2 wolfgang.brehm 2013-05-04 19:07:55 +0000 (In reply to comment #1) > Confirmed on KDE 4.10.2 on opensuse 12.3 x84-64 > Also if you try to trick Konsole into using transparency with a wallpaper > transparent itself, every action leaves some kind of visual trace or smear, > but the window is only transparent for the very first frame, after that it > seems the transparent image is added to itself over and over again. > This might even be an other bug, but highly related. I forgot, this was Konsole 2.10.2 Yakuake 2.9.9 is showing very similar behavoir, but no smear/trace 1428093 3 84925 wolfgang.brehm 2014-01-31 21:02:46 +0000 Created attachment 84925 setCompositionMode to Source when painting background for also aplying the opacity setting correctly one would probably make a little bit bigger changes, for example in ColorSchemeWallpaper to set the opacity there. 1428095 4 wolfgang.brehm 2014-01-31 21:08:09 +0000 I think I know what to do to let Konsole behave the way we expect it to, but I do not know how the Konsole developers would like it to be implemented. If one of them could step by to say what he thinks on this matter it would be very nice. I am happy to help in any way I can. The patch allowes a transparent PNG to be chosen as backgound displaying transparently according to its opacity without smearing. 1428098 5 84927 wolfgang.brehm 2014-01-31 21:32:23 +0000 Created attachment 84927 New Version of patch to fix error in previous ( do not check for useOpacity setting) error in the previous one that leads to misfunction, if transparency is set. 1428104 6 wolfgang.brehm 2014-01-31 21:51:57 +0000 It is a little more complex than I thougt, sadly. The background, if it is not the wallpaper is with the proposed patch incorrect. I will think about it a little more and hopefully come back the next time with a proper solution. 1428106 7 wolfgang.brehm 2014-01-31 22:01:40 +0000 It seems the first patch _is_ working how I expected... I am a little confused here... 1429680 8 khindenburg 2014-02-09 14:51:10 +0000 Hello, your first patch works except the %opacity doesn't seem to work 1429681 9 wolfgang.brehm 2014-02-09 14:57:15 +0000 (In reply to comment #8) > Hello, your first patch works except the %opacity doesn't seem to work I know, I could now that I know what the problem is easily get this to work also but I would have to change maybe 10 lines of code including extending the ColorSchemeWallpaper class that is being used, but I do not know if this is the way to go, but if you would like to just have it work, I will be glad providing a patch ;) 1429682 10 khindenburg 2014-02-09 14:59:18 +0000 Yes, if you are willing to put together a patch please do and attach it - you could also upload it to reviewboard.kde.org w/ group as Konsole. Thanks 1429978 11 85085 wolfgang.brehm 2014-02-10 21:16:44 +0000 Created attachment 85085 Proposed Patch for fixing Wallpaper transparency everything should work as expected, but I had to introduce a _opacity variable, which seemed a little unelegant. 1429999 12 khindenburg 2014-02-10 22:32:35 +0000 Thanks a lot - I'll commit after a few minor changes. 1430040 13 khindenburg 2014-02-11 01:51:05 +0000 Git commit 09ca63dbb602a2c5d4d58fd6c9ee9206668cf1cd by Kurt Hindenburg. Committed on 11/02/2014 at 01:47. Pushed by hindenburg into branch 'master'. Allow transparency to work when using images as backgrounds. Previously when using an image as the background, the opacity was ignored. This patch corrects that. Many thanks for patch to Wolfgang Brehm wolfgang brehm gmail com FIXED-IN: 2.13 M +10 -1 src/ColorScheme.cpp M +1 -1 src/ColorScheme.h M +3 -1 src/TerminalDisplay.cpp M +2 -0 src/TerminalDisplay.h http://commits.kde.org/konsole/09ca63dbb602a2c5d4d58fd6c9ee9206668cf1cd 1430357 14 wolfgang.brehm 2014-02-12 19:37:47 +0000 Oh nice :D This community seems to work beautifully, I am really encouraged to fix other bugs in my free time. Definitely the next time one is bugging me ;) 1431187 15 khindenburg 2014-02-17 14:22:13 +0000 Git commit d5d2d9ef0d41f2906f6995707b652b3260228f40 by Kurt Hindenburg. Committed on 11/02/2014 at 01:47. Pushed by hindenburg into branch 'frameworks'. Allow transparency to work when using images as backgrounds. Previously when using an image as the background, the opacity was ignored. This patch corrects that. Many thanks for patch to Wolfgang Brehm wolfgang brehm gmail com FIXED-IN: 2.13 (cherry picked from commit 09ca63dbb602a2c5d4d58fd6c9ee9206668cf1cd) M +10 -1 src/ColorScheme.cpp M +1 -1 src/ColorScheme.h M +3 -1 src/TerminalDisplay.cpp M +2 -0 src/TerminalDisplay.h http://commits.kde.org/konsole/d5d2d9ef0d41f2906f6995707b652b3260228f40 2270133 16 bug-janitor 2023-12-01 01:35:22 +0000 A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/933 2274593 17 khindenburg 2023-12-16 23:57:03 +0000 Git commit 8939910b61f2b9fd035a9bf9292dcdbda7ef17eb by Kurt Hindenburg, on behalf of Luis Javier Merino Morán. Committed on 16/12/2023 at 18:25. Pushed by hindenburg into branch 'master'. Show wallpaper on non-translucent top-levels For reasons, showing the background image (wallpaper) has become dependant on the ability of the top-level window to be translucent. This does not need to be so. Since 5bac30ab3, to draw the wallpaper, first a background color is used to fill the dirty region, and then the wallpaper is drawn, and the opacity of the background color and the wallpaper are separate, so we can fill with a totally opaque background color, and then draw a maybe translucent wallpaper over that, and no glitches should appear. Related: bug 477800, bug 157882 M +2 -2 src/terminalDisplay/TerminalPainter.cpp https://invent.kde.org/utilities/konsole/-/commit/8939910b61f2b9fd035a9bf9292dcdbda7ef17eb 84925 2014-01-31 21:02:46 +0000 2014-02-10 21:16:44 +0000 setCompositionMode to Source when painting background setCompositionMode.patch text/plain 1657 wolfgang.brehm RnJvbSA4OGI0ZTY4ZWNjYzY0MDYzMjMyM2I4NWZiODM3MmM0YjlhODhkYjg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBXb2xmZ2FuZyBCcmVobSA8d29sZmdhbmcuYnJlaG1AZ21haWwu Y29tPgpEYXRlOiBGcmksIDMxIEphbiAyMDE0IDIxOjMxOjAxICswMTAwClN1YmplY3Q6IFtQQVRD SF0gVGVtcG9yYXJpbHkgc2V0CiBwYWludGVyLnNldENvbXBvc2l0aW9uTW9kZShRUGFpbnRlcjo6 Q29tcG9zaXRpb25Nb2RlX1NvdXJjZSk7IHNvIHRoZSBuZXcKIEJhY2tncm91bmQgaXMgbm90IHBh aW50ZWQgb24gdG9wIG9mIHRoZSBvbGQgb25lLiBUaGlzIGFsbG93ZXMgdXNpbmcgYQogdHJhbnNw YXJlbnQgUE5HIGFzIGJhY2tncm91bmQgYW5kIGhhdmluZyBpdCB0cmFuc3BhcmVudCB3aXRob3V0 IHNtZWFyaW5nLgoKLS0tCiBzcmMvVGVybWluYWxEaXNwbGF5LmNwcCB8IDkgKysrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3NyYy9UZXJtaW5hbERpc3BsYXkuY3BwIGIvc3JjL1Rlcm1pbmFsRGlzcGxheS5jcHAKaW5k ZXggN2E0MzNkMy4uYzk4YTNhOCAxMDA2NDQKLS0tIGEvc3JjL1Rlcm1pbmFsRGlzcGxheS5jcHAK KysrIGIvc3JjL1Rlcm1pbmFsRGlzcGxheS5jcHAKQEAgLTUzLDcgKzUzLDcgQEAKICNpbmNsdWRl IDxLR2xvYmFsU2V0dGluZ3M+CiAjaW5jbHVkZSA8S0lPL05ldEFjY2Vzcz4KICNpZiBkZWZpbmVk KEhBVkVfTElCS09OUSkKLSAgICAjaW5jbHVkZSA8a29ucV9vcGVyYXRpb25zLmg+CisjaW5jbHVk ZSA8a29ucV9vcGVyYXRpb25zLmg+CiAjZW5kaWYKIAogI2luY2x1ZGUgPEtGaWxlSXRlbT4KQEAg LTYxMyw4ICs2MTMsMTEgQEAgdm9pZCBUZXJtaW5hbERpc3BsYXk6OmRyYXdCYWNrZ3JvdW5kKFFQ YWludGVyJiBwYWludGVyLCBjb25zdCBRUmVjdCYgcmVjdCwgY29uc3QKICAgICBRUmVnaW9uIGNv bnRlbnRzUmVnaW9uID0gUVJlZ2lvbihyZWN0KS5zdWJ0cmFjdGVkKHNjcm9sbEJhckFyZWEpOwog ICAgIFFSZWN0IGNvbnRlbnRzUmVjdCA9IGNvbnRlbnRzUmVnaW9uLmJvdW5kaW5nUmVjdCgpOwog Ci0gICAgaWYgKHVzZU9wYWNpdHlTZXR0aW5nICYmICFfd2FsbHBhcGVyLT5pc051bGwoKSAmJgot ICAgICAgICAgICAgX3dhbGxwYXBlci0+ZHJhdyhwYWludGVyLCBjb250ZW50c1JlY3QpKSB7Cisg ICAgaWYgKHVzZU9wYWNpdHlTZXR0aW5nICYmICFfd2FsbHBhcGVyLT5pc051bGwoKSl7CisgICAg ICAgIHBhaW50ZXIuc2F2ZSgpOworICAgICAgICBwYWludGVyLnNldENvbXBvc2l0aW9uTW9kZShR UGFpbnRlcjo6Q29tcG9zaXRpb25Nb2RlX1NvdXJjZSk7CisgICAgICAgIF93YWxscGFwZXItPmRy YXcocGFpbnRlciwgY29udGVudHNSZWN0KTsKKyAgICAgICAgcGFpbnRlci5yZXN0b3JlKCk7CiAg ICAgfSBlbHNlIGlmIChxQWxwaGEoX2JsZW5kQ29sb3IpIDwgMHhmZiAmJiB1c2VPcGFjaXR5U2V0 dGluZykgewogICAgICAgICAvLyBUT0RPIC0gT24gTWFjT1MsIHVzaW5nIENvbXBvc2l0aW9uTW9k ZSBkb2Vzbid0IHdvcmsuICBBbHRlcmluZyB0aGUKICAgICAgICAgLy8gICAgICAgIHRyYW5zcGFy ZW5jeSBpbiB0aGUgY29sb3Igc2NoZW1lIChhcHBlYXJzIHRvKSBhbHRlciB0aGUKLS0gCjEuOC41 LjIKCg== 84927 2014-01-31 21:32:23 +0000 2014-02-10 21:16:44 +0000 New Version of patch to fix error in previous ( do not check for useOpacity setting) setCompositionMode.patch text/plain 1636 wolfgang.brehm RnJvbSA4OGI0ZTY4ZWNjYzY0MDYzMjMyM2I4NWZiODM3MmM0YjlhODhkYjg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBXb2xmZ2FuZyBCcmVobSA8d29sZmdhbmcuYnJlaG1AZ21haWwu Y29tPgpEYXRlOiBGcmksIDMxIEphbiAyMDE0IDIxOjMxOjAxICswMTAwClN1YmplY3Q6IFtQQVRD SF0gVGVtcG9yYXJpbHkgc2V0CiBwYWludGVyLnNldENvbXBvc2l0aW9uTW9kZShRUGFpbnRlcjo6 Q29tcG9zaXRpb25Nb2RlX1NvdXJjZSk7IHNvIHRoZSBuZXcKIEJhY2tncm91bmQgaXMgbm90IHBh aW50ZWQgb24gdG9wIG9mIHRoZSBvbGQgb25lLiBUaGlzIGFsbG93ZXMgdXNpbmcgYQogdHJhbnNw YXJlbnQgUE5HIGFzIGJhY2tncm91bmQgYW5kIGhhdmluZyBpdCB0cmFuc3BhcmVudCB3aXRob3V0 IHNtZWFyaW5nLgoKLS0tCiBzcmMvVGVybWluYWxEaXNwbGF5LmNwcCB8IDkgKysrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3NyYy9UZXJtaW5hbERpc3BsYXkuY3BwIGIvc3JjL1Rlcm1pbmFsRGlzcGxheS5jcHAKaW5k ZXggN2E0MzNkMy4uYzk4YTNhOCAxMDA2NDQKLS0tIGEvc3JjL1Rlcm1pbmFsRGlzcGxheS5jcHAK KysrIGIvc3JjL1Rlcm1pbmFsRGlzcGxheS5jcHAKQEAgLTUzLDcgKzUzLDcgQEAKICNpbmNsdWRl IDxLR2xvYmFsU2V0dGluZ3M+CiAjaW5jbHVkZSA8S0lPL05ldEFjY2Vzcz4KICNpZiBkZWZpbmVk KEhBVkVfTElCS09OUSkKLSAgICAjaW5jbHVkZSA8a29ucV9vcGVyYXRpb25zLmg+CisjaW5jbHVk ZSA8a29ucV9vcGVyYXRpb25zLmg+CiAjZW5kaWYKIAogI2luY2x1ZGUgPEtGaWxlSXRlbT4KQEAg LTYxMyw4ICs2MTMsMTEgQEAgdm9pZCBUZXJtaW5hbERpc3BsYXk6OmRyYXdCYWNrZ3JvdW5kKFFQ YWludGVyJiBwYWludGVyLCBjb25zdCBRUmVjdCYgcmVjdCwgY29uc3QKICAgICBRUmVnaW9uIGNv bnRlbnRzUmVnaW9uID0gUVJlZ2lvbihyZWN0KS5zdWJ0cmFjdGVkKHNjcm9sbEJhckFyZWEpOwog ICAgIFFSZWN0IGNvbnRlbnRzUmVjdCA9IGNvbnRlbnRzUmVnaW9uLmJvdW5kaW5nUmVjdCgpOwog Ci0gICAgaWYgKHVzZU9wYWNpdHlTZXR0aW5nICYmICFfd2FsbHBhcGVyLT5pc051bGwoKSAmJgot ICAgICAgICAgICAgX3dhbGxwYXBlci0+ZHJhdyhwYWludGVyLCBjb250ZW50c1JlY3QpKSB7Cisg ICAgaWYgKCFfd2FsbHBhcGVyLT5pc051bGwoKSl7CisgICAgICAgIHBhaW50ZXIuc2F2ZSgpOwor ICAgICAgICBwYWludGVyLnNldENvbXBvc2l0aW9uTW9kZShRUGFpbnRlcjo6Q29tcG9zaXRpb25N b2RlX1NvdXJjZSk7CisgICAgICAgIF93YWxscGFwZXItPmRyYXcocGFpbnRlciwgY29udGVudHNS ZWN0KTsKKyAgICAgICAgcGFpbnRlci5yZXN0b3JlKCk7CiAgICAgfSBlbHNlIGlmIChxQWxwaGEo X2JsZW5kQ29sb3IpIDwgMHhmZiAmJiB1c2VPcGFjaXR5U2V0dGluZykgewogICAgICAgICAvLyBU T0RPIC0gT24gTWFjT1MsIHVzaW5nIENvbXBvc2l0aW9uTW9kZSBkb2Vzbid0IHdvcmsuICBBbHRl cmluZyB0aGUKICAgICAgICAgLy8gICAgICAgIHRyYW5zcGFyZW5jeSBpbiB0aGUgY29sb3Igc2No ZW1lIChhcHBlYXJzIHRvKSBhbHRlciB0aGUKLS0gCjEuOC41LjIKCg== 85085 2014-02-10 21:16:44 +0000 2014-02-10 21:16:44 +0000 Proposed Patch for fixing Wallpaper transparency 0001-Make-wallpaper-transparency-work-as-expected.patch text/plain 3427 wolfgang.brehm RnJvbSAyMDA1Y2FmZTNkYjllZDg4YzdhYTA3Yzc1MjY3MmUxYmRhMjk2NTg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBXb2xmZ2FuZyBCcmVobSA8d29sZmdhbmcuYnJlaG1AZ21haWwu Y29tPgpEYXRlOiBNb24sIDEwIEZlYiAyMDE0IDE3OjQ3OjI3ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gTWFrZSB3YWxscGFwZXIgdHJhbnNwYXJlbmN5IHdvcmsgYXMgZXhwZWN0ZWQuIFdhbGxwYXBl cnMgd2lsbAogYmUgYWZmZWN0ZWQgYnkgdHJhbnNwYXJlbmN5IGluIHRoZSBzYW1lIHdheSBhcyBh IHRyYW5zcGFyZW50IGJhY2tncm91bmQKIGNvbG9yLgoKLS0tCiBzcmMvQ29sb3JTY2hlbWUuY3Bw ICAgICB8IDEyICsrKysrKysrKystLQogc3JjL0NvbG9yU2NoZW1lLmggICAgICAgfCAgMiArLQog c3JjL1Rlcm1pbmFsRGlzcGxheS5jcHAgfCAgNCArKystCiBzcmMvVGVybWluYWxEaXNwbGF5Lmgg ICB8ICAyICsrCiA0IGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL0NvbG9yU2NoZW1lLmNwcCBiL3NyYy9Db2xvclNjaGVtZS5j cHAKaW5kZXggNjk0NWMzOS4uNzYzZjU3MSAxMDA2NDQKLS0tIGEvc3JjL0NvbG9yU2NoZW1lLmNw cAorKysgYi9zcmMvQ29sb3JTY2hlbWUuY3BwCkBAIC00MDEsMTIgKzQwMSwyMCBAQCBib29sIENv bG9yU2NoZW1lV2FsbHBhcGVyOjppc051bGwoKSBjb25zdAogICAgIHJldHVybiBfcGF0aC5pc0Vt cHR5KCk7CiB9CiAKLWJvb2wgQ29sb3JTY2hlbWVXYWxscGFwZXI6OmRyYXcoUVBhaW50ZXImIHBh aW50ZXIsIGNvbnN0IFFSZWN0JiByZWN0KQorYm9vbCBDb2xvclNjaGVtZVdhbGxwYXBlcjo6ZHJh dyhRUGFpbnRlciYgcGFpbnRlciwgY29uc3QgUVJlY3QmIHJlY3QsIHFyZWFsIG9wYWNpdHkpCiB7 CiAgICAgaWYgKCFfcGljdHVyZSB8fCBfcGljdHVyZS0+aXNOdWxsKCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKLQorICAgIGlmIChvcGFjaXR5PT0xLjApeworICAgICAgICBwYWludGVyLmRyYXdU aWxlZFBpeG1hcChyZWN0LCAqX3BpY3R1cmUsIHJlY3QudG9wTGVmdCgpKTsKKyAgICAgICAgcmV0 dXJuIHRydWU7CisgICAgfQorICAgIHBhaW50ZXIuc2F2ZSgpOworICAgIHBhaW50ZXIuc2V0Q29t cG9zaXRpb25Nb2RlKFFQYWludGVyOjpDb21wb3NpdGlvbk1vZGVfU291cmNlKTsKKyAgICBwYWlu dGVyLmZpbGxSZWN0KHJlY3QsIFFDb2xvcigwLDAsMCwwKSk7CisgICAgcGFpbnRlci5zZXRPcGFj aXR5KG9wYWNpdHkpOwogICAgIHBhaW50ZXIuZHJhd1RpbGVkUGl4bWFwKHJlY3QsICpfcGljdHVy ZSwgcmVjdC50b3BMZWZ0KCkpOworICAgIHBhaW50ZXIucmVzdG9yZSgpOwogICAgIHJldHVybiB0 cnVlOwogfQogCmRpZmYgLS1naXQgYS9zcmMvQ29sb3JTY2hlbWUuaCBiL3NyYy9Db2xvclNjaGVt ZS5oCmluZGV4IGRmMThmMjQuLjdjNjViNmQgMTAwNjQ0Ci0tLSBhL3NyYy9Db2xvclNjaGVtZS5o CisrKyBiL3NyYy9Db2xvclNjaGVtZS5oCkBAIC01Miw3ICs1Miw3IEBAIHB1YmxpYzoKICAgICB2 b2lkIGxvYWQoKTsKIAogICAgIC8qKiBSZXR1cm5zIHRydWUgaWYgd2FsbHBhcGVyIGF2YWlsYWJs ZSBhbmQgZHJhd24gKi8KLSAgICBib29sIGRyYXcoUVBhaW50ZXImIHBhaW50ZXIsIGNvbnN0IFFS ZWN0JiByZWN0KTsKKyAgICBib29sIGRyYXcoUVBhaW50ZXImIHBhaW50ZXIsIGNvbnN0IFFSZWN0 JiByZWN0LCBxcmVhbCBvcGFjaXR5PTEuMCk7CiAKICAgICBib29sIGlzTnVsbCgpIGNvbnN0Owog CmRpZmYgLS1naXQgYS9zcmMvVGVybWluYWxEaXNwbGF5LmNwcCBiL3NyYy9UZXJtaW5hbERpc3Bs YXkuY3BwCmluZGV4IDQ4ODg3NmEuLmFlNjRhMDkgMTAwNjQ0Ci0tLSBhL3NyYy9UZXJtaW5hbERp c3BsYXkuY3BwCisrKyBiL3NyYy9UZXJtaW5hbERpc3BsYXkuY3BwCkBAIC0zNDUsNiArMzQ1LDcg QEAgVGVybWluYWxEaXNwbGF5OjpUZXJtaW5hbERpc3BsYXkoUVdpZGdldCogcGFyZW50KQogICAg ICwgX3RyaW1UcmFpbGluZ1NwYWNlcyhmYWxzZSkKICAgICAsIF9tYXJnaW4oMSkKICAgICAsIF9j ZW50ZXJDb250ZW50cyhmYWxzZSkKKyAgICAsIF9vcGFjaXR5KDEpCiB7CiAgICAgLy8gdGVybWlu YWwgYXBwbGljYXRpb25zIGFyZSBub3QgZGVzaWduZWQgd2l0aCBSaWdodC1Uby1MZWZ0IGluIG1p bmQsCiAgICAgLy8gc28gdGhlIGxheW91dCBpcyBmb3JjZWQgdG8gTGVmdC1Uby1SaWdodApAQCAt NTc3LDYgKzU3OCw3IEBAIHZvaWQgVGVybWluYWxEaXNwbGF5OjpzZXRPcGFjaXR5KHFyZWFsIG9w YWNpdHkpCiB7CiAgICAgUUNvbG9yIGNvbG9yKF9ibGVuZENvbG9yKTsKICAgICBjb2xvci5zZXRB bHBoYUYob3BhY2l0eSk7CisgICAgX29wYWNpdHk9b3BhY2l0eTsKIAogICAgIC8vIGVuYWJsZSBh dXRvbWF0aWMgYmFja2dyb3VuZCBmaWxsaW5nIHRvIHByZXZlbnQgdGhlIGRpc3BsYXkKICAgICAv LyBmbGlja2VyaW5nIGlmIHRoZXJlIGlzIG5vIHRyYW5zcGFyZW5jeQpAQCAtNjE0LDcgKzYxNiw3 IEBAIHZvaWQgVGVybWluYWxEaXNwbGF5OjpkcmF3QmFja2dyb3VuZChRUGFpbnRlciYgcGFpbnRl ciwgY29uc3QgUVJlY3QmIHJlY3QsIGNvbnN0CiAgICAgUVJlY3QgY29udGVudHNSZWN0ID0gY29u dGVudHNSZWdpb24uYm91bmRpbmdSZWN0KCk7CiAKICAgICBpZiAodXNlT3BhY2l0eVNldHRpbmcg JiYgIV93YWxscGFwZXItPmlzTnVsbCgpICYmCi0gICAgICAgICAgICBfd2FsbHBhcGVyLT5kcmF3 KHBhaW50ZXIsIGNvbnRlbnRzUmVjdCkpIHsKKyAgICAgICAgICAgIF93YWxscGFwZXItPmRyYXco cGFpbnRlciwgY29udGVudHNSZWN0LCBfb3BhY2l0eSkpIHsKICAgICB9IGVsc2UgaWYgKHFBbHBo YShfYmxlbmRDb2xvcikgPCAweGZmICYmIHVzZU9wYWNpdHlTZXR0aW5nKSB7CiAgICAgICAgIC8v IFRPRE8gLSBPbiBNYWNPUywgdXNpbmcgQ29tcG9zaXRpb25Nb2RlIGRvZXNuJ3Qgd29yay4gIEFs dGVyaW5nIHRoZQogICAgICAgICAvLyAgICAgICAgdHJhbnNwYXJlbmN5IGluIHRoZSBjb2xvciBz Y2hlbWUgKGFwcGVhcnMgdG8pIGFsdGVyIHRoZQpkaWZmIC0tZ2l0IGEvc3JjL1Rlcm1pbmFsRGlz cGxheS5oIGIvc3JjL1Rlcm1pbmFsRGlzcGxheS5oCmluZGV4IGUzNWNkYWMuLjgzYzM2NjcgMTAw NjQ0Ci0tLSBhL3NyYy9UZXJtaW5hbERpc3BsYXkuaAorKysgYi9zcmMvVGVybWluYWxEaXNwbGF5 LmgKQEAgLTkwNSw2ICs5MDUsOCBAQCBwcml2YXRlOgogICAgIGludCBfbWFyZ2luOyAgICAgIC8v IHRoZSBjb250ZW50cyBtYXJnaW4KICAgICBib29sIF9jZW50ZXJDb250ZW50czsgICAvLyBjZW50 ZXIgdGhlIGNvbnRlbnRzIGJldHdlZW4gbWFyZ2lucwogCisgICAgcXJlYWwgX29wYWNpdHk7CisK ICAgICBmcmllbmQgY2xhc3MgVGVybWluYWxEaXNwbGF5QWNjZXNzaWJsZTsKIH07CiAKLS0gCjEu OC41LjIKCg==