312766 2013-01-06 17:39:53 +0000 digiKam uses lens crop factor, not camera's [patch] 2016-07-01 09:22:24 +0000 1 1 2 Applications digikam Plugin-Editor-LensCorrection 2.6.0 Other Linux CLOSED FIXED NOR normal --- 0 rik digikam-bugs-null caulier.gilles http://commits.kde.org/digikam/613d004121682d122e9ea7fd9041a7bbc49acb89 3.0.0 0 oldest_to_newest 1329228 0 rik 2013-01-06 17:39:53 +0000 Subj. Patch will follow with a bit more details. Reproducible: Always 1329229 1 76256 rik 2013-01-06 17:40:15 +0000 Created attachment 76256 Patch to fix the problem 1329445 2 caulier.gilles 2013-01-07 10:37:38 +0000 Git commit 613d004121682d122e9ea7fd9041a7bbc49acb89 by Gilles Caulier. Committed on 07/01/2013 at 11:34. Pushed by cgilles into branch 'master'. Apply patch #76256 from Roman I Khimov to use crop factor from camera, not from lens data. Lens crop factor in DB only tells us which crop factor was used for lens calibration data, but it has nothing to do with shots made on random user's camera. So the default behaviour should be to use camera's crop factor and only fallback to lens data if there in no data present for camera. As "this should not happen" it's appropriate to spit out some debug message in this case. Ref: http://lensfun.berlios.de/manual/el_lens.html Ref: http://lensfun.berlios.de/manual/el_camera.html Related: bug 312764, bug 253941, bug 266204, bug 267613, bug 281783, bug 284708 FIXED-IN: 3.0.0 CCMAIL: roman@khimov.ru M +2 -1 libs/dimg/filters/lens/lensfuncameraselector.cpp M +1 -1 libs/dimg/filters/lens/lensfuniface.cpp http://commits.kde.org/digikam/613d004121682d122e9ea7fd9041a7bbc49acb89 1329515 3 rik 2013-01-07 13:04:55 +0000 Patch applied, thanks, closing. 76256 2013-01-06 17:40:15 +0000 2013-01-06 17:40:15 +0000 Patch to fix the problem 0003-filters-lens-use-crop-factor-from-camera-not-from-le.patch text/plain 2834 rik RnJvbSA5NDU2YjhmYzM1ODk1MmMwMzdlNjQ5NjUyOTgyM2UyMzcyM2U0NzA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb21hbiBJIEtoaW1vdiA8cm9tYW5Aa2hpbW92LnJ1PgpEYXRl OiBTdW4sIDYgSmFuIDIwMTMgMTk6NDg6MTggKzA0MDAKU3ViamVjdDogW1BBVENIIDMvM10gZmls dGVycy9sZW5zOiB1c2UgY3JvcCBmYWN0b3IgZnJvbSBjYW1lcmEsIG5vdCBmcm9tIGxlbnMKIGRh dGEKCkxlbnMgY3JvcCBmYWN0b3IgaW4gREIgb25seSB0ZWxscyB1cyB3aGljaCBjcm9wIGZhY3Rv ciB3YXMgdXNlZCBmb3IgbGVucwpjYWxpYnJhdGlvbiBkYXRhLCBidXQgaXQgaGFzIG5vdGhpbmcg dG8gZG8gd2l0aCBzaG90cyBtYWRlIG9uIHJhbmRvbSB1c2VyJ3MKY2FtZXJhLiBTbyB0aGUgZGVm YXVsdCBiZWhhdmlvdXIgc2hvdWxkIGJlIHRvIHVzZSBjYW1lcmEncyBjcm9wIGZhY3RvciBhbmQg b25seQpmYWxsYmFjayB0byBsZW5zIGRhdGEgaWYgdGhlcmUgaW4gbm8gZGF0YSBwcmVzZW50IGZv ciBjYW1lcmEuIEFzICJ0aGlzIHNob3VsZApub3QgaGFwcGVuIiBpdCdzIGFwcHJvcHJpYXRlIHRv IHNwaXQgb3V0IHNvbWUgZGVidWcgbWVzc2FnZSBpbiB0aGlzIGNhc2UuCgpSZWY6IGh0dHA6Ly9s ZW5zZnVuLmJlcmxpb3MuZGUvbWFudWFsL2VsX2xlbnMuaHRtbApSZWY6IGh0dHA6Ly9sZW5zZnVu LmJlcmxpb3MuZGUvbWFudWFsL2VsX2NhbWVyYS5odG1sCi0tLQogbGlicy9kaW1nL2ZpbHRlcnMv bGVucy9sZW5zZnVuY2FtZXJhc2VsZWN0b3IuY3BwIHwgICAgMyArKy0KIGxpYnMvZGltZy9maWx0 ZXJzL2xlbnMvbGVuc2Z1bmlmYWNlLmNwcCAgICAgICAgICB8ICAgIDIgKy0KIDIgZmlsZXMgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpYnMv ZGltZy9maWx0ZXJzL2xlbnMvbGVuc2Z1bmNhbWVyYXNlbGVjdG9yLmNwcCBiL2xpYnMvZGltZy9m aWx0ZXJzL2xlbnMvbGVuc2Z1bmNhbWVyYXNlbGVjdG9yLmNwcAppbmRleCBhZWI0ZDljLi41N2I3 YzJhIDEwMDY0NAotLS0gYS9saWJzL2RpbWcvZmlsdGVycy9sZW5zL2xlbnNmdW5jYW1lcmFzZWxl Y3Rvci5jcHAKKysrIGIvbGlicy9kaW1nL2ZpbHRlcnMvbGVucy9sZW5zZnVuY2FtZXJhc2VsZWN0 b3IuY3BwCkBAIC02MzYsNyArNjM2LDcgQEAgdm9pZCBMZW5zRnVuQ2FtZXJhU2VsZWN0b3I6OnBv cHVsYXRlTGVuc0NvbWJvKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGtEZWJ1Zygp IDw8ICJkZXY6ICIgPDwgZGV2LT5NYWtlciA8PCAiIDo6ICIgPDwgZGV2LT5Nb2RlbDsKKyAgICBr RGVidWcoKSA8PCAiZGV2OiAiIDw8IGRldi0+TWFrZXIgPDwgIiA6OiAiIDw8IGRldi0+TW9kZWwg PDwgIiA6OiAiIDw8IGRldi0+Q3JvcEZhY3RvcjsKIAogICAgIGQtPmxlbnMtPmJsb2NrU2lnbmFs cyh0cnVlKTsKICAgICBjb25zdCBsZkxlbnMqKiBsZW5zZXMgICAgID0gZC0+aWZhY2UtPmxlbnNG dW5EYXRhQmFzZSgpLT5GaW5kTGVuc2VzKGRldiwgMCwgMCk7CkBAIC02ODUsNiArNjg1LDcgQEAg dm9pZCBMZW5zRnVuQ2FtZXJhU2VsZWN0b3I6OnNsb3RMZW5zU2VsZWN0ZWQoKQogICAgIGlmIChk LT5pZmFjZS0+dXNlZExlbnMoKSAmJgogICAgICAgICBzZXR0aW5ncy5jcm9wRmFjdG9yIDw9IDAu MCkgLy8gdGhpcyBzaG91bGQgbm90IGhhcHBlbgogICAgIHsKKyAgICAgICAga0RlYnVnKCkgPDwg Ik5vIGNyb3AgZmFjdG9yIGlzIHNldCBmb3IgY2FtZXJhLCB1c2luZyBsZW5zIGNhbGlicmF0aW9u IGRhdGE6ICIgPDwgZC0+aWZhY2UtPnVzZWRMZW5zKCktPkNyb3BGYWN0b3I7CiAgICAgICAgIHNl dHRpbmdzLmNyb3BGYWN0b3IgPSBkLT5pZmFjZS0+dXNlZExlbnMoKS0+Q3JvcEZhY3RvcjsKICAg ICB9CiAKZGlmZiAtLWdpdCBhL2xpYnMvZGltZy9maWx0ZXJzL2xlbnMvbGVuc2Z1bmlmYWNlLmNw cCBiL2xpYnMvZGltZy9maWx0ZXJzL2xlbnMvbGVuc2Z1bmlmYWNlLmNwcAppbmRleCA5YTAwOGZk Li41YjhkYTM0IDEwMDY0NAotLS0gYS9saWJzL2RpbWcvZmlsdGVycy9sZW5zL2xlbnNmdW5pZmFj ZS5jcHAKKysrIGIvbGlicy9kaW1nL2ZpbHRlcnMvbGVucy9sZW5zZnVuaWZhY2UuY3BwCkBAIC05 MCw2ICs5MCw3IEBAIHZvaWQgTGVuc0Z1bklmYWNlOjpzZXRVc2VkQ2FtZXJhKERldmljZVB0ciBj YW0pCiAgICAgZC0+dXNlZENhbWVyYSAgICAgICAgICAgPSBjYW07CiAgICAgZC0+c2V0dGluZ3Mu Y2FtZXJhTWFrZSAgPSBkLT51c2VkQ2FtZXJhID8gZC0+dXNlZENhbWVyYS0+TWFrZXIgOiBRU3Ry aW5nKCk7CiAgICAgZC0+c2V0dGluZ3MuY2FtZXJhTW9kZWwgPSBkLT51c2VkQ2FtZXJhID8gZC0+ dXNlZENhbWVyYS0+TW9kZWwgOiBRU3RyaW5nKCk7CisgICAgZC0+c2V0dGluZ3MuY3JvcEZhY3Rv ciAgPSBkLT51c2VkQ2FtZXJhID8gZC0+dXNlZENhbWVyYS0+Q3JvcEZhY3RvciA6IC0xLjA7CiB9 CiAKIExlbnNGdW5JZmFjZTo6TGVuc1B0ciBMZW5zRnVuSWZhY2U6OnVzZWRMZW5zKCkgY29uc3QK QEAgLTEwMSw3ICsxMDIsNiBAQCB2b2lkIExlbnNGdW5JZmFjZTo6c2V0VXNlZExlbnMoTGVuc1B0 ciBsZW5zKQogewogICAgIGQtPnVzZWRMZW5zICAgICAgICAgICAgPSBsZW5zOwogICAgIGQtPnNl dHRpbmdzLmxlbnNNb2RlbCAgPSBkLT51c2VkTGVucyA/IGQtPnVzZWRMZW5zLT5Nb2RlbCA6IFFT dHJpbmcoKTsKLSAgICBkLT5zZXR0aW5ncy5jcm9wRmFjdG9yID0gZC0+dXNlZExlbnMgPyBkLT51 c2VkTGVucy0+Q3JvcEZhY3RvciA6IC0xLjA7CiB9CiAKIGxmRGF0YWJhc2UqIExlbnNGdW5JZmFj ZTo6bGVuc0Z1bkRhdGFCYXNlKCkgY29uc3QKLS0gCjEuNy4xMC40Cgo=