312765 2013-01-06 17:37:05 +0000 Crop factor is being used as scale factor [patch] 2016-07-01 09:22:45 +0000 1 1 2 Applications digikam Plugin-Editor-LensCorrection 2.6.0 Other Linux CLOSED FIXED NOR normal --- 0 rik digikam-bugs-null caulier.gilles http://commits.kde.org/digikam/70cf9beaac9996c219f988d8ae74d75dc253c0ad 3.0.0 0 oldest_to_newest 1329226 0 rik 2013-01-06 17:37:05 +0000 Subject says it all, patch will be added. Reproducible: Always 1329227 1 76255 rik 2013-01-06 17:37:28 +0000 Created attachment 76255 Patch to fix the problem 1329457 2 caulier.gilles 2013-01-07 10:41:44 +0000 Git commit 70cf9beaac9996c219f988d8ae74d75dc253c0ad by Gilles Caulier. Committed on 07/01/2013 at 11:39. Pushed by cgilles into branch 'master'. Apply patch #76255 from Roman I Khimov to don't pass crop factor as scale factor to lensfun. Sixth parameter to Initialize() is actually a scale factor which has nothing in common with crop factor. I think it's safe to assume that we want no scaling from lensfun and thus use the value of one. Ref: http://lensfun.berlios.de/manual/structlfModifier.html Related: bug 312764, bug 253941, bug 266204, bug 267613, bug 281783, bug 284708 FIXED-IN: 3.0.0 CCMAIL: roman@khimov.ru M +1 -1 libs/dimg/filters/lens/lensfunfilter.cpp http://commits.kde.org/digikam/70cf9beaac9996c219f988d8ae74d75dc253c0ad 1329463 3 caulier.gilles 2013-01-07 10:46:08 +0000 Roman, Thanks a lots for your investiguations and patches around digiKam Lensfun interface. Gilles Caulier 1329514 4 rik 2013-01-07 13:04:45 +0000 Patch applied, thanks, closing. 76255 2013-01-06 17:37:28 +0000 2013-01-06 17:37:28 +0000 Patch to fix the problem 0002-filters-lens-don-t-pass-crop-factor-as-scale-factor-.patch text/plain 1446 rik RnJvbSBhZDRiOTNiMzNlM2ZiYzk2MmI5ZjAyM2JkODNmNmM3MGNjODYxYjg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb21hbiBJIEtoaW1vdiA8cm9tYW5Aa2hpbW92LnJ1PgpEYXRl OiBTdW4sIDYgSmFuIDIwMTMgMTk6NDI6MTEgKzA0MDAKU3ViamVjdDogW1BBVENIIDIvM10gZmls dGVycy9sZW5zOiBkb24ndCBwYXNzIGNyb3AgZmFjdG9yIGFzIHNjYWxlIGZhY3RvciB0bwogbGVu c2Z1bgoKU2l4dGggcGFyYW1ldGVyIHRvIEluaXRpYWxpemUoKSBpcyBhY3R1YWxseSBhIHNjYWxl IGZhY3RvciB3aGljaCBoYXMgbm90aGluZwppbiBjb21tb24gd2l0aCBjcm9wIGZhY3Rvci4gSSB0 aGluayBpdCdzIHNhZmUgdG8gYXNzdW1lIHRoYXQgd2Ugd2FudCBubwpzY2FsaW5nIGZyb20gbGVu c2Z1biBhbmQgdGh1cyB1c2UgdGhlIHZhbHVlIG9mIG9uZS4KClJlZjogaHR0cDovL2xlbnNmdW4u YmVybGlvcy5kZS9tYW51YWwvc3RydWN0bGZNb2RpZmllci5odG1sCi0tLQogbGlicy9kaW1nL2Zp bHRlcnMvbGVucy9sZW5zZnVuZmlsdGVyLmNwcCB8ICAgIDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpYnMvZGltZy9maWx0 ZXJzL2xlbnMvbGVuc2Z1bmZpbHRlci5jcHAgYi9saWJzL2RpbWcvZmlsdGVycy9sZW5zL2xlbnNm dW5maWx0ZXIuY3BwCmluZGV4IDFhMTU2YjQuLmY0M2Y2NmYgMTAwNjQ0Ci0tLSBhL2xpYnMvZGlt Zy9maWx0ZXJzL2xlbnMvbGVuc2Z1bmZpbHRlci5jcHAKKysrIGIvbGlicy9kaW1nL2ZpbHRlcnMv bGVucy9sZW5zZnVuZmlsdGVyLmNwcApAQCAtMTQyLDcgKzE0Miw3IEBAIHZvaWQgTGVuc0Z1bkZp bHRlcjo6ZmlsdGVySW1hZ2UoKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGQtPmlmYWNlLT5zZXR0aW5ncygpLmZvY2FsTGVuZ3RoLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGQtPmlmYWNlLT5zZXR0aW5ncygpLmFwZXJ0dXJl LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGQtPmlmYWNlLT5z ZXR0aW5ncygpLnN1YmplY3REaXN0YW5jZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBkLT5pZmFjZS0+c2V0dGluZ3MoKS5jcm9wRmFjdG9yLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDEuMCwgLyogbm8gc2NhbGluZyAqLwog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIExGX1JFQ1RJTElORUFS LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGlmeUZsYWdz LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDAvKm5vIGludmVy c2UqLyk7Ci0tIAoxLjcuMTAuNAoK