312178 2012-12-24 21:41:12 +0000 file system boundary check fails 2013-01-05 16:08:12 +0000 1 1 2 Applications filelight general 1.12 Compiled Sources Linux RESOLVED FIXED NOR normal --- 1 majewsky martin.sandsmark http://commits.kde.org/filelight/93e3bdfdf3cbc144919af5c78a6616bf29e54d2b 20 oldest_to_newest 1326300 0 majewsky 2012-12-24 21:41:12 +0000 I'm entering this as a separate bug since the comments at bug 239825 indicate that this is a different problem. My fstab is read properly, it recognizes the local filesystems "/" and "/home". But the check for stop-at-filesystem-boundary does not work since it the path it checks is "/home/", not "/home". The patch I'm attaching fixes the problem for me, but you probably want to look into how to sanitize paths properly. Reproducible: Always 1326301 1 76001 majewsky 2012-12-24 21:43:11 +0000 Created attachment 76001 Patch that removes the uncalled-for trailing slash when the path is checked I've added extra much context to the patch so you can see which block of code the slash-append is moving past. 1327489 2 martin.sandsmark 2012-12-30 19:27:22 +0000 Git commit 4b9e4209f537ac061f91477855447c59e8da6830 by Martin T. H. Sandsmark. Committed on 30/12/2012 at 20:26. Pushed by sandsmark into branch 'master'. Temporary fix for ignoring paths, thanks to Stefan Majewsky for the patch. M +4 -1 src/part/localLister.cpp http://commits.kde.org/filelight/4b9e4209f537ac061f91477855447c59e8da6830 1328860 3 martin.sandsmark 2013-01-05 16:08:12 +0000 Git commit 93e3bdfdf3cbc144919af5c78a6616bf29e54d2b by Martin T. H. Sandsmark. Committed on 30/12/2012 at 20:26. Pushed by sandsmark into branch 'KDE/4.10'. Temporary fix for ignoring paths, thanks to Stefan Majewsky for the patch. M +4 -1 src/part/localLister.cpp http://commits.kde.org/filelight/93e3bdfdf3cbc144919af5c78a6616bf29e54d2b 76001 2012-12-24 21:43:11 +0000 2012-12-24 21:43:11 +0000 Patch that removes the uncalled-for trailing slash when the path is checked patch text/plain 1447 majewsky ZGlmZiAtLWdpdCBhL3NyYy9wYXJ0L2xvY2FsTGlzdGVyLmNwcCBiL3NyYy9wYXJ0L2xvY2FsTGlz dGVyLmNwcAppbmRleCBkZDQwMGYyLi5kNTY5NWJkIDEwMDY0NAotLS0gYS9zcmMvcGFydC9sb2Nh bExpc3Rlci5jcHAKKysrIGIvc3JjL3BhcnQvbG9jYWxMaXN0ZXIuY3BwCkBAIC0xOTAsMzIgKzE5 MCwzNSBAQCBMb2NhbExpc3Rlcjo6c2Nhbihjb25zdCBRQnl0ZUFycmF5ICZwYXRoLCBjb25zdCBR Qnl0ZUFycmF5ICZkaXJuYW1lKQogICAgICAgICAgICAgY3dkLT5hcHBlbmQoZW50LT5kX25hbWUs IHN0YXRidWYuc3Rfc2l6ZSk7CiAjZW5kaWYKIAogICAgICAgICBlbHNlIGlmIChTX0lTRElSKHN0 YXRidWYuc3RfbW9kZSkpIC8vZm9sZGVyCiAgICAgICAgIHsKICAgICAgICAgICAgIEZvbGRlciAq ZCA9IDA7CiAgICAgICAgICAgICBRQnl0ZUFycmF5IG5ld19kaXJuYW1lID0gZW50LT5kX25hbWU7 CiAgICAgICAgICAgICBuZXdfZGlybmFtZSArPSAnLyc7Ci0gICAgICAgICAgICBuZXdfcGF0aCAg ICArPSAnLyc7CiAKICAgICAgICAgICAgIC8vY2hlY2sgdG8gc2VlIGlmIHdlJ3ZlIHNjYW5uZWQg dGhpcyBzZWN0aW9uIGFscmVhZHkKIAogICAgICAgICAgICAgZm9yIChJdGVyYXRvcjxGb2xkZXI+ IGl0ID0gbV90cmVlcy0+aXRlcmF0b3IoKTsgaXQgIT0gbV90cmVlcy0+ZW5kKCk7ICsraXQpCiAg ICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgaWYgKG5ld19wYXRoID09ICgqaXQpLT5uYW1l OEJpdCgpKQogICAgICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAgICAga0RlYnVnKCkg PDwgIlRyZWUgcHJlLWNvbXBsZXRlZDogIiA8PCAoKml0KS0+bmFtZSgpOwogICAgICAgICAgICAg ICAgICAgICBkID0gaXQucmVtb3ZlKCk7CiAgICAgICAgICAgICAgICAgICAgIG1fcGFyZW50LT5t X2ZpbGVzICs9IGQtPmNoaWxkcmVuKCk7CiAgICAgICAgICAgICAgICAgICAgIC8vKioqKiBpZGVh bGx5IGRvbid0IGhhdmUgdGhpcyByZWR1bmRhbnQgZXh0cmEgc29tZWhvdwogICAgICAgICAgICAg ICAgICAgICBjd2QtPmFwcGVuZChkLCBuZXdfZGlybmFtZSk7CiAgICAgICAgICAgICAgICAgfQog ICAgICAgICAgICAgfQogCisgICAgICAgICAgICAvLyBkbyB0aGlzIGFmdGVyIHRoZSBtX3RyZWVz IGNoZWNrIHNpbmNlIHRoZSBwYXRocyBpbiB0aGVyZQorICAgICAgICAgICAgLy8gbGFjayBhIHRy YWlsaW5nIHNsYXNoCisgICAgICAgICAgICBuZXdfcGF0aCArPSAnLyc7CisKICAgICAgICAgICAg IGlmICghZCkgLy90aGVuIHNjYW4KICAgICAgICAgICAgICAgICBpZiAoKGQgPSBzY2FuKG5ld19w YXRoLCBuZXdfZGlybmFtZSkpKSAvL3RoZW4gc2NhbiB3YXMgc3VjY2Vzc2Z1bAogICAgICAgICAg ICAgICAgICAgICBjd2QtPmFwcGVuZChkKTsKICAgICAgICAgfQogCiAgICAgICAgICsrbV9wYXJl bnQtPm1fZmlsZXM7CiAgICAgfQogCg==