<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>312128</bug_id>
          
          <creation_ts>2012-12-23 18:39:17 +0000</creation_ts>
          <short_desc>Amarok doesn&apos;t update database playlists when track&apos;s uid url changes</short_desc>
          <delta_ts>2012-12-23 22:46:28 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>amarok</product>
          <component>Collections/Local</component>
          <version>2.6.90 (2.7 beta)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.7</target_milestone>
          <dependson>308371</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matěj Laitl">matej</reporter>
          <assigned_to name="Amarok Bugs">amarok-bugs-null</assigned_to>
          <cc>graham</cc>
    
    <cc>matej</cc>
    
    <cc>ralf-engels</cc>
    
    <cc>walter.von.entferndt</cc>
          
          <cf_commitlink>http://commits.kde.org/amarok/2f261b02ede0ecc9a566cbcb2680e06db092dbc1</cf_commitlink>
          <cf_versionfixedin>2.7</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1326068</commentid>
    <comment_count>0</comment_count>
    <who name="Matěj Laitl">matej</who>
    <bug_when>2012-12-23 18:39:17 +0000</bug_when>
    <thetext>This is a bugreport for the second part of the bug 308371. From the original bug:

&gt; Maybe I edited the metadata of songs that were already referenced in a playlist in
&gt; the amarok database. When I opened the playlist, two songs were greyed and did
&gt; not play.

&gt; Right click -&gt; searching for module AMAROK-SQLTRACKUID. Then amarok was not
&gt; responding for a few minutes, but the module does not seem to be installed, the
&gt; two songs still do not play.

This part has been already solved.

&gt; Reproducible: Always
&gt; Steps to Reproduce:
&gt; 1. Save a playlist in the DB
&gt; 2. Edit the metadata of a song in the playlist
&gt; 3. Re-open the playlist Actual Results: The edited song is greyed and can not be played</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1326071</commentid>
    <comment_count>1</comment_count>
    <who name="Matěj Laitl">matej</who>
    <bug_when>2012-12-23 18:46:04 +0000</bug_when>
    <thetext>Git commit 2f261b02ede0ecc9a566cbcb2680e06db092dbc1 by Matěj Laitl.
Committed on 23/12/2012 at 19:42.
Pushed by laitl into branch &apos;master&apos;.

Fix SqlTrack::updatePlaylistToDb(): we need to update url too

This fixes all the remaining problems originally reported in bug 308371.
I&apos;ve confirmed it works both then the track uid change is triggered from
within Amarok and from external tool when Amarok is not running.

BUGFIXES:
 * Fix updating of Amarok database playlists then track uid changes.
Related: bug 308371
FIXED-IN: 2.7

M  +1    -0    ChangeLog
M  +15   -11   src/core-impl/collections/db/sql/SqlMeta.cpp
M  +1    -0    src/playlistmanager/sql/SqlPlaylist.cpp

http://commits.kde.org/amarok/2f261b02ede0ecc9a566cbcb2680e06db092dbc1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1326120</commentid>
    <comment_count>2</comment_count>
    <who name="Walter von Entferndt">walter.von.entferndt</who>
    <bug_when>2012-12-23 22:42:05 +0000</bug_when>
    <thetext>Dear Matěj,

I regret having caused trouble.  Thanx for your patience and insistence to fix 
the bug.

I wish you a peaceful and merry X-Mas.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1326123</commentid>
    <comment_count>3</comment_count>
    <who name="Matěj Laitl">matej</who>
    <bug_when>2012-12-23 22:46:28 +0000</bug_when>
    <thetext>(In reply to comment #2)
&gt; Dear Matěj,

Hi Torsten,

&gt; I regret having caused trouble.

No serious trouble caused, you couldn&apos;t have known our bugzilla usage in advance.

&gt; Thanx for your patience and insistence to fix  the bug.
&gt; 
&gt; I wish you a peaceful and merry X-Mas.

Thanks, to you too. :-)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>