<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>311548</bug_id>
          
          <creation_ts>2012-12-12 00:53:47 +0000</creation_ts>
          <short_desc>Potential infinite loop</short_desc>
          <delta_ts>2012-12-12 00:56:33 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>telepathy</product>
          <component>kded-module</component>
          <version>0.5.1</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>Future</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Edmundson">kde</reporter>
          <assigned_to name="Telepathy Bugs">kde-telepathy-bugs-null</assigned_to>
          
          
          <cf_commitlink>http://commits.kde.org/telepathy-kded-module/3277a4ada099b17a1e6d477f52181436d0d4410b</cf_commitlink>
          <cf_versionfixedin>0.5.2</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1323124</commentid>
    <comment_count>0</comment_count>
    <who name="David Edmundson">kde</who>
    <bug_when>2012-12-12 00:53:47 +0000</bug_when>
    <thetext>The kded module has a while loop in ContactRequestHandler::onContactRequestDenied which reads

while (i != list.constEnd()) {
  if (valid) {
     it++
  }
}

The it++ should obviously be outside the if.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1323125</commentid>
    <comment_count>1</comment_count>
    <who name="David Edmundson">kde</who>
    <bug_when>2012-12-12 00:56:23 +0000</bug_when>
    <thetext>Git commit 3277a4ada099b17a1e6d477f52181436d0d4410b by David Edmundson.
Committed on 12/12/2012 at 01:54.
Pushed by davidedmundson into branch &apos;kde-telepathy-0.5&apos;.

Fix potential infinite loop denying a contact

M  +1    -1    contact-request-handler.cpp

http://commits.kde.org/telepathy-kded-module/3277a4ada099b17a1e6d477f52181436d0d4410b</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>