<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>309498</bug_id>
          
          <creation_ts>2012-11-03 22:07:53 +0000</creation_ts>
          <short_desc>&quot;Play/Stop&quot; button in information panel is fixed size</short_desc>
          <delta_ts>2012-11-04 13:45:24 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>dolphin</product>
          <component>panels: information</component>
          <version>2.1</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kai Uwe Broulik">kde</reporter>
          <assigned_to name="Dolphin Bug Assignee">dolphin-bugs-null</assigned_to>
          
          
          <cf_commitlink>http://commits.kde.org/kde-baseapps/cc06935397ecb1c543ed7d52887007f425a1cddb</cf_commitlink>
          <cf_versionfixedin>4.9.4</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1312181</commentid>
    <comment_count>0</comment_count>
    <who name="Kai Uwe Broulik">kde</who>
    <bug_when>2012-11-03 22:07:53 +0000</bug_when>
    <thetext>[Probably a KDElibs issue]

The &quot;Play&quot; button in the places panel is hardcoded to 16px and does not follow KDE&apos;s global icon sizes making it hard to hit on high-dpi screens

Reproducible: Always</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1312194</commentid>
    <comment_count>1</comment_count>
    <who name="Jekyll Wu">adaptee</who>
    <bug_when>2012-11-03 23:46:19 +0000</bug_when>
    <thetext>
information/phononwidget.cpp:127:        m_playButton-&gt;setIconSize(QSize(16, 16));
information/phononwidget.cpp:133:        m_stopButton-&gt;setIconSize(QSize(16, 16));</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1312277</commentid>
    <comment_count>2</comment_count>
    <who name="Frank Reininghaus">frank78ac</who>
    <bug_when>2012-11-04 09:06:33 +0000</bug_when>
    <thetext>Thanks Kai for the bug report and Jekyll for finding the relevant code! I think that we should replace those &quot;16&quot; by KIconLoader::SizeSmall, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1312306</commentid>
    <comment_count>3</comment_count>
    <who name="Kai Uwe Broulik">kde</who>
    <bug_when>2012-11-04 10:12:55 +0000</bug_when>
    <thetext>IconSize(KIconLoader::Small) should do the job</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1312362</commentid>
    <comment_count>4</comment_count>
    <who name="Frank Reininghaus">frank78ac</who>
    <bug_when>2012-11-04 13:41:27 +0000</bug_when>
    <thetext>Git commit cc06935397ecb1c543ed7d52887007f425a1cddb by Frank Reininghaus.
Committed on 04/11/2012 at 14:39.
Pushed by freininghaus into branch &apos;KDE/4.9&apos;.

Do not use a hardcoded size for the buttons in the Information panel

Thanks to Kai Uwe Broulok and Jekyll Wu for the investigation!
FIXED-IN: 4.9.4

M  +5    -2    dolphin/src/panels/information/phononwidget.cpp

http://commits.kde.org/kde-baseapps/cc06935397ecb1c543ed7d52887007f425a1cddb</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1312363</commentid>
    <comment_count>5</comment_count>
    <who name="Frank Reininghaus">frank78ac</who>
    <bug_when>2012-11-04 13:45:24 +0000</bug_when>
    <thetext>@Kai: sorry for the typo in the commit message, found it only now. &quot;i&quot; and &quot;o&quot; are too close to each other on my keyboard ;-)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>