309170 2012-10-28 21:10:25 +0000 If a windows is fullscreen the quick (un)maximizing is triggered when Alt+click moving it 2012-11-14 20:33:47 +0000 1 1 4 Plasma kwin core 4.9.2 unspecified Linux RESOLVED FIXED NOR normal --- 0 kde kwin-bugs-null http://commits.kde.org/kde-workspace/cc50c7b974148539fc05558006b830709b445f23 0 oldest_to_newest 1310346 0 kde 2012-10-28 21:10:25 +0000 If you have a fullscreen window and move it using Alt+Left mouse, the quick (un)maximizing is triggered. This is usually not visible but when using the new Maximize effect, you can see that if your window is maximized and then you fullscreen it and move it around, that the maximize animation is triggered. See Review 107050 Reproducible: Always Steps to Reproduce: 0. Have the Maximize effect enabled 1. Open a window 2. Maximize it 3. Fullscreen it 4. Press Alt 5. Left click and hold the window Actual Results: The window jumps to its original size and then transitions back to fullscreen Expected Results: Nothing, you can just move the window around to any other screen 1310354 1 74857 thomas.luebking 2012-10-28 21:44:30 +0000 Created attachment 74857 patch preview applied is a patch that omits _all_ special alteration of maximized fullscreen windows (what should be correct, since you can only move the window between screens anyway) 1315319 2 thomas.luebking 2012-11-13 23:16:33 +0000 https://git.reviewboard.kde.org/r/107317/ 1315641 3 thomas.luebking 2012-11-14 20:33:47 +0000 Git commit cc50c7b974148539fc05558006b830709b445f23 by Thomas Lübking. Committed on 01/11/2012 at 20:54. Pushed by luebking into branch 'master'. don't leave quick tiling for FS windows REVIEW: 107317 M +21 -18 kwin/geometry.cpp http://commits.kde.org/kde-workspace/cc50c7b974148539fc05558006b830709b445f23 74857 2012-10-28 21:44:30 +0000 2012-10-28 21:44:30 +0000 patch preview __fix_309170.diff text/plain 3529 thomas.luebking ZGlmZiAtLWdpdCBhL2t3aW4vZ2VvbWV0cnkuY3BwIGIva3dpbi9nZW9tZXRyeS5jcHAKaW5kZXgg ODQyZTZkNi4uMWYxYjJkZCAxMDA2NDQKLS0tIGEva3dpbi9nZW9tZXRyeS5jcHAKKysrIGIva3dp bi9nZW9tZXRyeS5jcHAKQEAgLTI1MzQsMjQgKzI1MzQsMjcgQEAgYm9vbCBDbGllbnQ6OnN0YXJ0 TW92ZVJlc2l6ZSgpCiAgICAgLy8gd2hlbiBzdGFydGluZyBhIG1vdmUgYXMgdGhlIHVzZXIgY2Fu IHVuZG8gdGhlaXIgYWN0aW9uIGJ5IG1vdmluZyB0aGUgd2luZG93IGJhY2sgdG8KICAgICAvLyB0 aGUgdG9wIG9mIHRoZSBzY3JlZW4uIFdoZW4gdGhlIHNldHRpbmcgaXMgZGlzYWJsZWQgdGhlbiBk b2luZyBzbyBpcyBjb25mdXNpbmcuCiAgICAgYm9vbCBmYWtlTW92ZSA9IGZhbHNlOwotICAgIGlm IChtYXhpbWl6ZU1vZGUoKSAhPSBNYXhpbWl6ZVJlc3RvcmUgJiYgKG1heGltaXplTW9kZSgpICE9 IE1heGltaXplRnVsbCB8fCBvcHRpb25zLT5tb3ZlUmVzaXplTWF4aW1pemVkV2luZG93cygpKSkg ewotICAgICAgICAvLyBhbGxvdyBtb3ZlUmVzaXplLCBidXQgdW5zZXQgbWF4aW1pemF0aW9uIHN0 YXRlIGluIHJlc2l6ZSBjYXNlCi0gICAgICAgIGlmIChtb2RlICE9IFBvc2l0aW9uQ2VudGVyKSB7 IC8vIG1lYW5zICJpc1Jlc2l6ZSgpIiBidXQgbW92ZVJlc2l6ZU1vZGUgPSB0cnVlIGlzIHNldCBi ZWxvdwotICAgICAgICAgICAgaWYgKG1heGltaXplTW9kZSgpID09IE1heGltaXplRnVsbCkgeyAv LyBwYXJ0aWFsIGlzIGNvbmQuIHJlc2V0IGluIGZpbmlzaE1vdmVSZXNpemUKLSAgICAgICAgICAg ICAgICBnZW9tX3Jlc3RvcmUgPSBnZW9tZXRyeSgpOyAvLyAicmVzdG9yZSIgdG8gY3VycmVudCBn ZW9tZXRyeQotICAgICAgICAgICAgICAgIHNldE1heGltaXplKGZhbHNlLCBmYWxzZSk7Ci0gICAg ICAgICAgICB9Ci0gICAgICAgIH0gZWxzZSBpZiAocXVpY2tfdGlsZV9tb2RlICE9IFF1aWNrVGls ZU5vbmUpIC8vIG5vIGxvbmdlciBub3cgLSB3ZSBtb3ZlLCByZXNpemUgaXMgaGFuZGxlZCBiZWxv dwotICAgICAgICAgICAgc2V0UXVpY2tUaWxlTW9kZShRdWlja1RpbGVOb25lKTsgLy8gb3RoZXJ3 aXNlIHdlIG1lc3MgZXZlcnkgc2Vjb25kIHRpbGUsIGJ1ZyAjMzAzOTM3Ci0gICAgfSBlbHNlIGlm ICgobWF4aW1pemVNb2RlKCkgPT0gTWF4aW1pemVGdWxsICYmIG9wdGlvbnMtPmVsZWN0cmljQm9y ZGVyTWF4aW1pemUoKSkgfHwKLSAgICAgICAgICAgICAgIChxdWlja190aWxlX21vZGUgIT0gUXVp Y2tUaWxlTm9uZSAmJiBpc01vdmFibGUoKSAmJiBtb2RlID09IFBvc2l0aW9uQ2VudGVyKSkgewot ICAgICAgICAvLyBFeGl0IHF1aWNrIHRpbGUgbW9kZSB3aGVuIHRoZSB1c2VyIGF0dGVtcHRzIHRv IG1vdmUgYSB0aWxlZCB3aW5kb3csIGNhbm5vdCB1c2UgaXNNb3ZlKCkgeWV0Ci0gICAgICAgIGNv bnN0IFFSZWN0IGJlZm9yZSA9IGdlb21ldHJ5KCk7Ci0gICAgICAgIHNldFF1aWNrVGlsZU1vZGUo UXVpY2tUaWxlTm9uZSk7Ci0gICAgICAgIC8vIE1vdmUgdGhlIHdpbmRvdyBzbyBpdCdzIHVuZGVy IHRoZSBjdXJzb3IKLSAgICAgICAgbW92ZU9mZnNldCA9IFFQb2ludChkb3VibGUobW92ZU9mZnNl dC54KCkpIC8gZG91YmxlKGJlZm9yZS53aWR0aCgpKSAqIGRvdWJsZShnZW9tX3Jlc3RvcmUud2lk dGgoKSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgZG91YmxlKG1vdmVPZmZzZXQueSgp KSAvIGRvdWJsZShiZWZvcmUuaGVpZ2h0KCkpICogZG91YmxlKGdlb21fcmVzdG9yZS5oZWlnaHQo KSkpOwotICAgICAgICBmYWtlTW92ZSA9IHRydWU7CisgICAgaWYgKCFpc0Z1bGxTY3JlZW4oKSkg eyAvLyB4aW5lcmFtYSBtb3ZlIGFjcm9zcyBzY3JlZW5zIC0+IHdpbmRvdyBpcyBGUywgZXZlcnl0 aGluZyBlbHNlIGlzIHNlY29uZGFyeSBhbmQgdW50b3VjaGVkCisgICAgICAgIGlmIChtYXhpbWl6 ZU1vZGUoKSAhPSBNYXhpbWl6ZVJlc3RvcmUgJiYKKyAgICAgICAgICAgIChtYXhpbWl6ZU1vZGUo KSAhPSBNYXhpbWl6ZUZ1bGwgfHwgb3B0aW9ucy0+bW92ZVJlc2l6ZU1heGltaXplZFdpbmRvd3Mo KSkpIHsKKyAgICAgICAgICAgIC8vIGFsbG93IG1vdmVSZXNpemUsIGJ1dCB1bnNldCBtYXhpbWl6 YXRpb24gc3RhdGUgaW4gcmVzaXplIGNhc2UKKyAgICAgICAgICAgIGlmIChtb2RlICE9IFBvc2l0 aW9uQ2VudGVyKSB7IC8vIG1lYW5zICJpc1Jlc2l6ZSgpIiBidXQgbW92ZVJlc2l6ZU1vZGUgPSB0 cnVlIGlzIHNldCBiZWxvdworICAgICAgICAgICAgICAgIGlmIChtYXhpbWl6ZU1vZGUoKSA9PSBN YXhpbWl6ZUZ1bGwpIHsgLy8gcGFydGlhbCBpcyBjb25kLiByZXNldCBpbiBmaW5pc2hNb3ZlUmVz aXplCisgICAgICAgICAgICAgICAgICAgIGdlb21fcmVzdG9yZSA9IGdlb21ldHJ5KCk7IC8vICJy ZXN0b3JlIiB0byBjdXJyZW50IGdlb21ldHJ5CisgICAgICAgICAgICAgICAgICAgIHNldE1heGlt aXplKGZhbHNlLCBmYWxzZSk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfSBlbHNl IGlmIChxdWlja190aWxlX21vZGUgIT0gUXVpY2tUaWxlTm9uZSkgLy8gbm8gbG9uZ2VyIG5vdyAt IHdlIG1vdmUsIHJlc2l6ZSBpcyBoYW5kbGVkIGJlbG93CisgICAgICAgICAgICAgICAgc2V0UXVp Y2tUaWxlTW9kZShRdWlja1RpbGVOb25lKTsgLy8gb3RoZXJ3aXNlIHdlIG1lc3MgZXZlcnkgc2Vj b25kIHRpbGUsIGJ1ZyAjMzAzOTM3CisgICAgICAgIH0gZWxzZSBpZiAoKG1heGltaXplTW9kZSgp ID09IE1heGltaXplRnVsbCAmJiBvcHRpb25zLT5lbGVjdHJpY0JvcmRlck1heGltaXplKCkpIHx8 CisgICAgICAgICAgICAgICAgICAgKHF1aWNrX3RpbGVfbW9kZSAhPSBRdWlja1RpbGVOb25lICYm IGlzTW92YWJsZSgpICYmIG1vZGUgPT0gUG9zaXRpb25DZW50ZXIpKSB7CisgICAgICAgICAgICAv LyBFeGl0IHF1aWNrIHRpbGUgbW9kZSB3aGVuIHRoZSB1c2VyIGF0dGVtcHRzIHRvIG1vdmUgYSB0 aWxlZCB3aW5kb3csIGNhbm5vdCB1c2UgaXNNb3ZlKCkgeWV0CisgICAgICAgICAgICBjb25zdCBR UmVjdCBiZWZvcmUgPSBnZW9tZXRyeSgpOworICAgICAgICAgICAgc2V0UXVpY2tUaWxlTW9kZShR dWlja1RpbGVOb25lKTsKKyAgICAgICAgICAgIC8vIE1vdmUgdGhlIHdpbmRvdyBzbyBpdCdzIHVu ZGVyIHRoZSBjdXJzb3IKKyAgICAgICAgICAgIG1vdmVPZmZzZXQgPSBRUG9pbnQoZG91YmxlKG1v dmVPZmZzZXQueCgpKSAvIGRvdWJsZShiZWZvcmUud2lkdGgoKSkgKiBkb3VibGUoZ2VvbV9yZXN0 b3JlLndpZHRoKCkpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb3VibGUobW92 ZU9mZnNldC55KCkpIC8gZG91YmxlKGJlZm9yZS5oZWlnaHQoKSkgKiBkb3VibGUoZ2VvbV9yZXN0 b3JlLmhlaWdodCgpKSk7CisgICAgICAgICAgICBmYWtlTW92ZSA9IHRydWU7CisgICAgICAgIH0K ICAgICB9CiAKICAgICBpZiAocXVpY2tfdGlsZV9tb2RlICE9IFF1aWNrVGlsZU5vbmUgJiYgbW9k ZSAhPSBQb3NpdGlvbkNlbnRlcikgeyAvLyBDYW5ub3QgdXNlIGlzUmVzaXplKCkgeWV0Cg==