<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>308895</bug_id>
          
          <creation_ts>2012-10-23 18:17:35 +0000</creation_ts>
          <short_desc>Handle Enter key as well as Return to send message</short_desc>
          <delta_ts>2012-10-23 18:37:41 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>telepathy</product>
          <component>text-ui</component>
          <version>0.5.1</version>
          <rep_platform>unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>major</bug_severity>
          <target_milestone>Future</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Edmundson">kde</reporter>
          <assigned_to name="Telepathy Bugs">kde-telepathy-bugs-null</assigned_to>
          
          
          <cf_commitlink>http://commits.kde.org/telepathy-text-ui/880d89e43550d2631c377bc23f0bacb6cfa98f5a</cf_commitlink>
          <cf_versionfixedin>0.5.2</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1308525</commentid>
    <comment_count>0</comment_count>
    <who name="David Edmundson">kde</who>
    <bug_when>2012-10-23 18:17:35 +0000</bug_when>
    <thetext>Some people with quirky keyboards have a return key that appears as:

[11:14] &lt;ciummo&gt; KeyPress event, serial 34, synthetic NO, window 0x5400001,     root 0xac, subw 0x0, time 8823377, (7,335), root:(621,385),     state 0x0, keycode 104 (keysym 0xff8d, KP_Enter), same_screen YES, &quot;   XLookupString gives 1 bytes: (0d) &quot; &quot;   XmbLookupString gives 1 bytes: (0d) &quot;     XFilterEvent returns: False

this means it misses

if (e-&gt;key()==Qt::Key_Return &amp;&amp; !e-&gt;modifiers()) {
 Q_EMIT returnKeyPressed();
 return;
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308533</commentid>
    <comment_count>1</comment_count>
    <who name="Rohan Garg">rohan</who>
    <bug_when>2012-10-23 18:35:43 +0000</bug_when>
    <thetext>Git commit 558554b15ac75817881536546d8e9bc827e9bc61 by Rohan Garg, on behalf of David Edmundson.
Committed on 23/10/2012 at 20:27.
Pushed by garg into branch &apos;master&apos;.

Allow sending messages with the enter key as well as return.

M  +1    -1    lib/chat-text-edit.cpp

http://commits.kde.org/telepathy-text-ui/558554b15ac75817881536546d8e9bc827e9bc61</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1308535</commentid>
    <comment_count>2</comment_count>
    <who name="Rohan Garg">rohan</who>
    <bug_when>2012-10-23 18:37:41 +0000</bug_when>
    <thetext>Git commit 880d89e43550d2631c377bc23f0bacb6cfa98f5a by Rohan Garg, on behalf of David Edmundson.
Committed on 23/10/2012 at 20:27.
Pushed by garg into branch &apos;kde-telepathy-0.5&apos;.

Allow sending messages with the enter key as well as return.

M  +1    -1    lib/chat-text-edit.cpp

http://commits.kde.org/telepathy-text-ui/880d89e43550d2631c377bc23f0bacb6cfa98f5a</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>