308820 2012-10-22 17:40:33 +0000 Does not respond to style changes immediately 2012-10-23 12:19:18 +0000 1 1 10 Unmaintained telepathy contactlist unspecified unspecified Linux RESOLVED FIXED junior-jobs NOR normal Future 1 kde kde-telepathy-bugs-null mklapetek http://commits.kde.org/telepathy-contact-list/d57901ab55947c1f3bae152c7d30bd6704b056b7 0.5.2 0 oldest_to_newest 1308239 0 kde 2012-10-22 17:40:33 +0000 Changing the KDE colour scheme does not immediately update the contact list. This is because we have the following code in AbstractContactDelegate which we then use m_palette = new QPalette(QApplication::palette()); QApplication::palette is a very fast operation, so there's no point keeping it as a member variable. This call just needs moving into each of the paintEvents. 1308245 1 kde 2012-10-22 17:47:01 +0000 Marking as a junior job. To solve find every instance of m_palette in the subclass and replace it with QApplication::palette() instead Then remove m_palette completely. 1308277 2 cfeck 2012-10-22 19:30:07 +0000 Note that the palette is also passed in the QStyleOption and available per widget. Generally, there is no need to access the application's global palette. 1308404 3 mklapetek 2012-10-23 09:48:19 +0000 Btw. isn't there some signal saying "color scheme has changed"? I know I saw it somewhere, but can't find it now. 1308430 4 mklapetek 2012-10-23 12:18:37 +0000 Git commit d57901ab55947c1f3bae152c7d30bd6704b056b7 by Martin Klapetek. Committed on 23/10/2012 at 14:14. Pushed by mklapetek into branch 'master'. Use option's palette instead of storing app's palette in class var Reviewed-by: Rohan Garg REVIEW: 107008 Related: bug 308802 M +4 -6 abstract-contact-delegate.cpp M +0 -1 abstract-contact-delegate.h M +4 -4 contact-delegate-compact.cpp M +4 -4 contact-delegate.cpp http://commits.kde.org/telepathy-contact-list/d57901ab55947c1f3bae152c7d30bd6704b056b7