305875 2012-08-27 12:30:24 +0000 Decorations not visible 2012-08-27 20:58:07 +0000 1 1 4 Plasma kwin compositing git master Unlisted Binaries Linux RESOLVED FIXED VHI critical 4.10 1 hrvoje.senjan kwin-bugs-null cfeck winter http://commits.kde.org/kde-workspace/28cdb8338a574a745e5701092f7d99b2245ece34 0 oldest_to_newest 1292141 0 hrvoje.senjan 2012-08-27 12:30:24 +0000 After last git pull, there are no decorations visible. You can still drag windows by clicking on decos, as you can minimize, maximize, and close windows. *Also, after several kwn --replace(s), decos show up (!?), but it's slow as hell, and it drains the CPU terribly. At that point, if you kill compositing (Ctrl+Shift+F12), again, there's no decos. Reproducible: Always Steps to Reproduce: 1. Compile latest kde-workspace, git master 2. re-login Actual Results: No decos visible. Tried oxygen, aurorae, plastik(-qml), bespin Expected Results: Should see decorations. How it looks: http://i.imgur.com/C2uMn.png qdbus org.kde.kwin /KWin supportInformation: http://paste.kde.org/540170/ This behaviour is true with compositing turned on and off. Also, effects are muuuch slower (can't be sure this is related to this bug). *Output of kwin --replace: http://paste.kde.org/540176/ 1292144 1 mgraesslin 2012-08-27 12:40:22 +0000 I did quite some pushes yesterday. Please tell me which git commit you are using, if it is not the latest, please try the latest one. Please do a clean build (might be some issue related to that). I will have a look into it once I'm back home (three hours from now). 1292149 2 hrvoje.senjan 2012-08-27 12:52:49 +0000 No hurry :) It's a pull from today, so, latest. Full build-log: https://build.opensuse.org/package/rawlog?arch=x86_64&package=kdebase4-workspace&project=home%3Asumski%3AKDE%3AUnstable%3ASC&repository=home_sumski_KDE_QT_openSUSE_12.2_Update_standard 1292153 3 hrvoje.senjan 2012-08-27 13:06:10 +0000 Without compositing: http://i.imgur.com/ZUwEa.png http://i.imgur.com/4wYFm.png http://paste.kde.org/540194/ 1292185 4 winter 2012-08-27 14:37:14 +0000 for the record, happening for me too 1292199 5 mgraesslin 2012-08-27 15:31:39 +0000 bad, bad, bad. I just recompiled from master, restarted and have decorations... will investigate 1292200 6 mgraesslin 2012-08-27 15:49:45 +0000 important progress. I just caught an exception in the decoration rendering code. 1292201 7 mgraesslin 2012-08-27 15:53:29 +0000 this seems to be somewhat related to graphicssystem specific code. Running in graphicssystem native seems to not trigger the exception, but it looks quite broken using Aurorae seems also to be more secure. 1292203 8 mgraesslin 2012-08-27 16:06:45 +0000 found the bad commit, will now work on identifying the exact issue (had been running the code for days without issues) - most likely a wrong merge fix yesterday during rebase. 1292206 9 hrvoje.senjan 2012-08-27 16:18:53 +0000 During several kwin --replaces (experimenting with decos and graphicssystems) i managed to crash it: Application: KWin (kwin), signal: Segmentation fault Using host libthread_db library "/lib64/libthread_db.so.1". [Current thread is 1 (Thread 0x7fb1c4105780 (LWP 18428))] Thread 2 (Thread 0x7fb1aaf65700 (LWP 18430)): #0 0x00007fb1bf2428f4 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0 #1 0x00007fb1c082ebd7 in QTWTF::TCMalloc_PageHeap::scavengerThread (this=0x7fb1c0b3c640 <QTWTF::pageheap_memory>) at ../3rdparty/javascriptcore/JavaScriptCore/wtf/FastMalloc.cpp:2359 #2 0x00007fb1c082ec09 in QTWTF::TCMalloc_PageHeap::runScavengerThread (context=<optimized out>) at ../3rdparty/javascriptcore/JavaScriptCore/wtf/FastMalloc.cpp:1464 #3 0x00007fb1bf23ee0e in start_thread () from /lib64/libpthread.so.0 #4 0x00007fb1c393a2bd in clone () from /lib64/libc.so.6 Thread 1 (Thread 0x7fb1c4105780 (LWP 18428)): [KCrash Handler] #6 KWin::Compositor::setCompositeTimer (this=0x159d350) at /usr/src/debug/kde-workspace-git/kwin/composite.cpp:537 #7 0x00007fb1c3c51cc7 in KWin::Client::releaseWindow (this=0x1640b60, on_shutdown=true) at /usr/src/debug/kde-workspace-git/kwin/client.cpp:256 #8 0x00007fb1c3c41793 in KWin::Workspace::~Workspace (this=0x14d3560, __in_chrg=<optimized out>) at /usr/src/debug/kde-workspace-git/kwin/workspace.cpp:496 #9 0x00007fb1c3c41ea9 in KWin::Workspace::~Workspace (this=0x14d3560, __in_chrg=<optimized out>) at /usr/src/debug/kde-workspace-git/kwin/workspace.cpp:530 #10 0x00007fb1c3c5e967 in KWin::Application::lostSelection (this=0x7fff4f2a66d0) at /usr/src/debug/kde-workspace-git/kwin/main.cpp:354 #11 0x00007fb1bf5e59bf in QMetaObject::activate (sender=0x7fff4f2a66e8, m=<optimized out>, local_signal_index=<optimized out>, argv=0x0) at kernel/qobject.cpp:3556 #12 0x00007fb1c349a523 in KSelectionOwner::filterEvent (this=0x7fff4f2a66e8, ev_P=<optimized out>) at /usr/src/debug/kdelibs-git/kdeui/util/kmanagerselection.cpp:224 #13 0x00007fb1c3439ace in publicx11Event (e=<optimized out>, this=<optimized out>) at /usr/src/debug/kdelibs-git/kdeui/kernel/kapplication.cpp:918 #14 KApplication::x11EventFilter (this=0x159d350, _event=0x7fff4f2a6170) at /usr/src/debug/kdelibs-git/kdeui/kernel/kapplication.cpp:930 #15 0x00007fb1be7c880c in qt_x11EventFilter (ev=0x7fff4f2a6170) at kernel/qapplication_x11.cpp:435 #16 qt_x11EventFilter (ev=0x7fff4f2a6170) at kernel/qapplication_x11.cpp:423 #17 0x00007fb1be7d5dcb in QApplication::x11ProcessEvent (this=0x7fff4f2a66d0, event=0x7fff4f2a6170) at kernel/qapplication_x11.cpp:3348 #18 0x00007fb1be7fd509 in QEventDispatcherX11::processEvents (this=0x127ea70, flags=...) at kernel/qeventdispatcher_x11.cpp:132 #19 0x00007fb1bf5cde7f in QEventLoop::processEvents (this=this@entry=0x7fff4f2a63e0, flags=...) at kernel/qeventloop.cpp:149 #20 0x00007fb1bf5ce108 in QEventLoop::exec (this=0x7fff4f2a63e0, flags=...) at kernel/qeventloop.cpp:204 #21 0x00007fb1bf5d2da8 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1187 #22 0x00007fb1c3c5fab4 in kdemain (argc=4, argv=0x7fff4f2a6818) at /usr/src/debug/kde-workspace-git/kwin/main.cpp:545 #23 0x00007fb1c3877455 in __libc_start_main () from /lib64/libc.so.6 #24 0x0000000000400721 in _start () at ../sysdeps/x86_64/elf/start.S:113 1292208 10 thomas.luebking 2012-08-27 16:26:53 +0000 Got a better(?) crash: Application: KWin (kwin), signal: Segmentation fault Using host libthread_db library "/lib/libthread_db.so.1". [KCrash Handler] #6 0xb57ce695 in QRegion::operator+=(QRect const&) () from /lib/libQtGui.so.4 #7 0xb764fc27 in KWin::Compositor::addRepaint (this=0x9fab798, r=...) at /home/src/KDE4/kde-workspace/kwin/composite.cpp:430 #8 0xb75f0bb6 in KWin::Client::updateShape (this=0xa067e28) at /home/src/KDE4/kde-workspace/kwin/client.cpp:842 #9 0xb75ef73a in KWin::Client::setMask (this=this@entry=0xa067e28, reg=..., mode=mode@entry=0) at /home/src/KDE4/kde-workspace/kwin/client.cpp:921 #10 0xb75ef8e6 in KWin::Client::destroyDecoration (this=this@entry=0xa067e28) at /home/src/KDE4/kde-workspace/kwin/client.cpp:442 #11 0xb75f017a in KWin::Client::releaseWindow (this=0xa067e28, on_shutdown=true) at /home/src/KDE4/kde-workspace/kwin/client.cpp:270 #12 0xb75de0b4 in KWin::Workspace::~Workspace (this=0x9f6a190, __in_chrg=<optimized out>) at /home/src/KDE4/kde-workspace/kwin/workspace.cpp:496 #13 0xb75de812 in KWin::Workspace::~Workspace (this=0x9f6a190, __in_chrg=<optimized out>) at /home/src/KDE4/kde-workspace/kwin/workspace.cpp:530 #14 0xb75feae8 in KWin::Application::lostSelection (this=0xbfebcea8) at /home/src/KDE4/kde-workspace/kwin/main.cpp:354 #15 0xb6148e86 in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /lib/libQtCore.so.4 #16 0xb684a595 in KSelectionOwner::lostOwnership() () from /lib/libkdeui.so.5 #17 0xb684a71e in KSelectionOwner::filterEvent(_XEvent*) () from /lib/libkdeui.so.5 #18 0xb684af06 in ?? () from /lib/libkdeui.so.5 #19 0xb67d9c23 in KApplication::x11EventFilter(_XEvent*) () from /lib/libkdeui.so.5 #20 0xb75fd4c6 in x11EventFilter (e=0xbfebcb9c, this=0xbfebcea8) at /home/src/KDE4/kde-workspace/kwin/main.cpp:364 #21 KWin::Application::x11EventFilter (this=0xbfebcea8, e=0xbfebcb9c) at /home/src/KDE4/kde-workspace/kwin/main.cpp:360 #22 0xb56872e6 in ?? () from /lib/libQtGui.so.4 #23 0xb5696192 in QApplication::x11ProcessEvent(_XEvent*) () from /lib/libQtGui.so.4 #24 0xb56c0efd in ?? () from /lib/libQtGui.so.4 #25 0xb612f6ec in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/libQtCore.so.4 #26 0xb612f9e1 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/libQtCore.so.4 #27 0xb6134c7a in QCoreApplication::exec() () from /lib/libQtCore.so.4 #28 0xb560cde4 in QApplication::exec() () from /lib/libQtGui.so.4 #29 0xb75ffd49 in kdemain (argc=2, argv=0xbfebcf94) at /home/src/KDE4/kde-workspace/kwin/main.cpp:545 #30 0x0804873b in main (argc=2, argv=0xbfebcf94) at /home/src/KDE4/BUILD_stable/workspace/kwin/kwin_dummy.cpp:3 This is with xrender on the native graphicssystem. The behavior is somewhat unpredictable and "stunningly" running it in gdb, everything was fine 1292210 11 mgraesslin 2012-08-27 16:30:42 +0000 one issue I figured out so far is that I added a logic error in the Paintredirector. But it does not fix the issue. 1292213 12 thomas.luebking 2012-08-27 16:40:12 +0000 and a worse one: Application: KWin (kwin), signal: Aborted Using host libthread_db library "/lib/libthread_db.so.1". [Current thread is 1 (Thread 0xafa9f740 (LWP 32178))] Thread 3 (Thread 0xad1edb40 (LWP 32183)): #0 0xb7728424 in __kernel_vsyscall () #1 0xb5fb5ba3 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib/libpthread.so.0 #2 0xb602eb7d in QWaitCondition::wait(QMutex*, unsigned long) () from /lib/libQtCore.so.4 #3 0xb602148c in ?? () from /lib/libQtCore.so.4 #4 0xb602e690 in ?? () from /lib/libQtCore.so.4 #5 0xb54400e1 in ?? () from /lib/libGL.so.1 #6 0x5c8b0824 in ?? () #7 0xbab80424 in ?? () #8 0x65000000 in ?? () #9 0x001015ff in ?? () #10 0xd3890000 in ?? () #11 0xfff0013d in ?? () #12 0xc30173ff in ?? () #13 0x0f4c72e8 in ?? () #14 0xafc18100 in ?? () from /lib/libvorbisenc.so.2 Backtrace stopped: previous frame inner to this frame (corrupt stack?) Thread 2 (Thread 0xabc24b40 (LWP 32192)): #0 0xb7728424 in __kernel_vsyscall () #1 0xb5fb5ba3 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib/libpthread.so.0 #2 0xb602eb7d in QWaitCondition::wait(QMutex*, unsigned long) () from /lib/libQtCore.so.4 #3 0xb602148c in ?? () from /lib/libQtCore.so.4 #4 0xb602e690 in ?? () from /lib/libQtCore.so.4 #5 0xb54400e1 in ?? () from /lib/libGL.so.1 #6 0x5c8b0824 in ?? () #7 0xbab80424 in ?? () #8 0x65000000 in ?? () #9 0x001015ff in ?? () #10 0xd3890000 in ?? () #11 0xfff0013d in ?? () #12 0xc30173ff in ?? () #13 0x0f4c72e8 in ?? () #14 0xafc18100 in ?? () from /lib/libvorbisenc.so.2 Backtrace stopped: previous frame inner to this frame (corrupt stack?) Thread 1 (Thread 0xafa9f740 (LWP 32178)): [KCrash Handler] #6 0xb7728424 in __kernel_vsyscall () #7 0xb50ef5df in raise () from /lib/libc.so.6 #8 0xb50f0ec3 in abort () from /lib/libc.so.6 #9 0xb531064d in __gnu_cxx::__verbose_terminate_handler() () from /lib/libstdc++.so.6 #10 0xb530e2a3 in ?? () from /lib/libstdc++.so.6 #11 0xb530e2df in std::terminate() () from /lib/libstdc++.so.6 #12 0xb530e5d5 in __cxa_rethrow () from /lib/libstdc++.so.6 #13 0xb613ec67 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/libQtCore.so.4 #14 0xb6143c7a in QCoreApplication::exec() () from /lib/libQtCore.so.4 #15 0xb561bde4 in QApplication::exec() () from /lib/libQtGui.so.4 #16 0xb760ed59 in kdemain (argc=2, argv=0xbf8b2e04) at /home/src/KDE4/kde-workspace/kwin/main.cpp:545 #17 0x0804873b in main (argc=2, argv=0xbf8b2e04) at /home/src/KDE4/BUILD_stable/workspace/kwin/kwin_dummy.cpp:3 Heap/Stack corruption? 1292215 13 thomas.luebking 2012-08-27 16:42:17 +0000 the m_compositor field is not set and there're threads. It's also not nulled with the workspace - and there are threads. Checking. 1292216 14 thomas.luebking 2012-08-27 16:45:19 +0000 No, but a new backtrace: Application: KWin (kwin), signal: Segmentation fault Using host libthread_db library "/lib/libthread_db.so.1". [Current thread is 1 (Thread 0xafb05740 (LWP 2835))] Thread 3 (Thread 0xad23db40 (LWP 2841)): #0 0xb778e424 in __kernel_vsyscall () #1 0xb601bba3 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib/libpthread.so.0 #2 0xb6094b7d in QWaitCondition::wait(QMutex*, unsigned long) () from /lib/libQtCore.so.4 #3 0xb608748c in ?? () from /lib/libQtCore.so.4 #4 0xb6094690 in ?? () from /lib/libQtCore.so.4 #5 0xb54a60e1 in ?? () from /lib/libGL.so.1 #6 0x5c8b0824 in ?? () #7 0xbab80424 in ?? () #8 0x65000000 in ?? () #9 0x001015ff in ?? () #10 0xd3890000 in ?? () #11 0xfff0013d in ?? () #12 0xc30173ff in ?? () #13 0x0f4c72e8 in ?? () #14 0xafc18100 in ?? () from /lib/libvorbisenc.so.2 Backtrace stopped: previous frame inner to this frame (corrupt stack?) Thread 2 (Thread 0xabd24b40 (LWP 2849)): #0 0xb778e424 in __kernel_vsyscall () #1 0xb601bba3 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /lib/libpthread.so.0 #2 0xb6094b7d in QWaitCondition::wait(QMutex*, unsigned long) () from /lib/libQtCore.so.4 #3 0xb608748c in ?? () from /lib/libQtCore.so.4 #4 0xb6094690 in ?? () from /lib/libQtCore.so.4 #5 0xb54a60e1 in ?? () from /lib/libGL.so.1 #6 0x5c8b0824 in ?? () #7 0xbab80424 in ?? () #8 0x65000000 in ?? () #9 0x001015ff in ?? () #10 0xd3890000 in ?? () #11 0xfff0013d in ?? () #12 0xc30173ff in ?? () #13 0x0f4c72e8 in ?? () #14 0xafc18100 in ?? () from /lib/libvorbisenc.so.2 Backtrace stopped: previous frame inner to this frame (corrupt stack?) Thread 1 (Thread 0xafb05740 (LWP 2835)): [KCrash Handler] #6 0xb76dc752 in KWin::SceneOpenGL::Texture::load (this=this@entry=0xa24ff80, pix=@0xbfde1d68: 77597737, size=..., depth=depth@entry=163930696, region=...) at /home/src/KDE4/kde-workspace/kwin/scene_opengl_glx.cpp:708 #7 0xb76da15a in load (depth=163930696, size=..., pix=@0xbfde1d68: 77597737, this=0xa24ff80) at /home/src/KDE4/kde-workspace/kwin/scene_opengl.cpp:317 #8 KWin::SceneOpenGL::Texture::load (this=this@entry=0xa24ff80, pix=@0xbfde1d68: 77597737, size=..., depth=163930696) at /home/src/KDE4/kde-workspace/kwin/scene_opengl.cpp:311 #9 0xb76da20c in KWin::SceneOpenGL::Texture::load (this=0xa24ff80, pixmap=..., target=3553) at /home/src/KDE4/kde-workspace/kwin/scene_opengl.cpp:338 #10 0xb76e1fa4 in KWin::SceneOpenGL::Window::paintDecoration (this=this@entry=0xa24ff48, decoration=decoration@entry=0xa0bc7e8, decorationType=decorationType@entry=KWin::SceneOpenGL::Window::DecorationRight, region=..., rect=..., data=..., quads=..., updateDeco=updateDeco@entry=true, hardwareClipping=hardwareClipping@entry=false) at /home/src/KDE4/kde-workspace/kwin/scene_opengl.cpp:629 #11 0xb76e5567 in KWin::SceneOpenGL::Window::performPaint (this=0xa24ff48, mask=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/scene_opengl.cpp:570 #12 0xb76cde65 in KWin::Scene::finalDrawWindow (this=0xa04ff50, w=0xa2475e8, mask=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/scene.cpp:448 #13 0xb76f16d3 in KWin::EffectsHandlerImpl::drawWindow (this=0xa2306f0, w=w@entry=0xa2475e8, mask=mask@entry=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/effects.cpp:311 #14 0xb6ab10c2 in KWin::Effect::drawWindow (this=0xa46c2a0, w=0xa2475e8, mask=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/libkwineffects/kwineffects.cpp:516 #15 0xb76f1673 in KWin::EffectsHandlerImpl::drawWindow (this=0xa2306f0, w=w@entry=0xa2475e8, mask=mask@entry=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/effects.cpp:308 #16 0xb76cdc32 in KWin::Scene::finalPaintWindow (this=0xa04ff50, w=0xa2475e8, mask=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/scene.cpp:433 #17 0xb76f1ae3 in KWin::EffectsHandlerImpl::paintWindow (this=0xa2306f0, w=w@entry=0xa2475e8, mask=mask@entry=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/effects.cpp:274 #18 0xb6ab11e2 in KWin::Effect::paintWindow (this=0xa46c2a0, w=0xa2475e8, mask=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/libkwineffects/kwineffects.cpp:491 #19 0xb76f1a83 in KWin::EffectsHandlerImpl::paintWindow (this=0xa2306f0, w=0xa2475e8, mask=mask@entry=9, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/effects.cpp:271 #20 0xb76d0f40 in KWin::Scene::paintWindow (this=this@entry=0xa04ff50, w=0xa24ff48, mask=9, region=..., quads=...) at /home/src/KDE4/kde-workspace/kwin/scene.cpp:347 #21 0xb76d0136 in KWin::Scene::paintSimpleScreen (this=this@entry=0xa04ff50, orig_mask=orig_mask@entry=8, region=...) at /home/src/KDE4/kde-workspace/kwin/scene.cpp:333 #22 0xb76cdb73 in KWin::Scene::finalPaintScreen (this=0xa04ff50, mask=8, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/scene.cpp:191 #23 0xb76f1813 in KWin::EffectsHandlerImpl::paintScreen (this=0xa2306f0, mask=8, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/effects.cpp:247 #24 0xa8257421 in ?? () from /usr/lib/kde4/kwin4_effect_beclock.so #25 0xb76f17bb in KWin::EffectsHandlerImpl::paintScreen (this=0xa2306f0, mask=8, region=..., data=...) at /home/src/KDE4/kde-workspace/kwin/effects.cpp:244 #26 0xb76cf3fe in KWin::Scene::paintScreen (this=0xa04ff50, mask=0xbfde28fc, region=0xbfde2968) at /home/src/KDE4/kde-workspace/kwin/scene.cpp:145 #27 0xb76e6ace in KWin::SceneOpenGL::paint (this=0xa04ff50, damage=..., toplevels=...) at /home/src/KDE4/kde-workspace/kwin/scene_opengl_glx.cpp:481 #28 0xb76c74d8 in KWin::Compositor::performCompositing (this=0x9f59570) at /home/src/KDE4/kde-workspace/kwin/composite.cpp:502 #29 0xb61bbce4 in QObject::event(QEvent*) () from /lib/libQtCore.so.4 #30 0xb5683f5c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /lib/libQtGui.so.4 #31 0xb568895f in QApplication::notify(QObject*, QEvent*) () from /lib/libQtGui.so.4 #32 0xb684bc61 in KApplication::notify(QObject*, QEvent*) () from /lib/libkdeui.so.5 #33 0xb767248f in notify (e=0xbfde2e60, o=0x9f59570, this=0xbfde3228) at /home/src/KDE4/kde-workspace/kwin/main.cpp:371 #34 KWin::Application::notify (this=0xbfde3228, o=0x9f59570, e=0xbfde2e60) at /home/src/KDE4/kde-workspace/kwin/main.cpp:367 #35 0xb61a5c0e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /lib/libQtCore.so.4 #36 0xb61da320 in ?? () from /lib/libQtCore.so.4 #37 0xb61da518 in QEventDispatcherUNIX::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/libQtCore.so.4 #38 0xb5735f73 in ?? () from /lib/libQtGui.so.4 #39 0xb61a46ec in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/libQtCore.so.4 #40 0xb61a49e1 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/libQtCore.so.4 #41 0xb61a9c7a in QCoreApplication::exec() () from /lib/libQtCore.so.4 #42 0xb5681de4 in QApplication::exec() () from /lib/libQtGui.so.4 #43 0xb7674d69 in kdemain (argc=3, argv=0xbfde3314) at /home/src/KDE4/kde-workspace/kwin/main.cpp:545 #44 0x0804873b in main (argc=3, argv=0xbfde3314) at /home/src/KDE4/BUILD_stable/workspace/kwin/kwin_dummy.cpp:3 1292218 15 thomas.luebking 2012-08-27 16:48:03 +0000 Which is the evil one? 1292219 16 mgraesslin 2012-08-27 16:50:55 +0000 f************************ck can confirm that nulling the m_compositor fixes the issue. Though (threads aside) I don't understand it as the compositor is still created before the window manager is started. 1292220 17 thomas.luebking 2012-08-27 16:52:56 +0000 Not entirely - not here. I still get crashrestarts all over the place and no sane titlebar. (i wish it was that easy and the stupid painRedirector [sic!] took the rest) 1292222 18 mgraesslin 2012-08-27 16:53:28 +0000 with graphicssystem native I still do not have decorations... 1292225 19 thomas.luebking 2012-08-27 16:55:22 +0000 No, wait! Crashes *are* gone. There was a zombie kwin process and after killing that the nulled one does no longer crash. Sorry. Now get me back my titlebar! Now! ;-) 1292227 20 mgraesslin 2012-08-27 16:59:52 +0000 I have it back when using Aurorae 1292228 21 73509 mgraesslin 2012-08-27 17:01:31 +0000 Created attachment 73509 Current patch to fix the crashes This should fix: * uninitialized access to m_compositor * unintialized access in dtor * logic error in paint redirector 1292230 22 thomas.luebking 2012-08-27 17:10:17 +0000 right now, i'm back at the rethrows with the painRedirector patch and compositing enabled. compositing disabled now works reliably (surprise) 1292232 23 73510 mgraesslin 2012-08-27 17:16:28 +0000 Created attachment 73510 Better fix I'm now going to hide in my cave and will not leave it for at least a week 1292233 24 73511 mgraesslin 2012-08-27 17:19:17 +0000 Created attachment 73511 Even better fix removed not needed (added) include 1292235 25 mgraesslin 2012-08-27 17:21:01 +0000 this looks good now. I have decorations and no crashes with: * kwin + raster * kwin + native * kwin_gles + raster * kwin_gles + native * xrender 1292238 26 mgraesslin 2012-08-27 17:32:35 +0000 if I get confirmation that it works, I'm going to push it :-) 1292240 27 hrvoje.senjan 2012-08-27 17:43:10 +0000 With fix in attachment 73511 i no longer have kwin-transparent! :-D Yes, it works, with(out) compositing, tested with aurorae, plastik (-qml), and plain oxygen ;-) 1292241 28 mgraesslin 2012-08-27 17:47:26 +0000 Git commit 28cdb8338a574a745e5701092f7d99b2245ece34 by Martin Gräßlin. Committed on 27/08/2012 at 19:45. Pushed by graesslin into branch 'master'. Fix uninitialized memory and logic error in PaintRedirector The refactoring of Compositor starting with b1739c3 caused some regressions due to variables in Workspace and Compositor not being initialized. Furthermore there was a boolean logic error in PaintRedirector causing the decorations not to paint. M +7 -0 kwin/composite.cpp M +1 -1 kwin/paintredirector.cpp M +2 -0 kwin/workspace.cpp http://commits.kde.org/kde-workspace/28cdb8338a574a745e5701092f7d99b2245ece34 1292242 29 mgraesslin 2012-08-27 17:49:56 +0000 thanks a lot for the help and sorry for the inconvenience - that should never happen that KWin is broken. Still don't understand why I have not seen this issue. Well to be true I had no window decorations once this weekend but worked on another refactoring branch building up on this one and thought it's there (which would not have been surprising as it slightly changed the deco painting). 1292244 30 thomas.luebking 2012-08-27 17:51:12 +0000 I still got crashes (w/o stacktrace) when starting kwin w/ compositing enabled. Now trying updated master and relogin. 1292248 31 hrvoje.senjan 2012-08-27 17:56:03 +0000 (In reply to comment #29) > thanks a lot for the help and sorry for the inconvenience - that should > never happen that KWin is broken. That's alright, you fixed it ASAP, so no big deal 2 further notes: a) clicking on menu button in decoration does not work (i can live with that) with Aurorae (did it worked before?) b) effects still seem a little less smoother then before (In reply to comment #30) > I still got crashes (w/o stacktrace) when starting kwin w/ compositing Same here, but only with bespin deco: kwin --replace Object::connect: No such signal OrgKdeActivityManagerActivitiesInterface::presenceChanged(bool) kwin(1150) KWin::Extensions::init: Extensions: shape: 0x "11" composite: 0x "4" render: 0x "b" fixes: 0x "50" non_native_pixmaps: true kwin(1150) KDecorationPlugins::canLoad: kwin : path "/usr/lib64/kde4/kwin3_bespin.so" for "kwin3_bespin" kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 4294967295 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 41943596 ;WMCLASS: "plasma" : "plasma" ;Caption: "plasma-desktop" ' : 18446744073709551615 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 4294967295 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 41943605 ;WMCLASS: "plasma" : "plasma" ;Caption: "plasma-desktop" ' : 18446744073709551615 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 4294967295 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 41943614 ;WMCLASS: "plasma" : "plasma" ;Caption: "plasma-desktop" ' : 18446744073709551615 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 11563972 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 41943623 ;WMCLASS: "plasma" : "plasma" ;Caption: "plasma-desktop" ' : 11563972 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::checkActivities: no activities!?!? kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 4294967295 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 60817430 ;WMCLASS: "dolphin" : "dolphin" ;Caption: "hrvoje – Dolphin" ' : 18446744073709551615 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 16869245 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 39846082 ;WMCLASS: "firefox" : "navigator" ;Caption: "Bug 305875 – Decorations not visible - Mozilla Firefox" ' : 16869245 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::checkActivities: no activities!?!? kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 16879931 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 37748757 ;WMCLASS: "systemsettings" : "systemsettings" ;Caption: "Window Decorations – System Settings" ' : 16879931 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 16892808 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 27263203 ;WMCLASS: "konsole" : "konsole" ;Caption: "~ : bash – Konsole" ' : 16892808 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 16895568 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 41943587 ;WMCLASS: "plasma" : "plasma" ;Caption: "plasma-desktop" ' : 16895568 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, ASN: 16899690 kwin(1150) KWin::Client::readUserTimeMapTimestamp: User timestamp, final: 'ID: 27263446 ;WMCLASS: "konsole" : "konsole" ;Caption: "~ : bash – Konsole <2>" ' : 16899690 kwin(1150) KWin::Workspace::allowClientActivation: Activation: No client active, allowing kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::Workspace::updateClientArea: screens: 1 desktops: 4 kwin(1150) KWin::Workspace::updateClientArea: Done. kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadAtom [5], request: X_GetSelectionOwner[23]" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadAtom [5], request: X_GetSelectionOwner[23]" ) kwin(1150)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open ksycoca from "/var/tmp/kdecache-hrvoje/ksycoca4" kwin(1150)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open ksycoca from "/var/tmp/kdecache-hrvoje/ksycoca4" kwin(1150) KActivities::ConsumerPrivateCommon::currentActivityCallFinished: "3ca93cd2-717b-481c-9c8c-e93446975b69" kwin(1150) KActivities::ConsumerPrivateCommon::listActivitiesCallFinished: ("155b6243-1db0-4f79-a186-c7e16406419b", "e6d3f1d9-ad6d-4bd4-ac1f-25c9f68ca4ea", "44fdbbe1-c91b-4658-af34-8d3a1476243a", "1ac5715a-c3c2-448b-b75c-009f6a5abdfd", "2389ed7e-cd47-40a5-905f-09258f0f0931", "3ca93cd2-717b-481c-9c8c-e93446975b69", "526e748e-a960-4e31-89f3-94c1be843c95") kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: RenderBadPicture [RENDER+1], request: RenderComposite[RENDER+8], resource: 0x60000b8" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: RenderBadPicture [RENDER+1], request: RenderComposite[RENDER+8], resource: 0x60000b8" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: RenderBadPicture [RENDER+1], request: RenderComposite[RENDER+8], resource: 0x60000cf" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: RenderBadPicture [RENDER+1], request: RenderComposite[RENDER+8], resource: 0x60000cf" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: RenderBadPicture [RENDER+1], request: RenderComposite[RENDER+8], resource: 0x60000cf" ) kwin(1150) KWin::Workspace::slotReconfigure: Workspace::slotReconfigure() kwin(1150) KWin::Compositor::slotCompositingOptionsInitialized: Initializing OpenGL compositing kwin(1150) KWin::SceneOpenGL::initBufferConfigs: Drawable visual (depth 24 ): 0x "72" kwin(1150) KWin::SceneOpenGL::initBufferConfigs: Drawable visual (depth 32 ): 0x "a5" kwin(1150) KWin::SceneOpenGL::initBuffer: Buffer visual (depth 24 ): 0x "71" OpenGL vendor string: ATI Technologies Inc. OpenGL renderer string: ATI Mobility Radeon HD 3650 OpenGL version string: 2.1 (3.3.11653 Compatibility Profile Context) Driver: Catalyst Driver version: 2.1 GPU class: R600 OpenGL version: 2.1 X server version: 1.12.3 Linux kernel version: 3.4.9 Direct rendering: no Requires strict binding: yes GLSL shaders: no Texture NPOT support: yes NO VSYNC! glXGetVideoSync, glXSwapInterval, glXIsDirect false true 0 kwin(1150) KWin::SceneOpenGL::SceneOpenGL: DB: true , Direct: false kwin(1150) KWin::currentRefreshRate: Vertical Refresh rate 60 Hz kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadDrawable [9], request: X_GetGeometry[14], resource: 0x600003d" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadDrawable [9], request: RenderCreatePicture[RENDER+4], resource: 0x600003d" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: RenderBadPicture [RENDER+1], request: RenderFreePicture[RENDER+7], resource: 0x600003d" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadDrawable [9], request: X_GetGeometry[14], resource: 0x600003d" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadDrawable [9], request: RenderCreatePicture[RENDER+4], resource: 0x600003d" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: RenderBadPicture [RENDER+1], request: RenderFreePicture[RENDER+7], resource: 0x600003d" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadDrawable [9], request: X_GetGeometry[14], resource: 0x600003d" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadDrawable [9], request: RenderCreatePicture[RENDER+4], resource: 0x600003d" ) kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: RenderBadPicture [RENDER+1], request: RenderFreePicture[RENDER+7], resource: 0x600003d" ) kwin(1150): Shaders are not supported kwin(1150) KWin::ShaderManager::initShaders: Orho Shader is not valid kwin(1150)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open ksycoca from "/var/tmp/kdecache-hrvoje/ksycoca4" kwin(1150) KWin::x11ErrorHandler: kwin: X Error ( "error: BadAtom [5], request: X_GetSelectionOwner[23]" ) kwin: Fatal IO error: client killed QThreadStorage: Thread 0x25e1e40 exited after QThreadStorage 27 destroyed QThreadStorage: Thread 0x25e1e40 exited after QThreadStorage 26 destroyed QThreadStorage: Thread 0x25e1e40 exited after QThreadStorage 25 destroyed QThreadStorage: Thread 0x2289ad0 exited after QThreadStorage 27 destroyed QThreadStorage: Thread 0x2289ad0 exited after QThreadStorage 26 destroyed QThreadStorage: Thread 0x2289ad0 exited after QThreadStorage 25 destroyed 1292250 32 mgraesslin 2012-08-27 17:58:59 +0000 (In reply to comment #30) > I still got crashes (w/o stacktrace) when starting kwin w/ compositing > enabled. > Now trying updated master and relogin. I just started with KWIN_COMPOSE=N without any problems. > a) clicking on menu button in decoration does not work (i can live with > that) with Aurorae (did it worked before?) should not have changed, you have to long click or disable close on double click (this option is new since yesterday) > b) effects still seem a little less smoother then before there actually should not be any difference - at least I have not noticed anything yet :-) 1292255 33 hrvoje.senjan 2012-08-27 18:07:39 +0000 > should not have changed, you have to long click or disable close on double > click (this option is new since yesterday) Yup, works > there actually should not be any difference - at least I have not noticed > anything yet :-) I'll leave it at this, for now :-) 1292264 34 thomas.luebking 2012-08-27 18:37:13 +0000 After login first things worked. I altered backend and graphicssystem and when trying to move from XRender/Raster to XRender/Native (where i had been before) i got crash on any further attempt to start kwin. Then ran it through valgrind[1] and afterwards restarted (still XRender/Native) w/o problem. I'll check for Bespin (it uses native XRender Pictures and also tries to read from the paintredirector buffer) > I just started with KWIN_COMPOSE=N without any problems. WithOUT compositing has no longer been a problem once the painRedirector and m_compositor init were fixed. Trouble was (re)starting WITH compositing (and activating compositing after was fine as well -> threads ;-) Btw: > I'm now going to hide in my cave and will not leave it for at least a week Nix da, there's still a bunch of pending RRs for next Thursday :-P Resetting to fixed for the moment (who reopened it), but i've got an eye on you ;-) 1292265 35 thomas.luebking 2012-08-27 18:39:43 +0000 Forgot valgrind snippet: ==306== Conditional jump or move depends on uninitialised value(s) ==306== at 0x59CFCA8: QPixmap::fill(QColor const&) (in /usr/lib/libQtGui.so.4.8.2) ==306== by 0x40985E8: KWin::Client::resizeDecorationPixmaps() [clone .part.49] (client.cpp:696) ==306== by 0x409948F: KWin::Client::resizeDecoration(QSize const&) (client.cpp:785) ==306== by 0x40E9653: KWin::Client::setGeometry(int, int, int, int, KWin::ForceGeometry_t) (geometry.cpp:1886) ==306== by 0x40EB6BD: KWin::Client::blockGeometryUpdates(bool) (client.h:1208) ==306== by 0x40A18B1: KWin::Client::updateDecoration(bool, bool) (client.cpp:428) ==306== by 0x410215A: KWin::Client::finishCompositing() (composite.cpp:1083) ==306== ==306== Syscall param writev(vector[...]) points to uninitialised byte(s) ==306== at 0x65D506B: writev (in /usr/lib/libc-2.16.so) ==306== by 0x9513CC5: ??? (in /usr/lib/libxcb.so.1.1.0) ==306== by 0xFFFFFFFE: ??? ==306== Address 0xc6d9d14 is 52 bytes inside a block of size 16,384 alloc'd ==306== at 0x402953B: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==306== by 0x48B5D06: XOpenDisplay (in /usr/lib/libX11.so.6.3.0) ==306== by 0x4C505F53: ??? ==306== ==306== Syscall param writev(vector[...]) points to uninitialised byte(s) ==306== at 0x65D506B: writev (in /usr/lib/libc-2.16.so) ==306== by 0x9513CC5: ??? (in /usr/lib/libxcb.so.1.1.0) ==306== by 0x5931583: QWidget::isActiveWindow() const (in /usr/lib/libQtGui.so.4.8.2) ==306== by 0x48C6467: _XSend (in /usr/lib/libX11.so.6.3.0) ==306== by 0x48C6A69: _XReply (in /usr/lib/libX11.so.6.3.0) ==306== by 0x48ABFB9: XGetWindowProperty (in /usr/lib/libX11.so.6.3.0) ==306== by 0x48AAC95: XGetWMHints (in /usr/lib/libX11.so.6.3.0) ==306== by 0x598B4A8: QWidgetPrivate::show_sys() (in /usr/lib/libQtGui.so.4.8.2) ==306== by 0x5945AFD: QWidgetPrivate::show_helper() (in /usr/lib/libQtGui.so.4.8.2) ==306== Address 0xc6d9d16 is 54 bytes inside a block of size 16,384 alloc'd ==306== at 0x402953B: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==306== by 0x48B5D06: XOpenDisplay (in /usr/lib/libX11.so.6.3.0) ==306== by 0x4C505F53: ??? ==306== ==306== Invalid read of size 4 ==306== at 0x4A2443D: XRenderFindDisplay (in /usr/lib/libXrender.so.1.3.0) ==306== by 0x4A22865: XRenderFreePicture (in /usr/lib/libXrender.so.1.3.0) ==306== by 0x4D1459B: KWin::XRenderPicture::~XRenderPicture() (kwinxrenderutils.h:97) ==306== by 0x65259A2: __cxa_finalize (in /usr/lib/libc-2.16.so) ==306== by 0x4CFF242: ??? (in /usr/lib/libkwineffects.so.1.0.0) ==306== by 0x400F74B: _dl_fini (in /usr/lib/ld-2.16.so) ==306== by 0x6525600: __run_exit_handlers (in /usr/lib/libc-2.16.so) ==306== by 0x652568C: exit (in /usr/lib/libc-2.16.so) ==306== by 0x650D60C: (below main) (in /usr/lib/libc-2.16.so) ==306== Address 0x88 is not stack'd, malloc'd or (recently) free'd 1292268 36 hrvoje.senjan 2012-08-27 18:44:49 +0000 > Resetting to fixed for the moment (who reopened it), but i've got an eye on > you ;-) It seems i mistakenly changed it to reopened :-(, sorry for that. 1292301 37 winter 2012-08-27 20:00:41 +0000 working fine now. Yeehhaaawwww! 1292312 38 cfeck 2012-08-27 20:52:07 +0000 As long as such breakage is not going into release branches, there is no need to hide in a cave. Keep rocking :) With the number of different backtraces here, is anyone of them reproducible _after_ the commit that fixed this bug? If yes, maybe report them separately. 1292314 39 mgraesslin 2012-08-27 20:58:07 +0000 (In reply to comment #38) > With the number of different backtraces here, is anyone of them reproducible > _after_ the commit that fixed this bug? If yes, maybe report them separately. I am quite sure that all of them are now fixed - I had each of those and had found to reliable reproduce them. But I agree if one is still reproducable it should better go into a new report. 73509 2012-08-27 17:01:31 +0000 2012-08-27 17:16:57 +0000 Current patch to fix the crashes sane-compositor.diff text/plain 1013 mgraesslin ZGlmZiAtLWdpdCBhL2t3aW4vcGFpbnRyZWRpcmVjdG9yLmNwcCBiL2t3aW4vcGFpbnRyZWRpcmVj dG9yLmNwcAppbmRleCA3YmM0YmFmLi41NWIyMGM0IDEwMDY0NAotLS0gYS9rd2luL3BhaW50cmVk aXJlY3Rvci5jcHAKKysrIGIva3dpbi9wYWludHJlZGlyZWN0b3IuY3BwCkBAIC04Miw3ICs4Miw3 IEBAIGJvb2wgUGFpbnRSZWRpcmVjdG9yOjpldmVudEZpbHRlcihRT2JqZWN0KiBvLCBRRXZlbnQq IGUpCiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIFFFdmVudDo6UGFpbnQ6IHsKLSAg ICAgICAgaWYgKFdvcmtzcGFjZTo6c2VsZigpLT5jb21wb3NpdGluZ0FjdGl2ZSgpKSB7CisgICAg ICAgIGlmICghV29ya3NwYWNlOjpzZWxmKCktPmNvbXBvc2l0aW5nQWN0aXZlKCkpIHsKICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQogICAgICAgICBpZiAoIXJlY3Vyc2lvbkNo ZWNrKSB7CmRpZmYgLS1naXQgYS9rd2luL3dvcmtzcGFjZS5jcHAgYi9rd2luL3dvcmtzcGFjZS5j cHAKaW5kZXggYzZhZmE5My4uZTAzZTVlNyAxMDA2NDQKLS0tIGEva3dpbi93b3Jrc3BhY2UuY3Bw CisrKyBiL2t3aW4vd29ya3NwYWNlLmNwcApAQCAtMTA1LDYgKzEwNSw3IEBAIFdvcmtzcGFjZTo6 V29ya3NwYWNlKGJvb2wgcmVzdG9yZSkKICNpZmRlZiBLV0lOX0JVSUxEX1NDUkVFTkVER0VTCiAg ICAgLCBtX3NjcmVlbkVkZ2VPcmllbnRhdGlvbigwKQogI2VuZGlmCisgICAgLCBtX2NvbXBvc2l0 b3IoTlVMTCkKICAgICAvLyBVbnNvcnRlZAogICAgICwgYWN0aXZlX3BvcHVwKE5VTEwpCiAgICAg LCBhY3RpdmVfcG9wdXBfY2xpZW50KE5VTEwpCkBAIC00ODIsNiArNDgzLDcgQEAgdm9pZCBXb3Jr c3BhY2U6OmluaXQoKQogV29ya3NwYWNlOjp+V29ya3NwYWNlKCkKIHsKICAgICBkZWxldGUgbV9j b21wb3NpdG9yOworICAgIG1fY29tcG9zaXRvciA9IE5VTEw7CiAgICAgYmxvY2tTdGFja2luZ1Vw ZGF0ZXModHJ1ZSk7CiAKICAgICAvLyBUT0RPOiBncmFiWFNlcnZlcigpOwo= 73510 2012-08-27 17:16:28 +0000 2012-08-27 17:19:17 +0000 Better fix sane-compositor.diff text/plain 1996 mgraesslin ZGlmZiAtLWdpdCBhL2t3aW4vY29tcG9zaXRlLmNwcCBiL2t3aW4vY29tcG9zaXRlLmNwcAppbmRl eCA0ODM3ZDhhLi42NDBlYmQ2IDEwMDY0NAotLS0gYS9rd2luL2NvbXBvc2l0ZS5jcHAKKysrIGIv a3dpbi9jb21wb3NpdGUuY3BwCkBAIC04Nyw3ICs4NywxNCBAQCBDb21wb3NpdG9yOjpDb21wb3Np dG9yKFFPYmplY3QqIHdvcmtzcGFjZSkKICAgICA6IFFPYmplY3Qod29ya3NwYWNlKQogICAgICwg bV9zdXNwZW5kZWQoIW9wdGlvbnMtPmlzVXNlQ29tcG9zaXRpbmcoKSkKICAgICAsIG1fYmxvY2tl ZChmYWxzZSkKKyAgICAsIGNtX3NlbGVjdGlvbihOVUxMKQorICAgICwgdkJsYW5rSW50ZXJ2YWwo MCkKKyAgICAsIGZwc0ludGVydmFsKDApCiAgICAgLCBtX3hyclJlZnJlc2hSYXRlKDApCisgICAg LCBmb3JjZVVucmVkaXJlY3RDaGVjayhmYWxzZSkKKyAgICAsIG1fZmluaXNoaW5nKGZhbHNlKQor ICAgICwgbV90aW1lU2luY2VMYXN0VkJsYW5rKDApCisgICAgLCBtX25leHRGcmFtZURlbGF5KDAp CiAgICAgLCBtX3NjZW5lKE5VTEwpCiB7CiAgICAgY29ubmVjdCgmdW5yZWRpcmVjdFRpbWVyLCBT SUdOQUwodGltZW91dCgpKSwgU0xPVChkZWxheWVkQ2hlY2tVbnJlZGlyZWN0KCkpKTsKZGlmZiAt LWdpdCBhL2t3aW4vY29tcG9zaXRlLmggYi9rd2luL2NvbXBvc2l0ZS5oCmluZGV4IGE0YTM3MTAu LmVkY2NmYzkgMTAwNjQ0Ci0tLSBhL2t3aW4vY29tcG9zaXRlLmgKKysrIGIva3dpbi9jb21wb3Np dGUuaApAQCAtMjIsNiArMjIsOCBAQCBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwg c2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KICNpZm5kZWYgS1dJTl9DT01QT1NJ VEVfSAogI2RlZmluZSBLV0lOX0NPTVBPU0lURV9ICiAKKyNpbmNsdWRlICJzY2VuZS5oIgorCiAj aW5jbHVkZSA8UXRDb3JlL1FPYmplY3Q+CiAjaW5jbHVkZSA8UXRDb3JlL1FUaW1lcj4KICNpbmNs dWRlIDxRUmVnaW9uPgpkaWZmIC0tZ2l0IGEva3dpbi9wYWludHJlZGlyZWN0b3IuY3BwIGIva3dp bi9wYWludHJlZGlyZWN0b3IuY3BwCmluZGV4IDdiYzRiYWYuLjU1YjIwYzQgMTAwNjQ0Ci0tLSBh L2t3aW4vcGFpbnRyZWRpcmVjdG9yLmNwcAorKysgYi9rd2luL3BhaW50cmVkaXJlY3Rvci5jcHAK QEAgLTgyLDcgKzgyLDcgQEAgYm9vbCBQYWludFJlZGlyZWN0b3I6OmV2ZW50RmlsdGVyKFFPYmpl Y3QqIG8sIFFFdmVudCogZSkKICAgICAgICAgYnJlYWs7CiAgICAgfQogICAgIGNhc2UgUUV2ZW50 OjpQYWludDogewotICAgICAgICBpZiAoV29ya3NwYWNlOjpzZWxmKCktPmNvbXBvc2l0aW5nQWN0 aXZlKCkpIHsKKyAgICAgICAgaWYgKCFXb3Jrc3BhY2U6OnNlbGYoKS0+Y29tcG9zaXRpbmdBY3Rp dmUoKSkgewogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAgICAgICAgIGlm ICghcmVjdXJzaW9uQ2hlY2spIHsKZGlmZiAtLWdpdCBhL2t3aW4vd29ya3NwYWNlLmNwcCBiL2t3 aW4vd29ya3NwYWNlLmNwcAppbmRleCBjNmFmYTkzLi5lMDNlNWU3IDEwMDY0NAotLS0gYS9rd2lu L3dvcmtzcGFjZS5jcHAKKysrIGIva3dpbi93b3Jrc3BhY2UuY3BwCkBAIC0xMDUsNiArMTA1LDcg QEAgV29ya3NwYWNlOjpXb3Jrc3BhY2UoYm9vbCByZXN0b3JlKQogI2lmZGVmIEtXSU5fQlVJTERf U0NSRUVORURHRVMKICAgICAsIG1fc2NyZWVuRWRnZU9yaWVudGF0aW9uKDApCiAjZW5kaWYKKyAg ICAsIG1fY29tcG9zaXRvcihOVUxMKQogICAgIC8vIFVuc29ydGVkCiAgICAgLCBhY3RpdmVfcG9w dXAoTlVMTCkKICAgICAsIGFjdGl2ZV9wb3B1cF9jbGllbnQoTlVMTCkKQEAgLTQ4Miw2ICs0ODMs NyBAQCB2b2lkIFdvcmtzcGFjZTo6aW5pdCgpCiBXb3Jrc3BhY2U6On5Xb3Jrc3BhY2UoKQogewog ICAgIGRlbGV0ZSBtX2NvbXBvc2l0b3I7CisgICAgbV9jb21wb3NpdG9yID0gTlVMTDsKICAgICBi bG9ja1N0YWNraW5nVXBkYXRlcyh0cnVlKTsKIAogICAgIC8vIFRPRE86IGdyYWJYU2VydmVyKCk7 Cg== 73511 2012-08-27 17:19:17 +0000 2012-08-27 17:19:17 +0000 Even better fix sane-compositor.diff text/plain 1634 mgraesslin ZGlmZiAtLWdpdCBhL2t3aW4vY29tcG9zaXRlLmNwcCBiL2t3aW4vY29tcG9zaXRlLmNwcAppbmRl eCA0ODM3ZDhhLi42NDBlYmQ2IDEwMDY0NAotLS0gYS9rd2luL2NvbXBvc2l0ZS5jcHAKKysrIGIv a3dpbi9jb21wb3NpdGUuY3BwCkBAIC04Nyw3ICs4NywxNCBAQCBDb21wb3NpdG9yOjpDb21wb3Np dG9yKFFPYmplY3QqIHdvcmtzcGFjZSkKICAgICA6IFFPYmplY3Qod29ya3NwYWNlKQogICAgICwg bV9zdXNwZW5kZWQoIW9wdGlvbnMtPmlzVXNlQ29tcG9zaXRpbmcoKSkKICAgICAsIG1fYmxvY2tl ZChmYWxzZSkKKyAgICAsIGNtX3NlbGVjdGlvbihOVUxMKQorICAgICwgdkJsYW5rSW50ZXJ2YWwo MCkKKyAgICAsIGZwc0ludGVydmFsKDApCiAgICAgLCBtX3hyclJlZnJlc2hSYXRlKDApCisgICAg LCBmb3JjZVVucmVkaXJlY3RDaGVjayhmYWxzZSkKKyAgICAsIG1fZmluaXNoaW5nKGZhbHNlKQor ICAgICwgbV90aW1lU2luY2VMYXN0VkJsYW5rKDApCisgICAgLCBtX25leHRGcmFtZURlbGF5KDAp CiAgICAgLCBtX3NjZW5lKE5VTEwpCiB7CiAgICAgY29ubmVjdCgmdW5yZWRpcmVjdFRpbWVyLCBT SUdOQUwodGltZW91dCgpKSwgU0xPVChkZWxheWVkQ2hlY2tVbnJlZGlyZWN0KCkpKTsKZGlmZiAt LWdpdCBhL2t3aW4vcGFpbnRyZWRpcmVjdG9yLmNwcCBiL2t3aW4vcGFpbnRyZWRpcmVjdG9yLmNw cAppbmRleCA3YmM0YmFmLi41NWIyMGM0IDEwMDY0NAotLS0gYS9rd2luL3BhaW50cmVkaXJlY3Rv ci5jcHAKKysrIGIva3dpbi9wYWludHJlZGlyZWN0b3IuY3BwCkBAIC04Miw3ICs4Miw3IEBAIGJv b2wgUGFpbnRSZWRpcmVjdG9yOjpldmVudEZpbHRlcihRT2JqZWN0KiBvLCBRRXZlbnQqIGUpCiAg ICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIFFFdmVudDo6UGFpbnQ6IHsKLSAgICAgICAg aWYgKFdvcmtzcGFjZTo6c2VsZigpLT5jb21wb3NpdGluZ0FjdGl2ZSgpKSB7CisgICAgICAgIGlm ICghV29ya3NwYWNlOjpzZWxmKCktPmNvbXBvc2l0aW5nQWN0aXZlKCkpIHsKICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICAgICAgfQogICAgICAgICBpZiAoIXJlY3Vyc2lvbkNoZWNrKSB7 CmRpZmYgLS1naXQgYS9rd2luL3dvcmtzcGFjZS5jcHAgYi9rd2luL3dvcmtzcGFjZS5jcHAKaW5k ZXggYzZhZmE5My4uZTAzZTVlNyAxMDA2NDQKLS0tIGEva3dpbi93b3Jrc3BhY2UuY3BwCisrKyBi L2t3aW4vd29ya3NwYWNlLmNwcApAQCAtMTA1LDYgKzEwNSw3IEBAIFdvcmtzcGFjZTo6V29ya3Nw YWNlKGJvb2wgcmVzdG9yZSkKICNpZmRlZiBLV0lOX0JVSUxEX1NDUkVFTkVER0VTCiAgICAgLCBt X3NjcmVlbkVkZ2VPcmllbnRhdGlvbigwKQogI2VuZGlmCisgICAgLCBtX2NvbXBvc2l0b3IoTlVM TCkKICAgICAvLyBVbnNvcnRlZAogICAgICwgYWN0aXZlX3BvcHVwKE5VTEwpCiAgICAgLCBhY3Rp dmVfcG9wdXBfY2xpZW50KE5VTEwpCkBAIC00ODIsNiArNDgzLDcgQEAgdm9pZCBXb3Jrc3BhY2U6 OmluaXQoKQogV29ya3NwYWNlOjp+V29ya3NwYWNlKCkKIHsKICAgICBkZWxldGUgbV9jb21wb3Np dG9yOworICAgIG1fY29tcG9zaXRvciA9IE5VTEw7CiAgICAgYmxvY2tTdGFja2luZ1VwZGF0ZXMo dHJ1ZSk7CiAKICAgICAvLyBUT0RPOiBncmFiWFNlcnZlcigpOwo=