302074 2012-06-17 16:52:41 +0000 [PATCH] Thumnailer keeps running after exiting gwenview 2012-10-19 13:26:26 +0000 1 1 2 Applications gwenview general Git (add output of "git log -1 --oneline" to description) Compiled Sources Linux RESOLVED FIXED NOR critical --- 0 benni gwenview-bugs-null http://commits.kde.org/gwenview/3dbd4e95c9494d4ae5ed51ebfbfa75efeceff97f 2.9.1 0 oldest_to_newest 1266456 0 benni 2012-06-17 16:52:41 +0000 Git Version: e4e135c Fix images not showing after viewing a video When thumbnailing a folder for which gwenview hasn't created thumbnails yet, the thumbnailer keeps running after exiting gwenview. This is at least an annoying behaviour since this blocks unmounting of flash drives, etc. I marked this as critical since it might be possible that the user won't notice that unmounting had failed and therefore he would remove his external device (-> data loss?). Reproducible: Always Steps to Reproduce: 1. Open a folder for which gwenview has not created thumbnails yet. 2. When gwenview starts to thumbnail the images, hit control+q or similar to exit it 3. main window disappears Actual Results: A gwenview process keeps running and thumbnailing all the images in the queue. Expected Results: Gwenview should have exited immediately. 1266458 1 71892 benni 2012-06-17 16:54:45 +0000 Created attachment 71892 stop-thumbnailer-when-exiting The patch deletes the ThumbnailLoadJob when ThumbnailView is deleted. 1270775 2 agateau 2012-06-28 16:20:35 +0000 Hi, I agree it is a problem, but your patch just caused an assert here: ASSERT: "qMetaTypeGuiHelper" in file /home/aurelien/kdesrc/qt/src/corelib/kernel/qmetatype.cpp, line 1384 libpng error: Write Error gwenview(7376) Gwenview::storeThumbnailToDiskCache: Could not save thumbnail QFile::at: Cannot set file position 0 KCrash: crashing... crashRecursionCounter = 2 KCrash: Application Name = gwenview path = /home/aurelien/opt/k4m/bin pid = 7376 I think we need a safer way to stop the job. I think clearing the item list in the job destructor would be a better fix. 1280373 3 72860 benni 2012-08-01 00:05:34 +0000 Created attachment 72860 wait for sThumbnailCache to finish Phew! I think ThumbnailLoadJob has to wait for sThumbnailCache to finish. I don't know why, but somehow the QImage that is to be stored to disk seems to disappear (sometimes). 1280781 4 agateau 2012-08-02 16:08:55 +0000 Git commit 3dbd4e95c9494d4ae5ed51ebfbfa75efeceff97f by Aurélien Gâteau, on behalf of Benni Hill. Committed on 02/08/2012 at 18:06. Pushed by gateau into branch 'KDE/4.9'. Stop thumbnailing when Gwenview exits. This is important as it blocks unmounting of flash drives. FIXED-IN: 2.9.1 M +1 -0 lib/thumbnailloadjob.cpp M +1 -0 lib/thumbnailview/thumbnailview.cpp http://commits.kde.org/gwenview/3dbd4e95c9494d4ae5ed51ebfbfa75efeceff97f 71892 2012-06-17 16:54:45 +0000 2012-08-01 00:05:34 +0000 stop-thumbnailer-when-exiting 0001-stop-thumbnailer-when-exiting.patch text/plain 679 benni RnJvbSBmNjVlYjMxOTJjZmU5MjdkZTMzNGYzNjJiM2ZiM2U2NzdjNzdiZGFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QmVuamFtaW49MjBMPUMzPUI2d2U/PSA8YmVu amFtaW4ubG9ld2VAZnJlZW5ldC5kZT4KRGF0ZTogU3VuLCAxNyBKdW4gMjAxMiAxODoyODowNCAr MDIwMApTdWJqZWN0OiBbUEFUQ0hdIHN0b3AgdGh1bWJuYWlsZXIgd2hlbiBleGl0aW5nCgotLS0K IGxpYi90aHVtYm5haWx2aWV3L3RodW1ibmFpbHZpZXcuY3BwIHwgICAgMSArCiAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9saWIvdGh1bWJuYWlsdmlldy90aHVt Ym5haWx2aWV3LmNwcCBiL2xpYi90aHVtYm5haWx2aWV3L3RodW1ibmFpbHZpZXcuY3BwCmluZGV4 IDExZTE4N2YuLmQwMGFjZjIgMTAwNjQ0Ci0tLSBhL2xpYi90aHVtYm5haWx2aWV3L3RodW1ibmFp bHZpZXcuY3BwCisrKyBiL2xpYi90aHVtYm5haWx2aWV3L3RodW1ibmFpbHZpZXcuY3BwCkBAIC0z ODcsNiArMzg3LDcgQEAgVGh1bWJuYWlsVmlldzo6VGh1bWJuYWlsVmlldyhRV2lkZ2V0KiBwYXJl bnQpCiAKIFRodW1ibmFpbFZpZXc6On5UaHVtYm5haWxWaWV3KCkKIHsKKyAgICBkZWxldGUgZC0+ bVRodW1ibmFpbExvYWRKb2I7CiAgICAgZGVsZXRlIGQ7CiB9CiAKLS0gCjEuNy45LjUKCg== 72860 2012-08-01 00:05:34 +0000 2012-08-01 00:05:34 +0000 wait for sThumbnailCache to finish stopThumbnailer.patch text/plain 750 benni ZGlmZiAtLWdpdCBhL2xpYi90aHVtYm5haWxsb2Fkam9iLmNwcCBiL2xpYi90aHVtYm5haWxsb2Fk am9iLmNwcAppbmRleCA4MjcyMmNkLi45YzlhMmVlIDEwMDY0NAotLS0gYS9saWIvdGh1bWJuYWls bG9hZGpvYi5jcHAKKysrIGIvbGliL3RodW1ibmFpbGxvYWRqb2IuY3BwCkBAIC00MjQsNiArNDI0 LDcgQEAgVGh1bWJuYWlsTG9hZEpvYjo6flRodW1ibmFpbExvYWRKb2IoKQogICAgIGlmICghc1Ro dW1ibmFpbENhY2hlLT5pc1J1bm5pbmcoKSkgewogICAgICAgICBzVGh1bWJuYWlsQ2FjaGUtPnN0 YXJ0KCk7CiAgICAgfQorICAgIHNUaHVtYm5haWxDYWNoZS0+d2FpdCgpOwogfQogCiB2b2lkIFRo dW1ibmFpbExvYWRKb2I6OnN0YXJ0KCkKZGlmZiAtLWdpdCBhL2xpYi90aHVtYm5haWx2aWV3L3Ro dW1ibmFpbHZpZXcuY3BwIGIvbGliL3RodW1ibmFpbHZpZXcvdGh1bWJuYWlsdmlldy5jcHAKaW5k ZXggNTI1YTQ3Zi4uOTM2NmJmZCAxMDA2NDQKLS0tIGEvbGliL3RodW1ibmFpbHZpZXcvdGh1bWJu YWlsdmlldy5jcHAKKysrIGIvbGliL3RodW1ibmFpbHZpZXcvdGh1bWJuYWlsdmlldy5jcHAKQEAg LTMyOSw2ICszMjksNyBAQCBUaHVtYm5haWxWaWV3OjpUaHVtYm5haWxWaWV3KFFXaWRnZXQqIHBh cmVudCkKIAogVGh1bWJuYWlsVmlldzo6flRodW1ibmFpbFZpZXcoKQogeworICAgIGlmKGQtPm1U aHVtYm5haWxMb2FkSm9iKSBkZWxldGUgZC0+bVRodW1ibmFpbExvYWRKb2I7CiAgICAgZGVsZXRl IGQ7CiB9CiAK