302070 2012-06-17 16:13:35 +0000 CSS text-align property broken for textarea elements 2012-06-18 05:55:21 +0000 1 1 2 Applications konqueror khtml forms 4.8.4 unspecified Linux RESOLVED FIXED NOR normal --- 1 aiacovitti konqueror-bugs-null http://commits.kde.org/kdelibs/31ce1f9365000d7c3a9c39770234aa09009a2599 0 oldest_to_newest 1266449 0 71890 aiacovitti 2012-06-17 16:13:35 +0000 Created attachment 71890 testcase (Attached a testcase) Actually khtml fails to deal with 'text-align' css property, this is particularly evident in pre-filled textarea elements with 'text-align:right' style (as in the testcase). Switching text-align via javascript fails too. (Also note in the tescase another uncommon behavior where pre-filled textarea elements are initially showed with all content scrolled down to the end) 1266587 1 aiacovitti 2012-06-18 05:55:21 +0000 Git commit 31ce1f9365000d7c3a9c39770234aa09009a2599 by Andrea Iacovitti. Committed on 18/06/2012 at 07:04. Pushed by aiacovitti into branch 'KDE/4.8'. Fix applying css text-align property on textarea widget: - set text alignment on all textarea's paragraphs, not only the current one (aka the one at the current cursor position). - do not set at every setStyle call but only when it has changed (doing the same for lineedit widget). Also fix annoying behavior where initial content of pre-filled textarea is showed up all scrolled down to end. M +44 -39 khtml/rendering/render_form.cpp M +3 -2 khtml/rendering/render_form.h http://commits.kde.org/kdelibs/31ce1f9365000d7c3a9c39770234aa09009a2599 71890 2012-06-17 16:13:35 +0000 2012-06-17 16:13:35 +0000 testcase tc02_textarea.html text/html 1861 aiacovitti PGh0bWw+DQo8aGVhZD4NCjx0aXRsZT50ZXN0IHRleHRhcmVhIHRleHQgYWxpZ25tZW50PC90aXRs ZT4NCjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4NCiAgIGZ1bmN0aW9uIHRvZ2dsZUFs aWduKCkgew0KICAgICAgIHZhciBhbCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YSIpLnN0 eWxlLnRleHRBbGlnbjsNCiAgICAgICBpZiAoYWwgPT0gInJpZ2h0Iikgew0KICAgICAgICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGEiKS5zdHlsZS50ZXh0QWxpZ24gPSAibGVmdCI7DQog ICAgICAgfQ0KICAgICAgIGVsc2UNCiAgICAgICB7DQogICAgICAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0YSIpLnN0eWxlLnRleHRBbGlnbiA9ICJyaWdodCI7DQogICAgICAgfQ0KICAg fQ0KICAgZnVuY3Rpb24gZGlzcGxheVNlbGVjdGVkVGV4dCgpIHsNCiAgICAgICB2YXIgdCA9ICh0 YS52YWx1ZSkuc3Vic3RyaW5nKHRhLnNlbGVjdGlvblN0YXJ0LCB0YS5zZWxlY3Rpb25FbmQpOw0K ICAgICAgIGFsZXJ0KCdTZWxlY3RlZCB0ZXh0OlxuJyArIHQpOw0KICAgfQ0KICAgZnVuY3Rpb24g ZmlsbFRleHRhcmVhKCkgew0KICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YSIpLnZh bHVlID0gImxpbmUxXG5saW5lMlxubGluZTNcbmxpbmU0XG5saW5lNVxubGluZTZcbmxpbmU3IjsN CiAgIH0NCiAgIGZ1bmN0aW9uIGNsZWFyVGV4dGFyZWEoKSB7DQogICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInRhIikudmFsdWUgPSAiIjsNCiAgIH0NCiAgIGZ1bmN0aW9uIHNlbGVjdEFs bCgpIHsNCiAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGEiKS5zZWxlY3QoKTsNCiAg IH0NCjwvc2NyaXB0Pg0KPC9oZWFkPg0KDQo8Ym9keSBvbkxvYWQ9ImZpbGxUZXh0YXJlYSgpOyI+ DQoNCjxwPg0KdGV4dGFyZWEgKHN0eWxlPSJ0ZXh0LWFsaWduOnJpZ2h0OyIpPGJyIC8+DQo8dGV4 dGFyZWEgcm93cz0iNCIgY29scz0iMTAiIHN0eWxlPSJ0ZXh0LWFsaWduOnJpZ2h0OyI+PC90ZXh0 YXJlYT4NCg0KPHA+DQp0ZXh0YXJlYSAoc3R5bGU9InRleHQtYWxpZ246cmlnaHQ7Iik8YnIgLz4N Cjx0ZXh0YXJlYSByb3dzPSI0IiBjb2xzPSIxMCIgc3R5bGU9InRleHQtYWxpZ246cmlnaHQ7Ij5s aW5lMQ0KbGluZTINCmxpbmUzDQpsaW5lNA0KbGluZTUNCmxpbmU2DQpsaW5lNzwvdGV4dGFyZWE+ DQo8cD4tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLTwvcD4NCjxwPg0KdGV4dGFyZWEgZmlsbGVkIG9uTG9hZCAoc3R5bGU9InRleHQtYWxpZ246 cmlnaHQ7Iik8YnIgLz4NCjx0ZXh0YXJlYSBpZD0idGEiIHJvd3M9IjQiIGNvbHM9IjEwIiBzdHls ZT0idGV4dC1hbGlnbjpyaWdodDsiPjwvdGV4dGFyZWE+DQoNCjxwPg0KPGlucHV0IHR5cGU9ImJ1 dHRvbiIgdmFsdWU9IlRvZ2dsZSBUZXh0QWxpZ24gUmlnaHQvTGVmdCIgb25DbGljaz0idG9nZ2xl QWxpZ24oKSIgLz48YnIgLz4NCi0tLS0tLTxiciAvPg0KPGlucHV0IHR5cGU9ImJ1dHRvbiIgdmFs dWU9IkRpc3BsYXkgU2VsZWN0ZWQgVGV4dCIgb25DbGljaz0iZGlzcGxheVNlbGVjdGVkVGV4dCgp IiAvPjxiciAvPg0KPGlucHV0IHR5cGU9ImJ1dHRvbiIgdmFsdWU9IkZpbGwgVGV4dGFyZWEiIG9u Q2xpY2s9ImZpbGxUZXh0YXJlYSgpIiAvPjxiciAvPg0KPGlucHV0IHR5cGU9ImJ1dHRvbiIgdmFs dWU9IkNsZWFyIFRleHRhcmVhIiBvbkNsaWNrPSJjbGVhclRleHRhcmVhKCkiIC8+PGJyIC8+DQo8 aW5wdXQgdHlwZT0iYnV0dG9uIiB2YWx1ZT0iU2VsZWN0IEFsbCBUZXh0IiBvbkNsaWNrPSJzZWxl Y3RBbGwoKSIgLz48YnIgLz4NCjwvYm9keT4NCjwvaHRtbD4NCg==