301103 2012-06-03 11:55:30 +0000 Allow direct rendering with fglrx 2012-08-23 01:39:05 +0000 1 1 4 Plasma kwin scene-opengl 4.7.3 Chakra Linux RESOLVED FIXED NOR wishlist 4.10 1 wengxt kwin-bugs-null jammy.zhou russianneuromancer http://commits.kde.org/kde-workspace/1efa6a9d41237339298e45f0c791ffe1269077f4 4.10 0 oldest_to_newest 1261810 0 wengxt 2012-06-03 11:55:30 +0000 AMD release a new driver catalyst 12.6/fglrx 8.98, which seems to be the first version can work with kwin direct rendering without problem. So maybe driver newer than this can be removed from black list. Phoronix news: http://www.phoronix.com/scan.php?page=news_item&px=MTExMTU So far no problem here. Reproducible: Always 1261816 1 mgraesslin 2012-06-03 12:02:05 +0000 Some comments: * It's not a blacklist, but a whitelist * I have info that not everything is working yet (e.g. Slideback seems broken) When we enable the driver in the whitelist there is no easy way for users to go back. Because of that I'm reluctant to change it. Everything *has* to work perfectly with direct rendering. 1282789 2 jammy.zhou 2012-08-08 07:06:47 +0000 Hi Martin, The slideback issue has been confirmed to be an issue of kwin, which happens for both NV and AMD (radeon and fglrx). And bug has been reported below. https://bugs.kde.org/show_bug.cgi?id=304479 So currently there is no direct rendering specific issue for fglrx now. Maybe we can consider the whitelisting at some proper point of KDE 4.10. 1284682 3 mgraesslin 2012-08-14 15:58:25 +0000 I'm fine with setting the latest Catalyst to direct rendering in current master, but we need someone to write that code. To my knowledge no KWin developer is using the Catalyst driver . 1285007 4 jammy.zhou 2012-08-15 10:48:59 +0000 The reference patch is attached. 1285008 5 73178 jammy.zhou 2012-08-15 10:49:56 +0000 Created attachment 73178 Whitelist Catalyst driver for kwin direct rendering 1285015 6 thomas.luebking 2012-08-15 11:23:08 +0000 Please use git.reviewboard.kde.org to get the patch reviewed (imo quite necessary) However: +bool getCatalystversion(char *version) +{ + const char *RV = "ReleaseVersion"; + char *RVbuf = NULL; + char buf[MAX_LINE_LEN]; + FILE *fp = fopen("/etc/ati/amdpcsdb.default","rb"); ... -> is there really no version to get that info out of glGetString(GL_VERSION) or similar? 1285235 7 jammy.zhou 2012-08-16 01:55:02 +0000 Sure, I will send review request to git.reviewboard.kde.org later. -> is there really no version to get that info out of glGetString(GL_VERSION) or similar? The release version cannot be got from GL_VERSION currently, and only /etc/ati/amdpcsdb.default can be leveraged on. 1285248 8 jammy.zhou 2012-08-16 03:11:31 +0000 The review request has been submitted. https://git.reviewboard.kde.org/r/106050/ 1290065 9 mgraesslin 2012-08-22 18:33:55 +0000 Git commit 1efa6a9d41237339298e45f0c791ffe1269077f4 by Martin Gräßlin, on behalf of Jammy Zhou. Committed on 22/08/2012 at 08:05. Pushed by graesslin into branch 'master'. Whitelist AMD Catalyst for kwin direct rendering FIXED-IN: 4.10 REVIEW: 106050 M +34 -0 kwin/opengltest/opengltest.cpp http://commits.kde.org/kde-workspace/1efa6a9d41237339298e45f0c791ffe1269077f4 1290192 10 jammy.zhou 2012-08-23 01:39:05 +0000 Thanks Martin for pushing the patch. ;-) 73178 2012-08-15 10:49:56 +0000 2012-08-15 10:49:56 +0000 Whitelist Catalyst driver for kwin direct rendering atiopengltest.diff text/plain 1890 jammy.zhou LS0tIG9wZW5nbHRlc3QuY3BwCTIwMTEtMDItMjYgMDU6NTQ6NTAuMDAwMDAwMDAwICswODAwDQor KysgYXRpX29wZW5nbC5jcHAJMjAxMi0wNS0wMyAxNToxMDoxMi43OTk5NDk0NjYgKzA4MDANCkBA IC0yMyw2ICsyNCwzNSBAQA0KICNpbmNsdWRlIDxzdHJpbmcuaD4NCiAjaW5jbHVkZSA8c3RkaW8u aD4NCiANCisjZGVmaW5lIE1BWF9MSU5FX0xFTiAgICAxMDI0DQorDQorYm9vbCBnZXRDYXRhbHlz dHZlcnNpb24oY2hhciAqdmVyc2lvbikNCit7DQorICAgIGNvbnN0IGNoYXIgKlJWID0gIlJlbGVh c2VWZXJzaW9uIjsNCisgICAgY2hhciAqUlZidWYgPSBOVUxMOw0KKyAgICBjaGFyIGJ1ZltNQVhf TElORV9MRU5dOw0KKyAgICBGSUxFICpmcCA9IGZvcGVuKCIvZXRjL2F0aS9hbWRwY3NkYi5kZWZh dWx0IiwicmIiKTsNCisgICAgaWYgKCFmcCkNCisgICAgew0KKyAgICAgICAgcmV0dXJuIGZhbHNl Ow0KKyAgICB9DQorICAgIHdoaWxlICghZmVvZihmcCkpDQorICAgIHsNCisgICAgICAgIGZnZXRz KGJ1ZiwgTUFYX0xJTkVfTEVOLCBmcCk7DQorICAgICAgICBSVmJ1ZiA9IHN0cnN0cihidWYsUlYp Ow0KKyAgICAgICAgaWYgKE5VTEwgIT0gUlZidWYpDQorICAgICAgICB7DQorICAgICAgICAgICAg c3NjYW5mKFJWYnVmLCAiJSpbXlNdUyVbXi1dIiwgdmVyc2lvbik7DQorICAgICAgICAgICAgZmNs b3NlKGZwKTsNCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsNCisgICAgICAgIH0NCisgICAgfQ0K KyAgICBmY2xvc2UoZnApOw0KKyAgICByZXR1cm4gZmFsc2U7DQorfQ0KKw0KIA0KIC8vIFJldHVy biAwIGlmIHdlIGNhbiB1c2UgYSBkaXJlY3QgY29udGV4dCwgMSBvdGhlcndpc2UNCiBpbnQgbWFp bihpbnQgYXJnYywgY2hhciAqYXJndltdKQ0KQEAgLTk3LDcgKzEyNywzMyBAQA0KICAgICBjb25z dCBHTHVieXRlICp2ZW5kb3IgPSBnbEdldFN0cmluZyhHTF9WRU5ET1IpOw0KICAgICBpZiAoc3Ry c3RyKChjb25zdCBjaGFyICopdmVuZG9yLCAiTlZJRElBIikpDQogICAgICAgICByZXR1cm4gMDsN Ci0NCisgICAgLy9DaGVjayBkaXJlY3QgcmVuZGVyaW5nIGZvciBBTUQvQVRJDQorICAgIGlmIChz dHJzdHIoKGNvbnN0IGNoYXIgKil2ZW5kb3IsICJBVEkiKSB8fCBzdHJzdHIoKGNvbnN0IGNoYXIg Kil2ZW5kb3IsICJBTUQiKSkNCisgICAgew0KKyAgICAgICAgY2hhciB2ZXJzaW9uWzEwXSA9IHsw fTsNCisgICAgICAgIGNoYXIgYnVmMVsyXSA9IHswfTsNCisgICAgICAgIGNoYXIgYnVmMlsyXSA9 IHswfTsNCisgICAgICAgIGNoYXIgYnVmM1syXSA9IHswfTsNCisgICAgICAgIGNoYXIgYnVmNFsy XSA9IHswfTsNCisgICAgICAgIGlmIChnZXRDYXRhbHlzdHZlcnNpb24odmVyc2lvbikpDQorICAg ICAgICB7DQorICAgICAgICAgICAgaW50IHJldD1zc2NhbmYodmVyc2lvbiwgIiUxcy4lMXMlMXMl MXMiLCBidWYxLCBidWYyLCBidWYzLCBidWY0KTsNCisgICAgICAgICAgICBpZiAoKHJldCA9PSAz KXx8KHJldD09NCAmJiBidWY0PT0iLiIpKQ0KKyAgICAgICAgICAgIHsNCisgICAgICAgICAgICAg ICAgaWYoc3RyY21wKHZlcnNpb24sIjguOTgiKT49MCkNCisgICAgICAgICAgICAgICAgew0KKyAg ICAgICAgICAgICAgICAgICByZXR1cm4gMCA7DQorICAgICAgICAgICAgICAgIH0NCisgICAgICAg ICAgICB9DQorICAgICAgICAgICAgZWxzZSBpZiAocmV0ID09IDQpDQorICAgICAgICAgICAgew0K KyAgICAgICAgICAgICAgICBpZihzdHJjbXAodmVyc2lvbiwiOC45NzMiKT49MCkNCisgICAgICAg ICAgICAgICAgew0KKyAgICAgICAgICAgICAgICAgICByZXR1cm4gMCA7DQorICAgICAgICAgICAg ICAgIH0NCisgICAgICAgICAgICB9DQorICAgICAgICB9DQorICAgIH0NCiAgICAgcmV0dXJuIDE7 DQogfQ0KLQ0K