300557 2012-05-24 11:22:11 +0000 When a collection is updated, Amarok expands collapsed entries in the Collection Browser 2016-10-17 08:33:52 +0000 1 1 2 Applications amarok Collection Browser 2.8.0 Compiled Sources Linux RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=335217 NOR normal --- 188074 1 keplicz amarok-bugs-null bart.cerneels e.m.a.t.i.r.o.v maddiemadan matej robert http://commits.kde.org/amarok/3b5c6b2039ad943ae209341b5920fee929da9320 2.9 0 oldest_to_newest 1258075 0 keplicz 2012-05-24 11:22:11 +0000 When I plug in an iPod (a 6G), Amarok starts counting the tracks. Now, when I fold the iPod's listing, it automatically unfolds a moment later, when the tracks count is updated. That disrupts browsing the tracks in other collections. Reproducible: Always Steps to Reproduce: 1. Plug in an iPod. 2. Fold the iPod listing while tracks are being counted. Actual Results: The iPod's listing is unfolded when the tracks count is updated. Expected Results: The listing should remain folded until the user unfolds it. 1258414 1 myriam 2012-05-25 20:24:04 +0000 Piotr could you please not forget to set the Amarok version in your reports.. I assume this is from git as well, right? 1258438 2 keplicz 2012-05-25 21:27:15 +0000 Yes, it's from an up-to-date git. 1260117 3 bart.cerneels 2012-05-29 14:51:40 +0000 This needs to be fixed in the view by keeping state of the opened sub-trees. It's non trivial and not possible to do for the next release. But I'll put it one the list of items needed for 2.7. 1272101 4 matej 2012-07-03 13:49:43 +0000 See also bug 188074 that complements this bug. 1319940 5 maddiemadan 2012-12-01 08:00:22 +0000 Reproducible in v2.6.0-421-gf66a306 1320017 6 matej 2012-12-01 12:53:22 +0000 This is not specific to iPods and is a visual bug, nothing to do with iPod Collection. iPod collection is just one way to trigger this, other is UMS Collection, local collection... 1370621 7 matej 2013-05-23 13:47:33 +0000 *** Bug 319508 has been marked as a duplicate of this bug. *** 1415509 8 e.m.a.t.i.r.o.v 2013-12-01 12:06:00 +0000 Reproducible in v2.8.0 1447930 9 matej 2014-05-12 21:05:58 +0000 Git commit 3b5c6b2039ad943ae209341b5920fee929da9320 by Matěj Laitl. Committed on 12/05/2014 at 21:01. Pushed by laitl into branch 'master'. CollectionBrowser: do not expand tree needlessly The reasons were 2: * we were adding every collection to m_expandedCollections all the time, which then resulted in their expansion in each slotFilter() * we were doing auto-expansion even in cases where collection was updated, not just when user typed something (fixed in is still 2.9 for consistency with earlier commits) BACKPORT FIXED-IN: 2.9 M +1 -0 ChangeLog M +21 -16 src/browsers/CollectionTreeItemModelBase.cpp M +8 -3 src/browsers/CollectionTreeItemModelBase.h M +5 -5 src/browsers/CollectionTreeView.cpp M +1 -1 src/browsers/CollectionTreeView.h M +1 -1 tests/browsers/TestSingleCollectionTreeItemModel.cpp http://commits.kde.org/amarok/3b5c6b2039ad943ae209341b5920fee929da9320 1632810 10 matej 2016-10-16 22:09:10 +0000 Git commit 9fb00e5a97574af3f0cb22d740da7e0cd0761d78 by Matěj Laitl. Committed on 16/10/2016 at 22:03. Pushed by laitl into branch 'master'. Fix Collection Browser auto-expand after search expanding too little Underlying model is asynchronous, we need to cope with that. Do it using a RAII self-destructing object AutoExpander. As a side-effect, Amarok no longer expands collection after start in split collection mode. If this is desired, we may expand them explicitly upon start. Related: bug 335217 FIXED-IN: 2.9 M +1 -0 ChangeLog M +68 -20 src/browsers/CollectionTreeView.cpp http://commits.kde.org/amarok/9fb00e5a97574af3f0cb22d740da7e0cd0761d78 1632902 11 keplicz 2016-10-17 08:33:52 +0000 Thanks :)